From 92691a5b0afa149495615d7b269e74569b798944 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 12 Dec 2023 14:07:49 +0200 Subject: loplugin:unusedmethods Change-Id: Id0aed0077ed121fdaef574248427a3425248e7d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160617 Tested-by: Jenkins Reviewed-by: Noel Grandin --- compilerplugins/clang/unusedmethods.results | 174 +++++++++++---------- .../clang/unusedmethods.unused-returns.results | 30 +++- cui/source/dialogs/hlinettp.cxx | 5 - cui/source/inc/hlinettp.hxx | 2 - cui/source/options/optaboutconfig.cxx | 1 - cui/source/options/optaboutconfig.hxx | 2 - include/vcl/alpha.hxx | 5 - include/vcl/bitmapex.hxx | 21 --- vcl/source/bitmap/BitmapEx.cxx | 13 -- 9 files changed, 117 insertions(+), 136 deletions(-) diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index 85caa68bb670..ad0adbec091c 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -66,8 +66,6 @@ connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.hxx:92 type-parameter-?-? connectivity::mysqlc::OPreparedResultSet::retrieveValue(const int) connectivity/source/drivers/mysqlc/mysqlc_user.hxx:28 connectivity::mysqlc::User::User(com::sun::star::uno::Reference) -connectivity/source/drivers/mysqlc/mysqlc_user.hxx:32 - connectivity::mysqlc::User::User(com::sun::star::uno::Reference,const rtl::OUString &) connectivity/source/inc/calc/CDriver.hxx:30 com::sun::star::uno::Reference connectivity::calc::ODriver_CreateInstance(const com::sun::star::uno::Reference &) connectivity/source/inc/dbase/DDriver.hxx:29 @@ -118,8 +116,6 @@ cppuhelper/inc/interfacecontainer4.hxx:277 void cppuhelper::OInterfaceContainerHelper4::NotifySingleListener::operator()(const Reference &) const cui/source/dialogs/SpellAttrib.hxx:73 _Bool svx::SpellErrorDescription::operator==(const struct svx::SpellErrorDescription &) const -cui/source/inc/cuitabarea.hxx:750 - void SvxColorTabPage::SetCtlPreviewOld(const SfxItemSet &) cui/source/inc/CustomNotebookbarGenerator.hxx:30 CustomNotebookbarGenerator::CustomNotebookbarGenerator() cui/source/inc/fileextcheckdlg.hxx:32 @@ -132,8 +128,18 @@ cui/source/inc/GraphicsTestsDialog.hxx:48 void GraphicsTestsDialog::HandleResultViewRequest(weld::Button &) cui/source/inc/GraphicsTestsDialog.hxx:48 void GraphicsTestsDialog::LinkStubHandleResultViewRequest(void *,weld::Button &) +cui/source/inc/hlinettp.hxx:42 + void SvxHyperlinkInternetTp::Click_SmartProtocol_Impl(weld::Toggleable &) +cui/source/inc/hlinettp.hxx:42 + void SvxHyperlinkInternetTp::LinkStubClick_SmartProtocol_Impl(void *,weld::Toggleable &) +cui/source/inc/hlinettp.hxx:51 + rtl::OUString SvxHyperlinkInternetTp::GetSchemeFromButtons() cui/source/inc/SvxNotebookbarConfigPage.hxx:40 void SvxNotebookbarConfigPage::SetElement() +cui/source/options/optaboutconfig.hxx:70 + rtl::OUString CuiAboutConfigTabPage::EditNumberHdl(SvxListDialog &) +cui/source/options/optaboutconfig.hxx:70 + rtl::OUString CuiAboutConfigTabPage::LinkStubEditNumberHdl(void *,SvxListDialog &) dbaccess/source/filter/hsqldb/fbalterparser.hxx:19 void dbahsql::FbAlterStmtParser::ensureProperTableLengths() const dbaccess/source/filter/hsqldb/parseschema.hxx:80 @@ -158,7 +164,7 @@ dbaccess/source/ui/inc/unodatbr.hxx:316 _Bool dbaui::SbaTableQueryBrowser::implCopyObject(ODataClipboard &,const weld::TreeIter &,int) desktop/inc/lib/init.hxx:142 desktop::CallbackFlushHandler::CallbackData::CallbackData(const tools::Rectangle *,int) -desktop/qa/desktop_lib/test_desktop_lib.cxx:3712 +desktop/qa/desktop_lib/test_desktop_lib.cxx:3711 int main() desktop/source/lib/lokclipboard.hxx:95 LOKClipboardFactory::LOKClipboardFactory() @@ -182,9 +188,9 @@ drawinglayer/source/tools/emfpstringformat.hxx:99 _Bool emfplushelper::EMFPStringFormat::NoClip() const drawinglayer/source/tools/emfpstringformat.hxx:100 _Bool emfplushelper::EMFPStringFormat::BypassGDI() const -editeng/inc/editdoc.hxx:547 - _Bool EditLine::IsInvalid() const editeng/inc/editdoc.hxx:548 + _Bool EditLine::IsInvalid() const +editeng/inc/editdoc.hxx:549 _Bool EditLine::IsValid() const editeng/inc/edtspell.hxx:103 __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator >, std::vector > WrongList::begin() const @@ -192,7 +198,7 @@ editeng/inc/edtspell.hxx:104 __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator >, std::vector > WrongList::end() const editeng/source/editeng/impedit.hxx:234 tools::Rectangle LOKSpecialPositioning::GetWindowPos(const tools::Rectangle &,enum MapUnit) const -editeng/source/editeng/impedit.hxx:757 +editeng/source/editeng/impedit.hxx:756 double ImpEditEngine::scaleYFontValue(unsigned short) const embeddedobj/source/msole/olecomponent.hxx:75 _Bool OleComponent::InitializeObject_Impl() @@ -842,7 +848,7 @@ include/docmodel/color/ComplexColor.hxx:117 void model::ComplexColor::setSystemColorType(enum model::SystemColorType) include/docmodel/color/ComplexColor.hxx:127 void model::ComplexColor::setTransformations(const std::vector &) -include/docmodel/color/ComplexColor.hxx:146 +include/docmodel/color/ComplexColor.hxx:144 void model::ComplexColor::clearTransformations() include/docmodel/theme/FormatScheme.hxx:450 model::FormatScheme::FormatScheme(const rtl::OUString &) @@ -886,9 +892,9 @@ include/drawinglayer/tools/primitive2dxmldump.hxx:45 void drawinglayer::Primitive2dXmlDump::dump(const drawinglayer::primitive2d::Primitive2DContainer &,const rtl::OUString &) include/editeng/colritem.hxx:76 void SvxColorItem::setComplexColor(const model::ComplexColor &) -include/editeng/editeng.hxx:249 +include/editeng/editeng.hxx:248 _Bool EditEngine::GetVertical() const -include/editeng/editeng.hxx:251 +include/editeng/editeng.hxx:250 enum TextRotation EditEngine::GetRotation() const include/editeng/hyphenzoneitem.hxx:67 _Bool SvxHyphenZoneItem::IsPageEnd() const @@ -1066,11 +1072,11 @@ include/oox/export/DMLPresetShapeExport.hxx:100 _Bool oox::drawingml::DMLPresetShapeExporter::HasHandleValue() const include/oox/export/DMLPresetShapeExport.hxx:129 com::sun::star::uno::Any oox::drawingml::DMLPresetShapeExporter::FindHandleValue(com::sun::star::uno::Sequence,std::basic_string_view) -include/oox/export/drawingml.hxx:326 +include/oox/export/drawingml.hxx:338 _Bool oox::drawingml::DrawingML::EqualGradients(const struct com::sun::star::awt::Gradient2 &,const struct com::sun::star::awt::Gradient2 &) -include/oox/export/drawingml.hxx:363 +include/oox/export/drawingml.hxx:375 _Bool oox::drawingml::DrawingML::WriteCharColor(const com::sun::star::uno::Reference &) -include/oox/export/drawingml.hxx:504 +include/oox/export/drawingml.hxx:516 Color oox::drawingml::DrawingML::ColorWithIntensity(unsigned int,unsigned int) include/oox/helper/attributelist.hxx:68 long oox::AttributeConversion::decodeHyper(std::basic_string_view) @@ -1136,25 +1142,25 @@ include/svl/itempool.hxx:212 _Bool SfxItemPool::NeedsPoolRegistration(const SfxPoolItem &) const include/svl/itempool.hxx:216 _Bool SfxItemPool::Shareable(const SfxPoolItem &) const -include/svl/itempool.hxx:237 - void SfxItemPool::tryRegisterSfxPoolItem(const SfxPoolItem &,_Bool) -include/svl/itempool.hxx:254 +include/svl/itempool.hxx:246 void SfxItemPool::dumpAsXml(struct _xmlTextWriter *) const -include/svl/itemset.hxx:78 +include/svl/itemset.hxx:58 + unsigned short SfxPoolItemHolder::Which() const +include/svl/itemset.hxx:96 _Bool SfxItemSet::empty() const -include/svl/itemset.hxx:79 +include/svl/itemset.hxx:97 int SfxItemSet::size() const -include/svl/itemset.hxx:80 +include/svl/itemset.hxx:98 const SfxPoolItem * SfxItemSet::operator[](int) const include/svl/lockfilecommon.hxx:60 void svt::LockFileCommon::SetURL(const rtl::OUString &) include/svl/ondemand.hxx:346 const CharClass & OnDemandCharClass::operator*() const -include/svl/poolitem.hxx:177 +include/svl/poolitem.hxx:176 _Bool SfxPoolItem::isDeleteOnIdle() const -include/svl/poolitem.hxx:233 +include/svl/poolitem.hxx:232 type-parameter-?-? * SfxPoolItem::DynamicWhichCast(TypedWhichId) -include/svl/poolitem.hxx:282 +include/svl/poolitem.hxx:281 _Bool IsPoolDefaultItem(const SfxPoolItem *) include/svl/typedwhich.hxx:31 TypedWhichId::TypedWhichId(TypedWhichId,typename enable_if, int>::type) @@ -1844,6 +1850,8 @@ include/svl/typedwhich.hxx:31 TypedWhichId::TypedWhichId(TypedWhichId,typename enable_if, int>::type) include/svl/typedwhich.hxx:31 TypedWhichId::TypedWhichId(TypedWhichId,typename enable_if, int>::type) +include/svl/typedwhich.hxx:31 + TypedWhichId::TypedWhichId(TypedWhichId,typename enable_if, int>::type) include/svl/typedwhich.hxx:31 TypedWhichId::TypedWhichId(TypedWhichId,typename enable_if, int>::type) include/svl/typedwhich.hxx:31 @@ -2006,8 +2014,6 @@ include/svtools/ctrlbox.hxx:475 void FontSizeBox::set_size_request(int,int) include/svtools/DocumentToGraphicRenderer.hxx:105 _Bool DocumentToGraphicRenderer::isImpress() const -include/svtools/HtmlWriter.hxx:46 - void HtmlWriter::writeAttribute(SvStream &,std::basic_string_view,int) include/svtools/scrolladaptor.hxx:60 _Bool ScrollAdaptor::IsHoriScroll() const include/svx/autoformathelper.hxx:145 @@ -2022,7 +2028,7 @@ include/svx/diagram/IDiagramHelper.hxx:94 rtl::OUString svx::diagram::IDiagramHelper::getString() const include/svx/dlgctrl.hxx:263 void SvxLineEndLB::set_active_text(const rtl::OUString &) -include/svx/framelink.hxx:168 +include/svx/framelink.hxx:169 _Bool svx::frame::operator>(const svx::frame::Style &,const svx::frame::Style &) include/svx/hlnkitem.hxx:103 void SvxHyperlinkItem::SetReplacementText(const rtl::OUString &) @@ -2174,6 +2180,8 @@ include/tools/gen.hxx:520 Pair & Selection::toPair() include/tools/gen.hxx:750 RectangleTemplate::RectangleTemplate(long,long) +include/tools/json_writer.hxx:61 + void tools::JsonWriter::put(std::basic_string_view,const char (&)[_ArrayExtent]) include/tools/json_writer.hxx:91 void tools::JsonWriter::closeDocument() include/tools/link.hxx:134 @@ -2182,17 +2190,15 @@ include/tools/link.hxx:135 int Link::getSourceLineNumber() const include/tools/link.hxx:136 const char * Link::getTargetName() const -include/tools/poly.hxx:162 +include/tools/poly.hxx:163 _Bool tools::Polygon::operator!=(const tools::Polygon &) const -include/tools/poly.hxx:251 +include/tools/poly.hxx:252 _Bool tools::PolyPolygon::operator!=(const tools::PolyPolygon &) const -include/tools/stream.hxx:515 +include/tools/stream.hxx:504 rtl::OString read_uInt32_lenPrefixed_uInt8s_ToOString(SvStream &) -include/tools/urlobj.hxx:430 - _Bool INetURLObject::SetUserAndPass(std::basic_string_view,std::basic_string_view) -include/tools/urlobj.hxx:447 +include/tools/urlobj.hxx:444 _Bool INetURLObject::SetHost(std::basic_string_view) -include/tools/urlobj.hxx:952 +include/tools/urlobj.hxx:949 int INetURLObject::SubString::set(rtl::OUString &,std::basic_string_view) include/tools/weakbase.h:77 tools::WeakReference::WeakReference() @@ -2224,10 +2230,6 @@ include/tools/weakbase.h:151 struct tools::WeakConnection * tools::WeakBase::getWeakConnection() include/tools/XmlWriter.hxx:63 void tools::XmlWriter::element(const char *) -include/ucbhelper/fd_inputstream.hxx:46 - ucbhelper::FdInputStream::FdInputStream(void *) -include/ucbhelper/proxydecider.hxx:101 - _Bool ucbhelper::InternetProxyDecider::shouldUseProxy(const rtl::OUString &,const rtl::OUString &,int) const include/unotest/directories.hxx:46 rtl::OUString test::Directories::getPathFromWorkdir(std::basic_string_view) const include/unotools/charclass.hxx:101 @@ -2244,28 +2246,42 @@ include/unotools/resmgr.hxx:65 _Bool TranslateNId::operator!=(const struct TranslateNId &) const include/unotools/securityoptions.hxx:61 _Bool SvtSecurityOptions::Certificate::operator==(const struct SvtSecurityOptions::Certificate &) const -include/unotools/securityoptions.hxx:150 - _Bool SvtSecurityOptions::IsInfobarSecurityWarningEnable() include/unotools/textsearch.hxx:121 basic_ostream & utl::operator<<(basic_ostream &,const enum utl::SearchParam::SearchType &) include/unotools/weakref.hxx:72 unotools::WeakReference::WeakReference(type-parameter-?-? &) -include/vcl/alpha.hxx:47 +include/vcl/alpha.hxx:46 _Bool AlphaMask::operator!=(const AlphaMask &) const +include/vcl/alpha.hxx:109 + _Bool AlphaMask::CopyPixel_AlphaOptimized(const tools::Rectangle &,const tools::Rectangle &) include/vcl/animate/Animation.hxx:42 _Bool Animation::operator!=(const Animation &) const include/vcl/animate/AnimationFrame.hxx:77 _Bool AnimationFrame::operator!=(const struct AnimationFrame &) const -include/vcl/bitmap.hxx:250 - _Bool Bitmap::CombineOr(const Bitmap &) -include/vcl/bitmap.hxx:575 +include/vcl/bitmap.hxx:590 const basegfx::SystemDependentDataHolder * Bitmap::accessSystemDependentDataHolder() const include/vcl/BitmapBasicMorphologyFilter.hxx:63 BitmapDilateFilter::BitmapDilateFilter(int,unsigned char) +include/vcl/bitmapex.hxx:172 + _Bool BitmapEx::CopyPixel(const tools::Rectangle &,const tools::Rectangle &) +include/vcl/BitmapInfoAccess.hxx:163 + BitmapScopedInfoAccess::BitmapScopedInfoAccess(const AlphaMask &) +include/vcl/BitmapInfoAccess.hxx:184 + void BitmapScopedInfoAccess::reset() +include/vcl/BitmapInfoAccess.hxx:186 + BitmapInfoAccess * BitmapScopedInfoAccess::get() +include/vcl/BitmapInfoAccess.hxx:187 + const BitmapInfoAccess * BitmapScopedInfoAccess::get() const +include/vcl/BitmapInfoAccess.hxx:192 + BitmapInfoAccess & BitmapScopedInfoAccess::operator*() +include/vcl/BitmapInfoAccess.hxx:193 + const BitmapInfoAccess & BitmapScopedInfoAccess::operator*() const include/vcl/BitmapReadAccess.hxx:86 BitmapColor BitmapReadAccess::GetPixel(const Point &) const include/vcl/BitmapReadAccess.hxx:110 unsigned char BitmapReadAccess::GetPixelIndex(const Point &) const +include/vcl/BitmapWriteAccess.hxx:66 + void BitmapWriteAccess::SetFillColor() include/vcl/builder.hxx:107 const rtl::OUString & VclBuilder::getUIFile() const include/vcl/builder.hxx:333 @@ -2370,11 +2386,11 @@ include/vcl/opengl/OpenGLHelper.hxx:70 void OpenGLHelper::renderToFile(long,long,const rtl::OUString &) include/vcl/opengl/OpenGLHelper.hxx:103 void OpenGLHelper::debugMsgStreamWarn(const std::basic_ostringstream &) -include/vcl/outdev.hxx:1516 +include/vcl/outdev.hxx:1518 void OutputDevice::DrawMask(const Point &,const Size &,const Point &,const Size &,const Bitmap &,const Color &) -include/vcl/outdev.hxx:1606 +include/vcl/outdev.hxx:1608 basegfx::B2DPolyPolygon OutputDevice::LogicToPixel(const basegfx::B2DPolyPolygon &,const MapMode &) const -include/vcl/outdev.hxx:1624 +include/vcl/outdev.hxx:1626 basegfx::B2DPolyPolygon OutputDevice::PixelToLogic(const basegfx::B2DPolyPolygon &,const MapMode &) const include/vcl/pdfextoutdevdata.hxx:115 _Bool vcl::PDFExtOutDevData::GetIsExportNotesInMargin() const @@ -2514,6 +2530,12 @@ include/xmloff/txtimp.hxx:117 XMLPropertyBackpatcher & XMLTextImportHelper::GetSequenceNameBP() include/xmloff/xmluconv.hxx:190 _Bool SvXMLUnitConverter::convertEnum(type-parameter-?-? &,std::basic_string_view,const SvXMLEnumStringMapEntry *) +include/xmlreader/pad.hxx:38 + void xmlreader::Pad::add(const char (&)[_ArrayExtent]) +include/xmlreader/span.hxx:44 + xmlreader::Span::Span(const char (&)[_ArrayExtent]) +include/xmlreader/span.hxx:71 + _Bool xmlreader::Span::operator!=(const char (&)[_ArrayExtent]) const libreofficekit/qa/gtktiledviewer/gtv-comments-sidebar.cxx:31 void * gtv_comments_sidebar_get_instance_private(struct GtvCommentsSidebar *) libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.hxx:37 @@ -2548,6 +2570,10 @@ oox/source/drawingml/diagram/diagramlayoutatoms.hxx:331 const std::vector > & oox::drawingml::LayoutNode::getNodeShapes() const oox/source/drawingml/diagram/diagramlayoutatoms.hxx:340 const oox::drawingml::LayoutNode * oox::drawingml::LayoutNode::getParentLayoutNode() const +oox/source/shape/WordprocessingCanvasContext.hxx:30 + const _Bool & oox::shape::WordprocessingCanvasContext::isFullWPGSupport() const +oox/source/shape/WordprocessingCanvasContext.hxx:31 + void oox::shape::WordprocessingCanvasContext::setFullWPGSupport(_Bool) sal/osl/unx/uunxapi.hxx:35 int mkdir_c(const rtl::OString &,unsigned int) sal/osl/unx/uunxapi.hxx:70 @@ -2694,9 +2720,9 @@ sc/inc/stlalgorithm.hxx:60 _Bool sc::AlignedAllocator::operator==(const AlignedAllocator &) const sc/inc/stlalgorithm.hxx:61 _Bool sc::AlignedAllocator::operator!=(const AlignedAllocator &) const -sc/inc/table.hxx:352 +sc/inc/table.hxx:348 _Bool ScTable::IsColRowTabValid(const short,const int,const short) const -sc/inc/table.hxx:759 +sc/inc/table.hxx:756 const type-parameter-?-? * ScTable::GetAttr(short,int,TypedWhichId,int &,int &) const sc/qa/unit/helper/qahelper.hxx:77 std::basic_ostream & operator<<(std::basic_ostream &,const enum OpCode &) @@ -2804,11 +2830,11 @@ sc/source/ui/inc/SparklineDataRangeDialog.hxx:54 _Bool sc::SparklineDataRangeDialog::checkValidInputOutput() sc/source/ui/inc/TableFillingAndNavigationTools.hxx:120 unsigned long DataRangeIterator::size() -sc/source/ui/inc/viewdata.hxx:408 +sc/source/ui/inc/viewdata.hxx:410 long ScViewData::GetLOKDocWidthPixel() const -sc/source/ui/inc/viewdata.hxx:409 +sc/source/ui/inc/viewdata.hxx:411 long ScViewData::GetLOKDocHeightPixel() const -sc/source/ui/inc/viewdata.hxx:558 +sc/source/ui/inc/viewdata.hxx:560 _Bool ScViewData::IsGridMode() const scaddins/source/analysis/analysishelper.hxx:797 _Bool sca::analysis::ScaDate::operator>=(const sca::analysis::ScaDate &) const @@ -2834,14 +2860,6 @@ sd/source/ui/inc/GraphicViewShell.hxx:43 void sd::GraphicViewShell::RegisterFactory(struct o3tl::strong_int) sd/source/ui/inc/optsitem.hxx:178 _Bool SdOptionsContents::operator==(const SdOptionsContents &) const -sd/source/ui/inc/optsitem.hxx:250 - _Bool SdOptionsMisc::IsEnableSdremote() const -sd/source/ui/inc/optsitem.hxx:251 - _Bool SdOptionsMisc::IsPresenterScreenFullScreen() const -sd/source/ui/inc/optsitem.hxx:293 - void SdOptionsMisc::SetEnableSdremote(_Bool) -sd/source/ui/inc/optsitem.hxx:294 - void SdOptionsMisc::SetPresenterScreenFullScreen(_Bool) sd/source/ui/inc/OutlineViewShell.hxx:40 SfxViewFactory * sd::OutlineViewShell::Factory() sd/source/ui/inc/OutlineViewShell.hxx:40 @@ -2858,7 +2876,7 @@ sd/source/ui/inc/unomodel.hxx:137 _Bool SdXImpressDocument::operator==(const SdXImpressDocument &) const sd/source/ui/slidesorter/inc/view/SlsLayouter.hxx:199 _Bool sd::slidesorter::view::InsertPosition::operator!=(const sd::slidesorter::view::InsertPosition &) const -sdext/source/pdfimport/pdfparse/pdfparse.cxx:112 +sdext/source/pdfimport/pdfparse/pdfparse.cxx:114 long (anonymous namespace)::PDFGrammar>::pdf_string_parser::operator()(const type-parameter-?-? &,struct boost::spirit::classic::nil_t &) const sfx2/inc/autoredactdialog.hxx:74 void TargetsTable::select(int) @@ -2931,7 +2949,7 @@ slideshow/source/inc/box2dtools.hxx:261 slideshow/source/inc/box2dtools.hxx:299 std::shared_ptr box2d::utils::box2DWorld::makeShapeStatic(const std::shared_ptr &) slideshow/source/inc/eventmultiplexer.hxx:653 - basegfx::B2DPoint slideshow::internal::EventMultiplexer::toMatrixPoint(com::sun::star::uno::Reference,basegfx::B2DPoint) + basegfx::B2DPoint slideshow::internal::EventMultiplexer::toMatrixPoint(const com::sun::star::uno::Reference &,const basegfx::B2DPoint &) slideshow/source/inc/listenercontainer.hxx:44 _Bool slideshow::internal::FunctionApply::apply(type-parameter-?-?,const std::shared_ptr &) slideshow/source/inc/listenercontainer.hxx:44 @@ -3064,8 +3082,6 @@ svl/source/misc/gridprinter.cxx:42 void rtl::mdds_mtv_set_values(mdds::mtv::base_element_block &,unsigned long,const rtl::OUString &,const type-parameter-?-? &,const type-parameter-?-? &) svx/inc/sdr/contact/viewcontactofgraphic.hxx:52 SdrGrafObj & sdr::contact::ViewContactOfGraphic::GetGrafObject() -svx/source/inc/findtextfield.hxx:50 - void FindTextFieldControl::set_entry_message_type(enum weld::EntryMessageType) sw/inc/calbck.hxx:304 sw::WriterListener * sw::ClientIteratorBase::GetLeftOfPos() sw/inc/contentindex.hxx:68 @@ -3210,15 +3226,13 @@ sw/inc/rdfhelper.hxx:94 void SwRDFHelper::removeTextNodeStatement(const rtl::OUString &,SwTextNode &,const rtl::OUString &,const rtl::OUString &) sw/inc/rdfhelper.hxx:97 void SwRDFHelper::updateTextNodeStatement(const rtl::OUString &,const rtl::OUString &,SwTextNode &,const rtl::OUString &,const rtl::OUString &,const rtl::OUString &) -sw/inc/reffld.hxx:166 - void SwGetRefField::SetText(rtl::OUString,SwRootFrame *) sw/inc/ring.hxx:203 sw::RingIterator::RingIterator() sw/inc/shellio.hxx:89 void SwAsciiOptions::SetIncludeHidden(_Bool) sw/inc/swabstdlg.hxx:417 std::optional AbstractSwTranslateLangSelectDlg::GetSelectedLanguage() -sw/inc/swatrset.hxx:237 +sw/inc/swatrset.hxx:238 const SvxNoHyphenItem & SwAttrSet::GetNoHyphenHere(_Bool) const sw/inc/swcrsr.hxx:309 SwTableCursor * SwTableCursor::GetNext() @@ -3248,7 +3262,7 @@ sw/inc/viscrs.hxx:229 SwShellTableCursor * SwShellTableCursor::GetPrev() sw/inc/viscrs.hxx:230 const SwShellTableCursor * SwShellTableCursor::GetPrev() const -sw/qa/inc/swmodeltestbase.hxx:239 +sw/qa/inc/swmodeltestbase.hxx:231 com::sun::star::uno::Reference SwModelTestBase::getParagraphAnchoredObject(const int,const com::sun::star::uno::Reference &) const sw/source/core/access/accportions.cxx:55 unsigned long FindBreak(const vector > &,type-parameter-?-?) @@ -3256,15 +3270,15 @@ sw/source/core/access/accportions.cxx:59 unsigned long FindLastBreak(const vector > &,type-parameter-?-?) sw/source/core/inc/AccessibilityIssue.hxx:80 SwTextFootnote * sw::AccessibilityIssue::getTextFootnote() -sw/source/core/inc/frame.hxx:944 +sw/source/core/inc/frame.hxx:948 void SwFrame::dumpTopMostAsXml(struct _xmlTextWriter *) const -sw/source/core/inc/frame.hxx:1391 +sw/source/core/inc/frame.hxx:1395 Size SwRectFnSet::GetSize(const SwRect &) const -sw/source/core/inc/frame.hxx:1422 +sw/source/core/inc/frame.hxx:1426 long SwRectFnSet::LeftDist(const SwRect &,long) const -sw/source/core/inc/frame.hxx:1423 +sw/source/core/inc/frame.hxx:1427 long SwRectFnSet::RightDist(const SwRect &,long) const -sw/source/core/inc/mvsave.hxx:170 +sw/source/core/inc/mvsave.hxx:171 _Bool ZSortFly::operator==(const ZSortFly &) const sw/source/core/text/porlin.hxx:125 _Bool SwLinePortion::IsTabRightPortion() const @@ -3290,8 +3304,6 @@ ucb/source/ucp/gio/gio_mount.cxx:37 void * ooo_mount_operation_get_instance_private(struct OOoMountOperation *) unoxml/inc/node.hxx:116 void DOM::CNode::checkNoParent(const com::sun::star::uno::Reference &) -vcl/inc/bitmap/BitmapWriteAccess.hxx:73 - void BitmapWriteAccess::SetFillColor() vcl/inc/bitmap/ScanlineTools.hxx:23 void vcl::bitmap::ScanlineTransformer::skipPixel(unsigned int) vcl/inc/ControlCacheKey.hxx:35 @@ -3320,9 +3332,9 @@ vcl/inc/impfont.hxx:94 unsigned long ImplFont::GetHashValue() const vcl/inc/ImplLayoutArgs.hxx:75 std::basic_ostream & operator<<(std::basic_ostream &,const vcl::text::ImplLayoutArgs &) -vcl/inc/jsdialog/jsdialogbuilder.hxx:208 +vcl/inc/jsdialog/jsdialogbuilder.hxx:209 void JSDropTarget::fire_dragEnter(const struct com::sun::star::datatransfer::dnd::DropTargetDragEnterEvent &) -vcl/inc/jsdialog/jsdialogbuilder.hxx:665 +vcl/inc/jsdialog/jsdialogbuilder.hxx:668 void JSFormattedSpinButton::set_text_without_notify(const rtl::OUString &) vcl/inc/opengl/zone.hxx:25 void OpenGLZone::relaxWatchdogTimings() @@ -3386,9 +3398,9 @@ vcl/inc/skia/zone.hxx:25 void SkiaZone::relaxWatchdogTimings() vcl/inc/unx/gtk/gtkframe.hxx:300 void GtkSalFrame::DrawingAreaFocusInOut(enum SalEvent) -vcl/inc/unx/gtk/gtksalmenu.hxx:81 +vcl/inc/unx/gtk/gtksalmenu.hxx:80 const GtkSalFrame * GtkSalMenu::GetFrame() const -vcl/inc/unx/salframe.h:186 +vcl/inc/unx/salframe.h:185 enum SalFrameStyleFlags X11SalFrame::GetStyle() const vcl/inc/unx/saltype.h:21 _Bool SalX11Screen::operator==(const SalX11Screen &) const @@ -3450,7 +3462,11 @@ writerfilter/source/dmapper/CellColorHandler.hxx:74 model::ComplexColor writerfilter::dmapper::CellColorHandler::getComplexColor() const writerfilter/source/dmapper/DomainMapperTableManager.hxx:98 writerfilter::dmapper::TablePositionHandler * writerfilter::dmapper::DomainMapperTableManager::getCurrentTableRealPosition() -writerfilter/source/dmapper/PropertyMap.hxx:377 +writerfilter/source/dmapper/PropertyMap.hxx:361 + _Bool writerfilter::dmapper::SectionPropertyMap::getFirstPageHeader() +writerfilter/source/dmapper/PropertyMap.hxx:362 + _Bool writerfilter::dmapper::SectionPropertyMap::getFirstPageFooter() +writerfilter/source/dmapper/PropertyMap.hxx:389 int writerfilter::dmapper::SectionPropertyMap::GetBreakType() const writerfilter/source/dmapper/TablePositionHandler.hxx:40 int writerfilter::dmapper::TablePositionHandler::getY() const diff --git a/compilerplugins/clang/unusedmethods.unused-returns.results b/compilerplugins/clang/unusedmethods.unused-returns.results index edb7a1104cd2..751036a1e299 100644 --- a/compilerplugins/clang/unusedmethods.unused-returns.results +++ b/compilerplugins/clang/unusedmethods.unused-returns.results @@ -44,6 +44,8 @@ include/editeng/editview.hxx:280 ErrCode EditView::Read(SvStream &,enum EETextFormat,SvKeyValueIterator *) include/editeng/outliner.hxx:284 _Bool OutlinerView::Command(const CommandEvent &) +include/editeng/svxacorr.hxx:244 + _Bool SvxAutoCorrectLanguageLists::MakeCombinedChanges(std::vector &,std::vector &) include/oox/crypto/AgileEngine.hxx:121 _Bool oox::crypto::AgileEngine::decryptHmacKey() include/oox/crypto/AgileEngine.hxx:122 @@ -174,19 +176,27 @@ include/tools/config.hxx:38 _Bool Config::ImplUpdateConfig() const include/tools/multisel.hxx:93 _Bool StringRangeEnumerator::insertRange(int,int,_Bool) -include/tools/urlobj.hxx:738 +include/tools/urlobj.hxx:735 _Bool INetURLObject::SetParam(std::basic_string_view,enum INetURLObject::EncodeMechanism,unsigned short) -include/unotools/lingucfg.hxx:193 +include/unotools/lingucfg.hxx:191 _Bool SvtLinguConfig::GetElementNamesFor(const rtl::OUString &,com::sun::star::uno::Sequence &) const include/unotools/localedatawrapper.hxx:163 const com::sun::star::uno::Sequence & LocaleDataWrapper::getAllInstalledLocaleNames() const +include/vcl/alpha.hxx:87 + _Bool AlphaMask::Scale(const double &,const double &,enum BmpScaleFlag) +include/vcl/alpha.hxx:90 + _Bool AlphaMask::Convert(enum BmpConversion) +include/vcl/alpha.hxx:98 + _Bool AlphaMask::Expand(int,int,const Color *) +include/vcl/alpha.hxx:104 + _Bool AlphaMask::CopyPixel(const tools::Rectangle &,const tools::Rectangle &,const AlphaMask &) include/vcl/BinaryDataContainer.hxx:61 unsigned long BinaryDataContainer::writeToStream(SvStream &) const -include/vcl/bitmap.hxx:268 +include/vcl/bitmap.hxx:283 _Bool Bitmap::Blend(const AlphaMask &,const Color &) -include/vcl/bitmap.hxx:436 +include/vcl/bitmap.hxx:451 _Bool Bitmap::Replace(const AlphaMask &,const Color &) -include/vcl/bitmapex.hxx:227 +include/vcl/bitmapex.hxx:246 _Bool BitmapEx::Rotate(struct o3tl::strong_int >,const Color &) include/vcl/filter/SvmReader.hxx:36 SvStream & SvmReader::Read(GDIMetaFile &,struct ImplMetaReadData *) @@ -206,6 +216,8 @@ include/vcl/menu.hxx:392 _Bool Menu::HandleMenuActivateEvent(Menu *) const include/vcl/menu.hxx:393 _Bool Menu::HandleMenuDeActivateEvent(Menu *) const +include/vcl/outdev.hxx:1169 + _Bool OutputDevice::ForceFallbackFont(const vcl::Font &) include/vcl/texteng.hxx:271 _Bool TextEngine::Read(SvStream &,const TextSelection *) include/xmloff/unointerfacetouniqueidentifiermapper.hxx:65 @@ -220,7 +232,7 @@ lotuswordpro/inc/lwpsvstream.hxx:81 LwpSvStream & LwpSvStream::ReadUInt16(unsigned short &) lotuswordpro/inc/lwpsvstream.hxx:82 LwpSvStream & LwpSvStream::ReadUInt32(unsigned int &) -sc/inc/column.hxx:679 +sc/inc/column.hxx:681 _Bool ScColumn::DeleteSparkline(int) sc/inc/orcusfilters.hxx:44 _Bool ScOrcusFilters::importODS_Styles(ScDocument &,rtl::OUString &) const @@ -280,6 +292,8 @@ sc/source/ui/vba/vbaformat.hxx:145 com::sun::star::uno::Any ScVbaFormat::getMergeCells() sc/source/ui/vba/vbaformat.hxx:151 com::sun::star::uno::Any ScVbaFormat::getReadingOrder() +sd/source/filter/eppt/pptx-epptooxml.cxx:139 + oox::drawingml::ShapeExport & oox::core::PowerPointShapeExport::WritePlaceholderReferenceShape(enum oox::core::PlaceholderType,int,enum PageType,const com::sun::star::uno::Reference &) sd/source/filter/eppt/pptx-epptooxml.cxx:140 oox::drawingml::ShapeExport & oox::core::PowerPointShapeExport::WritePageShape(const com::sun::star::uno::Reference &,enum PageType,_Bool) sd/source/filter/html/htmlex.hxx:74 @@ -306,7 +320,7 @@ svx/inc/galleryfilestorage.hxx:102 SvStream & GalleryFileStorage::writeGalleryTheme(SvStream &,const GalleryTheme &,const GalleryThemeEntry *) svx/inc/galleryfilestorageentry.hxx:56 std::unique_ptr & GalleryFileStorageEntry::getCachedTheme(std::unique_ptr &) -sw/inc/calc.hxx:125 +sw/inc/calc.hxx:124 SwSbxValue & SwSbxValue::MakeDouble() sw/inc/crsrsh.hxx:601 _Bool SwCursorShell::TrySelectOuterTable() @@ -420,7 +434,7 @@ vcl/inc/salprn.hxx:116 _Bool SalPrinter::EndJob() vcl/inc/unx/gtk/gtkdata.hxx:336 int GtkSalDisplay::CaptureMouse(SalFrame *) -vcl/inc/unx/salframe.h:167 +vcl/inc/unx/salframe.h:166 _Bool X11SalFrame::Dispatch(union _XEvent *) vcl/source/fontsubset/ttcr.hxx:106 int vcl::TrueTypeTable::GetRawData(struct vcl::TableEntry *) diff --git a/cui/source/dialogs/hlinettp.cxx b/cui/source/dialogs/hlinettp.cxx index c74d6ae10699..610cdd8aea5e 100644 --- a/cui/source/dialogs/hlinettp.cxx +++ b/cui/source/dialogs/hlinettp.cxx @@ -199,11 +199,6 @@ void SvxHyperlinkInternetTp::RemoveImproperProtocol(std::u16string_view aProperS } } -OUString SvxHyperlinkInternetTp::GetSchemeFromButtons() -{ - return INET_HTTP_SCHEME; -} - INetProtocol SvxHyperlinkInternetTp::GetSmartProtocolFromButtons() { return INetProtocol::Http; diff --git a/cui/source/inc/hlinettp.hxx b/cui/source/inc/hlinettp.hxx index ad308a401f45..366d8243a8b6 100644 --- a/cui/source/inc/hlinettp.hxx +++ b/cui/source/inc/hlinettp.hxx @@ -39,7 +39,6 @@ private: std::unique_ptr m_xCbbTarget; std::unique_ptr m_xFtTarget; - DECL_LINK( Click_SmartProtocol_Impl, weld::Toggleable&, void ); ///< Radiobutton toggled: Type HTTP or DECL_LINK( LostFocusTargetHdl_Impl, weld::Widget&, void ); ///< Combobox "Target" lost its focus DECL_LINK( ModifiedTargetHdl_Impl, weld::ComboBox&, void ); ///< Contents of editfield "Target" modified @@ -48,7 +47,6 @@ private: void SetScheme(std::u16string_view rScheme); void RemoveImproperProtocol(std::u16string_view rProperScheme); - static OUString GetSchemeFromButtons(); static INetProtocol GetSmartProtocolFromButtons(); OUString CreateAbsoluteURL() const; diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx index 6e3bdd9b2747..dc4e8ffeb67c 100644 --- a/cui/source/options/optaboutconfig.cxx +++ b/cui/source/options/optaboutconfig.cxx @@ -104,7 +104,6 @@ CuiAboutConfigTabPage::CuiAboutConfigTabPage(weld::Window* pParent) , m_xPrefBox(m_xBuilder->weld_tree_view("preferences")) , m_xScratchIter(m_xPrefBox->make_iterator()) , m_bSorted(false) - , m_pParent(pParent) { m_xPrefBox->set_size_request(m_xPrefBox->get_approximate_digit_width() * 100, m_xPrefBox->get_height_rows(23)); diff --git a/cui/source/options/optaboutconfig.hxx b/cui/source/options/optaboutconfig.hxx index 28406a8fd776..d808e3ed04d5 100644 --- a/cui/source/options/optaboutconfig.hxx +++ b/cui/source/options/optaboutconfig.hxx @@ -52,7 +52,6 @@ private: std::vector m_prefBoxEntries; bool m_bSorted; - weld::Window* m_pParent; void AddToModifiedVector(const std::shared_ptr& rProp); static std::vector commaStringToSequence(std::u16string_view rCommaSepString); @@ -67,7 +66,6 @@ private: DECL_LINK(ExpandingHdl_Impl, const weld::TreeIter&, bool); DECL_LINK(HeaderBarClick, int, void); DECL_STATIC_LINK(CuiAboutConfigTabPage, ValidNameHdl, SvxNameDialog&, bool); - DECL_LINK(EditNumberHdl, SvxListDialog&, OUString); public: explicit CuiAboutConfigTabPage(weld::Window* pParent); diff --git a/include/vcl/alpha.hxx b/include/vcl/alpha.hxx index fb5be9c16388..ec7601847433 100644 --- a/include/vcl/alpha.hxx +++ b/include/vcl/alpha.hxx @@ -106,11 +106,6 @@ public: const AlphaMask& rBmpSrc ) { return maBitmap.CopyPixel(rRectDst, rRectSrc, rBmpSrc.maBitmap); } - bool CopyPixel_AlphaOptimized( - const tools::Rectangle& rRectDst, - const tools::Rectangle& rRectSrc ) - { return maBitmap.CopyPixel_AlphaOptimized(rRectDst, rRectSrc); } - bool CopyPixel_AlphaOptimized( const tools::Rectangle& rRectDst, const tools::Rectangle& rRectSrc, diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx index c159e7d4910c..de5d36ddad0f 100644 --- a/include/vcl/bitmapex.hxx +++ b/include/vcl/bitmapex.hxx @@ -152,27 +152,6 @@ public: const tools::Rectangle& rRectSrc, const BitmapEx& rBmpExSrc ); - /** Copy a rectangular area from one part of the bitmap to another. - - @param rRectDst - Destination rectangle in this bitmap. This is clipped to the - bitmap dimensions. - - @param rRectSrc - Source rectangle in this bitmap. This is clipped to the - bitmap dimensions. Note further that no scaling takes place - during this copy operation, i.e. only the minimum of source - and destination rectangle's width and height are used. - - @return true, if the operation completed successfully. false - is not only returned when the operation failed, but also if - nothing had to be done, e.g. because one of the rectangles are - empty. - */ - bool CopyPixel( - const tools::Rectangle& rRectDst, - const tools::Rectangle& rRectSrc ); - /** Fill the entire bitmap with the given color @param rFillColor diff --git a/vcl/source/bitmap/BitmapEx.cxx b/vcl/source/bitmap/BitmapEx.cxx index 40feacbf66dd..4246861679e4 100644 --- a/vcl/source/bitmap/BitmapEx.cxx +++ b/vcl/source/bitmap/BitmapEx.cxx @@ -407,19 +407,6 @@ void BitmapEx::Expand( sal_Int32 nDX, sal_Int32 nDY, bool bExpandTransparent ) "BitmapEx::Expand(): size mismatch for bitmap and alpha mask."); } -bool BitmapEx::CopyPixel( const tools::Rectangle& rRectDst, const tools::Rectangle& rRectSrc ) -{ - if( maBitmap.IsEmpty() ) - return false; - - bool bRet = maBitmap.CopyPixel( rRectDst, rRectSrc ); - - if( bRet && !maAlphaMask.IsEmpty() ) - maAlphaMask.CopyPixel( rRectDst, rRectSrc ); - - return bRet; -} - bool BitmapEx::CopyPixel( const tools::Rectangle& rRectDst, const tools::Rectangle& rRectSrc, const BitmapEx& rBmpExSrc ) { -- cgit