From 6c0f5f7f2a6cc122a738deb0a17353cca1cd5c7e Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 25 Mar 2019 15:55:37 +0200 Subject: loplugin:unusedmethods Change-Id: I8bbf439d69a330a9ad28ff52cc49a9fec2c12500 Reviewed-on: https://gerrit.libreoffice.org/69684 Tested-by: Jenkins Reviewed-by: Noel Grandin --- cui/source/factory/dlgfact.cxx | 11 ----------- cui/source/factory/dlgfact.hxx | 9 --------- include/sfx2/basedlgs.hxx | 4 ---- include/sfx2/tabdlg.hxx | 7 ------- include/svx/dbaexchange.hxx | 21 --------------------- include/vcl/svlbitm.hxx | 1 - include/vcl/treelistbox.hxx | 1 - sfx2/source/dialog/basedlgs.cxx | 13 ------------- sfx2/source/dialog/tabdlg.cxx | 18 ------------------ svx/source/fmcomp/dbaexchange.cxx | 29 ----------------------------- vcl/source/treelist/svlbitm.cxx | 5 ----- 11 files changed, 119 deletions(-) diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx index 91b3e943621b..08fea16c4049 100644 --- a/cui/source/factory/dlgfact.cxx +++ b/cui/source/factory/dlgfact.cxx @@ -97,7 +97,6 @@ using ::com::sun::star::uno::Reference; using namespace svx; // AbstractTabDialog implementations just forwards everything to the dialog -IMPL_ABSTDLG_BASE(CuiAbstractSfxDialog_Impl) short CuiAbstractController_Impl::Execute() { @@ -343,16 +342,6 @@ void CuiAbstractSingleTabController_Impl::SetText(const OUString& rStr) m_xDlg->set_title(rStr); } -const SfxItemSet* CuiAbstractSfxDialog_Impl::GetOutputItemSet() const -{ - return pDlg->GetOutputItemSet(); -} - -void CuiAbstractSfxDialog_Impl::SetText( const OUString& rStr ) -{ - pDlg->SetText( rStr ); -} - SvxDistributeHorizontal AbstractSvxDistributeDialog_Impl::GetDistributeHor()const { return m_xDlg->GetDistributeHor(); diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx index 83e156abbf97..dae667cd312e 100644 --- a/cui/source/factory/dlgfact.hxx +++ b/cui/source/factory/dlgfact.hxx @@ -96,15 +96,6 @@ public: virtual short Execute() override; }; -class CuiAbstractSfxDialog_Impl : public SfxAbstractDialog -{ - DECL_ABSTDLG_BASE(CuiAbstractSfxDialog_Impl,SfxModalDialog) - virtual const SfxItemSet* GetOutputItemSet() const override; - - //From class Window. - virtual void SetText( const OUString& rStr ) override; -}; - class CuiAbstractSingleTabController_Impl : public SfxAbstractDialog { std::unique_ptr m_xDlg; diff --git a/include/sfx2/basedlgs.hxx b/include/sfx2/basedlgs.hxx index f58feba3cba2..311d7d397f06 100644 --- a/include/sfx2/basedlgs.hxx +++ b/include/sfx2/basedlgs.hxx @@ -142,9 +142,7 @@ protected: virtual ~SfxModelessDialogController() override; public: - void FillInfo(SfxChildWinInfo&) const; void Initialize (SfxChildWinInfo const * pInfo); - void DeInit(); virtual void Close() override; virtual void EndDialog() override; virtual void Activate() override; @@ -221,8 +219,6 @@ public: void SetTabPage(SfxTabPage* pTabPage); SfxTabPage* GetTabPage() const { return pImpl->m_pSfxPage; } - OKButton* GetOKButton() const { return pOKBtn; } - private: VclPtr pOKBtn; VclPtr pCancelBtn; diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx index 3b858cf4a7f5..0f6babf2774a 100644 --- a/include/sfx2/tabdlg.hxx +++ b/include/sfx2/tabdlg.hxx @@ -134,7 +134,6 @@ public: CreateTabPage pCreateFunc, // != 0 sal_uInt16 nPos = TAB_APPEND); - void RemoveTabPage( const OString& rName ); // Name of the label for the page in the notebook .ui void RemoveTabPage( sal_uInt16 nId ); void SetCurPageId(sal_uInt16 nId) @@ -169,14 +168,8 @@ public: void SetInputSet( const SfxItemSet* pInSet ); const SfxItemSet* GetOutputItemSet() const { return m_pOutSet.get(); } - const PushButton& GetOKButton() const { return *m_pOKBtn; } - PushButton& GetOKButton() { return *m_pOKBtn; } - const CancelButton& GetCancelButton() const { return *m_pCancelBtn; } - CancelButton& GetCancelButton() { return *m_pCancelBtn; } - short Execute() override; bool StartExecuteAsync( VclAbstractDialog::AsyncContext &rCtx ) override; - void Start(); const SfxItemSet* GetExampleSet() const { return m_pExampleSet; } diff --git a/include/svx/dbaexchange.hxx b/include/svx/dbaexchange.hxx index ffae51c0849a..1a5927f84dfc 100644 --- a/include/svx/dbaexchange.hxx +++ b/include/svx/dbaexchange.hxx @@ -53,15 +53,6 @@ namespace svx class SAL_WARN_UNUSED SVX_DLLPUBLIC OColumnTransferable final : public TransferableHelper { public: - /** construct the transferable - */ - OColumnTransferable( - const OUString& _rDatasource - ,const OUString& _rCommand - ,const OUString& _rFieldName - ,ColumnTransferFormatFlags _nFormats - ); - /** construct the transferable from a data access descriptor Note that some of the aspects, in particular all which cannot be represented @@ -135,18 +126,6 @@ namespace svx static ODataAccessDescriptor extractColumnDescriptor(const TransferableDataHelper& _rData); - /** adds the data contained in the object to the given data container -

This method helps you treating this class as simple container class:
- At the moment, it is a data container and a transferable. - Using addDataToContainer, you can treat the class as dumb data container, - doing the Drag'n'Drop with a TransferDataContainer instance (which may contain - additional formats)

- @TODO - split this class into a two separate classes: one for the data container aspect, one for - the transfer aspect - */ - void addDataToContainer( TransferDataContainer* _pContainer ); - private: // TransferableHelper overridables virtual void AddSupportedFormats() override; diff --git a/include/vcl/svlbitm.hxx b/include/vcl/svlbitm.hxx index c5e478a6d539..e5c5f6dd840c 100644 --- a/include/vcl/svlbitm.hxx +++ b/include/vcl/svlbitm.hxx @@ -190,7 +190,6 @@ public: void SetStateUnchecked(); void SetStateTristate(); void SetStateHilighted(bool bHilight); - void SetStateInvisible(); SvLBoxButtonKind GetKind() const { return eKind; } diff --git a/include/vcl/treelistbox.hxx b/include/vcl/treelistbox.hxx index 7031c0954acd..b90ee4b9fdb4 100644 --- a/include/vcl/treelistbox.hxx +++ b/include/vcl/treelistbox.hxx @@ -496,7 +496,6 @@ public: void EnableCellFocus(); // For overwriting accessible role for all entries - normally 0, so each entry can be different - void SetAllEntriesAccessibleRoleType( SvTreeAccRoleType n ) { nAllItemAccRoleType = n; } SvTreeAccRoleType GetAllEntriesAccessibleRoleType() const { return nAllItemAccRoleType; } SvTreeFlags GetTreeFlags() const {return nTreeFlags;} diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx index b7174b1ff76d..ce416ad935e4 100644 --- a/sfx2/source/dialog/basedlgs.cxx +++ b/sfx2/source/dialog/basedlgs.cxx @@ -506,19 +506,6 @@ void SfxModelessDialogController::Close() SfxCallMode::RECORD|SfxCallMode::SYNCHRON, { &aValue } ); } -/* [Description] - - Fills a SfxChildWinInfo with specific data from SfxModelessDialog, - so that it can be written in the INI file. It is assumed that rinfo - receives all other possible relevant data in the ChildWindow class. - ModelessDialogs have no specific information, so that the base - implementation does nothing and therefore must not be called. -*/ -void SfxModelessDialogController::FillInfo(SfxChildWinInfo& rInfo) const -{ - rInfo.aSize = m_xDialog->get_size(); -} - bool SfxFloatingWindow::EventNotify( NotifyEvent& rEvt ) /* [Description] diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx index 4fcc3cc25653..c73265b406d5 100644 --- a/sfx2/source/dialog/tabdlg.cxx +++ b/sfx2/source/dialog/tabdlg.cxx @@ -564,18 +564,6 @@ bool SfxTabDialog::StartExecuteAsync( VclAbstractDialog::AsyncContext &rCtx ) return TabDialog::StartExecuteAsync( rCtx ); } -void SfxTabDialog::Start() -{ - m_pImpl->bModal = false; - Start_Impl(); - - Show(); - - if ( IsVisible() && ( !HasChildPathFocus() || HasFocus() ) ) - GrabFocusToFirstControl(); -} - - void SfxTabDialog::Start_Impl() { assert(m_pImpl->aData.size() == m_pTabCtrl->GetPageCount() @@ -685,12 +673,6 @@ void SfxTabDialog::RemoveTabPage( sal_uInt16 nId ) } } -void SfxTabDialog::RemoveTabPage(const OString &rName) -{ - RemoveTabPage(m_pTabCtrl->GetPageId(rName)); -} - - void SfxTabDialog::PageCreated /* [Description] diff --git a/svx/source/fmcomp/dbaexchange.cxx b/svx/source/fmcomp/dbaexchange.cxx index a01525cfc00d..0e52f13f10d0 100644 --- a/svx/source/fmcomp/dbaexchange.cxx +++ b/svx/source/fmcomp/dbaexchange.cxx @@ -41,16 +41,6 @@ namespace svx using namespace ::com::sun::star::container; using namespace ::com::sun::star::datatransfer; - OColumnTransferable::OColumnTransferable(const OUString& _rDatasource - ,const OUString& _rCommand - ,const OUString& _rFieldName - ,ColumnTransferFormatFlags _nFormats) - :m_nFormatFlags(_nFormats) - { - implConstruct(_rDatasource,OUString(), css::sdb::CommandType::TABLE, _rCommand, _rFieldName); - } - - OColumnTransferable::OColumnTransferable(const ODataAccessDescriptor& _rDescriptor, ColumnTransferFormatFlags _nFormats ) :m_nFormatFlags(_nFormats) { @@ -341,25 +331,6 @@ namespace svx } - void OColumnTransferable::addDataToContainer( TransferDataContainer* _pContainer ) - { - OSL_ENSURE( _pContainer, "OColumnTransferable::addDataToContainer: invalid container!" ); - if ( _pContainer ) - { - if ( m_nFormatFlags & ColumnTransferFormatFlags::FIELD_DESCRIPTOR ) - _pContainer->CopyAny( SotClipboardFormatId::SBA_FIELDDATAEXCHANGE, makeAny( m_sCompatibleFormat ) ); - - if ( m_nFormatFlags & ColumnTransferFormatFlags::CONTROL_EXCHANGE ) - _pContainer->CopyAny( SotClipboardFormatId::SBA_CTRLDATAEXCHANGE, makeAny( m_sCompatibleFormat ) ); - - if ( m_nFormatFlags & ColumnTransferFormatFlags::COLUMN_DESCRIPTOR ) - { - Any aContent = makeAny( m_aDescriptor.createPropertyValueSequence() ); - _pContainer->CopyAny( getDescriptorFormatId(), aContent ); - } - } - } - ODataAccessObjectTransferable::ODataAccessObjectTransferable( const OUString& _rDatasource ,const sal_Int32 _nCommandType diff --git a/vcl/source/treelist/svlbitm.cxx b/vcl/source/treelist/svlbitm.cxx index 8edd585539f8..76d67ff36b49 100644 --- a/vcl/source/treelist/svlbitm.cxx +++ b/vcl/source/treelist/svlbitm.cxx @@ -361,11 +361,6 @@ bool SvLBoxButton::CheckModification() const return eKind == SvLBoxButtonKind::EnabledCheckbox; } -void SvLBoxButton::SetStateInvisible() -{ - isVis = false; -} - // *************************************************************** // class SvLBoxContextBmp // *************************************************************** -- cgit