summaryrefslogtreecommitdiffstats
path: root/xmloff
Commit message (Collapse)AuthorAgeFilesLines
* Resolves: rhbz#976304 gallery elements may not support document.SettingsCaolán McNamara2013-06-231-8/+9
| | | | | | | | | so the createInstance throws, so the element doesn't get inserted into the documents. regression since f0cd6fe9075cd0aa00162474784ad804a07ed138 Change-Id: Ie6cef7a4f0d5ac8a34d41139c3439fc04e9c7f20
* fdo#43460 xmloff: use isEmpty()Jelle van der Waa2013-06-1915-28/+27
| | | | | | | Change-Id: I298767cc0ec03c22d3ae687939f0f9d5ce1963c1 Reviewed-on: https://gerrit.libreoffice.org/4348 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
* use the implicit conversionMarkus Mohrhard2013-06-161-2/+2
| | | | Change-Id: I1d4739721c297e6d5605d93b6e86e114ea12db85
* use proper offset for additional locale data formats, fdo#64947 relatedEike Rathke2013-06-151-1/+1
| | | | | | | | | | | | | | | | | Old number formats had predefined formats from 0..49, locale data could define additional formats from index 50 on. Internal (fractional) formats were added to the number formatter, shifting the number of predefined entries NF_INDEX_TABLE_ENTRIES by two that was also used as an offset to determine whether a format needed to be added additionally. As a consequece, formats defined with index values 50 and 51 in locale data were ignored and not available in the dialog. Introduced a new enum constant NF_INDEX_TABLE_LOCALE_DATA_DEFAULTS to use as the old offset value for not having to change all locale data definitions everytime an internally generated format is added. Change-Id: I94bdaabf360f7b9c253b1e3f5b73087f0c45fb44
* Introduce O[U]String::toUInt32Stephan Bergmann2013-06-131-2/+5
| | | | | | | | | | | | | | | ...which has become necessary since bd60d41176da540b01d7583cfe00637431967f39 "Handle oveflow in O(U)String::toInt() functions" reduces values in the range (SAL_MAX_INT32 .. SAL_MAX_UINT32] to zero, but some calls of toInt32(16) relied on getting a correct (unsigned) value for the whole input range ["0" .. "FFFFFFFF"] (see libreoffice-4-1 commit 9bf6c83367cedb7be81bf67f30d2147d26c7a8c3 "Revert overflow checks in O[U]String::toInt{32,64} again"). Audited all uses of toInt32/64 with non-decimal radix. (There is still a TODO comment in oox/source/helper/attributelist.cxx, and stoc/source/typeconv/convert.cxx will still need some love and test code.) Change-Id: Iadaca1c0e41dab553687d0ce41c20c10cd657a95
* remove method without definitionMarkus Mohrhard2013-06-131-5/+0
| | | | Change-Id: Ia41f28ed31fc254a6785c6444a78822eb969f2f9
* Resolves: #i121455# Adapted from NonPrimitive to non-primitive...Armin Le Grand2013-06-081-1/+1
| | | | | | | | | | | | | | as used in the spec Patch by: Regina Review by: alg (cherry picked from commit af6ada82a4634e4b64faf811eaf527c167c334bf) Conflicts: xmloff/source/draw/shapeexport4.cxx Change-Id: I2fe339ba35cf589a9d4034446c671d4f09b0c0f0
* For backward compatibility take mirrorings in setTransformation into accountArmin Le Grand2013-06-072-16/+60
| | | | | | | | | | | | Also found an error in SdrObjCustomShape::TRGetBaseGeometry when MirrorY was used (cherry picked from commit 4116c33b12d3787c406f0348f89efcb1cf409507) Conflicts: xmloff/source/draw/ximpshap.cxx xmloff/source/draw/ximpshap.hxx Change-Id: Id85ae4c4f5e26d53d501c72b84fc0e1b5cfe23b2
* Resolves: #i49853# comment the DTD to emphasize that this DTD is...Dennis E. Hamilton2013-06-071-0/+12
| | | | | | | | | | | | for OpenOffice.org 1.x XML Documents and is not a DTD for any ODF document. (cherry picked from commit 7061d6dbf8d446e96d0ad13ea308f421ea6a424b) Conflicts: xmloff/dtd/office.dtd Change-Id: If2a084e86f935c9dddfbd3a4aa5e2d76473b7d9d
* remove unused componentcontext.hxx includesNoel Grandin2013-06-052-2/+0
| | | | Change-Id: I598926b72c5540b472f9607e2f3df134a8c50048
* fix for unused return value.Noel Grandin2013-06-031-1/+1
| | | | | | | | | | | | | | | | This code was introduced by: commit d09dd8986436f17717443823ef18bd8552fdf408 Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Wed Sep 15 13:55:34 2010 +0200 dba34a: export/import min-/max-/default-/value for date/time as XML-Schema conformant strings It looks like it intended to use determineDefaultServiceName(), but neglected to store the return value. Change-Id: I1607f39cf771b594389492785c7e72478d44843a Reviewed-on: https://gerrit.libreoffice.org/4140 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
* Resolves: #i121507# Added comma to whitespace listArmin Le Grand2013-05-301-3/+18
| | | | | | (cherry picked from commit c9e446d6f79908ed4af06e7940788e91b924b793) Change-Id: I790bfada597e276f9f9e1d07f7208db6d1059f0f
* WaE: implicit conversion of NULL constant to nullptr_tTor Lillqvist2013-05-241-1/+1
| | | | Change-Id: I2eefbca1ef986219f04504cba4ca09a22972e8cb
* prevent invalid files if file contains currency formatsMarkus Mohrhard2013-05-231-1/+5
| | | | | | A regression from writing error cell information into the file. Change-Id: Idb55646094fcd76912bdcd2102370681bcc8703d
* WaE: function will cause runtime stack overflowTor Lillqvist2013-05-222-2/+3
| | | | | | | | | | Revert misguided changes from 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 that obviously would cause endless recursion if these functions were ever entered. Thanks to MSVC2012 for the nice warning. Change-Id: I8504aa8ac141164ec6e026cc4fa873f8273f92bd
* Use the new type-checking Reference constructor to reduce code noiseNoel Grandin2013-05-2210-44/+26
| | | | | | | | | | Also create a Clang compiler plugin to detect such cases. Change-Id: I61ad1a1d6b1c017eeb51f226d2dde0e9bb7f1752 Reviewed-on: https://gerrit.libreoffice.org/4001 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* set some bug id prefixes to indicate which tracker they are fromCaolán McNamara2013-05-182-2/+2
| | | | Change-Id: I5df2dd44a0612da893b1afe08d0c7a9ea71f3905
* i121972 Use svg rx/ry/cx/cy defines in draw:ellipse when used(cherry picked ↵Armin Le Grand2013-05-181-0/+9
| | | | from commit 19abb8de7e218ba08b2fa79c0379844303da328a)
* #121090# corrceted point reduction on svg:d export to only happen when ↵Armin Le Grand2013-05-181-1/+3
| | | | polygon is closed(cherry picked from commit 6e114c242bb21950fd8ea01885c2269744d0fc6f)
* i121965 Take draw:transform into account for draw:connector shapesArmin Le Grand2013-05-181-1/+29
| | | | | | | | | (cherry picked from commit 7b3f5521bd3c400cd9e08b745176b4ce40885011) Conflicts: xmloff/source/draw/ximpshap.cxx Change-Id: I973627f85ce6463c863863d6c180cb4c2cab86d0
* sw: change pool default of RES_FOLLOW_TEXT_FLOW to "false"Michael Stahl2013-05-151-6/+4
| | | | | | | | | | | | | | | For a new document the default is already effectively "false" due to SwDocShell::InitNew() and the ODF and WW8 filters set it explicitly to false... which is also the appropriate value for RTF and DOCX. But only OOoXML and (perhaps) HTML (not sure) want "true" as the default. It is also mysteriously reset to "true" in SwDoc::RemoveAllFmtLanguageDependencies() (which is called after loading a template) for no apparent reason. Change-Id: If5ad33c99f97412cb3ad4f9cec32f47825ed6f6b
* i#119922: reverse engineer 9a37613b5e8f08fae585d54a5745e887eb08f8ceMichael Stahl2013-05-151-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is not quite obvious what that commit attempts to do... especially since the bugdoc attachment does not actually exercise the code that was added in the commit, which changes the handling of the "IsFollowingTextFlow" property. The corresponding ODF attribute is style:flow-with-text, which has been added in OOo 2.0. Investigation revels that MSO's ODF filter does not support this attribute and acts as if it always had value "false". The code in FillBaseProperties effectively acts as a default if the value is not set; the ODF spec does not specify what the default should be. But when an ODF document was written by MSO, "false" makes more sense than the previous "true" default. Except when the document is not ODF but OOoXML format, which indicates it's likely written by OOo 1.x which did not support the attribute and acts as if it always had value "true". The Writer UNO API implementation is however not the right place for format specific handling, so replace that with an addition to the function reading the default graphic style that sets the "IsFollowingTextFlow" property to false as a default, which should have the same effect because all styles inherit from it. Note: MSO 2010 Word always writes a default graphic style into ODF docs. This has a side effect for loaded ODF documents: various newly inserted objects have the property turned off then. But it turns out this is actually an advantage, since the same behavior already exists for _new_ documents (see SwDocShell::InitNew) so it is more consistent now. Change-Id: Iba6444a0515fd583398ff052fc5018254da31c30
* factor out SvXMLImport::IsOOoXML()Michael Stahl2013-05-151-5/+28
| | | | Change-Id: I9ccfe565bde1112f9f3cb8c666e901bf121862dc
* Fix build.Thorsten Behrens2013-05-151-8/+0
| | | | Change-Id: I5b2de61407924cdde5d74a7ea639365a876de74e
* Fix fdo#64512 Handle xml:id correctly on multi-image draw:framesThorsten Behrens2013-05-152-64/+37
| | | | | | | | | | | | | | | | | | Fixes a regression from the pick-best-image from draw:frame in ODF, where before sometimes the XShape got deleted that the UnoInterfaceToUniqueIdentifierMapper::registerReference stored. For that, added a UnoInterfaceToUniqueIdentifierMapper::registerReferenceAlways function, which overwrites potentially existing earlier entries with the same identifier string. This fix was originally much more messy, but then dtardon committed 30b248dfe5bfb8a0649e36f22c943b3feb2f1385 which also fixes this here bug. Now only sneaking in slightly less involved interface map handling and a safeguard in ximpshap.cxx. Change-Id: I87501e43518a5fc2fee166c45a4e2f01718f5228
* Remove redundant doxygen doc strings.Thorsten Behrens2013-05-151-16/+0
| | | | | | This is already (identically) documented in the header file. Change-Id: I4a10cb0c1d1b1eee80fd828ab95829fb8128433f
* Use upper camel case for class names in xmloff.Thorsten Behrens2013-05-155-8/+8
| | | | | | Align multiimagehelper with module standard. Change-Id: I70a4dbc66a0d127b9bf04d1e8db694d3526b21d7
* Spelling "separate" (etc) correctly is hardTor Lillqvist2013-05-153-6/+6
|
* fdo#46808, Convert chart2::RegressionEquation service to new styleNoel Grandin2013-05-151-36/+28
| | | | | | The service already existed, it just needed an IDL file Change-Id: I56b7079b098a7615dfb24598d15fe7d57691f317
* fdo#46808, Convert some XMultiServiceFactory to XComponentContextNoel Grandin2013-05-153-22/+20
| | | | Change-Id: I2e3480bf4f616231ee50a83f440d9bb0955e4ce6
* typo fix: s/inavlid/invalid/Andras Timar2013-05-141-1/+1
| | | | Change-Id: If75cad038f35033be6dcad6f051673bd795accf3
* fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTRadu Ioan2013-05-147-88/+76
| | | | | | | | | | - replaced osl_trace with sal_info - replaced dbg_* with sal_* Change-Id: I80aca85562e4a43fded5c37f9895e51f79e42c14 Reviewed-on: https://gerrit.libreoffice.org/3771 Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr> Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
* Resolves: #i122208# introduce rtl::CStringHash and rtl::CStringEqualHerbert Dürr2013-05-101-15/+1
| | | | | | | | | | | | | | | | | | unify the various c-string compares and hashes. (cherry picked from commit b7e3470a154538a92f0a21b14e726d75723f4a92) Conflicts: oox/inc/oox/export/shapes.hxx oox/source/export/shapes.cxx sal/inc/rtl/string.hxx sdext/source/minimizer/pppoptimizertoken.cxx svx/source/customshapes/EnhancedCustomShapeTypeNames.cxx vcl/source/glyphs/gcach_ftyp.cxx writerfilter/source/resourcemodel/TagLogger.cxx xmloff/source/draw/EnhancedCustomShapeToken.cxx Change-Id: Ib742744077bfb4d38a462d88b44bdef45601b4ae
* Update pchAurimas Fišeras2013-05-091-0/+1
| | | | | | | Change-Id: I7c0c9158eb17cb79ffceae6770b4c513d57b3817 Reviewed-on: https://gerrit.libreoffice.org/3831 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
* officecfg: remove Package_cppheaderMichael Stahl2013-05-071-0/+4
| | | | | | Instead include generated headers directly from workdir. Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
* fix typos (wich instead of which)Philipp Riemer2013-05-061-1/+1
|
* install openoffice 1.0 DTD files using filelistDavid Tardon2013-05-041-17/+20
| | | | | | | Do we need to install them? Or even have them in the sources, FWIW? The old XML format has been superceded by ODF 10 years ago... Change-Id: I909afcf86ae808441c7dbc6182512bedb9789c1c
* fdo#48056 treat report chart as draw chartLionel Elie Mamane2013-05-031-1/+2
| | | | Change-Id: I0a716b4339747f1994e5c8710e15474807aea4a2
* janitorial: indentationLionel Elie Mamane2013-05-031-1/+1
| | | | Change-Id: I6886f5ed011871a1c2718c9e1fadc9d0cb053098
* add a warningDavid Tardon2013-05-031-0/+8
| | | | Change-Id: I0baf90cfe8d3caa96f826695c1be4bc563864c00
* fdo#60075 need to return context when availableDavid Tardon2013-05-031-0/+4
| | | | Change-Id: I53a83a3f2234dc061c23344116b0e294594f1c90
* fdo#60075 open drawings with connector attached to SVGDavid Tardon2013-05-033-7/+77
| | | | | | | | | | | | | | | | | | | | | | | This problem arises when there is a connector attached to draw:frame element with multiple draw:image elements in it. The import code expects that they are different representations of the same image (I have not found if this is specified in ODF), so it only selects the most "suitable" for import. To do that, it imports them all and then removes all but the selected one. The image import context, SdXMLGraphicObjectShapeContext, shares the parent frame's attributes, which means that all the images in a frame have got the same ID. in SdXMLGraphicObjectShapeContext::AddShape, the created css::draw::XShape is registered with its ID... That means that anything that refers to the frame's ID, like a draw:connector, will always get the _first_ image in the frame. Solution is to extend comphelper::UnoInterfaceToUniqueIdentifierMapper to allow reserving an identifier and setting an interface for it later. That way, SdXMLFrameShapeContext can reserve its own ID before it starts importing the first draw:image, and then set the selected XShape at the end. Change-Id: I2e11cfd38e1e3534df2b3c01d85da0d755a266c3
* the var. must be persistent over multiple callsDavid Tardon2013-05-032-3/+4
| | | | Change-Id: Ieb48dfe85ed16a8123917b30873f301d523ea381
* ditch explicit char arrays for string literalsLuboš Luňák2013-05-022-123/+49
| | | | Change-Id: I77a4f6d338751c00942f091f4267e5f7d1d1742f
* Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks2013-04-304-100/+16
|
* Fix fdo#64062 - can't assume para styles to be there.Thorsten Behrens2013-04-301-1/+1
| | | | Change-Id: I5da53ff44fdf00ec6c0fdf1a722f806971b6683a
* some more namespace cleanupThomas Arnhold2013-04-262-33/+28
| | | | Change-Id: Ib1e80d717f199db8f8ac4181d4377a86d88e3244
* add error to office:value-type for calc cells and fdo#51810Markus Mohrhard2013-04-251-13/+14
| | | | | | | | For cached value import we need the information which cells are error cells. For ODF 1.2 extended we therefore export now calcext:office-value with the additional value "error". Change-Id: I9bc988ea4924bea767ba5e504b77f6a16e51a82e
* update pchThomas Arnhold2013-04-251-1/+1
| | | | Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47
* comments and code reformatMaxime de Roucy2013-04-255-10/+33
| | | | | | | Change-Id: Ib4e45cb85c9e5e5ffa6476c939300c6795412b1a Reviewed-on: https://gerrit.libreoffice.org/3582 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>