summaryrefslogtreecommitdiffstats
path: root/vcl/source
Commit message (Collapse)AuthorAgeFilesLines
...
* remove unnecessary parentheses in case labelsNoel Grandin2016-03-1512-217/+217
| | | | Change-Id: I987bf68c767709080c67c8b183c036a4109c6caa
* loplugin:constantparamNoel Grandin2016-03-155-10/+9
| | | | Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
* tdf#95845 Use CommandInfoProvider to receive UNO command labelsSusobhan Ghosh2016-03-141-0/+33
| | | | | | | | | | Added GetCommandPropertyFromModule to CommandInfoProvider. Removed GetCommandText. Change-Id: Ie987984b6465d540029196df371c0c0467999a59 Reviewed-on: https://gerrit.libreoffice.org/22918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* GetEnglishSearchFontName is what is supposed to use hereDouglas Mencken2016-03-141-3/+5
| | | | Change-Id: I210359c28b5e66b64627cb49cdf388ee35015a92
* coverity#1355505 Uninitialized pointer fieldCaolán McNamara2016-03-131-6/+17
| | | | Change-Id: I95259c8a572529f47ef4fddf59f9ca29d078b6f4
* add assert preventing memory leakMarkus Mohrhard2016-03-131-0/+1
| | | | Change-Id: I0c659bf4fab2319f06df09dd11a768a295e95722
* fix strange memory leak in VclBuilderMarkus Mohrhard2016-03-131-1/+1
| | | | Change-Id: Iba34c25b19a94a8d4c147f8ccaef95f34183414b
* vcl graph: stop abusing a pointer for a boolNorbert Thiebaud2016-03-123-24/+40
| | | | | | | | Change-Id: I816fe3a52c03fa5a3fd372492985783f9f6ff91c Reviewed-on: https://gerrit.libreoffice.org/23181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#97966: Remove 'static' keywordsWastack2016-03-111-2/+2
| | | | | | | Change-Id: Id70f9e55fb4ad7d3a501399b055208ea10369c82 Reviewed-on: https://gerrit.libreoffice.org/23131 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#97966: Remove 'static' keywordsWastack2016-03-111-2/+2
| | | | | | | Change-Id: I67e6076d65b90fb386ab439c5716820a6322af38 Reviewed-on: https://gerrit.libreoffice.org/23130 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#97966: Remove 'static' keywordsWastack2016-03-111-1/+1
| | | | | | | Change-Id: I0a3f17d43917d05734980329231ef6e7cadfd58a Reviewed-on: https://gerrit.libreoffice.org/23129 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Avoid reserved identifier, remove unnecessary typedefStephan Bergmann2016-03-102-2/+2
| | | | Change-Id: I2dfce92ef98ca18ac0fe2c415240216228b4ee0a
* Avoid reserved identifierStephan Bergmann2016-03-101-4/+4
| | | | Change-Id: I554fde45000114dd19f117d93ef5c7a780231594
* Avoid reserved identifierStephan Bergmann2016-03-102-3/+3
| | | | Change-Id: Ie62bbf64a9cdb74725fd48a8f8dcc1ab76d97219
* Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann2016-03-103-9/+9
| | | | Change-Id: I6c0aaac10b2244271f3cdf45f4eceb6d685b213c
* Avoid reserved identifiersStephan Bergmann2016-03-101-4/+4
| | | | Change-Id: I751e75e0b63e95cc92be7b61a77ed21eeb52bc1f
* Related: tdf#98419 gtk3: reimplement passing window move control to wm...Caolán McNamara2016-03-103-9/+11
| | | | | | | | | | | | | | for wayland Dragging toolbars around to move them (starting with an undocked toolbar, not the moving outline fake thing) doesn't work under wayland (as far as I can see) without using gtk_window_begin_move_drag i.e. gtk_window_move doesn't work. But this is supposed to be used from the initial mouse click (while it works under wayland from a move, it doesn't work under X from a move) so rework the last attempt to occur right at the initial click to drag. Change-Id: I612f188b3e8482307bc816f5aa775530e6092eda
* Resolves: rhbz#1315385 use preferred size if widget supports itCaolán McNamara2016-03-091-1/+1
| | | | | | | when deciding if a popup needs to be placed up or down to stay visible on screen Change-Id: I718e0ee4a79152e919ac95841e15d4b53764ac78
* Add missing includesDavid Ostrovsky2016-03-091-0/+1
| | | | | | | | | | These include were needed to compile on Windows, MSVC 14.0 with clang-cl. Change-Id: I4ca5cec8314920e90fcca6fa69ec4df87d680f29 Reviewed-on: https://gerrit.libreoffice.org/23044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#98052 - even polygons were not drawn on the alpha deviceMarco Cecchetti2016-03-081-0/+2
| | | | | | | Change-Id: I5725ec23869b295c8021bef0330ee6f69f206351 Reviewed-on: https://gerrit.libreoffice.org/23024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* convert custom bibliography toolbar to .ui formatCaolán McNamara2016-03-081-0/+25
| | | | Change-Id: I70eb0e2ff96879d1168b241852a0079f540b0319
* loplugin:constantparams in vclNoel Grandin2016-03-0813-62/+52
| | | | | | | Change-Id: I2114436f4bef3ac71a3035a206186cefaf88bca1 Reviewed-on: https://gerrit.libreoffice.org/23023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Bin unneeded inclusions of dbggui.hxxTor Lillqvist2016-03-083-3/+0
| | | | Change-Id: I5cac6fb0278e3952e2538f06188ed510644fcaa0
* Bin a pointless level of macro abstractionTor Lillqvist2016-03-081-2/+6
| | | | Change-Id: I343844aca956a1ce05c733f60a28d51115574ef8
* Resolves: tdf#98425 gtk3: grab the SolarMutex when setting the clipboardCaolán McNamara2016-03-071-1/+1
| | | | Change-Id: Ic439affbd69532534f5caf82a743786d5975939e
* loplugin:unuseddefaultparamsNoel Grandin2016-03-075-22/+11
| | | | | | | Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#96099 Reduce number of trivial typedefsChirag Manwani2016-03-071-4/+3
| | | | | | | Change-Id: I39e9fcfdf2203239ac56d1c8195ca7ac07054817 Reviewed-on: https://gerrit.libreoffice.org/22898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* improve defaultparams lopluginNoel Grandin2016-03-072-7/+7
| | | | | | | | | to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unuseddefaultparam in variousNoel Grandin2016-03-072-10/+7
| | | | | | | Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* opengl: fix loading shader with preamble that uses #versionTomaž Vajngerl2016-03-071-2/+2
| | | | | | | The preamble was inserted into a false position so the shader could was constructed incorrectly and would fail to compile. Change-Id: I4c51adde9014a326bbe38a5d2d17dd0047e33195
* tdf#79679 vcl: dashed lines show as solid lines when importing EMF filesChris Sherlock2016-03-043-34/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Issue is a regression in commit 09c722873b2d378d2d155f5f1dd7d8f3fb2012e9. (EMF/WMF: fix rendering of pen styles (dash, dot, dashdot, dashdotdot). I've looked at how the latest version of Word on the Mac works, and it turns out that the spacings for the PenStyle enumerations in the LogPen objects for all the create pen EMF records are as follows: * PS_DOT - ■ □ ■ □ ■ □ ■ □ ■ □ ■ * PS_DASHDOT - ■ ■ ■ □ ■ □ ■ ■ ■ □ ■ * PS_DASHDOTDOT - ■ ■ ■ □ ■ □ ■ □ ■ ■ ■ (where ■ is the actual filled in area, and □ is the space between the filled in areas) In other words, each dash fills in the space of three dots, and there is the one dot worth of empty space between the dashes and dots. Each "dot" has a width and height equal to the width specified in the pen. So basically, we seem to be arbitrarily setting the dot, dash and distance lengths arbitrarily, which were reasonable guesses but tended to produce very odd lines at different zoom levels. Change-Id: Ie8b5fa396e4fb0f480cb3594c8129a59f472c1b8 Reviewed-on: https://gerrit.libreoffice.org/22886 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* tdf#98052 - polypolygons were not drawn on the alpha deviceMarco Cecchetti2016-03-041-0/+2
| | | | | | | | | | In OutputDevice::DrawPolyPolygon when b2dpolygon are used for drawing the source polygon is not drawn on the alpha device. Change-Id: I54f4e5a13469d9844866cea61b074420219b836d Reviewed-on: https://gerrit.libreoffice.org/22892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* -Werror,-WshadowStephan Bergmann2016-03-041-4/+4
| | | | | | | | | | Where wglChoosePixelFormatARB is defined as a macro expanding to __wglewChoosePixelFormatARB (as WGLEW_GET_FUN is just expanding to its argument), and __wglewChoosePixelFormatARB is declared in global scope in workdir/UnpackedTarball/glew/include/GL/wglew.h. itself) in workdir/UnpackedTarball/glew/include\GL/wglew.h Change-Id: I0c4d09e9112c2233d25a262ea1f2b35bdf49645c
* loplugin:unuseddefaultparams in vcl and xmloffNoel Grandin2016-03-0410-68/+40
| | | | | | | | | and teach the plugin about code that takes the address of a function Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc Reviewed-on: https://gerrit.libreoffice.org/22861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1355126 Logically dead codeCaolán McNamara2016-03-031-8/+5
| | | | | | | maybe we should be using more precision, but we haven't been in the past Change-Id: Icf1e1e95099c783435e04f60d8ade755a8d2d4d5
* nLog10Divisor is 1Caolán McNamara2016-03-031-15/+9
| | | | Change-Id: I8820d435e2f26d04ac3eccb710383399d050e020
* refactor these two bizarro positioning things into reusable chunksCaolán McNamara2016-03-031-21/+33
| | | | Change-Id: I3f89aca650d31658ce17b3b1496a7babba23bdc6
* Follow our code layout styleTor Lillqvist2016-03-031-4/+6
| | | | | | | | | Consistency is important. (I know that we are wildly inconsistent in many things, even inside individual source files. Like the spacing of the expression in an if statement. But putting an opening brace on a separate line is something we do quite consistently.) Change-Id: I7c50628653b94a4da0fc4dc8db8869a5f1a64527
* tdf#96393: reuse layout if availablePierre-Eric Pelloux-Prayer2016-03-031-5/+14
| | | | | | | | | | | | | If position and size were loaded from the WindowStateData structure there's no need to recompute the layout. As an added benefit if the user previously resized/move the dialog, the new one will open using the same geometry. Change-Id: I306504080357f9be8f3e628ba13ca5dc2957dd52 Reviewed-on: https://gerrit.libreoffice.org/21850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* vcl: scheduler - remove obsolete comment.Michael Meeks2016-03-031-1/+0
| | | | Change-Id: I8a469f73b682e32bbb15a71e5be9b64d8412f3f1
* Fix the import of line joins and caps from EMF filesStephan van den Akker2016-03-022-6/+39
| | | | | | | Change-Id: I976336d35366b661e402db484820b4dd9a7b0228 Reviewed-on: https://gerrit.libreoffice.org/22821 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
* tdf#84258 Allow creation of command aliasesMaxim Monastirsky2016-02-281-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | We already can use different labels for commands, based on whether they're in a menu, context menu or a toolbar. But in some cases we need different labels for the same type of UI element, or even different icons. One example is page/slide commands in Draw/Impress, as they share same commands, but need different icons/labels. Creating full-fledged duplicate slots just to satisfy the need of UI representation seems like overkill, and isn't flexible enough. The proposed solution is to allow creation of command entries, that do not correspond to real application slots, but instead link to another existing commands. The "real" commands will be used for controller factory and dispatch (execute/status) APIs, thus fully retaining functionality. This can be useful also for giving icons to complex commands (i.e. commands with arguments). Change-Id: I9b261b406ec8fc781cae06cf283963386379d4ad
* log to the crashreporter whether we use OpenGLMarkus Mohrhard2016-02-271-0/+3
| | | | Change-Id: I8fd2ffe5908074417aa5cfc00adbc54b6e9ed360
* lp#1506544 tdf#92458: default to breeze theme on unity desktopsBjoern Michaelsen2016-02-271-1/+1
| | | | Change-Id: I1e0e10d1561e32c5904e0e7352e914bb62b85363
* gtk3: add a menubar close buttonCaolán McNamara2016-02-262-0/+6
| | | | | | | the css foo is modeled on the similiar gedit close buttons in its tabs Change-Id: I7af32ad0434a49c52eea215f797c502be7f96dac
* loplugin:unuseddefaultparms in include/vcl (part2)Noel Grandin2016-02-2611-138/+78
| | | | | | | | | including a fix for a rather glaring bug in BitmapTools.cxx Change-Id: Id9db990b993cfeea9039c5fbaaa91996adeae22a Reviewed-on: https://gerrit.libreoffice.org/22713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Improve the import of pen styles from EMF filesStephan van den Akker2016-02-261-12/+24
| | | | | | | Change-Id: I643c29befeb29b7b1cdd66375f661f4adb0e6cfa Reviewed-on: https://gerrit.libreoffice.org/22638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
* loplugin:unuseddefaultparams in /include/vclNoel Grandin2016-02-2621-296/+137
| | | | | | | Change-Id: I36daccd90bfa6ba0ee8b9e76bff2bd8494155a04 Reviewed-on: https://gerrit.libreoffice.org/22710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unuseddefaultparam in vcl/Noel Grandin2016-02-268-97/+57
| | | | | | | Change-Id: Ic09d160ed6e3cdcd95bc04844ee8f20cfcb286ec Reviewed-on: https://gerrit.libreoffice.org/22698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Ah, xsqr got changed from unsigned to singedStephan Bergmann2016-02-241-5/+5
| | | | | | | | ...in 8bcc538953ceec4ef266f16cf72329bc6080d08c "WaE vs2015 literal implicit casting," that explains why 89fe180fbcdfcd8ee3f52955a29eccd3b9ad0f36 "Silence -fsanitize=shift ("left shift of negative value")" became necessary afterwards Change-Id: I1b3d09ba59d60a88e34e48cc3697a20084623817