summaryrefslogtreecommitdiffstats
path: root/unoxml
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:redundantcast: redundant static_casts in unoxmlStephan Bergmann2016-07-081-6/+6
| | | | Change-Id: I75db798c0b7d6951fc278b91f4162fa7c7ffd79c
* tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2016-06-091-4/+1
| | | | | | | | | | | | | | | | | | | | This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* unoxml: fix data race in CEventDispatcher::callListeners()Michael Stahl2016-06-072-21/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | JunitTest_unoxml_complex crashed with an assertion: error: attempt to increment a singular iterator. This is because the CEventDispatcher::dispatchEvent() attempts to copy the m_TargetListeners onto the stack, before dropping the mutex to call the, listeners, but the copy is unintentionally shallow and the ListenerMap that is the value of the outer type is not copied, so this member is accessed in callListeners() without MutexGuard. Fix this by replacing ListenerMap* with ListenerMap as the value, which also allows getting rid of explicit delete calls. 15 0x00002b7793e5ace8 in abort () at /lib64/libc.so.6 16 0x00002b77948c1565 in __gnu_debug::_Error_formatter::_M_error() const () at /lib64/libstdc++.so.6 17 0x00002b77b802a7d8 in __gnu_debug::_Safe_iterator<std::_Rb_tree_const_iterator<std::pair<_xmlNode* const, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEventListener> > >, std::__debug::multimap<_xmlNode*, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEventListener>, std::less<_xmlNode*>, std::allocator<std::pair<_xmlNode* const, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEventListener> > > > >::operator++() (this=0x2b77b7d99c90) at /usr/include/c++/4.8.2/debug/safe_iterator.h:291 18 0x00002b77b80275ae in DOM::events::CEventDispatcher::callListeners(std::__debug::map<rtl::OUString, std::__debug::multimap<_xmlNode*, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEventListener>, std::less<_xmlNode*>, std::allocator<std::pair<_xmlNode* const, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEventListener> > > >*, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, std::__debug::multimap<_xmlNode*, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEventListener>, std::less<_xmlNode*>, std::allocator<std::pair<_xmlNode* const, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEventListener> > > >*> > > const&, _xmlNode*, rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEvent> const&) (rTMap=std::__debug::map with 1 elements, pNode=0x21a9c10, aType=..., xEvent=...) at /unoxml/source/events/eventdispatcher.cxx:103 pMap = 0x2203b10 iter = {first = , second = {<com::sun::star::uno::BaseReference> = {_pInterface = }, <No data fields>}} ibound = {first = , second = {<com::sun::star::uno::BaseReference> = {_pInterface = }, <No data fields>}} tIter = {first = {pData = }, second = } 19 0x00002b77b80284e4 in DOM::events::CEventDispatcher::dispatchEvent(DOM::CDocument&, osl::Mutex&, _xmlNode*, com::sun::star::uno::Reference<com::sun::star::xml::dom::XNode> const&, com::sun::star::uno::Reference<com::sun::star::xml::dom::events::XEvent> const&) const (this=0x21fbee0, rDocument=..., rMutex=..., pNode=0x2200890, xNode=..., i_xEvent=...) at /unoxml/source/events/eventdispatcher.cxx:242 captureListeners = std::__debug::map with 0 elements targetListeners = std::__debug::map with 1 elements = {[{pData = 0x2202a30}] = 0x2203b10} Change-Id: I66fb7a461df0f8066383365850536f7b0394306d
* tdf#95416 Get rid of #include "../foo/bar.hxx" style includesBurcin Akalin2016-05-014-5/+10
| | | | | | | | | Change-Id: If7b44c772744c63e603740be6267453118cfd01b Signed-off-by: Burcin Akalin <brcnakalin@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/21937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2016-04-289-90/+90
| | | | | | | Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-208-19/+19
| | | | Change-Id: I97ad48b13fc5c134fea5a2a85001bbfefe6793f5
* tdf#97966 Drop 'static' keywordsWastack2016-04-011-12/+12
| | | | | | | | | Including no keywords from extern "C" blocks Change-Id: Ie3160af9decf04ceeda02dc20a6518afaa80f972 Reviewed-on: https://gerrit.libreoffice.org/23677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* unordf: replace boost::shared_array with std::shared_ptrMichael Stahl2016-03-241-4/+3
| | | | | | It was using a custom deleter anyway. Change-Id: I700b7cf314b7f837a7143206ba42e412c5a1670d
* unordf: replace boost::noncopyable with C++11 deleteMichael Stahl2016-03-244-14/+25
| | | | Change-Id: I996ca0589db8b73db045c87bbecfab03be9dbaef
* loplugin:unuseddefaultparam in unotoolsNoel Grandin2016-02-291-5/+3
| | | | Change-Id: Icb2dc74263026d90b7998b3fd880fd5d2c67a3b7
* Remove excess newlinesChris Sherlock2016-02-094-19/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* unoxml: replace boost::bind with lambdaMichael Stahl2016-01-291-4/+4
| | | | Change-Id: Id8d73fa9a93cd793dbce0d3f84ddde86860f7308
* Fix typosAndrea Gelmini2016-01-104-4/+4
| | | | | | | Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* loplugin:unusedfields unotools,unoxmlNoel Grandin2015-12-2110-47/+26
| | | | Change-Id: I824193a9f4b0196ce1127c5cbf16b0064dbb3446
* loplugin:unusedfields variousNoel Grandin2015-11-262-4/+0
| | | | Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
* Fast PCH generator and optimized PCH filesAshod Nakashian2015-11-151-13/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* use initialiser syntax for Sequence<OUString>Noel Grandin2015-11-154-8/+4
| | | | | | | | | | | | | | replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-1023-264/+264
| | | | Change-Id: I4f9d6c93a0bdbba290277a41537ba2728d1ee4f5
* java: remove ((unnecessary)) parenthesesNoel Grandin2015-11-051-2/+1
| | | | Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
* use uno::Reference::set method instead of assignmentNoel Grandin2015-11-053-14/+9
| | | | Change-Id: Id57ccff7ea6cf5c7053b51268b1190f5459bb357
* UNO: no need to use OUString constructor when calling createInstanceNoel Grandin2015-10-301-2/+2
| | | | | | | Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Remove unneeded boost/bind include from unoxml/source/dom/node.cxxMario J. Rugiero2015-10-261-2/+0
| | | | | | | Change-Id: Ia97d9a24ffd455a135c44bba250fd0c27df7f910 Reviewed-on: https://gerrit.libreoffice.org/19591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Replace uses of boost::bind with C++11 lambdas in unoxml/source/dom/node.cxxMario J. Rugiero2015-10-221-4/+2
| | | | | | | Change-Id: I2455476a876012051ca1651721915243503fbb22 Reviewed-on: https://gerrit.libreoffice.org/19308 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-1236-689/+689
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* Fix typosAndrea Gelmini2015-09-303-7/+7
| | | | | | | Change-Id: Ia7394ab3c0aa28002a7022e73c2b7d9eb73dacb8 Reviewed-on: https://gerrit.libreoffice.org/18991 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#94228 comphelper: replace BOOST_PPDaniel Robertson2015-09-251-1/+0
| | | | | | | | | Remove makeSequence. Change-Id: If07dc8702d811111fc634c9c7eb4c9a331517ca5 Reviewed-on: https://gerrit.libreoffice.org/18647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* boost->stdCaolán McNamara2015-09-1711-120/+119
| | | | Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
* unoxml: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe2015-09-1037-71/+79
| | | | | | | | | with the variadic variants. Change-Id: Id753717b228061c810a0122e551326ab001949a9 Reviewed-on: https://gerrit.libreoffice.org/18460 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* unoxml: Add missing includeDavid Ostrovsky2015-09-031-0/+1
| | | | | | | Change-Id: I5497abb747dc12080f076aaf81b946710bcd5570 Reviewed-on: https://gerrit.libreoffice.org/18319 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann2015-08-313-9/+9
| | | | Change-Id: Iddea2a6462b52e39aab31e96fbc83836cf157e27
* loplugin:unusedmethodsNoel Grandin2015-07-303-15/+1
| | | | | | | Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:simplifyboolStephan Bergmann2015-07-161-2/+1
| | | | Change-Id: Ic38df50884b370417ed62b65ac7f90a13faea230
* do not include boost/utility.hppMichael Stahl2015-07-101-1/+1
| | | | | | | | | | It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
* Fix typosAndrea Gelmini2015-07-081-1/+1
| | | | | Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
* loplugin:unusedmethods basebmpNoel Grandin2015-07-061-2/+0
| | | | | | | Change-Id: I9e89fea4e94a91edbbe355780c2a12d6e6cb6e4a Reviewed-on: https://gerrit.libreoffice.org/16728 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Fix typosAndrea Gelmini2015-07-041-1/+1
| | | | | | | Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec Reviewed-on: https://gerrit.libreoffice.org/16712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
* Revert "Typo: iff->if"Julien Nabet2015-06-231-1/+1
| | | | | | This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
* Typo: iff->ifJulien Nabet2015-06-231-1/+1
| | | | Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
* Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2015-06-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann2015-06-021-1/+1
| | | | Change-Id: Ic50468d68c92779a589894963ab4099eefb8adf4
* cppcheck: noExplicitConstructorCaolán McNamara2015-05-266-8/+8
| | | | Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
* loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann2015-05-111-1/+1
| | | | Change-Id: Ic046e96b395713336cb33ce48a003183f7648d36
* remove some @author tags from suspiciously unidiomatic codeMichael Stahl2015-04-251-1/+0
| | | | Change-Id: I3930420fe502978f8e14a688f2eb99c74d185f7b
* loplugin:staticmethodsNoel Grandin2015-04-131-35/+34
| | | | Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
* Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2015-03-311-1/+1
| | | | Change-Id: Ia275bf01d6c72e01e9144a99121f4a9858e88c8a
* Clean up C-style casts from pointers to voidStephan Bergmann2015-03-281-1/+1
| | | | Change-Id: Ie12eb8940ebb6059d234f5af25800812c085002a
* const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann2015-03-261-1/+1
| | | | Change-Id: I85007c6fdceca1c070ca9b4cb62715a5c92bfe15
* tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann2015-03-132-3/+5
| | | | | | | | ...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
* fdo#75757: Remove inheritance from std::vectorMatthew Pottage2015-02-061-5/+5
| | | | | | | | | | | | | | | | | | | Deprecated comphelper/sequenceasvector.hxx. Rewritten code using it. Using instead the functions containerToSequence and sequenceToContainer, found in include/comphelper/sequence.hxx. One class that inherits from it (in framework/inc/stdtypes.h), and the code using that has been left. Signed-off-by: Michael Stahl <mstahl@redhat.com> Conflicts: writerfilter/source/dmapper/DomainMapper.cxx writerfilter/source/dmapper/TblStylePrHandler.hxx writerfilter/source/dmapper/WrapPolygonHandler.hxx Change-Id: Ice61c94ffb052e389281aebb7cdf185134221061
* Updated all precompiled headers.Ashod Nakashian2015-02-051-1/+1
| | | | | | | | Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>