summaryrefslogtreecommitdiffstats
path: root/unoxml/source/dom
Commit message (Collapse)AuthorAgeFilesLines
* crashtesting: assert on fdo62508-1.odtCaolán McNamara2018-05-171-3/+3
| | | | | | | | | | | | | | | | | document, with meta:generator of "opxml2odf - Version KO 0.1" has a styles.xml xmlns of... xmlns:ofo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" instead of the usual xmlns:fo=... use the importer namespace map to get the importers namespace prefix for the fastparser namespace uri for the token Change-Id: Ib633009f6c2b7dae5a3ceb1c921adfff84e21150 Reviewed-on: https://gerrit.libreoffice.org/52720 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* use https links for api.libreoffice.org and opengrokdennisroczek2018-04-021-2/+2
| | | | | | | Change-Id: I74dd0142562cb8698f19b2715fa1d514f82bd749 Reviewed-on: https://gerrit.libreoffice.org/52262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Moving XSAXDocumentBuilder2 to use XFastDocumentHandler:Mohammed Abdul Azeem2018-03-142-120/+136
| | | | | | | | | | | This is used in parsing of meta Contexts across different modules. This also involved moving to XFastParser for parsing xml filters in sw, sd, starmath. Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929 Reviewed-on: https://gerrit.libreoffice.org/42989 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
* unoxml: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski2018-02-021-3/+0
| | | | | | | Change-Id: I6c09eeeb43cd0bf85b89b1332f2ee6121b11de3c Reviewed-on: https://gerrit.libreoffice.org/49056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* More loplugin:cstylecast: unoxmlStephan Bergmann2018-01-153-5/+5
| | | | Change-Id: I832b0495f3510e853037e87e90da2fd04c21f8ad
* ofz#4940 Null-dereference READCaolán McNamara2018-01-041-1/+1
| | | | | | | Change-Id: I2c8c83ef6ffde5f1599814538acc36ec5beab6c8 Reviewed-on: https://gerrit.libreoffice.org/47387 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* inline use-once typedefsNoel Grandin2017-12-192-7/+3
| | | | | | | Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157 Reviewed-on: https://gerrit.libreoffice.org/46764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salcall fix non-virtual methodsNoel Grandin2017-12-052-2/+2
| | | | | | | | | first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make loplugin:unnecessaryparen warn about (x) ? ... : ... after allStephan Bergmann2017-11-223-3/+3
| | | | | | | | | | | | | | | | | | | | | | ...which had been left out because "lots of our code uses this style, which I'm loathe to bulk-fix as yet", but now in <https://gerrit.libreoffice.org/#/c/45060/1/> "use std::unique_ptr" would have caused an otherwise innocent-looking code change to trigger a loplugin:unnecessaryparen warning for pFormat = (pGrfObj) ? ... (barring a change to ignoreAllImplicit in compilerplugins/clang/unnecessaryparen.cxx similar to that in <https://gerrit.libreoffice.org/#/c/45083/2> "Make not warning about !! in loplugin:simplifybool consistent", which should also have caused the warning to disappear for the modified code, IIUC). Change-Id: I8bff0cc11bbb839ef06d07b8d9237f150804fec2 Reviewed-on: https://gerrit.libreoffice.org/45088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* look for =() in loplugin:unnecessaryparenNoel Grandin2017-11-202-2/+2
| | | | | | | Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0 Reviewed-on: https://gerrit.libreoffice.org/44944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:flatten in toolkit..writerfilterNoel Grandin2017-11-181-66/+69
| | | | | | | Change-Id: I4da2a768b6b55869c3a3d6f8a8d50dc018709acd Reviewed-on: https://gerrit.libreoffice.org/44865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:includeform: unoxmlStephan Bergmann2017-10-2325-52/+52
| | | | Change-Id: I447ba963bd9163e99932d95c3f3e9aeac623d822
* Move unoxml/source/events include files to common include directoryStephan Bergmann2017-10-174-9/+9
| | | | | | | | | | ...that are included from various source directories. Change done in preparation of loplugin:includeform. Change-Id: I186ab7581ee7896c54a600e5cde8721a97b26425 Reviewed-on: https://gerrit.libreoffice.org/43444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:finalclasses in unotools..vbahelperNoel Grandin2017-10-059-15/+0
| | | | | | | Change-Id: I9350f9d37eaba99a1d74e103c969a9dcfe795497 Reviewed-on: https://gerrit.libreoffice.org/43160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* add << operator for css::uno::ExceptionNoel Grandin2017-10-042-10/+5
| | | | | | | Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* unoxml: CDocumentBuilder: just catch all ExceptionMichael Stahl2017-08-251-2/+2
| | | | | | | Turns out that XErrorHandler can throw SAXException too, which isn't derived from RuntimeException. Change-Id: Ib853805259b5b32a979e4f9a20297975431dee08
* tdf#84237 use XErrorHandler in CDocumentBuilderFyodor Yemelyanenko2017-08-252-9/+70
| | | | | | | | | | | | | In documentbuilder.cxx added code to call XErrorHandler::warning and XErrorHandler::error functions (from DOM::warning_func and DOM::error_func) In domtest.cxx added try {} catch () block to BasicTest::validInputTest, BasicTest::warningInputTest and BasicTest::errorInputTest and to SerializerTest::serializerTest. Also uncommented lines CPPUNIT_TEST(warningInputTest); and CPPUNIT_TEST(errorInputTest); Unit tests are now working (FatalError test removed, as lib2xml doesn't distinguish between error and fatal error and counts everything as error). Change-Id: I27c5036df6a1cc5bef5dbb8171c201d81bae2ccd Reviewed-on: https://gerrit.libreoffice.org/41376 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* convert std::map::insert to std::map::emplace IINoel Grandin2017-08-111-7/+6
| | | | | | | Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert std::map::insert to std::map::emplaceNoel Grandin2017-08-111-3/+3
| | | | | | | | | which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unnecessary use of 'this->'Noel Grandin2017-08-021-2/+2
| | | | | | | Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4 Reviewed-on: https://gerrit.libreoffice.org/40671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar: empty strings: unoxmlStephan Bergmann2017-07-131-4/+2
| | | | Change-Id: I8acebad074a2da4848489eaa0f64d63fe76d69c1
* simplify calls OUString::copy in foo.copy(x, foo.getLength() - x)Noel Grandin2017-07-112-5/+5
| | | | | | | Change-Id: I20318c77dcc3bc2a64336541ef5a3f412bfd9483 Reviewed-on: https://gerrit.libreoffice.org/39803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach unnecessaryparen loplugin about identifiersNoel Grandin2017-07-101-1/+1
| | | | | | | Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar in ucb..vbahelperNoel Grandin2017-06-281-5/+2
| | | | | | | Change-Id: I1fc7c7505a42b3bf9d4a5ab22961930b9831d4ae Reviewed-on: https://gerrit.libreoffice.org/39327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields in tools..vbahelperNoel Grandin2017-06-161-3/+0
| | | | | | | Change-Id: Ief7d4c8e1866604eda6308ea2a5c1ce4b1c093bc Reviewed-on: https://gerrit.libreoffice.org/38836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove some unnecessary scaffolding around SAL_WARN callsStephan Bergmann2017-05-311-2/+0
| | | | Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18
* remove unnecessary use of OString::getStrNoel Grandin2017-05-283-6/+5
| | | | | | | Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* revert OSL_ASSERT changesChris Sherlock2017-05-073-8/+8
| | | | Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
* tdf#43157: convert xmloff module away from OSL_ASSERT to assertChris Sherlock2017-05-073-8/+8
| | | | Change-Id: I7eb36a11a7de5f7cf35ce97b59c8b461b64385a7
* ASan stack-use-after-scopeStephan Bergmann2017-04-071-11/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...as reported during CppunitTest_extensions_test_update (see below). I don't see a reason why those pContext should be shared_ptr, so better make them unique_ptr to guarantee that xmlFreeParserCtxt is called with c still in scope (in CDocumentBuilder::parse). > ==10883==ERROR: AddressSanitizer: stack-use-after-scope on address 0x2b111da94b68 at pc 0x2b116e55a200 bp 0x7fff7228b0f0 sp 0x7fff7228b0e8 > READ of size 8 at 0x2b111da94b68 thread T0 > #0 0x2b116e55a1ff in com::sun::star::uno::BaseReference::is() const include/com/sun/star/uno/Reference.h:94:27 > #1 0x2b116e699756 in DOM::xmlIO_close_func(void*) unoxml/source/dom/documentbuilder.cxx:214:33 > #2 0x2b11300cf646 in xmlFreeParserInputBuffer__internal_alias workdir/UnpackedTarball/xml2/xmlIO.c:2575:2 > #3 0x2b112fdd2706 in xmlFreeInputStream__internal_alias workdir/UnpackedTarball/xml2/parserInternals.c:1341:9 > #4 0x2b112fddebf3 in xmlFreeParserCtxt__internal_alias workdir/UnpackedTarball/xml2/parserInternals.c:1774:9 > #5 0x2b116e6aaddc in std::_Sp_counted_deleter<_xmlParserCtxt*, void (*)(_xmlParserCtxt*), std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/shared_ptr_base.h:464:9 > #6 0x2b116e65370a in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/shared_ptr_base.h:150:6 > #7 0x2b116e653494 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/shared_ptr_base.h:662:11 > #8 0x2b116e6a78b1 in std::__shared_ptr<_xmlParserCtxt, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/shared_ptr_base.h:928:31 > #9 0x2b116e69f01d in std::shared_ptr<_xmlParserCtxt>::~shared_ptr() /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/bits/shared_ptr.h:93:11 > #10 0x2b116e696aca in DOM::CDocumentBuilder::parse(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) unoxml/source/dom/documentbuilder.cxx:336:5 > #11 0x2b116e699fe2 in non-virtual thunk to DOM::CDocumentBuilder::parse(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) unoxml/source/dom/documentbuilder.cxx > #12 0x2b116df6449a in (anonymous namespace)::UpdateInformationProvider::getUpdateInformationEnumeration(com::sun::star::uno::Sequence<rtl::OUString> const&, rtl::OUString const&) extensions/source/update/feed/updatefeed.cxx:589:83 > #13 0x2b116df682ea in non-virtual thunk to (anonymous namespace)::UpdateInformationProvider::getUpdateInformationEnumeration(com::sun::star::uno::Sequence<rtl::OUString> const&, rtl::OUString const&) extensions/source/update/feed/updatefeed.cxx > #14 0x2b115d9a73eb in testupdate::Test::testGetUpdateInformationEnumeration() extensions/qa/update/test_update.cxx:57:26 > #15 0x2b115d9baf1b in CppUnit::TestCaller<testupdate::Test>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 > #16 0x2b111904ad8b in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #17 0x2b11322dab0f in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:39:14 > #18 0x2b11190093ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #19 0x2b1128c6214f in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #20 0x2b11190093ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #21 0x2b1124efc351 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #22 0x2b11190093ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #23 0x2b1118f87350 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #24 0x2b11190093ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #25 0x2b1119005e70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18 > #26 0x2b11190c50f5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28 > #27 0x2b1119048fa4 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #28 0x2b111904d7a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #29 0x2b111904c819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #30 0x2b111904d7a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #31 0x2b111904c819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #32 0x2b11191035c9 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #33 0x2b11190c340d in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9 > #34 0x2b111910489b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #35 0x532fb4 in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:306:20 > #36 0x52e7c3 in sal_main() sal/cppunittester/cppunittester.cxx:456:20 > #37 0x52cb6f in main sal/cppunittester/cppunittester.cxx:363:1 > #38 0x2b111acb5400 in __libc_start_main (/lib64/libc.so.6+0x20400) > #39 0x438019 in _start (workdir/LinkTarget/Executable/cppunittester+0x438019) > > Address 0x2b111da94b68 is located in stack of thread T0 at offset 104 in frame > #0 0x2b116e69553f in DOM::CDocumentBuilder::parse(com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const&) unoxml/source/dom/documentbuilder.cxx:303 > > This frame has 4 object(s): > [32, 40) 'g' (line 308) > [64, 80) 'pContext' (line 310) > [96, 120) 'c' (line 321) <== Memory access at offset 104 is inside this variable > [160, 168) 'ref.tmp' (line 333) Change-Id: I3398d54776af4927417e392e55bbca740d4121af
* Fix typosAndrea Gelmini2017-03-251-1/+1
| | | | | | | Change-Id: Ieea40e1b7282267157810f9f58ca083e68ae6715 Reviewed-on: https://gerrit.libreoffice.org/35659 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:subtlezeroinit: unoxmlStephan Bergmann2017-02-212-2/+2
| | | | Change-Id: I4e7f42d5d9d0056a59b8e6b67731628e1cc5cfa1
* Fix typosAndrea Gelmini2017-02-131-1/+1
| | | | | | | Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
* Add missing #includesStephan Bergmann2017-02-061-0/+1
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* Remove dynamic exception specificationsStephan Bergmann2017-01-2643-1116/+538
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Probably makes more sense to return DONTKNOW if the element is DONTKNOW ...Tor Lillqvist2017-01-241-1/+3
| | | | | | | | | | | ... and not the namespace token without any element token ORed in. DONTKNOW is what the two callers look for. Does not break any unit test. (Does not fix the bug I am investigating either, though.) Change-Id: Ibd75ee06797d7b62476d4bf2302338b2bb3266d4
* New loplugin:dynexcspec: Add @throws documentation, unoxmlStephan Bergmann2017-01-191-0/+1
| | | | Change-Id: I085b0c080acc38d1ec17bc96aac24d2b17e14b3b
* coverity#440749 Explicit null dereferencedCaolán McNamara2017-01-071-1/+1
| | | | Change-Id: I0927e51d0cdb53b5bd20d4f1cf567cbfb4b377da
* Remove noise SAL_INFO that even crashed when pPrefix was NULLTor Lillqvist2016-12-061-3/+0
| | | | | | Not sure why it crashed only on macOS? Change-Id: I9578d7de39e22ba79950c6b47aad26944a5d0fa2
* OSL_TRACE->SAL in unotools..uuiNoel Grandin2016-12-062-5/+6
| | | | Change-Id: I7f391604401b8a10f5d451673ed6223c031c56ab
* loplugin:unnecessaryoverride (dtors) in unoxmlStephan Bergmann2016-11-241-4/+0
| | | | Change-Id: Ieca0d355031f25731a519be26145cda3b2172cb1
* loplugin:countusersofdefaultparams in sw..vclNoel Grandin2016-10-031-1/+1
| | | | | | | Change-Id: I152df55f5a30e073c66cfd3a64d5090a20cb232d Reviewed-on: https://gerrit.libreoffice.org/29471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-133-3/+3
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* tdf#95416 Get rid of #include "../foo/bar.hxx" style includesBurcin Akalin2016-05-011-334/+0
| | | | | | | | | Change-Id: If7b44c772744c63e603740be6267453118cfd01b Signed-off-by: Burcin Akalin <brcnakalin@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/21937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2016-04-288-84/+84
| | | | | | | Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-207-18/+18
| | | | Change-Id: I97ad48b13fc5c134fea5a2a85001bbfefe6793f5
* Fix typosAndrea Gelmini2016-01-102-2/+2
| | | | | | | Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* loplugin:unusedfields unotools,unoxmlNoel Grandin2015-12-217-26/+11
| | | | Change-Id: I824193a9f4b0196ce1127c5cbf16b0064dbb3446
* loplugin:unusedfields variousNoel Grandin2015-11-262-4/+0
| | | | Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-1016-196/+196
| | | | Change-Id: I4f9d6c93a0bdbba290277a41537ba2728d1ee4f5