summaryrefslogtreecommitdiffstats
path: root/unotools
Commit message (Collapse)AuthorAgeFilesLines
* Update comment now that we use an enum classTor Lillqvist2016-08-231-1/+1
| | | | Change-Id: I2daefa5a0e63d9a571ee90a9b8be5e58fa2315a1
* Some clang-tidy misc-move-constructor-initStephan Bergmann2016-08-191-1/+1
| | | | | | ...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
* Remove unnecessary UcbStreamHelper::CreateStream overloadStephan Bergmann2016-08-161-6/+0
| | | | | | | | | | | ...with an explicit XInteractionHandler, but which was only ever called with a null XInteractionHandler, so could just as well call the overload that doesn't specify one (but internally uses a special SimpleFilaAccessInteraction handler since f60eaab748add19683e66c7e4bc073c9ce7887f7 "Related: tdf#99312, add specialized interaction handler", which is probably also what is wanted for these two calls to UcbStreamHelper::CreateStream in cui and sd). Change-Id: I2bf7bebd32f1c06b7414a4646631a19b689ee52f
* ubsan: -1 is not a valid value for type 'css::util::SearchAlgorithms'Caolán McNamara2016-08-151-1/+1
| | | | Change-Id: I59e435c1814da57c318c12f2c1539542960f5b90
* loplugin:unusedenumconstants in unotools..xmlhelpNoel Grandin2016-08-153-22/+10
| | | | | | | Change-Id: Id7ddc0fc1f57c5e8e7fb002e31d54fb8e9f8ffab Reviewed-on: https://gerrit.libreoffice.org/28050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Related: tdf#99312, add specialized interaction handlerGiuseppe Castagno2016-08-081-2/+17
| | | | | | | | | | Needed to manage https certificates and authentication whenever needed. Change-Id: If20b85a9b349b203a8c46d453afa823629d114cb Reviewed-on: https://gerrit.libreoffice.org/27927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
* improve passstuffbyref return analysisNoel Grandin2016-07-273-3/+3
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Improve loplugin:unnecessaryoverrideStephan Bergmann2016-07-152-7/+0
| | | | | | | | | | | | | | | <sberg> thorsten, remember what that "TODO" in SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly, in a909acb7009acadffa53e74ea05ddb88803490f1 ? <thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review me' <sberg> thorsten, OK, thanks (that override will eventually go away with loplugin:unnecessaryoverride, and the TODO comment be lost) Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac Reviewed-on: https://gerrit.libreoffice.org/27232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* new loplugin unnecessary overrideNoel Grandin2016-07-153-18/+2
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#84635 - Slow layout of large tablesNoel Grandin2016-07-132-6/+12
| | | | | | | | | | | | | | | | | | | | | | | Based on suggestion from Aron Budea. And do something similar to most other places keeping vectors of weak references where the code looks like it will hold more than a few entries. Measurements: the 26 page file file takes 51s without my path 15s with this patch the 69 page file file takes 5m28 without my path 51s with this patch the 84 page file file takes 8m28 without my path 58s with this patch Change-Id: I8da94c525fc73ebd969e0343c6f074be4f0063b1 Reviewed-on: https://gerrit.libreoffice.org/27093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* ditch the application per-language IsAutoMnemonicEnabled settingCaolán McNamara2016-07-103-251/+0
| | | | Change-Id: I9734ada09edb6544a332893a7c5d31730b0d081d
* ditch the multiply dialog width * X where X is based on language thingCaolán McNamara2016-07-101-33/+1
| | | | | | | Which should be unnecessary since the vcl layout work and optimal size widgets, and its a small and arbitary set of languages for which its set. Change-Id: Ifa397218510ade251f795cdd9360d6bdccb115b7
* Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke2016-07-082-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-072-7/+7
| | | | Change-Id: I08992bb66d5459333e018bb52dceee3e808fac8b
* loplugin:singlevalfields in variousNoel Grandin2016-06-281-27/+0
| | | | | | | Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Clean up uses of Any::getValue() in unotoolsStephan Bergmann2016-06-274-18/+19
| | | | Change-Id: I2e1d98c5947d0d72c369fa6b2df17eb2eec1f64c
* Mark these functions as finalXisco Fauli2016-06-202-2/+2
| | | | | | | | | | | | Comment from Michael Stahl in Gerrit: "to prevent potential disasters if somebody adds a sub-class and overrides ImplCommit, which is then not called here." Change-Id: I2d991c713734fd516827a5dd6c8929aa64e59409 Reviewed-on: https://gerrit.libreoffice.org/26278 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* tdf#89329: use shared_ptr for pImpl in moduleoptionsXisco Fauli2016-06-181-51/+38
| | | | | | | Change-Id: I2dfcdde6ef1782edc22ca6d70d353549706eb14f Reviewed-on: https://gerrit.libreoffice.org/26322 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in dynamicmenuoptionsXisco Fauli2016-06-171-25/+12
| | | | | | | Change-Id: I66bdeeee7f70e6ca16a39e8804aaf8a5f0d08205 Reviewed-on: https://gerrit.libreoffice.org/26327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* properly prefix various global variables and hide themMichael Stahl2016-06-1611-33/+65
| | | | Change-Id: I6b97e6a4c6ac4c0e26bcbb2b132b333920c16f19
* Local linkage for static var (and drop misleading "m_" prefix)Stephan Bergmann2016-06-161-3/+7
| | | | Change-Id: Ibb66eadf4d10fa4e67dae09287e82dcc937bfea3
* tdf#89329: use shared_ptr for pImpl in pathoptionsXisco Fauli2016-06-161-62/+59
| | | | | | | Change-Id: Id932a0886f0a8a3cb05a3d0474e29a2e0b84ad4e Reviewed-on: https://gerrit.libreoffice.org/25630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in historyoptionsXisco Fauli2016-06-161-30/+11
| | | | | | | Change-Id: I0020b7e66fe8e09db9a96127a77c3792afab63a8 Reviewed-on: https://gerrit.libreoffice.org/26324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in localisationoptionsXisco Fauli2016-06-161-27/+10
| | | | | | | Change-Id: I9b2f7f7e59a71c056608635773c4b4fb2120a902 Reviewed-on: https://gerrit.libreoffice.org/26323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in securityoptionsXisco Fauli2016-06-161-42/+30
| | | | | | | Change-Id: I91c9c9dcbb9df644836c87d4789521d668c2ba49 Reviewed-on: https://gerrit.libreoffice.org/26319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in cmdoptionsXisco Fauli2016-06-161-27/+11
| | | | | | | Change-Id: Ie6297cf8c26964a6c7cc017c1257c61825c2c791 Reviewed-on: https://gerrit.libreoffice.org/26320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in printwarningoptionsXisco Fauli2016-06-161-32/+16
| | | | | | | Change-Id: I0b202ae78d2afe5fad4aa4bb4a3323f2672b1b93 Reviewed-on: https://gerrit.libreoffice.org/26321 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in extendedsecurityoptionsXisco Fauli2016-06-161-26/+9
| | | | | | | Change-Id: I3d344c4872bbed9527f254a4eabc48534e38452f Reviewed-on: https://gerrit.libreoffice.org/26326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in fontoptionsXisco Fauli2016-06-161-28/+11
| | | | | | | Change-Id: I844f23d7674fe6e564575b150ba1f94754da4d3b Reviewed-on: https://gerrit.libreoffice.org/26325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Use SAL_WARN on swallowed exceptionsStephan Bergmann2016-06-151-50/+106
| | | | Change-Id: If4d7b51de338c026b3308a733c8f4a41478158b2
* loplugin:overrideStephan Bergmann2016-06-142-2/+2
| | | | Change-Id: Ib66e1f58eaa383a66660a28e39cdbd11dade2972
* tdf#89329: use shared_ptr for pImpl in misccfgXisco Fauli2016-06-141-23/+19
| | | | | | | Change-Id: I90d3d008f68991613775234b29379c31b8f4ad39 Reviewed-on: https://gerrit.libreoffice.org/26237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in compatibility...Xisco Fauli2016-06-141-45/+22
| | | | | | | | | | ... and remove some, at least from my point of view, useless comments Change-Id: Id97c90dd7764ae4569468abc73c79ae9b2a56e75 Reviewed-on: https://gerrit.libreoffice.org/26235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in defaultoptions...Xisco Fauli2016-06-141-12/+13
| | | | | | | | | | instead of unique_ptr as in commit 7bc1c79c26e52d5196fb36eee5c2f12f12d49ba6 Change-Id: I4e57378a333455b818162c6cc8484be9dcaddb03 Reviewed-on: https://gerrit.libreoffice.org/26236 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use shared_ptr for pImpl in syslocaleXisco Fauli2016-06-141-9/+7
| | | | | | | Change-Id: I646495e3538cb438a06765fe8cde252bad667bea Reviewed-on: https://gerrit.libreoffice.org/25969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:sallogareasStephan Bergmann2016-06-134-7/+7
| | | | Change-Id: I97fe4a566531015fe6c9fd275aaa46723aee9513
* convert more DBG_ASSERT(false to SAL_WARNNoel Grandin2016-06-124-8/+9
| | | | | | | Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2016-06-091-4/+1
| | | | | | | | | | | | | | | | | | | | This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* Resolves: tdf#89394 revert attempt to ditch missing file from recent filesCaolán McNamara2016-06-081-29/+8
| | | | | | | | | | | | | | | this reverts commit 93eefe54f5d6b6092371bad1e86444489d29eee2 Author: Krisztian Pinter <pin.terminator@gmail.com> Date: Fri Sep 6 14:45:13 2013 +0200 Make SvtHistoryOptions not return files if they can't be opened which seemed like a good idea, but was only really to fix a cosmetic problem, while the outcome was a more serious issue Change-Id: Ic9c9c136e1e50f5e28fe377b64f56e501fb836ca
* tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl2016-06-062-5/+5
| | | | | | | Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* tdf#89329: use unique_ptr for pImpl in configvaluecontainerXisco Fauli2016-06-061-1/+0
| | | | | | | Change-Id: Ide38cacc59a44515287d51dadb23836eaac14518 Reviewed-on: https://gerrit.libreoffice.org/25904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use unique_ptr for pImpl in accessiblestatesethelperXisco Fauli2016-06-061-8/+4
| | | | | | | Change-Id: I768bfd5a19a2633e6d6cd37f919c20cbfc76824e Reviewed-on: https://gerrit.libreoffice.org/25905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use unique_ptr for pImpl in accessiblerelationsethelperXisco Fauli2016-06-061-6/+3
| | | | | | | Change-Id: I29578afa206e869a5b2e6fb42c7f5ebf4a6f2fe8 Reviewed-on: https://gerrit.libreoffice.org/25906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove some manual ref counting in svx and xmloffNoel Grandin2016-06-061-15/+9
| | | | | | | Change-Id: Ica0b6ff8ff7fa9e65cd758160d6e3ea7110ebb46 Reviewed-on: https://gerrit.libreoffice.org/25824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Some clean up of uses of css::uno::Any::setValueStephan Bergmann2016-05-301-12/+7
| | | | Change-Id: I04e8aef35a6083b61d775c8eb3f96757da2b31bd
* tdf#89329: use unique_ptr for pImpl in fltrcfgXisco Fauli2016-05-301-47/+46
| | | | | | | Change-Id: Icbb7d122d7f553215de562a98b0127764b30faa1 Reviewed-on: https://gerrit.libreoffice.org/25628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#89329: use unique_ptr for pImpl in defaultoptionsXisco Fauli2016-05-301-2/+2
| | | | | | | Change-Id: I355888c44d1413f8d0ebd7a247649b79647c38ec Reviewed-on: https://gerrit.libreoffice.org/25629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#99973 - Crash when changing Locale Setting in optionsNoel Grandin2016-05-241-3/+2
| | | | | | | | | | | regression from commit 0f672545 "clang-tidy modernize-loop-convert in toolkit to uui", probably because the list is being modified while the loop is executing Change-Id: I18cd21001aee132e06d577c469aed5eb46a16a7f Reviewed-on: https://gerrit.libreoffice.org/25368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy misc-assign-operator-signatureNoel Grandin2016-05-201-1/+1
| | | | | | | Change-Id: I2953a88d9e2f5923732865ef17615d5928ac5f5f Reviewed-on: https://gerrit.libreoffice.org/25154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethods in unotoolsNoel Grandin2016-05-198-218/+8
| | | | | | | Change-Id: I5729c2a20dd5fb310570cb9e4bb0e0874dbc8049 Reviewed-on: https://gerrit.libreoffice.org/25102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>