summaryrefslogtreecommitdiffstats
path: root/ucbhelper
Commit message (Collapse)AuthorAgeFilesLines
* convert InsertOperation to scoped enumNoel Grandin2017-02-101-7/+3
| | | | | | and drop unused LINK enumerator Change-Id: I6c42424ae5a7503b3e14e5f04fcf7a49b595b416
* Add missing #includesStephan Bergmann2017-02-068-0/+18
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* Revert "cancelCommandExecution - no need to pass exception by Any"Noel Grandin2017-02-012-10/+10
| | | | | | | | This reverts commit 4739b31dafc5154a2c7d6b3f0ee90686863656f0. Apparently, passing a param of type css::uno::Exception to Any will record precisely a css::uno::Exception in that Any, losing any subtype information, which this commit changed.
* cancelCommandExecution - no need to pass exception by AnyNoel Grandin2017-02-012-10/+10
| | | | | | | | | all the call sites are passing an uno::Exception subtype Change-Id: I6de1f00810e063e75ef620314561d7e2d6445ada Reviewed-on: https://gerrit.libreoffice.org/33657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-311-2/+2
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-281-7/+4
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-2619-353/+21
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* new loplugin: useuniqueptr: ucb..ucbhelperNoel Grandin2017-01-204-23/+9
| | | | | | | Change-Id: Ib19ca3225b96d1bfec8a43bb762e16597f33b690 Reviewed-on: https://gerrit.libreoffice.org/33297 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:dynexcspec: Add @throws documentation, ucbhelperStephan Bergmann2017-01-191-3/+8
| | | | Change-Id: Ib197a945bb51823399c4e19a5ffdfe64483107a3
* inline InteractionContinuation_ImplNoel Grandin2017-01-161-15/+2
| | | | | | since it only contains one field, and does nothing special with it Change-Id: Ie1c099a4507a6b99af28be5852793ccaa557aa72
* loplugin:unnecessaryoverride (dtors) in ucbhelperStephan Bergmann2016-12-011-8/+0
| | | | Change-Id: I7d77af190087e5f7190849c1e316c9d4f178a6c2
* simplify macrosNoel Grandin2016-11-301-89/+79
| | | | | | | Change-Id: Ib56bdc2f8a7015afc8ac83d7cfd6eb65089682bb Reviewed-on: https://gerrit.libreoffice.org/31364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert VALUE_SET constants to o3tl::typed_flagsNoel Grandin2016-11-301-79/+81
| | | | | | | Change-Id: Ie2dead5e661cbcf31a92b3d38cba1983fa65dff4 Reviewed-on: https://gerrit.libreoffice.org/31363 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethods in ucb..ucbhelperNoel Grandin2016-10-262-7/+31
| | | | | | | Change-Id: I42d077d7ebcfb77447d011644f8d64e80eae69c2 Reviewed-on: https://gerrit.libreoffice.org/30266 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2016-10-031-1/+1
| | | | | | | Change-Id: Ie75beb4e282a4d1b784a5847262e39cf9c851527 Reviewed-on: https://gerrit.libreoffice.org/29440 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert CONTINUATION constants to typed_flags_setNoel Grandin2016-09-261-52/+19
| | | | Change-Id: I38333e5d229aa520fbe0a8ad72007c503853956e
* loplugin:unusedfieldsNoel Grandin2016-09-201-5/+2
| | | | | | | Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-133-3/+3
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* loplugin:constantparam in framework..vbahelperNoel Grandin2016-09-072-11/+7
| | | | Change-Id: I592f73012ae8a4df8488ef04dc0956d9400625bc
* cid#1371163 Missing move assignment operatorNoel Grandin2016-08-291-0/+9
| | | | Change-Id: Ie050cfae965adf7bc43c91f366904cf6876783c0
* ucbhelper::Std{In,Out}putStream are only used in ucb/source/ucb/cmis/Stephan Bergmann2016-08-223-297/+0
| | | | | | | | ...where their use of boost::shared_ptr (instead of std::shared_ptr) matches the use in libcmis, but makes them unlikely to be useful anywhere else. So move them into ucb/source/ucb/cmis/. Change-Id: I68359be6b43d6889af4f241dcdcbdc0d9d70d717
* Some clang-tidy misc-move-constructor-initStephan Bergmann2016-08-192-2/+2
| | | | | | ...by turning the relevant ctor parameters into "const &". Change-Id: Ia8d0aba5da10ad6b25f8689e2281e45b3d71c1fc
* improve passstuffbyref return analysisNoel Grandin2016-07-271-1/+1
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:singlevalfields in variousNoel Grandin2016-06-281-6/+2
| | | | | | | Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* ucbhelper: get rid of pointless scope in ContentImplHelper::releaseMichael Stahl2016-06-241-4/+2
| | | | Change-Id: I5a35674115388288190e3a6496010badc32cf589
* loplugin:singlevalfields in ucbhelperNoel Grandin2016-06-243-97/+22
| | | | | | | Change-Id: I738bda6e6e161fb5ea96bd496a21ccf72680cd7f Reviewed-on: https://gerrit.libreoffice.org/26604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove some more (void) style function definitions/declarationsNoel Grandin2016-06-231-7/+3
| | | | | | | | | | found with git grep -nP '^\s*void\s*\)' Change-Id: I1206031cf957cb6f957cae64ec5cae1280bda694 Reviewed-on: https://gerrit.libreoffice.org/26590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove some manual ref-countingNoel Grandin2016-06-061-8/+4
| | | | | | | | | | | | | triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Revert "remove some manual ref-counting"Noel Grandin2016-05-241-4/+8
| | | | | | | until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
* remove some manual ref-countingNoel Grandin2016-05-241-8/+4
| | | | | | | | | | | | | triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:passstuffbyrefStephan Bergmann2016-05-121-1/+1
| | | | Change-Id: Iba108c1007f33de2e7207e25d7eb2dfc18d1c22c
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-101-1/+1
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* teach passstuffbyref plugin to check for..Noel Grandin2016-05-061-1/+1
| | | | | | | | | | | | unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-204-42/+42
| | | | Change-Id: Ie47a53763332119d290ebe5646af987ddd44be9d
* loplugin:passstuffbyref in ucbhelperNoel Grandin2016-04-141-2/+1
| | | | Change-Id: I680e4ca0d20d5ddabdc875a1d6bec27322956f5e
* clang-tidy performance-unnecessary-value-param in ucbhelperNoel Grandin2016-04-111-1/+1
| | | | Change-Id: I595485e8804d6f2e4e0f9bc8a78c8cb132411f7d
* loplugin:constantfunction in ucbhelperNoel Grandin2016-03-164-26/+14
| | | | | | | Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:constantparamNoel Grandin2016-03-151-2/+2
| | | | Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
* tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar2016-03-151-2/+2
| | | | | | | | | | I simply replaced OSL_DEBUG_LEVEL > 1 with OSL_DEBUG_LEVEL > 0 as suggested in easy hack Change-Id: Id30d93fa439fa4cddf4a56c90b6054203c7882b1 Reviewed-on: https://gerrit.libreoffice.org/23233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
* new loplugin: commaoperatorNoel Grandin2016-02-231-1/+4
| | | | Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
* Remove excess newlinesChris Sherlock2016-02-0912-239/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* InterfaceContainer2 with vector instead of SequenceNoel Grandin2016-01-252-9/+2
| | | | | | | | | | create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
* Fix typosAndrea Gelmini2016-01-101-1/+1
| | | | | | | Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* loplugin:unusedfields variousNoel Grandin2015-11-261-1/+0
| | | | Change-Id: I18f94269a1172cf195ee402384f7144610e1e82d
* use unique_ptr for pImpl in ucbhelper/Noel Grandin2015-11-177-11/+3
| | | | Change-Id: Ibae75fc4d843bd38179d4c7afc6ddb532835c7a6
* use initialiser for Sequence<OUString>Noel Grandin2015-11-151-4/+2
| | | | | | | | | | | | using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* com::sun::star->css in ucbhelper/Noel Grandin2015-11-1111-156/+141
| | | | | | | Change-Id: I01e3046caefdcfbf630f4a794f12e8890be6db40 Reviewed-on: https://gerrit.libreoffice.org/19902 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-109-35/+35
| | | | Change-Id: I3003db8a411740db48c2e0c6ecd81a7fd9209e6c
* loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann2015-11-061-2/+2
| | | | Change-Id: I970a03643f3c460110bc7caf1dc33c6dde1d78d5
* use uno::Reference::set method instead of assignmentNoel Grandin2015-11-053-5/+3
| | | | Change-Id: Id57ccff7ea6cf5c7053b51268b1190f5459bb357
generated by cgit (git 2.34.1) at 2024-07-29 05:03:21 +0000