summaryrefslogtreecommitdiffstats
path: root/ucb
Commit message (Collapse)AuthorAgeFilesLines
* remove last WeakImplHelper8 usesCaolán McNamara2015-08-212-7/+5
| | | | Change-Id: I7ecadedb77832fb3073870880dbfba121fdae826
* loplugin: defaultparamsNoel Grandin2015-08-215-8/+7
| | | | Change-Id: If1d183f32079548645b4974a16161dc997c026b7
* Consolidate isFileUrl checksStephan Bergmann2015-08-191-1/+2
| | | | Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
* cppcheck:noExplicitConstructor in webdav, serf versionGiuseppe Castagno2015-08-183-17/+5
| | | | | | | | | | | | | | Explicitly add constructors that where previously hidden. The right implementation of what I did in aade7198d72bc4ddb18f10729b89f0435e6ca197. The explict keyword was added in 6343754e310a589cb49e2a1da0cd68472571179d Change-Id: I66f6ee51c8b51d93d6ac673e75555e13024e4b48 Reviewed-on: https://gerrit.libreoffice.org/17823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Clean up reinterpret_castsStephan Bergmann2015-08-171-17/+6
| | | | Change-Id: Idd25acf645af7f99e332ec1d5431f7988408675d
* loplugin:cstylecastStephan Bergmann2015-08-172-6/+5
| | | | Change-Id: I32a9feb5851691b02475e9eb5dbb024d3330b232
* cppcheck:noExplicitConstructorGiuseppe Castagno2015-08-172-1/+13
| | | | | | | | | | | Added a constructor and a method there were missing. The explict keyword was added in 6343754e310a589cb49e2a1da0cd68472571179d Change-Id: Iaff33eba8581dc201a8e899c7be024e87f8e6b0e Reviewed-on: https://gerrit.libreoffice.org/17781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* CMIS: remember new session for each userSzymon Kłos2015-08-145-10/+29
| | | | Change-Id: I7d0a72e48b8f9056e8761cae8939e2b8f6dbdd24
* cppcheck:noExplicitConstructorNoel Grandin2015-08-078-14/+13
| | | | Change-Id: I2717d3d120df8af5b7e9af8d147a57b9f5b5ecbe
* loplugin:unusedmethodsNoel Grandin2015-08-051-4/+0
| | | | | | | Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* inline some use-once typedefsNoel Grandin2015-08-031-6/+3
| | | | | | | Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d Reviewed-on: https://gerrit.libreoffice.org/17495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove some unused typedefsNoel Grandin2015-08-031-1/+0
| | | | | | | Change-Id: I98c1e7eaa66b7afb05255a017a3de54714637501 Reviewed-on: https://gerrit.libreoffice.org/17491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* new loplugin: refcountingNoel Grandin2015-08-032-4/+3
| | | | | | | | | | | | | | This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethodsNoel Grandin2015-07-302-19/+0
| | | | | | | Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:cstylecastNoel Grandin2015-07-274-8/+5
| | | | Change-Id: I21fd75b3c891d98f6ad1e4c8af985c2cd21c7db4
* loplugin:staticmethodsNoel Grandin2015-07-274-12/+12
| | | | Change-Id: Iab1eda788690366bfc03ba7c4f085cb474fef1b8
* loplugin:loopvartoosmallNoel Grandin2015-07-271-1/+1
| | | | Change-Id: I9114a7dd3eae7a76432655c4459a7326bb1908f4
* loplugin:simplifyboolNoel Grandin2015-07-272-8/+4
| | | | Change-Id: Id57ee3c09b11c3ce4820ed06a15f13866a10f19a
* loplugin:stringconstantNoel Grandin2015-07-275-19/+20
| | | | Change-Id: I95765e9c26e393a838ee0c617fde415e6c50e884
* fix --with-webdav=serf buildNoel Grandin2015-07-271-1/+1
| | | | | | fallout from the conversion to variadic WeakImplHelper template Change-Id: I1ff6b4aa0b574bbd4787f548e0bc4bf51b211aba
* inline a bunch of use-once macrosNoel Grandin2015-07-2711-56/+19
| | | | | | | no point in having a macro unless it's actually going to reduce the number of lines of code Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
* remove some unused definesNoel Grandin2015-07-274-19/+4
| | | | | | | Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* inline a handful of use-once #definesNoel Grandin2015-07-234-59/+28
| | | | Change-Id: Id2654555c4042f8c0bdbd6bab6507e705f08326b
* tdf#82744: fix WebDAV lock/unlock behaviour - part 1Giuseppe Castagno2015-07-222-18/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are some areas in ucb outside the issue scope that should later be addressed, among them: - in ucb/webdav make flag m_bTransient working right, currently lock option for WebDAV server not supporting it is suboptimal: there are not needed lock requests; - change the method the modified file is checked against the old one, using DAV:etag instead of the DateTime; - some http status code returned by the server don't seem to be managed; - during WebDAV operation some redundant request of properties is carried out. Probably some clean up to remove these not needed transactions is to be done. Accessing only those really supported by the referenced href would be better. Changes done to the code in ucb, in no particular order - remove current WebDAV lock management - have the lock/unlock working correctly when the webdav resource is first created: in the case of creation is the first lock on the non existent resource that actually creates it - fix a problem while fetching WebDAV properties. If a single WebDAV non-cached property was requested, it would not be fetched from the server without this fix. - change the lock owner name. This should probably be different. Something to be discussed. This same string can be read by all the applications accessing the lock. Spec reference is: RFC4918 [2007]: '14.17. owner XML Element' link (as of 20150713): http://tools.ietf.org/html/rfc4918#section-14.17 - manage WebDAV locked file exception directly while locking. The ucb::InteractiveLockingLockedException is thrown directly when detected by the lock command, to avoid the user interaction activated by the cancelCommandExecution method. - terminate gracefully if WebDAV lock/unlock is not supported Change-Id: I4c5cd652ac7b2c32fb1c3307c34fc31d1a0305c2 Reviewed-on: https://gerrit.libreoffice.org/17080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* cmis: throw an error if we were not able to open repositoryVasily Melenchuk2015-07-202-12/+52
| | | | | | | | | | | | It was an crash before, if we have stored CMIS url with repository that does not exist. Session was created, but with empty repo. Now this nuance is checked and slightly improved error reporting for cmis. Change-Id: I447ec767fd735829f8a507733552b26e05cba441 Reviewed-on: https://gerrit.libreoffice.org/17224 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* loplugin:simplifyboolStephan Bergmann2015-07-162-2/+2
| | | | Change-Id: I164b62e2c98fad49d581b2ee282b6329b83bdbfb
* If user cancels authorization, don't show login dialog againSzymon Kłos2015-07-161-0/+5
| | | | Change-Id: I4b110c041f1b8908fdfeeec3b4544f8607f23ddb
* PlaceEditDialog: only one error after failed authSzymon Kłos2015-07-161-1/+5
| | | | Change-Id: I215de03282b3692ebfdc6a7a0e9fd02ecc04f722
* tdf#84190 : when auth fails, don't remember passwords for cmisSzymon Kłos2015-07-162-3/+3
| | | | Change-Id: Ia1e0d553556693e0efa6de0bfc6f8b0ae9d40b5d
* PlaceEditDialog: temporary error box (showing when auth failed)Szymon Kłos2015-07-161-0/+1
| | | | Change-Id: I614c62df60e4da4f6bb36438cbd3360484cd518c
* cleanup some unnecessary direct usage of the OString/OUString C API.Noel Grandin2015-07-101-1/+1
| | | | | | | Change-Id: I6edee95aae1c169ce70063562a0c1b287e0c4735 Reviewed-on: https://gerrit.libreoffice.org/16861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Fix typosAndrea Gelmini2015-07-083-3/+3
| | | | | Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
* loplugin:unusedmethods ucbNoel Grandin2015-07-0719-185/+0
| | | | | | | Change-Id: Idc0ca78da8ebbdfe8489eee92a1167eb1bd9722f Reviewed-on: https://gerrit.libreoffice.org/16794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1309265 Uncaught exceptionCaolán McNamara2015-07-042-2/+2
| | | | Change-Id: I879b55c919edff1e146edd8a83bce6e5e9e699b5
* Fix typosAndrea Gelmini2015-07-043-3/+3
| | | | | | | Change-Id: Id9296115f30858e7fd470a199e59343a96d7deec Reviewed-on: https://gerrit.libreoffice.org/16712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
* typo: therfore -> thereforeAndras Timar2015-07-031-1/+1
| | | | Change-Id: I9dcc0ce882dfd533d98a4f71625bb85e44084283
* coverity#1309068 Uncaught exceptionCaolán McNamara2015-07-022-2/+2
| | | | Change-Id: I8243eca8d23409cc134379f168aef668dc9c7917
* coverity#1309065 Uncaught exceptionCaolán McNamara2015-07-023-4/+3
| | | | Change-Id: I1ed3bec714a36bde4d4472b93f8e3a8950161e4d
* coverity#1309063 Uncaught exceptionCaolán McNamara2015-07-022-2/+2
| | | | Change-Id: I4fa0f2c0bb139c5c0a95647fc84fef978d3149b9
* coverity#1309060 Uncaught exceptionCaolán McNamara2015-07-022-2/+2
| | | | Change-Id: I9815d25807f19bdd87e4aca9348e95f521f4fdd8
* Coverity 1308468 etc.: Exception specificationsStephan Bergmann2015-06-304-65/+22
| | | | | | | | | | While these functions do not throw any UNO exceptions, no need to specify them as nothrow, and do allow std exceptions to pass through. Also covers Coverity 1308470, 1308476, 1308482, 1308495, 1308496, 1308502, 1308506, and 1308575. Change-Id: I00306f606f3f20462016177eebbd26ed5af76506
* Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin2015-06-291-6/+6
| | | | This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
* return and use std::vector from OInterfaceContainerHelperNoel Grandin2015-06-291-6/+6
| | | | | | | | | | since most of the time we don’t need a heavyweight uno::Sequence. Adds a new method getElementsAsVector(). Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a Reviewed-on: https://gerrit.libreoffice.org/15747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1308540 Uncaught exceptionCaolán McNamara2015-06-282-2/+2
| | | | Change-Id: I1faf09f6cee0d9dfa4a3b006916978add95ca38c
* Fix typosAndrea Gelmini2015-06-281-1/+1
| | | | | | | Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* coverity#1308498 Uncaught exceptionCaolán McNamara2015-06-282-2/+2
| | | | Change-Id: I979b9281216906188c01c5afa03cee1f6568fbb7
* coverity#1308497 Uncaught exceptionCaolán McNamara2015-06-282-2/+2
| | | | Change-Id: Icf49cb8bd275c9c2591c85276f05952b5e253cb5
* coverity#1308494 Uncaught exceptionCaolán McNamara2015-06-281-1/+1
| | | | Change-Id: Ie05140e8b144fdf40b473920092d66d42ec47d74
* coverity#1308493 Uncaught exceptionCaolán McNamara2015-06-282-2/+2
| | | | Change-Id: I2ec82799b08aa1762812dc9e1683329ebc72ab0f
* coverity#1308488 Uncaught exceptionCaolán McNamara2015-06-282-2/+2
| | | | Change-Id: Ibdf76c21c8805b11a3e0961b2f131ca4143cbabd
generated by cgit (git 2.34.1) at 2024-09-02 07:31:48 +0000