summaryrefslogtreecommitdiffstats
path: root/ucb
Commit message (Collapse)AuthorAgeFilesLines
* Fix typosAndrea Gelmini2016-06-131-1/+1
| | | | | | | Change-Id: Ic3efae53430fbb2c1eb7962c3cf69bf99315e55b Reviewed-on: https://gerrit.libreoffice.org/26202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2016-06-091-4/+1
| | | | | | | | | | | | | | | | | | | | This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* remove some manual ref counting in svx and xmloffNoel Grandin2016-06-063-23/+14
| | | | | | | Change-Id: Ica0b6ff8ff7fa9e65cd758160d6e3ea7110ebb46 Reviewed-on: https://gerrit.libreoffice.org/25824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Resolves: tdf#55566 opening two docs with open document macro events can crashCaolán McNamara2016-06-031-6/+7
| | | | | | | | | OfficeDocumentsManager::buildDocumentsList was set up to ignore disposed documents, but didn't ignore documents which were still uninitialized (i.e. waiting for the macro warning dialog of the other in-construction document to return a decision) Change-Id: I936e29ab6fad14a33609e8d57d11d7d0178075e4
* teach refcounting clang plugin about uno::ReferenceNoel Grandin2016-05-317-9/+9
| | | | | | | | | | | | | | uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* avoid a global uno::Reference to the current XCommandEnvironmentCaolán McNamara2016-05-262-5/+16
| | | | | | | | | | | | | because the Env is kept until we exit, which we get away with now. But we won't get away with it if we set the parent window property of the InteractionHandler belonging to the Env. Because we then end up trying to destroy the vcl dialog well after all the vcl, etc infrastructure is torn down and crash on exit. Here I'm assuming that its safe to use a WeakReference because we're just using this to smuggle into the c-style callbacks a Reference to a Env currently belonging to something else Change-Id: I2d6b90ae23d5a24431dc49d4316bdc3194560403
* loplugin:unusedmethods in ucb/ucbhelperNoel Grandin2016-05-1910-76/+0
| | | | | | | Change-Id: I2935904e2cbecec6c928f4cbc88979bc2d1a40f8 Reviewed-on: https://gerrit.libreoffice.org/25090 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#87938 libcmis: Google 2FA implementationSzymon Kłos2016-05-164-0/+52
| | | | | | | | | | | | | 2 Factor Authentication for Google Drive, changes: + parsing additional page with challenge - pin code verification + calling the interaction dialog requesting the code + dialog title changed to more general: Authentication Code + dialog shows url field only if not empty Change-Id: Idb3ebbad6a12849b9e50af87b46324bfbe966bab Reviewed-on: https://gerrit.libreoffice.org/25002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
* clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin2016-05-138-37/+30
| | | | | | | Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Assign 0 explicitly, avoiding intermediate downcastsMatteo Casalin2016-05-101-1/+1
| | | | Change-Id: I43a9adeaf7078551a3447032fbf65affab817b15
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-103-6/+6
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* tdf#99426 Use correct path for lock in PUT methodGiuseppe Castagno2016-05-061-1/+7
| | | | | | | Change-Id: I2091024a601bebede5d2fb8596dda1054ca4ef3b Reviewed-on: https://gerrit.libreoffice.org/24691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* teach passstuffbyref plugin to check for..Noel Grandin2016-05-062-6/+6
| | | | | | | | | | | | unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use Any constructor instead of temporariesNoel Grandin2016-05-048-65/+25
| | | | Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
* tdf#98644 : better error message when wrong password enteredSzymon Kłos2016-05-032-92/+123
| | | | | | | Change-Id: Idf4da8000cce43cb66cb94fdfc8be8a3d6909fa6 Reviewed-on: https://gerrit.libreoffice.org/23475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2016-04-281-12/+12
| | | | | | | Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Some more sal_Bool -> boolStephan Bergmann2016-04-251-1/+1
| | | | Change-Id: I974a1c8d64f5b13b9052365c3219dcd2dc6927dc
* Related tdf#88502 a better implementation than the one in...Giuseppe Castagno2016-04-221-23/+1
| | | | | | | | | | | | | | | ...commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1. This commit reverts previous implementation in commit 70bb8c257e7fc402da60fa70109cece1fe4c69d1 and makes use of a dedicated interaction wrapper instead. See comphelper::SimpleFileAccessInteraction for details. Change-Id: Ia037ea14267afaf66d8f9aa2324649264a7cb4bf Reviewed-on: https://gerrit.libreoffice.org/24275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* new plugin stylepoliceNoel Grandin2016-04-213-15/+15
| | | | | | | check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-2016-97/+97
| | | | Change-Id: Ib340ec1731cba5a4409f0e8d8bdde48753312672
* clang-tidy performance-unnecessary-copy-initializationNoel Grandin2016-04-181-2/+1
| | | | | | | | | | | probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* clean-up: unused using declarations and includesJochen Nitschke2016-04-185-28/+0
| | | | | | | | | | | | | | Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Related tdf#88502 Add default XCommandEnvironment to ...Giuseppe Castagno2016-04-151-1/+23
| | | | | | | | | | | | | | | ... Content::getResourceType During WebDAV operation the css::ucb::XCommandEnvironment is almost always needed. Depending on the operation, sometimes the client doesn't set it, in order to disable the exception processing that takes part in ucbhelper::cancelCommandExecution. Change-Id: Ib4bf6a7ca3a902437cab9050c3e310342c655ff2 Reviewed-on: https://gerrit.libreoffice.org/23327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* clang-tidy performance-unnecessary-value-param in variousNoel Grandin2016-04-149-32/+32
| | | | | | | Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:passstuffbyref in ucbNoel Grandin2016-04-1410-12/+12
| | | | Change-Id: I4ba18c767c67c9c8d23aac3f8de728b7a229804d
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-125-15/+0
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cppcheck: noExplicitConstructorCaolán McNamara2016-04-111-1/+1
| | | | Change-Id: Ie25240030fd848a5b30526746206bfd5fe543091
* These are SAL_INFO, at bestStephan Bergmann2016-04-051-2/+2
| | | | Change-Id: I2f4c34de154aa71db721dc30da29173d6c37709f
* loplugin:constantparam in ucbNoel Grandin2016-04-059-49/+21
| | | | | | | Change-Id: Ifa36b58a36232e6333a1c85d85d0372fb0de219b Reviewed-on: https://gerrit.libreoffice.org/23829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* unnecessary reallocNoel Grandin2016-04-042-14/+12
| | | | | | | Change-Id: Iafd6495a8b6a2b371cf004e4383ed92ac6ae4bd2 Reviewed-on: https://gerrit.libreoffice.org/23760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cleanup: remove unused Reference.h(xx) includesJochen Nitschke2016-04-025-13/+0
| | | | | | | | | and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* use SAL_N_ELEMENTS more widelyNoel Grandin2016-03-315-9/+9
| | | | | | | found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
* loplugin:nullptr: Find some more cases in templatesStephan Bergmann2016-03-301-2/+2
| | | | Change-Id: I1f127d56e40b04f2b4df85c0afbcfd424d68a8cc
* Avoid reserved identifiersStephan Bergmann2016-03-292-20/+20
| | | | Change-Id: I210133e82bc72dcb89da5f7700314ddcf6bee269
* Remaining argument from loplugin:constantparam in ucbKorrawit Pruegsanusak2016-03-181-1/+1
| | | | | | | | | Still one remaining after b47cb646ff2a62fcd3fac0e453a7261bbaefbcb7 Change-Id: If1dfaa6bbc9f8582f7b2a7dab49815a0a4c6a7b8 Reviewed-on: https://gerrit.libreoffice.org/23355 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Restore WebDAV credential dialog functionality...Giuseppe Castagno2016-03-181-1/+0
| | | | | | | | | ...that was broken in 3d264450989cecdc59a2e64f46a0328432ba0d08. Change-Id: Icd601196867258490f9241efc3d0d6ebea334a2a Reviewed-on: https://gerrit.libreoffice.org/23353 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:constantfunction in ucbhelperNoel Grandin2016-03-165-11/+6
| | | | | | | Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:constantparamNoel Grandin2016-03-154-7/+7
| | | | Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
* tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar2016-03-151-22/+7
| | | | | | | | | | I removed OSL_DEBUG_LEVEL > 1 conditionals and the g_warning() with SAL_INFO() and SAL_WARN Change-Id: Icb4ab72245111b52c59a47cc659dfdb79d5690ee Reviewed-on: https://gerrit.libreoffice.org/23232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
* inline some use-once macrosNoel Grandin2016-03-142-4/+1
| | | | | | | Change-Id: I7ebd8fe70b083a772118a1aab8cdfbf795d6f1e5 Reviewed-on: https://gerrit.libreoffice.org/23235 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#97966 redundant static keywords removed 6Wastack2016-03-111-3/+3
| | | | | | | Change-Id: Iaf034f3b2282a973f6503edea41cb3184543fb11 Reviewed-on: https://gerrit.libreoffice.org/23133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Avoid reserved identifiersStephan Bergmann2016-03-101-10/+10
| | | | Change-Id: Ic2c7cc2a78e8e58c3ca28acd9b6a35ddaceeab60
* Avoid reserved identifierStephan Bergmann2016-03-101-1/+1
| | | | Change-Id: I4d0dc49e44b9e9f7504008ea1d10876cd80e76f8
* Avoid reserved identifierStephan Bergmann2016-03-101-2/+2
| | | | Change-Id: I6c60905541de56229bc26e9dc6e589d4099e9266
* Avoid reserved identifiersStephan Bergmann2016-03-101-4/+4
| | | | Change-Id: I75158ff7588452f38306b0bed351a6532b9c8d1f
* Make CppunitTest name match *.mk file nameStephan Bergmann2016-03-101-9/+9
| | | | | | ...so "make CppunitTest_ucb_webdav_local_neon" works as expected. Change-Id: Iecdd5d1ad19be4789bca60d455a3dfdd8fee9cb3
* These tests can just derive from plain CppUnit::TestFixtureStephan Bergmann2016-03-101-18/+3
| | | | | | ...and then no longer need to override any base class setUp/tearDown Change-Id: Iaea19dfb341325bb45062d0ac0b5fa1eed0d34e0
* loplugin:constantparams in ucbNoel Grandin2016-03-093-23/+7
| | | | Change-Id: I6b925336b13404ccf0f78f194bd3488a22f99b97
* follow the boost lib naming scheme for DateTime tooDavid Tardon2016-03-081-1/+1
| | | | Change-Id: Iae7967bd5f161ecbe888824a4bcb9b87ec8d947a
* tdf#97499 Remove some Default arguments in unordered containerJaskaran2016-03-071-1/+1
| | | | | | | Change-Id: Ic008e244b8ae1888fa45379371f5525ee77f6087 Reviewed-on: https://gerrit.libreoffice.org/22887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-16 23:57:14 +0000