summaryrefslogtreecommitdiffstats
path: root/toolkit
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1312-14/+14
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* loplugin:constantparam in framework..vbahelperNoel Grandin2016-09-072-10/+10
| | | | Change-Id: I592f73012ae8a4df8488ef04dc0956d9400625bc
* convert ScrollType to scoped enumNoel Grandin2016-09-051-3/+3
| | | | Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
* convert RasterOp to scoped enumNoel Grandin2016-09-051-2/+2
| | | | Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
* std::list<sal_uInt16> -> vectorNoel Grandin2016-09-018-38/+38
| | | | Change-Id: Ic08ac3fcb750ceff1f5b3201d4a3151ad567aa1f
* Reduce ENABLE_OPENGL / ENABLE_HEADLESS confusionTor Lillqvist2016-08-031-1/+1
| | | | | | | | | | | | ENABLE_OPENGL means whether to enable the OpenGL slideshow transition code. It does not mean whether to enable use of OpenGL in general. So rename it to ENABLE_OPENGL_TRANSITIONS while at it. ENABLE_HEADLESS means whether to disable use of X11 and OpenGL on X11 (and Wayland) platforms, I think, meaning Linux and maybe Solaris and the BSDs. Maybe it should be renamed to DISABLE_X11_AND_OPENGL. Change-Id: Ibb30f51646b1bcc477fe691a3fa38c7a1e3944ae
* cppcheck: noExplicitConstructorCaolán McNamara2016-07-271-1/+1
| | | | Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
* improve passstuffbyref return analysisNoel Grandin2016-07-271-1/+1
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* new loplugin fragiledestructorNoel Grandin2016-07-121-1/+1
| | | | | | | | | fix up a small number of places that it finds Change-Id: Iedc91e141edfb28f727454f698cd2155a7fd5bf4 Reviewed-on: https://gerrit.libreoffice.org/26566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:redundantcast: redundant static_casts in toolkitStephan Bergmann2016-07-081-1/+1
| | | | Change-Id: Iee61c812384e24a9ac68f1e0ee4ba590838442ca
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-071-1/+1
| | | | Change-Id: I89b22238078c00339a06d7023e024e25a4d4e5bd
* merge toolkit::NameContainer_Impl with toolkit::ScriptEventContainerNoel Grandin2016-07-041-12/+13
| | | | | | | Change-Id: I14e9401056e31ee9d4ad5945a73ca31969430b4c Reviewed-on: https://gerrit.libreoffice.org/26891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:singlevalfields in variousNoel Grandin2016-06-281-3/+0
| | | | | | | Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:singlevalfields in vcl(part1)Noel Grandin2016-06-242-6/+4
| | | | | | | Change-Id: I0031199937cc95793951a070c4b3d8910933e69f Reviewed-on: https://gerrit.libreoffice.org/26595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#97527 - vcl: reference-count MenuNoel Grandin2016-06-231-5/+5
| | | | | | | | | | | some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:salbool: Implicit conversions from non-Boolean fundamental typesStephan Bergmann2016-06-191-4/+4
| | | | Change-Id: I67eac95686678e6f5a2d60798535b2c65a9ba5d7
* Add a pause() method to XToolkitExperimentalTor Lillqvist2016-06-101-0/+35
| | | | | | | Pauses the main thread of LibreOffice for the requested amount of time. Change-Id: I5978a3a9b9561623c698526d8c29695d71df3d03
* fix compile error in SelectionDialog (java unit test)Noel Grandin2016-06-011-1/+1
| | | | | | I suspect that this code is not actually in use anymore Change-Id: I1888c4beec9add7d82e321ad09e1116d1205fbca
* tdf#100092: Deterministic scheduling to prevent unpredictable behavior.Jan Holesovsky2016-05-311-2/+12
| | | | | | | | | | | | Low priority idles can fire more or less randomly, and consequently two consequent runs of LibreOffice differ in the amount of the idles that have been performed during an operation. This commit adds a possibility to turn on a 'deterministic mode' where two subsequent runs of LibreOffice trigger about the same amount of events when they perform the same set of operations. Change-Id: I92566ef4eee20e7d604cfd48f01c4df30c77e653
* Convert SelectionMode to scoped enumNoel Grandin2016-05-301-1/+1
| | | | | | | Change-Id: I86c435de3918540cb54a0cb24568e58456c2f9d1 Reviewed-on: https://gerrit.libreoffice.org/25611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert ImageSet to scoped enumNoel Grandin2016-05-301-1/+1
| | | | | | | Change-Id: I9957435f769957d76e95248914a422e82019e22d Reviewed-on: https://gerrit.libreoffice.org/25604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Resolve: "TODO(Q1): Make GetSystemData method virtual"Caolán McNamara2016-05-192-2/+2
| | | | | | | | | and remove the casting silliness, allowing the removal of cairo_cairo.?xx If anything is to go wrong I'd guess it'll be the windows directx stuff. Change-Id: I3e22c07b9c26ade9b27a245fdd8408de540643f4
* rename to two GetSystemData methods to find all call-sitesCaolán McNamara2016-05-192-2/+2
| | | | | | | | | | | | | | | anyplace calling GetSystemChildSystemData on a SystemChildWindow is definitely right anyplace calling GetWindowSystemData on a Window *might* have intended to call GetSystemChildSystemData on a Window casted back to an underlying SystemChildWindow. Change-Id: I7dcf3a50d0b7ed29bc08cfdb15cc0dcb86be8fa7 Reviewed-on: https://gerrit.libreoffice.org/25158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* clang-tidy modernize-make-sharedNoel Grandin2016-05-181-1/+1
| | | | | | | Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-loop-convert in toolkit to uuiNoel Grandin2016-05-134-16/+15
| | | | | | | Change-Id: I805aa1389ef8dde158f0b776d6b59579fa3082e4 Reviewed-on: https://gerrit.libreoffice.org/24921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-102-2/+2
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* Insert explicit "break" when falling through to empty next caseStephan Bergmann2016-05-101-1/+3
| | | | | | | ...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
* convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin2016-05-091-1/+1
| | | | | | | Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* use Any constructor instead of temporariesNoel Grandin2016-05-044-247/+84
| | | | Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
* teach stylepolice plugin about ref-counted-pointer namingNoel Grandin2016-04-281-2/+3
| | | | | | | Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Some more sal_Bool -> boolStephan Bergmann2016-04-251-1/+1
| | | | Change-Id: Ibb07e8c5b9ef44dac5ce23c590783c1462c532d7
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-2018-51/+51
| | | | Change-Id: I04d2884dcb81482c5c3450c98cccb36096a126d4
* clang-tidy performance-unnecessary-copy-initializationNoel Grandin2016-04-189-20/+17
| | | | | | | | | | | probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* clean-up: unused using declarations and includesJochen Nitschke2016-04-183-5/+0
| | | | | | | | | | | | | | Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke2016-04-133-8/+9
| | | | | | | | | | | | | | | Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-123-10/+0
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy performance-unnecessary-value-param in toolkitNoel Grandin2016-04-112-5/+5
| | | | Change-Id: Ic08723ef15f2bc31031e3887b9916ecc7e2205da
* Typo: multible->multipleJulien Nabet2016-04-101-1/+1
| | | | | | | Change-Id: I1c61841be58d49132ac3c69a6b227d75e829f769 Reviewed-on: https://gerrit.libreoffice.org/23972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* sequence->vector in toolkitNoel Grandin2016-04-041-10/+8
| | | | | | | Change-Id: Ia042eea672bb7535192132ae0b133d1745dc8cde Reviewed-on: https://gerrit.libreoffice.org/23759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#97499 Fixed containers parameters clearing #4tymyjan2016-04-041-2/+1
| | | | | | | Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cleanup: remove unused Reference.h(xx) includesJochen Nitschke2016-04-023-6/+0
| | | | | | | | | and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#97966 Drop 'static' keywordsWastack2016-04-016-10/+10
| | | | | | | | | Including no keywords from extern "C" blocks Change-Id: Ie3160af9decf04ceeda02dc20a6518afaa80f972 Reviewed-on: https://gerrit.libreoffice.org/23677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* use SAL_N_ELEMENTS in for loopsNoel Grandin2016-03-311-1/+1
| | | | | | | | | | for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* fix headless buildOliver Specht2016-03-252-1/+12
| | | | | | | | | | disables OpenGL and glew usage, lets --without-gui do what --without-x did before and disables X related test Change-Id: I680b47c9962a0d43c8ece593db0b82e347ceebdb Reviewed-on: https://gerrit.libreoffice.org/23474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
* loplugin:constantparams in vcl/Noel Grandin2016-03-162-3/+3
| | | | | | | | | also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar2016-03-122-31/+1
| | | | | | | | | | I replaced OSL_DEBUG_LEVEL > 1 conditionals to OSL_DEBUG_LEVEL > 0 as suggested in easy hack Change-Id: Ie852e95992bb8b0c49f2d01348ed598dfc26a39a Reviewed-on: https://gerrit.libreoffice.org/23074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
* Avoid reserved identifiersStephan Bergmann2016-03-101-4/+4
| | | | Change-Id: I52cab3f30c5a1365dd51d7db2c2cf2b3a609fa11
* loplugin:constantparam in toolkitNoel Grandin2016-03-104-13/+10
| | | | Change-Id: I45d6c37bfe17ef686b50d688698bcc3a7f3cc311
* new loplugin: commaoperatorNoel Grandin2016-02-231-2/+2
| | | | Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
* Fix missing iterator include on MSVC 14.0David Ostrovsky2016-02-171-0/+1
| | | | | | | Change-Id: I55de612aef52038fd9979426950d4ae4131ca586 Reviewed-on: https://gerrit.libreoffice.org/22448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
generated by cgit (git 2.34.1) at 2024-10-27 08:34:52 +0000