summaryrefslogtreecommitdiffstats
path: root/svx
Commit message (Collapse)AuthorAgeFilesLines
* tdf#88710 Cleanup after removing dbtoolsclientMatthew Nicholls2015-04-228-36/+66
| | | | | | | | | | | | | | | | | | | | | | Removes "virtualdbtools" and its implementation under "simpledbt", which are mostly wrappers around various dbtools functions and classes, previously aiding the now removed dynamic loading logic. Removes IDataAccessTools, IDataAccessTypeConversion and IDataAccessToolsFactory interfaces and their accompanying implementations which are completely unused. Removes IDataAccessCharSet (implemented by ODataAccessCharSet) and moves the implementation into a function which replaces ODataAccessCharsetHelper. Removes ISQLParseNode and ISQLParser and their implementation in OSimpleParseNode and OSimpleSQLParser, which simply wrap around OSQLParseNode and OSQLParser respectively. To avoid including "sqlbison.hxx" unnecessarily, includes to "sqlbison.hxx" are now only used where needed. Change-Id: Id882dfbf43514d84a1eaffc1f916d627830c8cd6 Reviewed-on: https://gerrit.libreoffice.org/15450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
* Resolves: tdf#76825 styles drop down menu is too narrowCaolán McNamara2015-04-211-18/+71
| | | | Change-Id: I3d1ba1da40990df2427f0d380a85d5e704f37038
* refactor for reuseCaolán McNamara2015-04-211-20/+15
| | | | Change-Id: I46e04464376324c7e48fe0ccf7362c3a4256e3c2
* split out the code that sets up the device for each entryCaolán McNamara2015-04-211-9/+17
| | | | Change-Id: Iad426e1cb1eaac24edf1e7bb61307f29d33d8786
* draw all entries the same wayCaolán McNamara2015-04-211-23/+13
| | | | Change-Id: I9da3c8dca4db4a02197a67e1fbedd9b525dc7768
* break out text drawing bit as UserDrawEntryCaolán McNamara2015-04-211-23/+34
| | | | Change-Id: Icb1bcfb5f9f7475f67c9c001efdad2aa7e0d0834
* fix indentCaolán McNamara2015-04-211-6/+3
| | | | Change-Id: I2628ac3fbabe9f33c41c7f3612eae608fb854ae3
* Use cppu::ImplInheritanceHelperStephan Bergmann2015-04-211-23/+0
| | | | Change-Id: If4f7ebcc2da2bda68a6c51b309541181a40b6df4
* svx: nPtAnz -> nPointCountMiklos Vajna2015-04-216-43/+43
| | | | Change-Id: Iec25a45729143cea7a8ff5cf4e03969998f2c355
* loplugin:passstuffbyrefStephan Bergmann2015-04-211-2/+2
| | | | Change-Id: I4889b3d56b9e6f6926d1d094130c277588ff143c
* Get rid of trivial comphelper::query_interface wrapperStephan Bergmann2015-04-211-1/+2
| | | | Change-Id: I2b9dafd2a34d055dcd8b8c4d894be30dc821d3be
* Get rid of trivial comphelper::in-/decrement wrappersStephan Bergmann2015-04-213-7/+6
| | | | Change-Id: Id3a12ef9d56c30719f483e610c8a8b08caf05def
* StyleManager & StylePreviewRenderer + common implementationTomaž Vajngerl2015-04-213-0/+252
| | | | | | | | | | | | | | | StyleManager is a new class responsible to handle document styles. The current implementation has only the responsibility to provide a implementation of StylePreviewReneder, but the idea is to move all style related functionallity to this class (and relieve the SfxObjectShell a bit). CommonStyleMAnager is the common impl. StylePreviewRenderer is responsible to render a preview of a style. As styles can be handled differently by each component it is possible to provide component specific StylePreviewRendered, but currently only the common one is implemented and used by sw. Change-Id: Id271485f571a777a3e94f855d3c614a2efc14628
* convert SEARCH_OPTIONS constants to scoped enumNoel Grandin2015-04-202-32/+32
| | | | | | | Change-Id: Id0f0c7d692410cf5e1477c5180e7cfb8e7b0f52b Reviewed-on: https://gerrit.libreoffice.org/15345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unreffunStephan Bergmann2015-04-191-2/+0
| | | | Change-Id: Ib6b8e49e1795c1b748dfec6a63333ee5011c04ad
* callcatcher: update unusedcodeCaolán McNamara2015-04-191-12/+0
| | | | Change-Id: I4b2a7ea03aafbfbf1fece1533da801a4326d80f9
* cleanup svxitems.sdiTomaž Vajngerl2015-04-181-91/+17
| | | | Change-Id: Id154295e7f241acf986d9c3078c9ca18dbcce0e7
* remove stdio.h include from compressgraphicdialogTomaž Vajngerl2015-04-181-2/+0
| | | | Change-Id: I510995b55f69b7541f3cf11f0af66b73657af1ca
* fdo#71797 strange font selection bug with font previewNoel Power2015-04-171-1/+10
| | | | | | | | | | | | | | | The dialog seems to be automatically in preview mode from the start (which seems wrong) That bogus mode of operation (which I failed to fix from the begining) is somewhat responsible for the behaviour we see. Adding here a further ugly hack to ensure we use GetText when not in drop down mode (this is when clicking on a cell or cycling through the font list with up/down keys) In dropdown mode sweeping with the mouse highlights fonts (and we preview the highlighted ones) Note: in this case the selected font and the highlighted font are different, we need to pick up the correct one. Change-Id: Id2ba96a57d2f8cfc9657bce8de3ac27588868eaf Signed-off-by: Noel Power <noel.power@suse.com>
* Revert "WaE: unused variables"Tor Lillqvist2015-04-175-0/+18
| | | | | | | See 3ac1584549364c573d4d4e3baed9ad39ad6ce8e4. This reverts commit 7bcf9131032cbcdb162f33d03230e43d4f1db2aa. This reverts commit 063aec33f029f1fbdd1b1ee274e94a00f256465e.
* SvStream: WriteUChar -> WriteBoolStephan Bergmann2015-04-174-5/+5
| | | | Change-Id: I89aa0e22c31d368ab36fe46917db6aacb11c7b14
* WaE: unused variablesTor Lillqvist2015-04-175-18/+0
| | | | Change-Id: I3b0ed8a6c8e5d13b9236ee1a1337820c3cbce9ac
* svx: nPntAnz -> nPointCountMiklos Vajna2015-04-176-74/+74
| | | | Change-Id: I2a4c7ef9d33db1c34a4ab338f70f800b30083f4f
* convert SCRIPTTYPE_ constants to scoped enumNoel Grandin2015-04-172-7/+7
| | | | | | | Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433 Reviewed-on: https://gerrit.libreoffice.org/15344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* svx: can avoid comphelper/implbase_var.hxx in formcontrollerMiklos Vajna2015-04-161-6/+2
| | | | Change-Id: I37a1d16f76cad6b8ff5727ecd09d718e15519de9
* DBTOOLS_DLL_NAME not used anymoreMatúš Kukan2015-04-151-1/+0
| | | | Change-Id: Ieb9a373e4d59bfe72a7709bd7822617f9877054a
* and SvxContourDlgItem is also unused nowCaolán McNamara2015-04-151-17/+0
| | | | Change-Id: I9696123d8ce9cd69520921cd19cf26e3f60bc61a
* and now SvxBmpMaskSelectItem is unusedCaolán McNamara2015-04-151-21/+0
| | | | Change-Id: I76993ffb0dd347afe4f114431e8c12922d5c6882
* -Werror,-Wunused-private-fieldStephan Bergmann2015-04-153-3/+0
| | | | Change-Id: I90cb42aff1d57a92f371d339b0be7c71b1a15ff8
* convert SFX_ITEM constants to scoped enumNoel Grandin2015-04-152-2/+2
| | | | | | | Change-Id: Ief8c30c356ba947727c5ab70092042816a0db99e Reviewed-on: https://gerrit.libreoffice.org/15302 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* convert SIGNATURESTATE_ constants to scoped enumNoel Grandin2015-04-151-13/+13
| | | | | | | Change-Id: I715e39599464a199a8b78ec274bfe47b90fc4bb7 Reviewed-on: https://gerrit.libreoffice.org/15301 Tested-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-1591-452/+452
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* tdf#89750: svx: fix ExternalToolEdit on WindowsMichael Stahl2015-04-141-2/+1
| | | | | | | | | | While adding check that the temp file move succeeds, overlooked that the file handle is actually leaked, which means the move will fail on WNT because the file is already open. (regression from ef490df2119523e1761f99b5fdbb387c2c71608d) Change-Id: I779ccde79871930fef3bad7e17b633fb62e36a46
* tdf#89478: svx: ODF import: SvxBrushItem Graphics should override ColorMichael Stahl2015-04-141-13/+14
| | | | | | | | | | | | | | | | | | The bugdoc has: <style:page-layout-properties fo:background-color="#007f7f" > <style:background-image xlink:href="Pictures/2000003900002FA3000055F455EC9F63.svm"/> </style:page-layout-properties> In this case it's clearly better to prefer the Graphics. The old code could actually store both in the model but the UI only allows setting either Color or Graphic, so this should be good enough. (regression from 7d9bb549d498d6beed2c4050c402d09643febdfa) Change-Id: Id33231ad90815d9791f90289fb0b55455d334c14
* svx: hack around LogicToPixel assert in SvxRuler::UpdateTabsMichael Stahl2015-04-141-0/+10
| | | | | | | | Somehow this gets called in a different order than in 4.3; with the bugdoc from tdf#89478 i get this assert on master because of the uninitizlized / LONG_MAX. Change-Id: Iacce21571246c96276bd3c126f982282df7fc491
* tdf#88710 Kill svx dbtoolsclientMatthew Nicholls2015-04-1421-397/+67
| | | | | | | | | | Removes dynamic loading logic described in tdf#84315, similar thing removed in swdbtoolsclient. Change-Id: I8762102a7263e6933354c2ff6f9978929b760f6e Reviewed-on: https://gerrit.libreoffice.org/15147 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
* Resolves: tdf#90583 3D pie-chart missing guide handlesCaolán McNamara2015-04-131-8/+1
| | | | | | | | | | | | | | | | partial revert of commit db1d2af02861b49e4f53d726d59cd71c20cee9b1 Author: Armin Le Grand <alg@apache.org> Date: Tue Feb 18 21:18:13 2014 +0000 Resolves: #i123539# some optimizations for 3D chart... geometry creation using UNO API (cherry picked from commit bbe35be767d76d08891c4f3d3600d80e0e6805f2) Change-Id: If35f05fb62230e90cfc43a0beac053e8a87820d4
* loplugin:redundantcast: redundant const_cast followed by implicit upcastStephan Bergmann2015-04-132-2/+2
| | | | Change-Id: I58297ba336d96358eb0683684bbd763870ef56cb
* loplugin:staticmethodsNoel Grandin2015-04-134-11/+11
| | | | Change-Id: I332d3b3158b46cf130540c6e1479dd01cb457d03
* Calm down TBsJulien Nabet2015-04-111-1/+1
| | | | | | Of course, I suppose there should be a better fix than this one Change-Id: I65505d52b0a161ebea2e4bda5d1b32934e74906b
* svx: add an assertion to this fixed-size thingMichael Stahl2015-04-101-1/+2
| | | | Change-Id: I3d496f78fd60a3a47cc62d4237f31e5e131a9692
* Change tools::Time::GetSystemTicks to sal_uInt64Stephan Bergmann2015-04-092-5/+5
| | | | | | | | | | | | | | | ...as follow-up clean-up after 71fefe1dc2bcda3a4cc18d71e1acaf161cc059f2 "Change 'blink times' to be of type sal_uInt64 and thus consistent with Timer::Get/SetTimeout since 9c7016b5b530ca212b1275f44f9e2fc0527109ee 'Scheduler: Changed uLong to uInt32/uInt64.'" Transitively meant to change quite a number of further time-related places from sal_uLong/sal_uIntPtr to consistently use sal_uInt64. Change-Id: I38eb493943906356138bf58eb098d2f54a3dee34 Reviewed-on: https://gerrit.libreoffice.org/15214 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Resolves: tdf#90384 queue_resize needs to Invalidate the optimal cache sizeCaolán McNamara2015-04-091-0/+1
| | | | | | but the PanelLayout didn't Change-Id: I38a8975f1488fa2a2ffe91b66745e1a1c6c48a28
* Just use a plain std::vector<OUString>Stephan Bergmann2015-04-091-8/+9
| | | | | | | | | | Nothing obvious that would speak against converting from the original SvStringsDtor to plain std::vector<...> instead of slavishly sticking to boost::ptr_vector<boost::nullable<...>>. Also, prevents a false -fsanitize=null warning about "reference binding to null pointer of type 'rtl::OUString'" in boost::void_ptr_iterator<...>::operator*() during ~SvxClipboardFmtItem_Impl(). Change-Id: I08d8fc573ff99a5bddd67c0d2be4e7ea38025958
* loplugin:staticmethodsNoel Grandin2015-04-091-5/+5
| | | | Change-Id: I715374b531da2850434b2436633b6042ecb9ebe0
* remove DELETEZ in tbcontrlTomaž Vajngerl2015-04-091-7/+5
| | | | | | | DELETEZ is redefined here and used just 2 times in the code. Better to just delete it - it doesn't really make the code more readable. Change-Id: I094a7d41fa9e86d3f20cce357bc13e9fc04df3df
* use std::unique_ptr for Impl in SvxStyleToolBoxControlTomaž Vajngerl2015-04-091-4/+3
| | | | Change-Id: Ia01755ee617002ef2c234e29b1edd497b031ef8a
* Remove dead INetProtocol::VimStephan Bergmann2015-04-071-2/+2
| | | | | | | ...which removes the need to abstract over the standard URI '%' escape prefix vs. the silly vim '=' special case invention. Change-Id: I54a52dd912c3aafc38275a0ac2466a6daeec328f
* Change "blink times" to be of type sal_uInt64Stephan Bergmann2015-04-075-14/+8
| | | | | | | | | | ...and thus consistent with Timer::Get/SetTimeout since 9c7016b5b530ca212b1275f44f9e2fc0527109ee "Scheduler: Changed uLong to uInt32/uInt64." Otherwise, at least JunitTest_forms_unoapi on 32-bit Linux would stay busy forever in vcl::Cursor::ImplTimerHdl, alternating among ImplRestore() and ImplDraw(). Change-Id: Ic3fd349344c105078b52749ca85559fce485d0c4
* Remove unused getBlinkTime functionsStephan Bergmann2015-04-071-3/+0
| | | | Change-Id: I9820f0ede94e1b335410a3aa803ff10b6f246b00