summaryrefslogtreecommitdiffstats
path: root/svgio
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:oncevar in starmath..svlNoel Grandin2017-06-274-64/+49
| | | | | | | Change-Id: I20e3796407c7e429a88d2811673929ac1141a41c Reviewed-on: https://gerrit.libreoffice.org/39280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields store..svlNoel Grandin2017-06-214-50/+1
| | | | | | | Change-Id: I6070a683e5128271b84a10caccb548d07c950927 Reviewed-on: https://gerrit.libreoffice.org/39021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-delete-null-pointerNoel Grandin2017-06-121-14/+3
| | | | | | | | | which in turn triggered some loplugin:useuniqueptr Change-Id: I0c38561fc9b68dac44e8cf58c8aa1f582196cc64 Reviewed-on: https://gerrit.libreoffice.org/38281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cppcheck: knownConditionTrueFalseJochen Nitschke2017-06-061-2/+2
| | | | | | | Change-Id: I231113eaf3117e13ed18de906e3787643abe9335 Reviewed-on: https://gerrit.libreoffice.org/38423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert GRFILTER constants to ERRCODE_GRFILTER_Noel Grandin2017-06-021-2/+2
| | | | | | | | | | since various code mixes these constants in with ErrCode values from other code, let us just make it into real ErrCode values. Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95 Reviewed-on: https://gerrit.libreoffice.org/38313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unnecessary use of OString::getStrNoel Grandin2017-05-283-23/+3
| | | | | | | Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:checkunusedparams in svgioNoel Grandin2017-05-0426-29/+28
| | | | | | | Change-Id: I2e05fc51715902737ead6e57d0fbe167d715b822 Reviewed-on: https://gerrit.libreoffice.org/37194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove empty namespacesJochen Nitschke2017-05-031-7/+0
| | | | | | | Change-Id: I3eae0ecc1ffc5500d3c55abc6554822f5432a50a Reviewed-on: https://gerrit.libreoffice.org/37173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:salunicodeliteral: svgioStephan Bergmann2017-04-284-31/+31
| | | | Change-Id: I98461a30c14d3939e8fd5313a49aa478b39df1c3
* clang-tidy readability-simplify-boolean-exprNoel Grandin2017-04-281-6/+1
| | | | | | | Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a Reviewed-on: https://gerrit.libreoffice.org/36450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-211-1/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* Fix typosAndrea Gelmini2017-03-034-4/+4
| | | | | | | Change-Id: Ib25dadb25d8c2df1361de194f74cf3ddd459650d Reviewed-on: https://gerrit.libreoffice.org/34783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-263-24/+24
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* new loplugin: useuniqueptr: svgioNoel Grandin2017-01-1930-64/+67
| | | | | | | Change-Id: I645ac954ac519fe713f4347cdf69780b0f8070e4 Reviewed-on: https://gerrit.libreoffice.org/33252 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#104339 Partially revert d5649ae7b76278cb3155f951d6327157c7c92b65Xisco Fauli2016-12-191-18/+1
| | | | | | | Change-Id: I5160c6efe7cf58351955d9d1d3066e3b33bdfe20 Reviewed-on: https://gerrit.libreoffice.org/32082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
* convert DecodeMechanism to scoped enumNoel Grandin2016-12-051-1/+1
| | | | Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
* loplugin:unnecessaryoverride (dtors) in svgioStephan Bergmann2016-12-021-5/+0
| | | | Change-Id: Icff1b3d5072c9a854de7ae12141131b0a9650b91
* convert Primitive2DContainer to std::dequeNoel Grandin2016-11-091-5/+3
| | | | | | | | | | | since we only care about appending to this container, and then traversing it (normally once). So reduce the re-allocations that std::vector requires Change-Id: I206a7b82d9eefc1fa3762c4a03e7b5e21136951f Reviewed-on: https://gerrit.libreoffice.org/30706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar in sd..svgioNoel Grandin2016-11-011-4/+2
| | | | | | | Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethods in stoc..svlNoel Grandin2016-10-272-6/+3
| | | | | | | Change-Id: I7dd701ef07a14f70589b87154bfeeda7530b628f Reviewed-on: https://gerrit.libreoffice.org/30316 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethodds in svgioNoel Grandin2016-10-2036-184/+85
| | | | | | | Change-Id: Iac2aa6dae56d96819589d198be5875ecfe14f26f Reviewed-on: https://gerrit.libreoffice.org/30056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryoverrideNoel Grandin2016-10-131-7/+0
| | | | | | | Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedenumvaluesNoel Grandin2016-09-181-3/+1
| | | | | | | Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b Reviewed-on: https://gerrit.libreoffice.org/28942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl2016-09-151-1/+1
| | | | | | | | ... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1329-29/+29
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* Remove nonsense comments: // bitfieldTor Lillqvist2016-09-139-11/+0
| | | | | | | Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
* tdf#101237 SVGIO: Use black as default when parents' fill...Xisco Fauli2016-08-303-6/+49
| | | | | | | | | | ...attributes are empty or none and there's a reference to a clip-path present. Change-Id: I4dc4e3bcaac43a007fbdb8a1d006cbd39c737396 Reviewed-on: https://gerrit.libreoffice.org/28500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
* put StreamMode masks in scope of enum classJochen Nitschke2016-08-271-1/+1
| | | | | | | | Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparams in sfx2..svgioNoel Grandin2016-08-0523-108/+108
| | | | | | | Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0 Reviewed-on: https://gerrit.libreoffice.org/27903 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparams in store..svtoolsNoel Grandin2016-07-292-2/+2
| | | | | | | Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6 Reviewed-on: https://gerrit.libreoffice.org/27580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#101070: svg/insert, avoid infinite recursive loop when referencing oneselfJulien Nabet2016-07-241-1/+1
| | | | | | | | | | See bt https://bugs.documentfoundation.org/attachment.cgi?id=126377 Change-Id: I3c6546a5449fc42613e30a7f45f31862752b7187 Reviewed-on: https://gerrit.libreoffice.org/27468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* SVGIO: use clamp on strokeOpacity in case it's negativeXisco Fauli2016-07-201-4/+2
| | | | | | | | | | testcase: painting-stroke-08-t.svg Change-Id: Ia09a4581e5189cbb88aca4391474ada89e7af042 testcase: painting-stroke-08-t.svg Reviewed-on: https://gerrit.libreoffice.org/27326 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
* new loplugin unnecessary overrideNoel Grandin2016-07-151-6/+0
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#82214 optimize PatternFillPrimitive and SVGArmin Le Grand2016-07-071-39/+60
| | | | | | | | | | Use buffering in the drawinglayer, and don't do slow stuff in the windows gdi renderer. Conflicts: svgio/source/svgreader/svgstyleattributes.cxx Change-Id: Id955ee6a3b03e568c2678f02d77af35d2e5ba1d4
* Fix some spelling errors in comments and stringsOtto Kekäläinen2016-07-041-1/+1
| | | | | | | Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e Reviewed-on: https://gerrit.libreoffice.org/26883 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2016-06-091-4/+1
| | | | | | | | | | | | | | | | | | | | This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl2016-06-061-1/+1
| | | | | | | Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* tdf#99994: Add unittestXisco Fauli2016-06-012-0/+27
| | | | | | | Change-Id: I1a58dc21fdcdf8e7688508105fbd6438c7f4bda0 Reviewed-on: https://gerrit.libreoffice.org/25690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
* tdf#99994 Avoid invalid access by reusing getFontFamily() resultSam Tygier2016-06-011-2/+3
| | | | | | | | | | | getFontFamily() can give a different result on the second call so in order to protect against access to an invalid element of the vector the result must be reused. Change-Id: Iec7d58537263cb5c8a7c2ea95761dd929d659e01 Reviewed-on: https://gerrit.libreoffice.org/25704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
* SVGIO: Modify a unittest to check "inherit" in font-familyXisco Fauli2016-05-312-3/+9
| | | | | | | Change-Id: I4a339b419a5abd1ad02f7aef2abd016a1c2260b8 Reviewed-on: https://gerrit.libreoffice.org/25695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
* SVGIO: Add support for font-family in unittests and unify...Xisco Fauli2016-05-312-10/+77
| | | | | | | | | .. textsimpleportion's assert Change-Id: I97d4c76dcfaa6d3ebebfe3eebfabc8ee7799589d Reviewed-on: https://gerrit.libreoffice.org/25691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
* SVGIO: Add support for "inherit" in font-familyXisco Fauli2016-05-311-1/+1
| | | | | | | Change-Id: I180ab3b119af124d2d1113df055986168d39d30d Reviewed-on: https://gerrit.libreoffice.org/25694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <anistenis@gmail.com>
* Get rid of unnecessary directory levels $D/inc/$DTor Lillqvist2016-05-2766-247/+247
| | | | | | | | Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48 Reviewed-on: https://gerrit.libreoffice.org/25532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* Convert GRAPHIC to scoped enumNoel Grandin2016-05-271-1/+1
| | | | | | | Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Fix typosAndrea Gelmini2016-05-251-2/+2
| | | | | | | Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Convert SpreadMethod to scoped enumNoel Grandin2016-05-221-4/+4
| | | | | | | Change-Id: I2a04247bd58ed6f2af8da7e109b31ff83d6d5e49 Reviewed-on: https://gerrit.libreoffice.org/25298 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann2016-05-101-0/+2
| | | | Change-Id: Iba1556d1918a336e376c0fda5e7e14b3e890d267
* convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin2016-05-091-1/+1
| | | | | | | Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* teach passstuffbyref plugin to check for..Noel Grandin2016-05-062-21/+21
| | | | | | | | | | | | unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#48066 render stroke-miterlimit correctly in SVG importRegina Henschel2016-04-264-12/+35
| | | | | | | | | | | | | | | | | | The property stroke-miterlimit is transported to the renderers via a new member mfMiterMinimumAngle in class LineAttribute Several drawPolyLine methods are adapted. This patch does not include changes in MetaAction. Presentation mode, printing, and PDF-export is still wrong. Corrected LineJoinMiter to LineJoinBevel in canvas, that s closer to NONE. Removed DrawPolyLine method without MiterMinimumAngle and adapted calls accordingly. Change-Id: I6bcd24add5d85c4d9a39e3788e0682091c5fc9c4 Reviewed-on: https://gerrit.libreoffice.org/23946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Regina Henschel <rb.henschel@t-online.de>