summaryrefslogtreecommitdiffstats
path: root/store
Commit message (Collapse)AuthorAgeFilesLines
* coverity#1326107 Unchecked return valueCaolán McNamara2015-10-141-1/+1
| | | | Change-Id: I6f2dc9c12349a5175ed34e22fa29d875d6b9bd0a
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-127-40/+40
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-125-10/+10
| | | | Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
* loplugin:mergeclassesNoel Grandin2015-10-072-161/+88
| | | | Change-Id: I14985f98989861d74b3904ab79f3ced5a3d96f73
* loplugin:mergeclassesNoel Grandin2015-10-075-50/+16
| | | | Change-Id: I28d8bd79f266df7e9ea420f7238ed332ec4205a9
* clang-analyzer-deadcode.DeadStoresStephan Bergmann2015-10-051-2/+2
| | | | Change-Id: I490f345d382b62001cf29a64ed732e854bdc5f7b
* tdf#42949 remove unnecessary includes using iwyuNoel Grandin2015-10-011-0/+1
| | | | | | | | Change-Id: I13960721b7e15b1761aff8497391e39ae5645b89 Reviewed-on: https://gerrit.libreoffice.org/18616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:removeunusedmethods, remove unused stuffNoel Grandin2015-09-291-7/+0
| | | | Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
* cppcheck: redundantPointerOpCaolán McNamara2015-09-211-1/+1
| | | | Change-Id: I19f02169a113b8c9bae634691e28cf9f9d6977b5
* cppcheck: redundantPointerOpCaolán McNamara2015-09-131-1/+1
| | | | Change-Id: Ifb32fc03b686aeb0835422764178e54650b183f5
* cppcheck: redundantPointerOpCaolán McNamara2015-09-071-1/+1
| | | | Change-Id: I46f0e7c4cd45c7ac596dceae7ad28664b0cc2183
* Avoid explicit casts of (sizeof) constants known at compile timeMatteo Casalin2015-08-293-8/+8
| | | | | | | | Partially revert my previous commit eb4cbea657b9038c488f1b1bcf5107cc226a6681 "Silence some conversion warnings", since no warning was really raised for these obvious conversions. Change-Id: Ie035655cdc56ceeb12a6141b168f7e9a8b863fee
* Silence some conversion warningsMatteo Casalin2015-08-217-25/+25
| | | | Change-Id: I676ed010576f3a24b193ffc6c28a319bcc5ac968
* new loplugin: defaultparamsNoel Grandin2015-08-111-1/+1
| | | | | | | | find places where we do not need to be passing a parameter to a function, because that function has a default value which matches the value we are passing. Change-Id: I04d1fd6275204dd4925e6563282464f461123632
* cppcheck: redundantPointerOpCaolán McNamara2015-08-101-1/+1
| | | | Change-Id: I0101893f5e8b65fb473a321e6169c3b610b33e60
* loplugin:unusedmethodsNoel Grandin2015-07-301-19/+0
| | | | | | | Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cppcheck: noExplicitConstructorCaolán McNamara2015-07-151-1/+1
| | | | Change-Id: Id438b987f72ae57bd4fa882e01fba17d3fa5b95b
* loplugin:unusedmethods registry,storeNoel Grandin2015-07-023-76/+0
| | | | | | | Change-Id: Ie78eb881a7fc47d0cd7b9862bd0cd200153ce77d Reviewed-on: https://gerrit.libreoffice.org/16679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-081-4/+4
| | | | Change-Id: Iac7bb1008806efbef42ee1f9b32df0788a7c9915
* Add back functionality erroneously removedStephan Bergmann2015-05-112-2/+14
| | | | | | | | | | | | ...with 09d5b31ebe187a4cd9f3efca5a7cb7f87e1e19f6 "loplugin:constantfunction: store," which apparently over-eagerly reduced functionality that happened to be constant in one specific implicit instantiation of a template, but not in others. (Plus, adapting the original code to silence false loplugin:staticmethods warnings.) Change-Id: I156df3aef1b3b0c9d36b2a54c57de29948749bde
* Various #include <sal/log.hxx> fixupsStephan Bergmann2015-04-221-0/+1
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-1513-66/+66
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* loplugin:staticmethodsNoel Grandin2015-04-021-1/+1
| | | | Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
* Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2015-03-311-1/+1
| | | | Change-Id: Ie38450a082dc840714051ad65c297886038e68f3
* Clean up C-style casts from pointers to voidStephan Bergmann2015-03-282-3/+3
| | | | Change-Id: Ibd23c1d96b093ae2670e7752691dad29c081639f
* loplugin:constantfunction: storeNoel Grandin2015-03-243-43/+26
| | | | Change-Id: I13284409404ef77eb16164b7ce2074259d2cad12
* tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann2015-03-132-3/+7
| | | | | | | | ...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
* remove unnecessary parenthesis in return statementsNoel Grandin2015-02-234-12/+12
| | | | | | | found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
* loplugin:deletedspecialStephan Bergmann2015-02-075-26/+11
| | | | Change-Id: I87b252d3d6e5322dbc4b6cc77b846766a0d35893
* convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara2015-02-055-14/+8
| | | | | | and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
* followup code removal after changing virtual methods to non-virtualNoel Grandin2015-01-261-42/+0
| | | | | | | | | | This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
* new loplugin: change virtual methods to non-virtualNoel Grandin2015-01-261-2/+2
| | | | | | | | | | Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
* Suppress 1 cppcheck warning arrayIndexOutOfBoundsJulien Nabet2015-01-191-0/+3
| | | | | | See http://nabble.documentfoundation.org/cppcheck-arrayIndexOutOfBounds-report-in-stortree-cxx-store-module-td4136432.html Change-Id: I365befacf7d10bcbf0a159cfdcabd3eb1644d02b
* Remvoe store/workben/Stephan Bergmann2014-11-216-2585/+0
| | | | | | ...probably not worth dragging that unused code around any more Change-Id: I4f22a704af862d8a1fe1f2202609f355ccee7c9c
* More iwyu suggested headers removalRiccardo Magliocchetti2014-11-182-5/+0
| | | | | | | | Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
* coverity#1242813 Unused valueCaolán McNamara2014-11-121-2/+2
| | | | | | | | and coverity#1242867 Unused value Change-Id: I8ad069a5a84b97e956cafcd925fd733fb5ed9b2e
* coverity#1242933 unused valueDavid Tardon2014-11-041-1/+1
| | | | Change-Id: I416144a4ccf2856ce85ab4b24a69958615276cb9
* coverity#1242809 unused valueDavid Tardon2014-11-041-1/+1
| | | | Change-Id: I16430567b3d57016458bd7877c36bc6e01197741
* warning C4189: : local variable is initialized but not referencedThomas Arnhold2014-08-141-2/+1
| | | | Change-Id: I650fab8227fd8b6aeb4fd4d420cb820aefd80271
* cid#1226495 Uninitialized scalar fieldNoel Grandin2014-07-181-1/+1
| | | | Change-Id: I5f05fc312032c50639f147f27353aa560a69f65a
* use SimpleReferenceObject in stoc moduleNoel Grandin2014-07-1010-148/+15
| | | | | | to replace hand-rolled version Change-Id: I30635aec81313e4e0d1b67b30c8992fd63bb1f67
* WaE: C4754Tor Lillqvist2014-07-081-2/+2
| | | | | | | VS 2013 warns: Conversion rules for arithmetic operations in the comparison mean that one branch cannot be executed. Change-Id: I85f6df16b0ced94677568441d87a588bed1bfb9b
* loplugin:staticcallStephan Bergmann2014-06-131-11/+8
| | | | Change-Id: I2317522af91c8c60672c72a3b514767039930e22
* Bin ugly (ab)use of preprocessor in headers (final part)Thomas Arnhold2014-06-061-1/+0
| | | | | | | | | | | Finish the work of ec8617568ff091026b2f17cce3b547b1633fa6c4 Only one is left: SC_PROGRESS_CXX Change-Id: Ifdc07ec377d7a84e92bc4b0a66ab82b1fc93f76a Reviewed-on: https://gerrit.libreoffice.org/9636 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
* various: remove SAL_THROW macroNoel Grandin2014-06-052-6/+6
| | | | Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
* fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IFMichaël Lefèvre2014-05-127-35/+47
| | | | | Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* simplify ternary conditions "xxx ? yyy : false"Noel Grandin2014-05-052-2/+2
| | | | | | | | | Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
* fixincludeguards.sh: some smaller dirsThomas Arnhold2014-04-1910-30/+30
| | | | Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
* TypoStephan Bergmann2014-04-071-1/+1
| | | | Change-Id: Ie264bfec4a8c34adcaa45c0a5cc43c1109d31c95
* Fix READMEStephan Bergmann2014-04-071-1/+5
| | | | Change-Id: Ib07a18d6592432e9e1716641938a6f336daa7b4b