summaryrefslogtreecommitdiffstats
path: root/store
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:countusersofdefaultparams in sot..svtoolsNoel Grandin2016-10-144-6/+6
| | | | Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
* tdf#100302: gbuild: always use $(LFS_CFLAGS)Michael Stahl2016-10-071-1/+0
| | | | | | | | | | Currently LFS_CFLAGS are only used in a handful of libraries but there's no obvious reason why it can't just be set everywhere. Also set it in windows.mk, i have no idea if it's needed for MinGW (certainly not for MSVC). Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
* cid#1371195, cide#1371212: Replace PageHolder with shared_ptrStephan Bergmann2016-09-308-164/+81
| | | | | | ...removing the need for SharedCount, too Change-Id: I20c724c940c571aef1c12453da30c3e9fbb46466
* Remove OStorePageData typedefStephan Bergmann2016-09-305-12/+11
| | | | Change-Id: I9f4e8fa41a59325fe7036acb66d045a833294bd6
* Remove "#if 1 /* EXP */"Stephan Bergmann2016-09-301-2/+0
| | | | | | ...whatever it was supposed to be good for Change-Id: I8f2a526aeaa484675e1bd6763fa692f8cbed2a51
* No need for rtl_cache_* hereStephan Bergmann2016-09-302-64/+7
| | | | | | ...which shows that m_pCount will never be null Change-Id: I87c6e4bf5d258c59a8e91cd194c64b1ce85b4445
* convert storeAccessMode to scoped enumNoel Grandin2016-09-196-22/+22
| | | | Change-Id: I67705cdff0440487019a2992571147d648be1bfc
* replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl2016-09-153-10/+10
| | | | | | | | ... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1310-12/+12
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* store: remove STORE_IMPL_ISP2 and STORE_IMPL_CONCAT.Arnaud Versini2016-08-312-10/+1
| | | | | | | Change-Id: Iec6cff8da24515f17a5ad2b9ba6e1f92df124921 Reviewed-on: https://gerrit.libreoffice.org/28508 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* store : Replace store::swap with std::swapArnaud Versini2016-08-311-16/+10
| | | | | | | Change-Id: I85c1026502dc69b229aaf287858ae76f9391a34d Reviewed-on: https://gerrit.libreoffice.org/28506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparams in store..svtoolsNoel Grandin2016-07-291-2/+2
| | | | | | | Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6 Reviewed-on: https://gerrit.libreoffice.org/27580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* update unusedmethods plugin to deal with constructorsNoel Grandin2016-05-181-4/+0
| | | | | | | | | | and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-101-2/+2
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke2016-04-134-15/+20
| | | | | | | | | | | | | | | Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:constantparamNoel Grandin2016-04-112-5/+4
| | | | Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
* Drop __store_ prefix from static entity (avoid reserved identifier)Stephan Bergmann2016-03-101-3/+3
| | | | Change-Id: Ib03727f6b47d8f013f78a590d36d568ebc405bf3
* loplugin:unuseddefaultparam in storeNoel Grandin2016-03-012-30/+17
| | | | Change-Id: I825eb075b73daa5bf52e1d41c32cf2100abebe47
* new loplugin: commaoperatorNoel Grandin2016-02-235-21/+56
| | | | Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
* loplugin:unusedmethods unused return value in store,svlNoel Grandin2016-01-141-28/+0
| | | | Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
* loplugin:unusedfields in store,svtools,svxNoel Grandin2015-12-211-19/+0
| | | | Change-Id: I9577c64e33950899c2e3467c7b481504e021d470
* More loplugin:nullptr automatic rewrite (within templates)Stephan Bergmann2015-12-101-5/+5
| | | | Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
* loplugin:unusedfields in store/Noel Grandin2015-11-231-3/+1
| | | | Change-Id: I0fae339e3736f98d5d534b8a01a3040c237c6621
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-1012-92/+92
| | | | Change-Id: I2a4f84e8c36197a9d39a5bd36cb1e2401a956d87
* loplugin:unusedmethodsNoel Grandin2015-10-302-32/+0
| | | | | | | Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethodsNoel Grandin2015-10-278-1014/+0
| | | | | | | Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#65108 use <> instead of "" in include lineFeyza Yavuz2015-10-221-3/+3
| | | | | | | Change-Id: Icc497610505d160ee7d0e3a129eb499fe4ba5c93 Reviewed-on: https://gerrit.libreoffice.org/19422 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* coverity#1326107 Unchecked return valueCaolán McNamara2015-10-141-1/+1
| | | | Change-Id: I6f2dc9c12349a5175ed34e22fa29d875d6b9bd0a
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-127-40/+40
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-125-10/+10
| | | | Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
* loplugin:mergeclassesNoel Grandin2015-10-072-161/+88
| | | | Change-Id: I14985f98989861d74b3904ab79f3ced5a3d96f73
* loplugin:mergeclassesNoel Grandin2015-10-075-50/+16
| | | | Change-Id: I28d8bd79f266df7e9ea420f7238ed332ec4205a9
* clang-analyzer-deadcode.DeadStoresStephan Bergmann2015-10-051-2/+2
| | | | Change-Id: I490f345d382b62001cf29a64ed732e854bdc5f7b
* tdf#42949 remove unnecessary includes using iwyuNoel Grandin2015-10-011-0/+1
| | | | | | | | Change-Id: I13960721b7e15b1761aff8497391e39ae5645b89 Reviewed-on: https://gerrit.libreoffice.org/18616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:removeunusedmethods, remove unused stuffNoel Grandin2015-09-291-7/+0
| | | | Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
* cppcheck: redundantPointerOpCaolán McNamara2015-09-211-1/+1
| | | | Change-Id: I19f02169a113b8c9bae634691e28cf9f9d6977b5
* cppcheck: redundantPointerOpCaolán McNamara2015-09-131-1/+1
| | | | Change-Id: Ifb32fc03b686aeb0835422764178e54650b183f5
* cppcheck: redundantPointerOpCaolán McNamara2015-09-071-1/+1
| | | | Change-Id: I46f0e7c4cd45c7ac596dceae7ad28664b0cc2183
* Avoid explicit casts of (sizeof) constants known at compile timeMatteo Casalin2015-08-293-8/+8
| | | | | | | | Partially revert my previous commit eb4cbea657b9038c488f1b1bcf5107cc226a6681 "Silence some conversion warnings", since no warning was really raised for these obvious conversions. Change-Id: Ie035655cdc56ceeb12a6141b168f7e9a8b863fee
* Silence some conversion warningsMatteo Casalin2015-08-217-25/+25
| | | | Change-Id: I676ed010576f3a24b193ffc6c28a319bcc5ac968
* new loplugin: defaultparamsNoel Grandin2015-08-111-1/+1
| | | | | | | | find places where we do not need to be passing a parameter to a function, because that function has a default value which matches the value we are passing. Change-Id: I04d1fd6275204dd4925e6563282464f461123632
* cppcheck: redundantPointerOpCaolán McNamara2015-08-101-1/+1
| | | | Change-Id: I0101893f5e8b65fb473a321e6169c3b610b33e60
* loplugin:unusedmethodsNoel Grandin2015-07-301-19/+0
| | | | | | | Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* cppcheck: noExplicitConstructorCaolán McNamara2015-07-151-1/+1
| | | | Change-Id: Id438b987f72ae57bd4fa882e01fba17d3fa5b95b
* loplugin:unusedmethods registry,storeNoel Grandin2015-07-023-76/+0
| | | | | | | Change-Id: Ie78eb881a7fc47d0cd7b9862bd0cd200153ce77d Reviewed-on: https://gerrit.libreoffice.org/16679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-081-4/+4
| | | | Change-Id: Iac7bb1008806efbef42ee1f9b32df0788a7c9915
* Add back functionality erroneously removedStephan Bergmann2015-05-112-2/+14
| | | | | | | | | | | | ...with 09d5b31ebe187a4cd9f3efca5a7cb7f87e1e19f6 "loplugin:constantfunction: store," which apparently over-eagerly reduced functionality that happened to be constant in one specific implicit instantiation of a template, but not in others. (Plus, adapting the original code to silence false loplugin:staticmethods warnings.) Change-Id: I156df3aef1b3b0c9d36b2a54c57de29948749bde
* Various #include <sal/log.hxx> fixupsStephan Bergmann2015-04-221-0/+1
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-1513-66/+66
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* loplugin:staticmethodsNoel Grandin2015-04-021-1/+1
| | | | Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd