| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Change-Id: Ife3cb18d22c57c9c2e59317b68cf11a4bf94a40a
|
|
|
|
|
|
| |
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
|
|
|
|
| |
Change-Id: Ib753cacf91baa6a761ac8f971b67c0f5ade555b6
|
|
|
|
| |
Change-Id: I9cba1299c54f196a5a7b35384f4c15bbbea273bb
|
|
|
|
|
|
|
|
| |
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
|
|
|
|
| |
Change-Id: Ieafdefb5a6981ee2f375cb9ba852de7b21688b42
|
|
|
|
| |
Change-Id: If736316402c49153d4c8552672c90552548f90b8
|
|
|
|
|
|
|
| |
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
|
|
|
|
| |
Change-Id: Ic197b0fc962ff33b0f0a3c7f04d8208ea9123094
|
|
|
|
| |
Change-Id: Ib4fa4669adb217be810840b3f8e4f0e2dda0f7c5
|
|
|
|
| |
Change-Id: Ic7bd99f920fc954e2eeb734e324d15b1af01e30d
|
|
|
|
|
|
|
|
|
|
| |
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
|
|
|
|
| |
Change-Id: I83552efc825d54da9e00d4a9a637118565bd30ca
|
|
|
|
| |
Change-Id: I127cfc84412984e9c190f3e5b2e37cf76ebf82f1
|
|
|
|
| |
Change-Id: I5f78d97bcd55c0db71d7c5e3383678586c2cf392
|
|
|
|
| |
Change-Id: I57eca2dcf316232c26c528015c4ba18ba3c4760d
|
|
|
|
|
|
|
| |
so we can hopefully deprecate getImplementationId and make all implementations
return an empty sequence.
Change-Id: I161b5fce727541ea2c8303b5d228dbc4939a55b6
|
|
|
|
| |
Change-Id: Ied10da0f491e7723245056a4c98540f8b56ffe5d
|
|
|
|
| |
Change-Id: I416e2cb8e22d200dfb72d512a4b4278ca582cd10
|
|
|
|
| |
Change-Id: Ida1c78309cc0cde3082ce4340084aa34986c63c5
|
|
|
|
| |
Change-Id: Ia01efee8c7cc28d1f71fd87c735a6cbc205b3eaf
|
|
|
|
|
|
| |
...deprecating com.sun.star.beans.Introspection (single-instance) service.
Change-Id: Ica2e3a3541c7dcb1aab79222c5abf40d6988c882
|
|
|
|
| |
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
|
|
|
|
|
|
|
| |
Change-Id: I19edfb2796298c4870124d0d1e9488974a010bb8
Reviewed-on: https://gerrit.libreoffice.org/8316
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
|
| |
Change-Id: I8e11ffe888aac8887c4c0875c41de51f343debae
|
|
|
|
|
|
|
| |
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
|
|
| |
Change-Id: I9901991a320b87895230a92095c9c7d3109380a6
|
|
|
|
|
|
| |
...and deprecate what cannot be removed for compatibility.
Change-Id: I1ea335af775b867b468b8285113631167729a92a
|
|
|
|
| |
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
|
|
|
|
| |
Change-Id: Ic29ea184cb40f6f49313ac2ff1abb4a37246d5bd
|
|
|
|
| |
Change-Id: Ia7c817ca0b002279bee8699e4940c57937657ad4
|
|
|
|
|
|
|
|
|
|
|
| |
Additional changes according to Chris Sherlock's wishes (removing
comment decorations, removing no-purpose comments)
Change-Id: I5346010d67ed5d1b2b2ad0df91ac472dde905683
Reviewed-on: https://gerrit.libreoffice.org/7504
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
|
|
|
|
|
|
|
|
| |
This is much better approach compared to the callback function, as it allows
passing arguments to the c++ constructor directly, while still allowing some
additional initialization after having acquired the instance.
Change-Id: I5a0f981915dd58f1522ee6054e53a3550b29d624
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of the initalizations (in eg. framework) have to be done on an
acquire()'d object, so instead of doing the initialization directly, return
the initialization member function back to the createInstance() /
createInstanceWithContext() / ... and perform the initialization there.
As a sideeffect, I belive the calling initialize() from servicemanager is not
that much a hack any more - whoever converts the implementation to be
constructor-base has the choice to provide the callback, or still initialize
through XInitialization, where the callback is preferred by servicemanager
when it exists.
Change-Id: I8a87b75c54c1441ca0f184967d31ff4902fc4081
|
|
|
|
| |
Change-Id: I9e5e77ad2c29ccdae1a794b7a0223858d8a662a6
|
|
|
|
|
|
|
| |
3af99e4d59d89c343965a928681a30f36b1007d2 "convert equalsAsciiL calls to
startsWith calls" should rather have converted to oprator ==.
Change-Id: Id4a8836c5d6d570e54661c40be7214632e202b21
|
|
|
|
| |
Change-Id: I00e7cdadc4e66fa9656c0a63f4ef18d3673b8e8a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of the constructors are supposed to be only a call of
new TheInstance(arguments)
or an equivalent; so let's just change the constructor caller accordingly, to
accept unacquired new instance.
If there are exceptions that need to do more heavy lifting, they do not have
to use the constructor feature, or there can be a wrapper for the real
implementation, doing the additional work in their (C++) constructor.
Change-Id: I035c378778aeda60d15af4e56ca3761c586d5ded
|
|
|
|
|
|
|
|
| |
There is no need to use different styles for writing the same thing.
It also makes it easier in future to use search & replace.
But of course, there are also some more complicated functions.
Change-Id: I773da20378af0e0d5a27689d3903df7063fb8ac0
|
|
|
|
| |
Change-Id: I07fe0671d0633ef9480a4f3431df6a64c7902db8
|
|
|
|
| |
Change-Id: I19ce8bd1a23123ac9a62a7fc95cd54fea5315221
|
|
|
|
| |
Change-Id: I7c25cd94f8a1ca339f7423c26f21f13c7a68906d
|
|
|
|
|
|
|
|
|
| |
Convert code like:
buf.append( static_cast<sal_Unicode>('!') );
to:
buf.append( '!' );
Change-Id: Iacb03a61de65a895540940953b49620677b3d051
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...to directly call constructor functions of ComponentContext-based C++
implementations of (non-single-instance) UNO services. The case where these
calls would need to be bridged across different environments (e.g., from gcc3
to gcc3:affine) is not yet implemented.
bootstrap.component and expwrap.component are adapted accordingly as a proof-of-
concept (which had previously been adapted to use the prefix="direct" feature,
which may become unnecessary again in the end, depending on how to handle
single-instance services/singletons). More to follow.
Change-Id: I18682d75bcd29d3d427e31331b4ce8161dbb846d
|
|
|
|
| |
Change-Id: I91cb0177edd79485eab885e995e79b1a19a769d5
|
|
|
|
| |
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
|
|
|
|
| |
Change-Id: Ib2690e3ec9987b97363687b61fe8ddae4ace9058
|
|
|
|
|
|
|
|
|
| |
Convert code like
aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp");
to
aFilename = OUString::number(nFilePostfixCount) + ".bmp";
Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
|
|
|
|
| |
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
|