summaryrefslogtreecommitdiffstats
path: root/starmath
Commit message (Collapse)AuthorAgeFilesLines
* starmath: SmDynIntegralNode always has a couple of subnodesTakeshi Abe2016-08-032-3/+4
| | | | | | | | | And the 0th subnode is SmDynIntegralSymbolNode. Change-Id: Icb15125abf1846204d0f9130ad1ec964c5172589 Reviewed-on: https://gerrit.libreoffice.org/27820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: SmRootSymbolNode must have type NROOTSYMBOLTakeshi Abe2016-08-031-1/+1
| | | | Change-Id: I1ce875fba10e0e84fc015cecdb5a36e48ee8ea0e
* Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with altCaolán McNamara2016-08-021-0/+7
| | | | | | | | | this returns things to passing the alt to the thing with the focus and depends on ::Command handlers passing the alt-press/release back up through the Command hierarchy to get to the default top-level handler eventually Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
* starmath: SmVerticalBraceNode always has a triple of nodesTakeshi Abe2016-08-025-17/+17
| | | | | | | | | Moreover the middle ("Brace") node is a SmMathSymbolNode. Change-Id: Ia0e4f798b69a9a205269bbd3f6c63d2059e8c766 Reviewed-on: https://gerrit.libreoffice.org/27769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* tdf#91665 l10n: Replace string list by separate strings in SmPrintUIOptionsMuhammet Kara2016-08-013-29/+61
| | | | | | | | | | | | | | String lists are sometimes (mis)used to group unrelated items; the advantage(?) being that only one identifier needs to be defined for the whole group. The items are then referenced by index, which is rather fragile when they are used in different parts of UI. String lists like this one should be replaced by separate strings. Change-Id: I58c927790287b36c0cb204c815a2788bd7cf1e02 Reviewed-on: https://gerrit.libreoffice.org/27665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparams in shell..starmathNoel Grandin2016-08-0112-16/+16
| | | | | | | Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6 Reviewed-on: https://gerrit.libreoffice.org/27672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#101022 Export Greek symbol to MathML with correct mathvariantTakeshi Abe2016-07-315-1/+232
| | | | | | | | | | | | | | | | In StarMath notation "{ital %GAMMA}" is recognized as italic, and "{nitalic %iGAMMA}" is non-italic. That is, the ital/nitalic directive takes priority over special characters' flavor. On the other hand, in MathML a mathvariant attribute given in <mi> overwrites inherited value. This does not handle "bold-italic" case etc. yet. Change-Id: I9c72dc4472f8cec553417d516d9d82aebd43d15c Reviewed-on: https://gerrit.libreoffice.org/27604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* add uui to starmath import filters testCaolán McNamara2016-07-271-0/+1
| | | | Change-Id: I0482891fa628f810c42e6a780abdec35bc62ea7e
* cppcheck: noExplicitConstructorCaolán McNamara2016-07-271-1/+1
| | | | Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
* improve passstuffbyref return analysisNoel Grandin2016-07-272-2/+2
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* masses of MessBoxes not being disposed promptlyCaolán McNamara2016-07-262-6/+5
| | | | | | | | | | | | | | | | since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
* starmath: Fix invalid static_castTakeshi Abe2016-07-251-1/+1
| | | | | | | | | | | which caused an undefined behavior by downcasting SmSpecialNode to SmMathSymbolNode. Change-Id: I00b6d2111733bddffa31d12c85fbb5bbdd675f76 Reviewed-on: https://gerrit.libreoffice.org/27531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* new loplugin overrideparamNoel Grandin2016-07-256-9/+9
| | | | | | | | | | verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* starmath: Add unit test for tdf#52225Takeshi Abe2016-07-241-0/+49
| | | | | | | Change-Id: Id0e9cb3f2fb939bedc2f8e7a56d40a0f82c1e9ca Reviewed-on: https://gerrit.libreoffice.org/27469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Return early if the cursor locates after a text nodeTakeshi Abe2016-07-221-5/+6
| | | | | | | | | No longer create unnecessary copy of nodes. Change-Id: Icf8cdd3ce0f9ebbf7159e9e7eaea7abe52c05060 Reviewed-on: https://gerrit.libreoffice.org/27366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* -Werror,-Winconsistent-missing-overrideStephan Bergmann2016-07-171-2/+2
| | | | Change-Id: I56241813298f0c76dfbffd91e1090df326755cb6
* uitest: add wrapper for element selectorMarkus Mohrhard2016-07-175-0/+194
| | | | Change-Id: I641a290b3a9cf46ba484a9a851a27456cc68678c
* remove wrong outdated commentMarkus Mohrhard2016-07-171-1/+0
| | | | Change-Id: I3fe6957b73776152b90c34ac411167f6f4e9e4f5
* uitest: annotate the math edit windowMarkus Mohrhard2016-07-171-0/+1
| | | | Change-Id: Ic902ba191d632d6a9e399c6809a8e88fdfc26301
* new loplugin unnecessary overrideNoel Grandin2016-07-152-7/+0
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* starmath: Make AdjustFontDesc() precede Prepare()Takeshi Abe2016-07-152-3/+5
| | | | | | | | | | because what Prepare() does depends on both nFontDesc and token of the SmTextNode. Change-Id: Ib7f8c408eb8f95a10f27ccbd3d80cdd0d6ea6d56 Reviewed-on: https://gerrit.libreoffice.org/27210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Drop redundant SetLineColor() callTakeshi Abe2016-07-141-2/+0
| | | | | | | | | 10 lines later the same code appears again. Change-Id: I06bccbb89e9bc3dd1339ca4f8c2482a2ee75c9f2 Reviewed-on: https://gerrit.libreoffice.org/27176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Moved SfxModule owner to SfxApplicationMark Page2016-07-132-13/+7
| | | | | | | | | | | | | ::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* starmath: no need to create temporary string for comparisonTakeshi Abe2016-07-121-1/+1
| | | | | | | | Change-Id: I906ef285ec6164284924ca4771a6da758bd23fd6 Reviewed-on: https://gerrit.libreoffice.org/27140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* starmath: Prefer assert to SAL_WARN hereTakeshi Abe2016-07-111-1/+1
| | | | | | | | | as defined enum cases are exhausted. Change-Id: I6564cc0cd64d593f6aa02f0651ecb490bf7845bd Reviewed-on: https://gerrit.libreoffice.org/27081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* tdf#47813 Fix alignment for SmUnHorNodeTakeshi Abe2016-07-083-19/+99
| | | | | | | | | | | Originally SmUnHorNode::Arrange() was somewhat kludgy. This change implements a similar manner with SmBinHorNode::Arrange(). Change-Id: Ic18d2e7f70becfabb2c651719926e358a4585526 Reviewed-on: https://gerrit.libreoffice.org/26841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* starmath: Fix missing negationTakeshi Abe2016-07-081-1/+1
| | | | | | | | | which was a regression from fa614231733800f4a961b77e36c86f8840d12251. Change-Id: Ia7bab72dbd6f82519024809cf6384e1442a02327 Reviewed-on: https://gerrit.libreoffice.org/27033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
* starmath: Remove a couple of unused error codesTakeshi Abe2016-07-074-17/+2
| | | | | | | | Change-Id: Iae3118150cf9119e48b1740ea630dea0ebef895a Reviewed-on: https://gerrit.libreoffice.org/26998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* starmath: Drop useless PE_BINOPER_EXPECTEDTakeshi Abe2016-07-074-8/+2
| | | | | | | | | as no code generates the error. Change-Id: I86f2db28030090e0a9284e7771f26821468bb685 Reviewed-on: https://gerrit.libreoffice.org/26974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Drop unused PE_UNEXPECTED_END_OF_INPUTTakeshi Abe2016-07-061-1/+1
| | | | | | | Change-Id: Ic5e6df6d332ef20dec22ac84544f53e0e79f5eb1 Reviewed-on: https://gerrit.libreoffice.org/26938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin2016-07-061-0/+2
| | | | | | | Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* starmath: Remove unused GetRect()Takeshi Abe2016-07-051-1/+0
| | | | | | | Change-Id: I8544520a920f5ba2863a9d1b74e73f5cf47238aa Reviewed-on: https://gerrit.libreoffice.org/26887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* SfxModule to use initializer_list instead of variadic argumentsMark Page2016-07-041-1/+1
| | | | | | | | | The compiler can perform type checking with initializer lists Change-Id: I1d26b56a3a2b67fe719f33d758ca9b0c95ebd4d1 Reviewed-on: https://gerrit.libreoffice.org/26852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove comphelper::string::removeNoel Grandin2016-07-042-3/+3
| | | | | | | | | and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* starmath: Drop unused definitionTakeshi Abe2016-07-042-6/+1
| | | | | | | Change-Id: Ifb91d3a913d6fe3f92ef93bd0e25b8c6152727f3 Reviewed-on: https://gerrit.libreoffice.org/26872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Make SmStructureNode's ctor initialize the number of sub nodesTakeshi Abe2016-07-012-24/+14
| | | | | | | | | This also drops newly unused SetNumSubNodes() as a result. Change-Id: I9b33cb547eb6883da4b45dc5760144cce8fa14ee Reviewed-on: https://gerrit.libreoffice.org/26795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Replace OSL_ENSURE with assertTakeshi Abe2016-06-291-2/+2
| | | | | | | | | | as negative n would be undefined for OUString::copy(..., n). Change-Id: I950ec60656142450a5d5f6804324f6080c9c4c2a Reviewed-on: https://gerrit.libreoffice.org/26753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* starmath: SmBinDiagonalNode's 3rd child must be SmPolyLineNodeTakeshi Abe2016-06-291-3/+4
| | | | | | | Change-Id: If3b81de299eca8b398a65534d1b201bf38daf19f Reviewed-on: https://gerrit.libreoffice.org/26733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* loplugin:singlevalfields in variousNoel Grandin2016-06-282-4/+2
| | | | | | | Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* starmath: This condition must be metTakeshi Abe2016-06-281-4/+1
| | | | | | | | | Otherwise, the following static_cast would be broken. Change-Id: Iad4738292ed6903eed78d5af98f77194d5a1d8fe Reviewed-on: https://gerrit.libreoffice.org/26696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Fix invalid static_castTakeshi Abe2016-06-262-4/+4
| | | | | | | | | | | It was an undefined behavior that static_cast'ing a pointer to SmVisibleNode to SmStructureNode's. Change-Id: Ic391175a5535cec84bd7f9ec58fa13a411398331 Reviewed-on: https://gerrit.libreoffice.org/26676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* starmath: Drop unnecessary definitionsTakeshi Abe2016-06-252-14/+5
| | | | | | | Change-Id: I709e612fd03dfa50d6f7bcfa4545fcd23f0ebe60 Reviewed-on: https://gerrit.libreoffice.org/26654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Remove unused definitionTakeshi Abe2016-06-252-7/+1
| | | | | | | Change-Id: I46674e606ad7ef586597c926a21dd745ee762011 Reviewed-on: https://gerrit.libreoffice.org/26634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: IndexOfSubNode() is for SmStructureNode onlyTakeshi Abe2016-06-241-11/+13
| | | | | | | | | ... not for the base class. Change-Id: I9f6a6de93a4db964c8b019349049fdef4afaf224 Reviewed-on: https://gerrit.libreoffice.org/26583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* tdf#97527 - vcl: reference-count MenuNoel Grandin2016-06-231-3/+4
| | | | | | | | | | | some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* starmath: Add a test case for parsing -Takeshi Abe2016-06-232-0/+98
| | | | | | | Change-Id: I0fc0b7e2abbadee2f13d477c5ddd2290f37487a0 Reviewed-on: https://gerrit.libreoffice.org/26563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Drop unused #includeTakeshi Abe2016-06-223-29/+0
| | | | | | | Change-Id: Ic0cf4605cc7d02fdd537d05cbaa744c52126e6f1 Reviewed-on: https://gerrit.libreoffice.org/26545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* This can be an assert()Takeshi Abe2016-06-211-25/+22
| | | | | | | Change-Id: I2b0a8f50359e5b12fa27bf48c355f736e2b05033 Reviewed-on: https://gerrit.libreoffice.org/26491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Possible cases are exhaustedTakeshi Abe2016-06-201-1/+1
| | | | | | | Change-Id: Icc48aa8ffa6a56f804c4d01f2fb3bcdf7de838d4 Reviewed-on: https://gerrit.libreoffice.org/26397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: more assertions holdTakeshi Abe2016-06-161-21/+20
| | | | | | | Change-Id: I9a7fb2f4d45c5b34c0ea1d186dd90353fedc8a6d Reviewed-on: https://gerrit.libreoffice.org/26299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>