summaryrefslogtreecommitdiffstats
path: root/starmath
Commit message (Collapse)AuthorAgeFilesLines
* starmath: Return SmGlyphSpecialNode from DoGlyphSpecial()Takeshi Abe2017-03-102-8/+6
| | | | | | | | | instead of pushing it to the stack. This spares some pops. Change-Id: I9fc987ebf851ff6387e347a2878ff01f482d8f7f Reviewed-on: https://gerrit.libreoffice.org/35029 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Prepare messsages for all parsing errorsTakeshi Abe2017-03-093-17/+52
| | | | | | | | | and kill the unhelpful "unknown" one. Change-Id: I3137f7e363caeb64d285aacd2e56446148d85353 Reviewed-on: https://gerrit.libreoffice.org/34977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* loplugin:loopvartoosmallStephan Bergmann2017-03-081-3/+1
| | | | Change-Id: I394c1e291ef4fb637d871d9cb8cc563e6e787ddb
* starmath: Drop unused RIDsTakeshi Abe2017-03-082-12/+1
| | | | | | | Change-Id: I1449b3e58f319c67f3a921f74ceab283a6fc4f12 Reviewed-on: https://gerrit.libreoffice.org/34962 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Return the expression node from DoExpression()Takeshi Abe2017-03-082-14/+10
| | | | | | | | | instead of pushing it to the stack. This saves extra pops. Change-Id: I2fcf9b86eab9ade45db4351b34bafbcbc42ef056 Reviewed-on: https://gerrit.libreoffice.org/34944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Avoid creating SmFontNode with a default tokenTakeshi Abe2017-03-071-0/+6
| | | | | | | | | when an unexpected token is found. Change-Id: I1a11c08ce54c55bb32289498fbb26af019396b83 Reviewed-on: https://gerrit.libreoffice.org/34918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* remove some unnecessary use of OUString constructorNoel Grandin2017-03-061-2/+2
| | | | | | | | | | found with git grep -nP '<<= OUString\(\w*[A-Za-z]+' Change-Id: I43354842f1e0418fb292f2e8e0cb30f1229d1c67 Reviewed-on: https://gerrit.libreoffice.org/34864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* starmath: Push next token to escape only in a valid caseTakeshi Abe2017-03-061-4/+2
| | | | | | | Change-Id: I935e7d2992a93ff451bcc5689f2dc59fe7afff40 Reviewed-on: https://gerrit.libreoffice.org/34875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Remove redundant 'inline' keywordStephan Bergmann2017-03-033-5/+5
| | | | | | | | | | ...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* starmath: Replace SmParseError::FuncExpected with assertionTakeshi Abe2017-03-034-10/+2
| | | | | | | Change-Id: I7d1089fd615ac09a6e59c06c094f79364510b290 Reviewed-on: https://gerrit.libreoffice.org/34800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Drop SmParseError::UnoperExpectedTakeshi Abe2017-03-024-10/+2
| | | | | | | | | | because it cannot happen unless the invariant about TG::UnOper is broken. Change-Id: I2250c785c278d77e991be04353cf34b5c1c45a21 Reviewed-on: https://gerrit.libreoffice.org/34735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* move SvtLinguOptions into SmDocShellCaolán McNamara2017-03-013-14/+12
| | | | Change-Id: I46b84ab4cb9cc5d25b6cb60241fcc8a65e449886
* fix indentCaolán McNamara2017-03-011-50/+46
| | | | Change-Id: Ib5679684c899a7362b71ab8688fd37d276176fef
* unroll SmEditWindow::GetEditEngineItemPoolCaolán McNamara2017-03-012-13/+4
| | | | Change-Id: Iaf7a7c65109864f429ab5cc6848a12a37421afa1
* GetEditEngineItemPool can be privateCaolán McNamara2017-03-011-1/+2
| | | | Change-Id: Ie7a8230dcc5b8576aea44c6e62eedaf971241be7
* new loplugin unoanyNoel Grandin2017-02-281-1/+1
| | | | | | | Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* starmath: Add test cases for errors at parsingTakeshi Abe2017-02-281-0/+143
| | | | | | | Change-Id: Ic8de7f1c925d7a77520681121cbdd00c036ccab8 Reviewed-on: https://gerrit.libreoffice.org/34683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Test whether SmEditWindow::SelNextMark() keeps cursor positionTakeshi Abe2017-02-221-1/+10
| | | | | | | | | when there is no next placeholder marker. Change-Id: I9846b304074c39f49118710a758d44a43f926b25 Reviewed-on: https://gerrit.libreoffice.org/34531 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
* tdf#106116 "Previous Marker" changes selection only when neededTakeshi Abe2017-02-212-26/+18
| | | | | | | | | | | | | This fixes a hang caused by repeated Shift+F4. Although it seems a regression from 2af1f5691e8d64afd5246d245d7876b5a2cd5cd8, the original code of SmEditWindow::SelPrevMark() had been doomed due to conditional loop depending on obscure signed/unsigned conversion. Change-Id: I61f630eec44b285dc1f1c27097acde4b48ed2991 Reviewed-on: https://gerrit.libreoffice.org/34503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* loplugin:subtlezeroinit: starmathStephan Bergmann2017-02-212-9/+9
| | | | Change-Id: Ifc6f4788bb285e28451df9c98a72b454b7685160
* starmath: Convert SmParseError to scoped enumTakeshi Abe2017-02-193-52/+59
| | | | | | | Change-Id: Ia2663a768c424ea6f03bd0933a3c2fd608c239d8 Reviewed-on: https://gerrit.libreoffice.org/34422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* convert EditEngineAttribs to scoped enumNoel Grandin2017-02-162-6/+3
| | | | | | and drop unused EditEngineAttribs_HardAndPara enumerator Change-Id: Ic1fcddc6adeb5317f96bcef9b6f715b26d901a8d
* convert SmBracketType to scoped enumNoel Grandin2017-02-153-84/+21
| | | | | | and drop unused enumerators Change-Id: Icda3ff510331f9f0adb97d6dac56edf325d0d1a7
* starmath: Avoid unnecessary stack operations in parsingTakeshi Abe2017-02-151-8/+3
| | | | | | | | | unless the top is "nospace". Change-Id: I03cfa2b8223298370d9d82ce5e149d61e8793737 Reviewed-on: https://gerrit.libreoffice.org/34249 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: This condition always holdsTakeshi Abe2017-02-141-2/+3
| | | | | | | Change-Id: I6d47676dc71644766fdaea7033c53efa0bf9b549 Reviewed-on: https://gerrit.libreoffice.org/34212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Various typos on accessibleJulien Nabet2017-02-122-3/+3
| | | | | | | Change-Id: Id28a4a2cbbcec10a7cc9cb40ad208d575352039b Reviewed-on: https://gerrit.libreoffice.org/34161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* starmath: Make stricter assertion to prevent out of rangeTakeshi Abe2017-02-111-20/+13
| | | | | | | Change-Id: I3ce0712e5095ade35628bad026a91a11dc6b9967 Reviewed-on: https://gerrit.libreoffice.org/34146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Kill redundant checkTakeshi Abe2017-02-101-4/+0
| | | | | | | Change-Id: I45f873f3733800c43c36b38dcefb79eba46b9007 Reviewed-on: https://gerrit.libreoffice.org/34030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Add missing #includesStephan Bergmann2017-02-062-0/+2
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* .uno:ScriptOrganizer should be menu:menuitemMaxim Monastirsky2017-02-051-1/+1
| | | | | | | | ... so it won't show as an empty submenu in the customization dialog, and allow accidentally overwriting it. Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
* starmath: Prefix member of SmNodeToTextVisitorTakeshi Abe2017-02-032-5/+5
| | | | | | | Change-Id: I83f5c5664aca925f874be8ac939356228697d05f Reviewed-on: https://gerrit.libreoffice.org/33850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* convert method names in tools::SvRef to be more like our other..Noel Grandin2017-02-029-12/+12
| | | | | | | | | | | reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* starmath: these functions are localTakeshi Abe2017-02-022-87/+80
| | | | | | | Change-Id: I7b1c9722e300585603ce54610d7ef20425a4e634 Reviewed-on: https://gerrit.libreoffice.org/33797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* loplugin:useuniqueptr extend to check local varsNoel Grandin2017-02-011-8/+4
| | | | | | | | | | | just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* starmath: Simplify and micro-optimize lookup in SmIsMathAlpha()Takeshi Abe2017-02-011-24/+17
| | | | | | | Change-Id: Ica2e0d14141785b9e14c05179e517117afadc5e0 Reviewed-on: https://gerrit.libreoffice.org/33734 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* tdf#105571 Drop toolbar:helpid attribute from toolbar definitionsGabor Kelemen2017-01-311-2/+2
| | | | | | | | | | | | These are no longer useful. Made with: git grep toolbar:helpid | cut -d : -f1 | sort -u | xargs sed -i -r -e 's/ toolbar:helpid="[0-9]*"//' git grep toolbar:helpid | cut -d : -f1 | sort -u | xargs sed -i -r -e 's/ toolbar:helpid=""//'1 Change-Id: If1bf04265f4e03b44b6a92529f6133aff1589526 Reviewed-on: https://gerrit.libreoffice.org/33642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-313-7/+7
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* starmath: Make some functions private, instead of protectedTakeshi Abe2017-01-301-1/+0
| | | | | | | Change-Id: Ic1192a2fca86833e9efd954c7625fb4f84f46b7c Reviewed-on: https://gerrit.libreoffice.org/33618 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
* tdf#105483: let's put lowercase Greek letter in italicJulien Nabet2017-01-262-8/+8
| | | | | | | | | | | | and let uppercase one in non italic See comments from tdf#52225 in addition to initial description of this one + adapt QA tests associated (keep on to test "0" case) Change-Id: Ia84685fc5d336dd96b97d02c0e81f92e7966a6f1 Reviewed-on: https://gerrit.libreoffice.org/33480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Remove dynamic exception specificationsStephan Bergmann2017-01-2613-198/+117
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* use rtl::Reference in SmGraphicWindowNoel Grandin2017-01-262-14/+10
| | | | | | instead of storing both a raw pointer and an uno::Reference Change-Id: Ib84809bee35c01fb590439174740d92bf4cd54bd
* loplugin: unnecessary destructor sfx2..storeNoel Grandin2017-01-252-5/+0
| | | | | | | Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typo in comments: relativ -> relativeTakeshi Abe2017-01-252-4/+4
| | | | | | | Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
* starmath: Inline and remove SmRect::BuildRect()Takeshi Abe2017-01-242-22/+6
| | | | | | | | | because a ctor was its only client. Change-Id: I31cce925231210930576bf93396f9d7aa44a5a71 Reviewed-on: https://gerrit.libreoffice.org/33414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* Change all Idle* LINKs to be Timer*Jan-Marek Glogowski2017-01-233-8/+8
| | | | | | | | | | | | | | | | | | | | | Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
* starmath: Avoid ad hoc LanguageTag and CharClass at tokenizationTakeshi Abe2017-01-202-18/+15
| | | | | | | | | Instead, keep them as SmParser's members. Change-Id: I8a2aad7ba8baaad9a761f42f62d51fc67cadec07 Reviewed-on: https://gerrit.libreoffice.org/32348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* New loplugin:dynexcspec: Add @throws documentation, starmathStephan Bergmann2017-01-192-0/+5
| | | | Change-Id: I1181cd9fd50fc0307c4475abb8c59e3f16bade91
* replace boost::checked_deleter with std::default_deleteJochen Nitschke2017-01-172-3/+1
| | | | | | | | | and remove all traces of boost/checked_delete.hpp Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2 Reviewed-on: https://gerrit.libreoffice.org/33182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* Refactor Scheduler to add Task classJan-Marek Glogowski2017-01-171-2/+2
| | | | | | | | Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
* starmath: Rely on the default ctors for SmRectTakeshi Abe2017-01-172-32/+0
| | | | | | | | | | No need to define its copy ctor manually nor to use placement new for assignment operator. Change-Id: I679a19c1d1a87072d818cdfa4a9347edb6f4cea1 Reviewed-on: https://gerrit.libreoffice.org/33202 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>