summaryrefslogtreecommitdiffstats
path: root/sdext
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:unusedfields improve write-only analysisNoel Grandin2017-05-166-21/+4
| | | | | | | | | | by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Resolves: tdf#107812 add check for -ObliqueCaolán McNamara2017-05-151-12/+18
| | | | | | | | | and move checks for -BoldOblique and -LightOblique before -Bold and -Light Change-Id: I59b59a10c6e92c6a6dc269aad616b9eb9e185ccd Reviewed-on: https://gerrit.libreoffice.org/37652 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#107823: missing buttons in Presentation MinimizerJulien Nabet2017-05-141-1/+1
| | | | | | | | | Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=5d0e485e827057eee9fb2c997685690b710e7f34 Change-Id: I1864e7f7ac73fc13af82237f4f7d4dbaaa5733f5 Reviewed-on: https://gerrit.libreoffice.org/37584 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* remove unused uno::Reference varsNoel Grandin2017-05-124-15/+3
| | | | | | | | | found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cleanup osl/diagnose.h includesJochen Nitschke2017-05-093-3/+0
| | | | | | | | | | | | | | with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* make loplugin constantparam smarter about string paramsNoel Grandin2017-05-092-4/+1
| | | | | | | Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unnecessary empty OUString fields and varsNoel Grandin2017-05-091-2/+1
| | | | | | | Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach loplugin:constantparam about simple constructor callsNoel Grandin2017-05-088-25/+6
| | | | | | | Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* revert OSL_ASSERT changesChris Sherlock2017-05-0725-94/+94
| | | | Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
* tdf#43157: convert sdext codebase away from OSL_ASSERT to assertChris Sherlock2017-05-0725-94/+94
| | | | Change-Id: If60f3585f202aabf42582239840aa87c96ae7842
* loplugin:salunicodeliteral: sdextStephan Bergmann2017-04-281-3/+3
| | | | Change-Id: Ibcfe4cec41a18ab3fb79cb0545c71a21200c0f2c
* loplugin:cppunitassertequals: sdextStephan Bergmann2017-04-281-46/+46
| | | | Change-Id: I9c00bed21ae2ca49d1be60fe2161271cb7aa334d
* sdext: fix loplugin:stringconcat warningMiklos Vajna2017-04-271-1/+1
| | | | Change-Id: I1e9aa0826d8692819fb05d2f572cf3c4e976fe00
* can detangle the sdext graphic resource nowCaolán McNamara2017-04-273-5/+24
| | | | Change-Id: I2992b859bbebfa4bfae3ea5bfe76e8aa62193f69
* tools: move errcode.hxx to the vcl moduleChris Sherlock2017-04-271-1/+1
| | | | | | | Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2017-04-252-0/+2
| | | | | | | Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-212-5/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin2017-04-211-1/+1
| | | | | | | Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* no need to use OUStringToOString in SAL_INFONoel Grandin2017-04-122-5/+5
| | | | | | | Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2 Reviewed-on: https://gerrit.libreoffice.org/36451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Improved loplugin:redundantcast, static_cast on arithmetic types: sdextStephan Bergmann2017-04-061-1/+1
| | | | Change-Id: Ib9d4c9ee077ffe7e3625818d2468658ee00b9c77
* use actual UNO enums in reportdesign..svtoolsNoel Grandin2017-04-032-2/+2
| | | | | | | Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203 Reviewed-on: https://gerrit.libreoffice.org/36043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2017-03-252-3/+3
| | | | | | | Change-Id: I35d4a7648566105b176eb39f6a1db44ca91d4f4c Reviewed-on: https://gerrit.libreoffice.org/35643 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Remove unused #include <ctype.h>Stephan Bergmann2017-03-231-1/+0
| | | | Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
* just make the VirtualDevice a parser memberCaolán McNamara2017-03-081-5/+5
| | | | | | rather than over complicating things Change-Id: Ife65207dab8ddfedb6a9cbe111adf13fd03b5b3b
* Fix typosAndrea Gelmini2017-03-021-1/+1
| | | | | | | Change-Id: If5e709c9d6e3a4fbb568bdc261cccd214dd0cbd3 Reviewed-on: https://gerrit.libreoffice.org/34784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:sallogareasStephan Bergmann2017-02-281-2/+2
| | | | Change-Id: Ida8a58bd95164cd651934dbf8be0923ac2c08a8e
* new loplugin unoanyNoel Grandin2017-02-284-45/+45
| | | | | | | Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:loopvartoosmallStephan Bergmann2017-02-272-8/+5
| | | | Change-Id: Id2771f413798ed9ceb76e9c4dd3113633d4e481e
* fix crash in pdfimportMarkus Mohrhard2017-02-241-3/+10
| | | | | | | | | | Found by the crashreporter: http://crashreport.libreoffice.org/stats/crash_details/2eaeda85-849d-4098-b215-a8e64fe82089 Change-Id: I113f4dfc4a4f45511102c417d39fe15db6050daa Reviewed-on: https://gerrit.libreoffice.org/34628 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* vector::data seems more natural than &vector::frontCaolán McNamara2017-02-241-1/+1
| | | | Change-Id: I0ce48075ad186cf1f9bd3e13fa76269fa9819af1
* change intervall -> intervalDavid Tardon2017-02-234-18/+18
| | | | Change-Id: Ib211619428f16304603d9c0a9fce0b22dde2a617
* loplugin:subtlezeroinit: sdextStephan Bergmann2017-02-213-5/+5
| | | | Change-Id: Idaf62b25bba7328e5f7942619df14d0fff4014e6
* PaneDescriptor::mbNeedsClipping is never readStephan Bergmann2017-02-172-3/+0
| | | | Change-Id: If8e5f5dca0927b961685af7339fd1d982314a6d7
* remove unused Right from Anchor enumNoel Grandin2017-02-152-2/+1
| | | | Change-Id: I7943a37407481305d28e526840caf320e7ff6bf2
* "Unicode" is a proper noun and should not be used in pluralTor Lillqvist2017-02-121-4/+4
| | | | | | | The 16-bit things that make up the UTF-16 encoding are called "code units". Change-Id: Iab2b83323783e518198c1a0553f7b053fc415985
* Add missing #includesStephan Bergmann2017-02-064-0/+4
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-319-18/+18
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#105536: PDF image should be v-flipped unconditionallyMike Kaganski2017-01-283-2/+21
| | | | | | | | | Unit test included Change-Id: Id0d054a6b9922666daf4f36908f97ed6e65fb6c7 Reviewed-on: https://gerrit.libreoffice.org/33649 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-2811-18/+12
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-2664-1009/+378
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor scaddins..sdextNoel Grandin2017-01-259-46/+0
| | | | | | | Change-Id: I6ae02ad25863ec7e0f780020dbc69c9a99488c24 Reviewed-on: https://gerrit.libreoffice.org/33511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#105382 Set URL-decoded default filename for minimized presentationTakeshi Abe2017-01-242-18/+10
| | | | | | | | | | | See mailing-list thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076702.html> for a discussion on the original presentation file's URL. Change-Id: I51ccd7672513118f39518c4ed21902de16b2298f Reviewed-on: https://gerrit.libreoffice.org/33261 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* New loplugin:dynexcspec: Add @throws documentation, sdextStephan Bergmann2017-01-1915-6/+15
| | | | Change-Id: Id01b4012d2ac3cf479a96ed496eff3d97e5c80c5
* new loplugin: useuniqueptr: sdextNoel Grandin2017-01-174-22/+22
| | | | | | | Change-Id: Iae1dfc7f566d2f5bd1652f170218b502b5663126 Reviewed-on: https://gerrit.libreoffice.org/33205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringconstant: handle OStringBuffer::appendStephan Bergmann2017-01-111-1/+1
| | | | Change-Id: I283da52c0ee2b63c19e31e9a61ab24997c037a6a
* Some loplugin:conststringvar/stringconstant improvements: sdextStephan Bergmann2017-01-111-1/+1
| | | | Change-Id: I47884eeb14a67b7e260835b8603d7b76c7ec018b
* New loplugin:conststringvar: sdextStephan Bergmann2017-01-101-6/+6
| | | | Change-Id: I2452ef62e34b1837048ab79bde07660a50b6dec9
* New loplugin:externvar: sdextStephan Bergmann2017-01-091-1/+1
| | | | Change-Id: I46185dcefcd369f623fe4f4773e78275711d7f18
* ODR violation (base class must be the same across compilation units)Stephan Bergmann2016-12-2119-155/+117
| | | | Change-Id: Ieb98d8984c8d39fb72afbceccca29a2d402dc41e
* Revert "verify SolarMutex when ref-counting VclPtr" seriesNoel Grandin2016-12-134-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts the following commits: commit 722f4e1d86710f2facd37d7e040df9e1fd585e26 tdf#104573 - Assertion failed: SolarMutex not locked commit f04ec99f5e6a543b8191ced61db4710c3c0de356 tdf#104573 - Assertion failed: SolarMutex not locked commit 71b1e3ff6374c23e65200d3bcafca387d29af04f tdf#104573 - Assertion failed: SolarMutex not locked when trying commit e794ce1eef6730e5a46d5fb0aa6db2895ede85e7 verify that we hold the SolarMutex when ref-counting VclPtr IRC discussion: <noelgrandin> sberg, maybe I should revert this whole "VclPtr assert" series, I don't have mental bandwidth to sort this out properly now <sberg> noelgrandin, what I fear is that you'll end up adding lots of SolarMutex locks to small places, where the proper fix would be to add it further out; and once such a dreaded recursive SolarMutex lock is in place (but needlessly so, once the proper fix is done), it's hard to clean that up again <noelgrandin> sberg, yeah, in that case I'll just remove all of this, leave it for another day Change-Id: Ie4f84b72b79a1b7e80164b5c7693af398c2c569a Reviewed-on: https://gerrit.libreoffice.org/31946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-10-07 11:31:18 +0000