summaryrefslogtreecommitdiffstats
path: root/sdext/source
Commit message (Collapse)AuthorAgeFilesLines
* Fix typosAndrea Gelmini2016-10-011-1/+1
| | | | | | | Change-Id: I1e0e6f1b99090f26a6cd657ee9019bf2fa906dd9 Reviewed-on: https://gerrit.libreoffice.org/29436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethods in sc..vclNoel Grandin2016-09-225-51/+0
| | | | | | | Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1342-79/+79
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* loplugin:constantparam in sdNoel Grandin2016-09-105-15/+7
| | | | | | | Change-Id: I2bc989802c12b379a1ba4202f54ecfef1f339c8c Reviewed-on: https://gerrit.libreoffice.org/28774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:staticaccess: Extend loplugin:staticcall to cover all access...Stephan Bergmann2016-08-252-4/+4
| | | | | | | to static members (data, in addition to function) via class member access syntax. Also covers the (somewhat obscure) access to enumerator members. Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
* coverity#1371125 Copy-paste errorCaolán McNamara2016-08-181-2/+5
| | | | | | | | | | | | | | this went wrong with commit 9b9e5cfd2fa629b2e1dc4a193e48a4a4e8d34126 Date: Mon Jun 20 17:40:13 2016 +0300 tdf#99589 - tolower / toupper - dangerous to Turks ... restore the logic to the original logic, but with the new api Change-Id: I445064b19eeefabbd25849bae9ca569710cdfac5
* cppcheck: nullPointerRedundantCheckCaolán McNamara2016-08-181-2/+1
| | | | Change-Id: I9d6c38ad3104369c7661bc8a8561807598aecfcb
* loplugin:countusersofdefaultparams in sdNoel Grandin2016-08-029-11/+11
| | | | | | | Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5 Reviewed-on: https://gerrit.libreoffice.org/27765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Resolves: tdf#84121 wrong password passed to xpdfimportCaolán McNamara2016-07-291-7/+0
| | | | | | | | | | | | | | | | | | | regression from... commit eb276d11a652601f743d69ada7a38016bd97d73e Author: Fridrich Štrba <fridrich.strba@bluewin.ch> Date: Mon Jul 8 14:01:17 2013 +0200 fdo#38878: Upgrading internal xpdf -> poppler before this the hashed _OOO_pdfi_Credentials_ was used in the removed OOoImportSecurityhandler::authorize but after this the hashed password continued to be passed through stdin, while the unhashed password was the required data. Change-Id: Iadc8a372abcfab514f724dd95f05776e5153d007
* improve passstuffbyref return analysisNoel Grandin2016-07-279-12/+12
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann2016-07-077-10/+10
| | | | Change-Id: I3774f16c09b89fc6888bff3a388c290c32bb8a14
* loplugin:unusedfieldsNoel Grandin2016-06-301-7/+0
| | | | | | | Change-Id: If06fffa8db050df0f9c1c7da6163575bf522382e Reviewed-on: https://gerrit.libreoffice.org/26754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:singlevalfields in variousNoel Grandin2016-06-282-4/+2
| | | | | | | Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:singlevalfields in sdextNoel Grandin2016-06-2710-68/+14
| | | | | | | Change-Id: I9bf194fb58b3bd37071647a83a629b6782836890 Reviewed-on: https://gerrit.libreoffice.org/26659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu2016-06-231-2/+4
| | | | | | | Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* tdf#96080 PDF Import: fix incorrect whitespace characters sequenceVort2016-06-201-0/+7
| | | | | | | Change-Id: I0f8e0217cb661be318af611216191def1b209ea1 Reviewed-on: https://gerrit.libreoffice.org/26426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann2016-06-082-2/+2
| | | | Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
* Reintroduce some code removed with "Remove unneeded Pane code in ..."Jan Holesovsky2016-06-061-1/+6
| | | | | | | | This code was removed in 71cf1aefca1ecf10272308d7c75201bd39d3b0f6, but it was guarded by an "ifndef", not by an "ifdef", so it should still stay (unless I'm missing something). Change-Id: Ib344e73d39d1fcd3b84784977769708726d8ed1e
* Remove unneeded Pane code in Presenter ConsoleBryan Quigley2016-06-063-728/+1
| | | | | | | | | | | This code hasn't been touched (on purpose) in years, it appears to have been used to resize part of the console. (It's prefed off) Change-Id: Iaaeaa8a95c71ae91299bbeeea24869bf2a237b6b Reviewed-on: https://gerrit.libreoffice.org/24663 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* teach refcounting clang plugin about uno::ReferenceNoel Grandin2016-05-312-5/+6
| | | | | | | | | | | | | | uno::Reference is only allowed to used with classes that have a ::static_type member. So convert all those places to rtl::Reference. Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and uno::Reference to make this a little smoother? Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3 Reviewed-on: https://gerrit.libreoffice.org/25516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethods in sdNoel Grandin2016-05-196-26/+2
| | | | | | | Change-Id: I27da3e7afd86217ec9f75958775da9c144d7a0a5 Reviewed-on: https://gerrit.libreoffice.org/25111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy modernize-make-sharedNoel Grandin2016-05-182-3/+3
| | | | | | | Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* sdext: replace boost::bindMichael Stahl2016-05-132-15/+8
| | | | | | | | | | MSVC 2013 with non-debug runtime requires an additional assignment operator in OUStringBufferAppender. Change-Id: Ic93fc8d6b1d4760f0eb89e34beb1fcb18e783f73 Reviewed-on: https://gerrit.libreoffice.org/24980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:stringconstantStephan Bergmann2016-05-121-1/+1
| | | | Change-Id: I5515f35871b23b67564d5eda52bf3323e7e047bb
* sdext: replace boost::bind with C++11 lambdas, part 2Michael Stahl2016-05-127-28/+42
| | | | Change-Id: Ife5fbf7a7a41182de00dca339cba160e3bb0062f
* loplugin:stringconstantTor Lillqvist2016-05-121-1/+1
| | | | Change-Id: I9eed9713a0d208e7aa4cdddc0cedb97edf831239
* loplugin:defaultparamsTor Lillqvist2016-05-121-1/+1
| | | | Change-Id: I4905e4c1dd72dabe2229d99742ee0012295a9742
* sdext: replace boost::bind with C++11 lambdasMichael Stahl2016-05-118-36/+33
| | | | | | | Change-Id: I2a30e764b96530e21d5ff201b18f98d1cd334a6d Reviewed-on: https://gerrit.libreoffice.org/24888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Insert explicit "break" when falling through to empty next caseStephan Bergmann2016-05-101-0/+1
| | | | | | | ...which itself only contains a "break" (or nothing at all at the end of the "switch"), as otherwise Clang -Wimplicit-fallthrough would warn about these. Change-Id: I25c1cf2ca74dfeba7ca0385ca8f1c1bf30bbf91b
* fix Windows buildNoel Grandin2016-05-101-2/+4
| | | | Change-Id: Ib80cc10c259e26e997e3a548fbf267621c050e29
* clang-tidy modernize-loop-convert scaddins to sdextNoel Grandin2016-05-103-15/+15
| | | | | | | Change-Id: I63ccc56df1a1de8bc443abb95e520246c457912f Reviewed-on: https://gerrit.libreoffice.org/24798 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* teach passstuffbyref plugin to check for..Noel Grandin2016-05-062-2/+2
| | | | | | | | | | | | unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use Any constructor instead of temporariesNoel Grandin2016-05-041-3/+1
| | | | Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
* Fix typosAndrea Gelmini2016-04-301-1/+1
| | | | | | | Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* update loplugin stylepolice to check local pointers varsNoel Grandin2016-04-261-17/+17
| | | | | | | | | | | | are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* new plugin stylepoliceNoel Grandin2016-04-212-9/+9
| | | | | | | check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-2027-92/+92
| | | | Change-Id: I0a24f0d6fa58407f9e365a5c812743151b88513b
* tdf#99352 - Some VclPtrs leak past DeInitVCLNoel Grandin2016-04-181-5/+6
| | | | | | | Change-Id: I74b27b1d8b662a644df580ae128643b8495355f8 Reviewed-on: https://gerrit.libreoffice.org/24204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy performance-unnecessary-copy-initializationNoel Grandin2016-04-181-1/+1
| | | | | | | | | | | probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* clang-tidy performance-unnecessary-value-param in variousNoel Grandin2016-04-147-7/+7
| | | | | | | Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:passstuffbyref in sdextNoel Grandin2016-04-1414-50/+50
| | | | Change-Id: I954510b953dab133bcf7b37cf598757b7d8e5fca
* Avoid reserved identifierStephan Bergmann2016-04-121-2/+2
| | | | Change-Id: I0d75653dcde39b0fbd8af723295262615978d903
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-121-1/+0
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke2016-04-1121-66/+70
| | | | | | | | | | | | | | | ... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Avoid reserved identifierStephan Bergmann2016-04-062-5/+5
| | | | Change-Id: I3ded47656c4e0f1c3134337bddab5713f29be27e
* cleanup: remove unused Reference.h(xx) includesJochen Nitschke2016-04-021-1/+0
| | | | | | | | | and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* loplugin:constantparam in sdNoel Grandin2016-03-244-19/+4
| | | | Change-Id: I1a7f4cab28a70c45e5232e1c44f6ca6f7b014bff
* loplugin:constantparam in sdextNoel Grandin2016-03-235-44/+18
| | | | Change-Id: Ib349a856665776ef51524b3c6613774f739bbdfe
* delete hidden pages before deleting unused mastersDavid Tardon2016-03-221-7/+7
| | | | Change-Id: I40b624c0e6e6cff2c88815f7d16e862f09d79d5c
* sdext.presenter: change OSL_TRACE -> SAL_INFODouglas Mencken2016-03-171-7/+5
| | | | | | | Change-Id: I34724f28b96b00b8afe2b618d8d47561082987ca Reviewed-on: https://gerrit.libreoffice.org/23311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>