summaryrefslogtreecommitdiffstats
path: root/sd
Commit message (Collapse)AuthorAgeFilesLines
* GSoC notebookbar: updated ui filesSzymon Kłos2016-08-031-0/+3
| | | | Change-Id: Ie087e0bf8bbce2770c6576817d32747607f38105
* sd: track view shell id in SdUndoActionMiklos Vajna2016-08-033-2/+45
| | | | | | | | | | This helps in case of e.g. setting the page size of an Impress slide from the sidebar. Change-Id: I6247d6efcc59f2c6311dcd33d0f989a39fd7b3f9 Reviewed-on: https://gerrit.libreoffice.org/27827 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* svx: track view shell id in SdrUndoActionMiklos Vajna2016-08-031-0/+13
| | | | | | | | | This is used in Impress e.g. when resizing a picture. Change-Id: I2e0a9228ed0ff9ecfd72696ef84e56f88e4c0f70 Reviewed-on: https://gerrit.libreoffice.org/27822 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* GSoC notebookbar: Calc, Impress placeholder iconsSzymon Kłos2016-08-021-1/+17
| | | | Change-Id: I2a18c4d610ab1dac2627284c008207a3dbaab406
* Resolves: tdf#99324 let sidebar toggle auto-mnemonics on/off with altCaolán McNamara2016-08-021-1/+4
| | | | | | | | | this returns things to passing the alt to the thing with the focus and depends on ::Command handlers passing the alt-press/release back up through the Command hierarchy to get to the default top-level handler eventually Change-Id: I869120f43810adfa2fac4670c2db143b790a1f9b
* loplugin:simplifyboolNoel Grandin2016-08-021-1/+1
| | | | Change-Id: I2e1f288bf71cd5598bccf12322f74c096386b3c9
* loplugin:countusersofdefaultparams in sdNoel Grandin2016-08-0283-172/+172
| | | | | | | Change-Id: I848d9b555a26e9d343efdfaaaec44a2c7d8be5b5 Reviewed-on: https://gerrit.libreoffice.org/27765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna2016-08-0113-17/+34
| | | | | | | | | | | | | Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* tdf#100969 ensure proper update after model changeDavid Tardon2016-08-012-25/+37
| | | | Change-Id: I62836056aeda7497552d60d33fedd9490a6fe545
* svl: avoid defaulted parameter in SfxUndoManager::EnterListAction()Miklos Vajna2016-08-0112-15/+15
| | | | | | | | | It's a virtual function, and defaulted parameters there are problematic. Change-Id: I3f110c7ac36dfda90811b033620286ad9fce1af1 Reviewed-on: https://gerrit.libreoffice.org/27772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Padding adjustment to Custom Animations PanelSusobhan Ghosh2016-08-011-1/+2
| | | | | | | Change-Id: Ib09d138d2f8e82d08ce1f2082a25690ce01ac7cc Reviewed-on: https://gerrit.libreoffice.org/27752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
* Add border padding to Slide Background PanelSusobhan Ghosh2016-08-011-0/+3
| | | | | | | Change-Id: I6b0ae2e65cba6768f566dfffb3e54181987d5757 Reviewed-on: https://gerrit.libreoffice.org/27749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
* assert from unsorted sid arrayCaolán McNamara2016-07-291-2/+2
| | | | Change-Id: I9f4d6274581bc800c8404fcbbe2369aa42d05302
* GSoC Emoji ControlAkshay Deep2016-07-284-0/+14
| | | | | | | | | | | | | | | Tab Window Add emoji.json to installation directory Read the JSON data from code Filter emojis according to categories Insert Emoji at cursor position Toolbar control Change-Id: Ia5a577ce41398132872914ebfa499e4d4077d57e Reviewed-on: https://gerrit.libreoffice.org/26700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Akshay Deep <akshaydeepiitr@gmail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Revert "temp tinderbox fix"Caolán McNamara2016-07-283-0/+3
| | | | | | This reverts commit d4cb9c3a8851cb874fd8b6c77d4d7521da7579b7. Change-Id: Ifd11427ea6b4137d0e0c007e7f140fbc6caa3f31
* add uui component to some other placesCaolán McNamara2016-07-271-0/+1
| | | | Change-Id: Ic703b509bac0a57e0780bbb83537e7e4323a79d0
* svx lok: fix handling of text edit drawing when view/page changesMiklos Vajna2016-07-272-6/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow-up to commit 9d91d371e92548c7f75a7d0155eecaf3769fdee6 (svx lok: draw text edits in all views, 2016-07-26). Two corner-cases are now handled: 1) When the SfxViewShell is created after begin text edit and 2) When the other draw view is already created, but at the time begin text edit happens, the other draw view shows a different page. And the opposite of these: switching away from a page were we observe a text edit done in an other view or destroying a view that observes a text edit. When the complete view goes away, then SdrObjEditView::HideSdrPage() is not called, so also try to destroy the outliner view of the text edit from SdrObjEditView::DeleteWindowFromPaintView(). The GetSfxViewShell() call in SdrObjEditView::ShowSdrPage() is important, because we let the other draw view create the outliner view, but the outliner view should invoke our view shell, not the view shell of the other draw view. Also improve the SdTiledRenderingTest::testCursorViews() testcase, so that it asserts it managed to begin text edit and use a test document that still has a single slide and shape, but the shape is not auto-sized; otherwise invalidations happen even if outliner views are not created in all draw views, so the test would pass even without the fixes. Change-Id: I2c3bb27826c6887115366db818599fc8adabc5a5 Reviewed-on: https://gerrit.libreoffice.org/27583 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* formally->formerlyCaolán McNamara2016-07-271-1/+1
| | | | Change-Id: I1d631f8dd09193c57b7b65e3202ed080ce15861b
* svx lok: avoid SfxViewShell::Current() during constructing a new view shellMiklos Vajna2016-07-272-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | Currently when a text edit is started, then in the LOK case if there is an other view that shows the same page, then both draw views will have an outliner view showing the text edit. This means that in case a view shell is created after starting the text edit, that won't have an outliner view for the text edit. Before fixing this, calls to SfxViewShell::Current() has to be avoided when we're in the process of setting up a new LOK view. In case of Impress, this is a double initialization, and by the time SdrObjEditView::ImpMakeOutlinerView() is called, we're already in the process of setting up the second SfxViewShell (as part of SdXImpressDocument::initializeForTiledRendering()), but SfxViewShell::Current() still points to the old view shell. Which means that the outliner view would refer to a view shell that's deleted soon, and we crash as soon as it tries to invoke a LOK callback. Fix this by adding a virtual member function to SdrObjEditView, and override it in sd, so in case applications want to provide a more precise way of giving the view shell owning a draw view, then they can. Change-Id: Ie0005f73237d4ff9cf576bf16fa5b46280f13759 Reviewed-on: https://gerrit.libreoffice.org/27561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* cppcheck: noExplicitConstructorCaolán McNamara2016-07-274-4/+4
| | | | Change-Id: Id0a6cd461b2ba56e3b9b944514f3b0d0eb75cc44
* improve passstuffbyref return analysisNoel Grandin2016-07-2718-36/+36
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* masses of MessBoxes not being disposed promptlyCaolán McNamara2016-07-2610-29/+29
| | | | | | | | | | | | | | | | since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
* move parseExport to SdExportTest base classMichael Stahl2016-07-256-48/+40
| | | | Change-Id: I20cc59e21aa1b99d8cee5a9f60c0703e9c457187
* sd: OOoXML import: fix loss of animationsMichael Stahl2016-07-256-0/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There are 2 different animation formats, legacy one used in OOoXML format, based on presentation:animations element, and SMIL based one used in ODF format, based on a node hierarchy with <anim:par presentation:node-type="timing-root"> at the top. The problem is that when the legacy animations are imported, they are not immediately set on the draw-page in the same way as the new animations are imported. "soffice --convert-to odp ooo28334-1.sxi" loses all of the animations, whereas loading the file in the UI and storing it all animations are converted, and if you use API load/store methods some are converted and some not depending on timing. The problem is that there is a necessary conversion step MainSequence::implRebuild() that needs to happen after all the EffectMigration calls for a particular SdPage are finished, which is only triggered by a timer MainSequence::onTimerHdl(). Fix it by forcing a call to implRebuild() from DrawDocShell::Load(). Note: SdDrawDocument::NewOrLoadCompleted() is a horribly misleading function name as it is actually called *before* loading the document. Change-Id: I9881cb9bf2ae6ccc5fcf06602343f2d0e0704699
* Revert "loplugin:unreffun"Michael Stahl2016-07-251-0/+16
| | | | | | | | This reverts commit eeb852ea1ecb77c2980d44075429b06e7d420c3a. Only the function in export-tests.cxx which is now used. Change-Id: I0751a4fd2d651676cfee42dd077b1d438a98fc92
* Resolves: tdf#101076 drag-create creates an unfilled shape...Caolán McNamara2016-07-251-1/+0
| | | | | | | | | | | | | | | | | after using the slide properties->background->all slides This SetAttributes with nothing selected will end up setting the default object properties. Here I think we are setting the bg color to the master, and then unsetting the bg color of the slides to none so the master color shows through. So the additional SetAttributes call unsets the bg of the default object style Change-Id: I5cfd74eef5637b87d2a8778d4b8c8a0cbc0960db Reviewed-on: https://gerrit.libreoffice.org/27487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* new loplugin overrideparamNoel Grandin2016-07-259-19/+23
| | | | | | | | | | verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptrTor Lillqvist2016-07-251-1/+1
| | | | Change-Id: If8f933706b0acb86dcdebb85ec647abfd61fa949
* Fix typosAndrea Gelmini2016-07-221-1/+1
| | | | | | | | | | Thanks to Carlo Bertoldi for the german translation. Change-Id: I76f554e757318aed4e28b5a05fae0ba15bd46afb Reviewed-on: https://gerrit.libreoffice.org/27355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Fix --disable-pdfimport buildMiklos Vajna2016-07-221-0/+2
| | | | | | | Change-Id: Ida06b892aea92cfe26fd62372e21ca611d8838d3 Reviewed-on: https://gerrit.libreoffice.org/27447 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* sd: implement LOK_CALLBACK_VIEW_LOCKMiklos Vajna2016-07-222-1/+63
| | | | | | | | | | So that edited shape text doesn't just disappear in other views without any indication. Change-Id: I806051492f7bc247c0e66eceda4df5eba8322aad Reviewed-on: https://gerrit.libreoffice.org/27444 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* GSoC notebookbar: better default page handlingSzymon Kłos2016-07-221-0/+4
| | | | | | | | | | | | | + selected default tab page in the Impress + the default tab page is set when context isn't supported + switching between unsupported contexts is not causing switch to default tab to avoid closing of tab which was recently used by user Change-Id: Ieeda8a79e6c67708551351f9bb49d8b006c0e74f Reviewed-on: https://gerrit.libreoffice.org/27432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* GSoC notebookbar: image tab for ImpressSzymon Kłos2016-07-221-0/+517
| | | | Change-Id: I45ef6691d32f3fd084143a80ac904e441b4a6098
* sd lok: decouple vcl window focus from cursor visibilityMiklos Vajna2016-07-202-3/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem was the the blinking cursor was hidden when another vcl window got its focus, so it wasn't possible to edit two shape text in parallel in two windows. The code path is like this: - show cursor, cursor is created: SdrObjEditView::SdrBeginTextEdit() -> OutlinerView::ShowCursor() - show cursor, focus case: sd::FuText::Activate() -> OutlinerView::ShowCursor() - hide cursor, cursor is deleted: SdrObjEditView::SdrEndTextEdit() -> OutlinerView::HideCursor() - hide cursor, focus case: sd::FuText::Deactivate() -> OutlinerView::HideCursor() So add a new optional bool parameter that allows not emitting the LOK_CALLBACK_CURSOR_VISIBLE callback in the focus change case. Also, if we're at it, make sure that painting emits no show/cursor LOK callbacks. Change-Id: I1068a1b1f5cd76fd09b5a79066834bfb0daebc77 Reviewed-on: https://gerrit.libreoffice.org/27335 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* sfx2 lok: expose part number in SfxLokHelper::notifyOtherViews()Miklos Vajna2016-07-195-5/+70
| | | | | | | | | | This way a client can decide if the view cursor it gets is relevant (the views show the same part) or not. Change-Id: I7b274b28f0c4f0509df5071831acf50512eff640 Reviewed-on: https://gerrit.libreoffice.org/27311 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* GSoC notebookbar: don't show empty space for hidden tabsSzymon Kłos2016-07-181-1/+1
| | | | | | | Change-Id: Ia00f64c1cb5d990e852cc297b6b7bd76df4b1b05 Reviewed-on: https://gerrit.libreoffice.org/27191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* lok::Document::destroyView: clean up view cursors/selectionsMiklos Vajna2016-07-151-0/+7
| | | | Change-Id: Icd3f96a922e7d1aec0d52e90df87ec45790c9807
* new loplugin unnecessary overrideNoel Grandin2016-07-1537-234/+1
| | | | | | | Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann2016-07-131-4/+0
| | | | | | | Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Moved SfxModule owner to SfxApplicationMark Page2016-07-136-33/+14
| | | | | | | | | | | | | ::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#99107: Unify single click behaviour across panelsKatarina Behrens2016-07-122-5/+1
| | | | | | | Change-Id: Ib182f6caae61eda5f85d241ddb1499671df0a28b Reviewed-on: https://gerrit.libreoffice.org/27134 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
* Resolves: tdf#100861 replace all doesn't workCaolán McNamara2016-07-121-2/+0
| | | | | | | | Revert "lool - search all - unit test failure - solved" This reverts commit d6f1ca24932ba85607ba3e526c5721132cd39252. Change-Id: I328ece1029955ff9f4e5043084d649898e3e8809
* Related: tdf#100861 same selection recorded multiple times...Caolán McNamara2016-07-122-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in FindAll libreofficekit impress test on find all we loop through the textboxes searching for the string. We start by searching into the first textbox with the string in it. mbStringFound gets set to true and this first selection is reported. Now the current pos is still in that textbox at the end of the string. The next loop will find nothing in this textbox, but because mbStringFound was set in the earlier pass, the same selection gets reported again. The next loop will move to the next textbox. To keep this fix as simple as possible just check if the selection was the previously reported one and skip it if it is. I believe this is the problem that commit d6f1ca24932ba85607ba3e526c5721132cd39252 Author: Marco Cecchetti <marco.cecchetti@collabora.com> Date: Mon Jan 11 16:43:02 2016 +0100 lool - search all - unit test failure - solved wanted to solve Change-Id: I30e7b9c581488b48fa27f138209f291063b459a3
* fix assert about unsorted ids when search+replace in impressCaolán McNamara2016-07-121-3/+2
| | | | Change-Id: Ib4d549a18365f954cb3e35ac016a4c69803cff99
* GSoC notebookbar: File tabSzymon Kłos2016-07-111-43/+161
| | | | Change-Id: I98640b0b4585b2fe1088b13b07dce82a185fd8bf
* GSoC notebookbar: impress table tabSzymon Kłos2016-07-117-2/+255
| | | | | | | Change-Id: I50338e2f5405171785ea610a9febc3d4f5df96e5 Reviewed-on: https://gerrit.libreoffice.org/27052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* loplugin:staticcallStephan Bergmann2016-07-111-4/+4
| | | | Change-Id: I800eef0517f063ff7e08a95de9da268fb0e9d621
* rhbz#1351292 correctly set edit modeDavid Tardon2016-07-111-17/+40
| | | | | | | ... when switching between different shells, e.g., from Outline to Slide master. Change-Id: I22ef6f6cac73c52fb1bedd97e653b4b57c5a7a24
* ditch the font/screen-scaling thingCaolán McNamara2016-07-101-14/+0
| | | | | | | its of limited utility wrt the vcl layout work and optimal size widgets, and its confuses people looking for hidpi settings Change-Id: I37d21b480446f9fe2845b3a2d9fd59cdeddf1a93
* tdf#87643: Default Shapes Panel for Shapes DeckSusobhan Ghosh2016-07-081-1/+1
| | | | | | | Change-Id: Ib3d4a32e70b6dc2ae0898846a27d3ffcb43c2a75 Reviewed-on: https://gerrit.libreoffice.org/26770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
generated by cgit (git 2.34.1) at 2024-08-09 06:55:40 +0000