summaryrefslogtreecommitdiffstats
path: root/sd
Commit message (Collapse)AuthorAgeFilesLines
* Improved loplugin:redundantcast static_cast handling: sdStephan Bergmann2017-06-021-4/+1
| | | | Change-Id: I07297ff8ceb69c0da2396b452bb7448f8c4ca07b
* convert GRFILTER constants to ERRCODE_GRFILTER_Noel Grandin2017-06-024-15/+15
| | | | | | | | | | since various code mixes these constants in with ErrCode values from other code, let us just make it into real ErrCode values. Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95 Reviewed-on: https://gerrit.libreoffice.org/38313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#108024 Keep original selection during DrawViewShell::FuTemporary()Takeshi Abe2017-06-011-1/+2
| | | | | | | | | | Otherwise it was disposed in the middle of its own mouse event handler FuSelection::MouseButtonUp(). Change-Id: I0d96048526dece7232e5a777364ad4da1d64c904 Reviewed-on: https://gerrit.libreoffice.org/37976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove some unnecessary scaffolding around SAL_WARN callsStephan Bergmann2017-05-313-3/+0
| | | | Change-Id: Iaec105d85a283ad15fdca6ffc5cf3d2ec5acac18
* disambiguate dual use of toolbar idsCaolán McNamara2017-05-3115-147/+63
| | | | | | | | | | for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* lok: impress: add support for undoing comment editingMarco Cecchetti2017-05-313-5/+30
| | | | | | | | | | Conflicts: sd/source/ui/annotations/annotationmanager.cxx Change-Id: I735dd68d658f007ddd44d6acf692ee9b4555eb53 Reviewed-on: https://gerrit.libreoffice.org/37816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* lok: impress: undoing comment deletion doesn't workMarco Cecchetti2017-05-313-58/+82
| | | | | | | Change-Id: I3399ea4131acde42bdd307a8438a9129a83817f2 Reviewed-on: https://gerrit.libreoffice.org/37815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* remove duplicate 'using namespace'Jochen Nitschke2017-05-302-9/+5
| | | | | | | Change-Id: I7f8828f677cfb588135ff75c03ffb75895773440 Reviewed-on: https://gerrit.libreoffice.org/38201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* sal,sd: remove deprecated Windows XP socket codeMichael Stahl2017-05-301-1/+1
| | | | Change-Id: I220911496ed2734224b1eb96a929ec8d8bf2a3ef
* Fix highlighting in sd::FuTemplateRohan Kumar2017-05-302-23/+48
| | | | | | | | | sd::FuTemplate Highlighting tab's colors don't stick anymore. Change-Id: Idb1701ddf1f7d47758a4ef8ebe6705ee6ff16c11 Reviewed-on: https://gerrit.libreoffice.org/35800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* teach redundantcast plugin about functional castsNoel Grandin2017-05-307-11/+10
| | | | | | | Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "[API-CHANGE] Add persistent (in addition to persistant)"Stephan Bergmann2017-05-291-1/+1
| | | | | This reverts commit 795d56dfd55a78a240cef79c822ba958c4f18006. The Gerrit UI had fooled me into pushing the "Submit" button in error.
* [API-CHANGE] Add persistent (in addition to persistant)Julien Nabet2017-05-291-1/+1
| | | | | | | | | | + keep "persistant" for compatibility reasons but put it as deprecated Change-Id: I7ef8efb9f376eadfdac876d142840aab5a0b4416 Reviewed-on: https://gerrit.libreoffice.org/37042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Capitalization of menu itemsAdolfo Jayme Barrientos2017-05-281-4/+4
| | | | Change-Id: I8d69da8b916c232e12d24b92543478fc79b76bc0
* remove unnecessary use of OString::getStrNoel Grandin2017-05-289-164/+61
| | | | | | | Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#101815 impress: redraw after ExecuteSpellPopupJustin Luth2017-05-262-0/+3
| | | | | | | | | | After replacing a misspelled word, impress wasn't updating the screen in outline or normal mode. This is attempt #2. Change-Id: I3eb213a951d55faf9f5b36392f37bf2263851247 Reviewed-on: https://gerrit.libreoffice.org/34406 Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
* loplugin:constantparamNoel Grandin2017-05-251-1/+1
| | | | | | | | | add the results files so I can just see the diff in future Change-Id: Ia20a1aa6418be95ed620719cde340c00b7b053e1 Reviewed-on: https://gerrit.libreoffice.org/37988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* SdResId used just for its idCaolán McNamara2017-05-241-1/+1
| | | | Change-Id: I37bc1e8f52c4968a26b12d5b9609dfe7b1f7827a
* mysterious and missing 4077 resource used in sdCaolán McNamara2017-05-233-19/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this would have been String RID_WEBWIZARDDIALOG_START +77 from wizards/source/formwizard/dbwizres.src which is now gone (very reasonably) since... commit 82d863b4a410fa78120d2efc41bd2b3b61f21cee Date: Sat Feb 18 14:02:30 2017 +0100 Related tdf#99967: Cleanup after Web Wizard drop There are still webwizard*.xhp in help/source/text/shared/autopi/ Change-Id: If54d7bfc093c8c0765fd881eeb14f62bc3517194 Reviewed-on: https://gerrit.libreoffice.org/34402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> the original complicated reuse of another modules translation was in commit 660c23c4c1c624b9db626be8f01166a154021e0d Date: Fri Jan 28 14:38:37 2005 +0000 INTEGRATION: CWS impress30 (1.18.40); FILE MERGED 2005/01/20 13:44:50 cl 1.18.40.1: #b4752338# give warning when overwriting files Change-Id: I80ff0a545bbf08bcea142bb8bd41c547713ee11b
* enhance useuniqueptr lopluginNoel Grandin2017-05-232-4/+22
| | | | | | | | | | | teach it to look for the following sequence in a destructor: delete m_pfoo; m_pfoo = nullptr; Change-Id: Icd6271a63a024e32b53cc9e599f8f59952160380 Reviewed-on: https://gerrit.libreoffice.org/37900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Test _WIN32 instead of WIN32Takeshi Abe2017-05-221-1/+1
| | | | | | | | | | | | since the former is predefined by Visual C++ [0], but the latter is not. [0] https://msdn.microsoft.com/en-us/library/b0084kay.aspx Change-Id: I9ecb84779cbaf5f0186ef0b05da61b32293f8f2b Reviewed-on: https://gerrit.libreoffice.org/37808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Resolves: tdf#107959 SdrGrafObj leak triggers later crashCaolán McNamara2017-05-221-10/+7
| | | | | | | if the graphic doesn't change, then the cloned SdrGrafObj persists beyond stylesheet destruction and blows up Change-Id: I0013e7e118985c1334ab460507bc5c8271700160
* cleanup unused css/animations/ and css/presentation/ includesJochen Nitschke2017-05-2134-68/+12
| | | | | | | Change-Id: Iafd106d431869d80f664bd540092bee4f10e14b5 Reviewed-on: https://gerrit.libreoffice.org/37862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2017-05-211-13/+12
| | | | | | | Change-Id: I438b6719817e0bbb47370ec54561eed2bc402cba Reviewed-on: https://gerrit.libreoffice.org/37783 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* cleanup unused css/uri/ includesJochen Nitschke2017-05-201-2/+0
| | | | | | | Change-Id: I08c7981ecce45e343ff9e98277dd3aea4ed68ab9 Reviewed-on: https://gerrit.libreoffice.org/37860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#104423 Restore saving of Duplicate dlg parametersLaurent Balland-Poirier2017-05-201-0/+25
| | | | | | | | | | Saving of parameters in Duplicate dlg was removed by ce82146a6be87b239a0bde0b59fddf8865290b99 Change-Id: Id7aaf0734132e3d2a5bd4f11f3a5a7abeaf64911 Reviewed-on: https://gerrit.libreoffice.org/36755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* loplugin:stringcopy: sdStephan Bergmann2017-05-1912-28/+28
| | | | Change-Id: I6cb37109870b4461d08fccc4a7ac31096416b1d4
* make string translation loading more uniformCaolán McNamara2017-05-19121-626/+588
| | | | | | | | | | | | | | | change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* SdResId used just for its idCaolán McNamara2017-05-197-9/+9
| | | | Change-Id: Ic9a762c23a356ea5cb67d03e679292d440311da8
* loplugin:unusedfieldsNoel Grandin2017-05-194-6/+0
| | | | | | | | | make it a little smarter in dealing with fields that are smart pointers Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11 Reviewed-on: https://gerrit.libreoffice.org/37751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove parentheses around some comparisonsStephan Bergmann2017-05-181-1/+1
| | | | | | | ...where Clang would otherwise start to emit -Wparentheses-equality as soon as the order of arguments were switched by loplugin:comparisonwithconstant Change-Id: If064c2c6e2f81478154395137138b71f2d1c6534
* loplugin:checkunusedparams variousNoel Grandin2017-05-163-4/+4
| | | | | | | Change-Id: I5d1cc807134230d86e0226a12fada204004312d3 Reviewed-on: https://gerrit.libreoffice.org/37675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields improve write-only analysisNoel Grandin2017-05-162-20/+0
| | | | | | | | | | by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#96681: Add flag so we can actually work with SID_ATTR_BRUSH_CHARKatarina Behrens2017-05-141-0/+5
| | | | | | | Change-Id: I3e380304eae49290aec80b6aa0f078fcf6618de7 Reviewed-on: https://gerrit.libreoffice.org/37563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* loplugin:constantparamNoel Grandin2017-05-121-1/+1
| | | | | | | Change-Id: I67d74072c776c32a1f91df94c621efe180baf5dc Reviewed-on: https://gerrit.libreoffice.org/37481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "coverity#1399034 Unrecoverable parse warning"Caolán McNamara2017-05-121-4/+0
| | | | | | that didn't work This reverts commit 9905eb90b3bfe9e7281642b7915db177c5143ff0.
* remove unused uno::Reference varsNoel Grandin2017-05-126-13/+0
| | | | | | | | | found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert SdrLayerId to strong_intNoel Grandin2017-05-1236-140/+140
| | | | | | | | | | | | | | Also - rename SetOfByte to SdrLayerIDSet - add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't allocate overlapping SdrLayerID values - add a new constant SDRLAYERPOS_NOTFOUND to be returned from SdrLayerAdmin::GetLayerPos Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8 Reviewed-on: https://gerrit.libreoffice.org/37467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#1399034 Unrecoverable parse warningCaolán McNamara2017-05-111-0/+4
| | | | | | | | have another guess as fixing emit.cpp:1472: assertion failure: emit-ast.cpp:1123: assertion failed: Ran out of fields in aggregate initializer Change-Id: I814c12c350cd1dbd58c25ada3a376477b5809c06
* tdf#107258 Create show/hide all comments toggle button.Gulsah Kose2017-05-113-4/+4
| | | | | | | | | | | | Created new show/hide all comments button for calc by ShowAnnotations command. Unifyied writer, calc and impress's ShowAnnotations slot. Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/36697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
* remove some unnecessary temporary OUStringsNoel Grandin2017-05-113-3/+3
| | | | | | | | | | found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cleanup osl/diagnose.h includesJochen Nitschke2017-05-092-2/+0
| | | | | | | | | | | | | | with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Clean up uses of SAL_U/SAL_W: sdStephan Bergmann2017-05-091-2/+1
| | | | Change-Id: I9646cbd6544e88fd8b086cd04ff6d318a04375ce
* make loplugin constantparam smarter about string paramsNoel Grandin2017-05-094-10/+2
| | | | | | | Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop unused FadeEffectLBCaolán McNamara2017-05-095-94/+0
| | | | Change-Id: I9de95edc7f018fa9e7b11111e071d738f63e35b4
* sd: Kill empty FadeEffectLBImplTakeshi Abe2017-05-092-28/+0
| | | | | | | | | | This completes 3fea7ac94b986ba5e3632d1bbb383c65ced79f1a. Change-Id: Iee18c577354de8b569f5e07378964b267e766554 Reviewed-on: https://gerrit.libreoffice.org/37383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* remove unnecessary empty OUString fields and varsNoel Grandin2017-05-093-8/+5
| | | | | | | Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparamNoel Grandin2017-05-091-2/+2
| | | | | | | Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2 Reviewed-on: https://gerrit.libreoffice.org/37390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach loplugin:constantparam about simple constructor callsNoel Grandin2017-05-087-18/+11
| | | | | | | Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cppcheck nitpicks variableScope and redundantAssignmentJochen Nitschke2017-05-081-2/+1
| | | | | | | Change-Id: I1399e066a96bbd9a3b59e2670a75b0022c882a1d Reviewed-on: https://gerrit.libreoffice.org/37354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-04 06:56:05 +0000