summaryrefslogtreecommitdiffstats
path: root/sd/source/ui/tools/PreviewRenderer.cxx
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:oncevar in sdNoel Grandin2017-06-261-1/+1
| | | | | | | Change-Id: I56649b4df8c517f152ed4e9132985bbef22f8634 Reviewed-on: https://gerrit.libreoffice.org/39241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make loplugin constantparam smarter about string paramsNoel Grandin2017-05-091-3/+1
| | | | | | | Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach loplugin:constantparam about simple constructor callsNoel Grandin2017-05-081-3/+2
| | | | | | | Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* revert OSL_ASSERT changesChris Sherlock2017-05-071-1/+1
| | | | Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
* tdf#43157: convert sd module away from OSL_ASSERT to assertChris Sherlock2017-05-071-1/+1
| | | | Change-Id: I1e768d23da6adb1a3fe351a8105286b0cb5b5192
* tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna2017-03-311-5/+5
| | | | | | | | | | | | | | | Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* convert SFX_HINT to scoped enumNoel Grandin2016-12-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryoverride (dtors) in sdStephan Bergmann2016-12-051-5/+1
| | | | Change-Id: Ibe339042a523f7c55fbcea68756524fc168e8558
* convert inventorId to scoped enumNoel Grandin2016-11-211-1/+1
| | | | | | | | | | SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethodds in scaddins..sdextNoel Grandin2016-10-201-6/+1
| | | | | | | Change-Id: Ife021e368efaafe9097750b4ca1a5472e94352a9 Reviewed-on: https://gerrit.libreoffice.org/30054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert MapUnit to scoped enumNoel Grandin2016-10-051-3/+3
| | | | | | | | | | | | I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke2016-09-231-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-131-1/+1
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* loplugin:constantparam in sdNoel Grandin2016-09-101-11/+2
| | | | | | | Change-Id: I2bc989802c12b379a1ba4202f54ecfef1f339c8c Reviewed-on: https://gerrit.libreoffice.org/28774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* formally->formerlyCaolán McNamara2016-07-271-1/+1
| | | | Change-Id: I1d631f8dd09193c57b7b65e3202ed080ce15861b
* loplugin:constantparam in sdNoel Grandin2016-04-051-5/+2
| | | | | | | Change-Id: Ife610abb1f8ed19ab219301d41d7fc2174ff1d29 Reviewed-on: https://gerrit.libreoffice.org/23830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* vcl: take into account the font width is the average font widthChris Sherlock2016-02-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Bail out early (so to avoid unuseful dynamic_casts)Matteo Casalin2015-12-271-1/+4
| | | | Change-Id: Ie1940e2178585c56cecdbbcff9c9e57aa8b05459
* tdf#69977: uno::Sequence is expensiveNoel Grandin2015-12-111-5/+5
| | | | | | | | | | | | | when used as a mutable data-structure. Plain std::vector halves the time taken to display the chart dialog Create a class to represent the std::vector we are going to be passing around, and move some of the utility methods into it to make the code prettier. Also create an optimised append(&&) method for the common case of appending small temporaries. Change-Id: I7f5b43fb4a8a84e40e6a52fcb7e9f974091b4485
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-18/+18
| | | | Change-Id: If1b80da64ba575f07b31dce9bc0e34b7eb9f11a4
* com::sun::star->css in sdNoel Grandin2015-10-291-3/+3
| | | | Change-Id: Ic0cbc857a3a9c66241b94c30bf8c859435f5a4b4
* loplugin:defaultparamsStephan Bergmann2015-10-201-1/+1
| | | | Change-Id: Ibf07815fa1a113876730382b8d14960eb7a78a0b
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-121-1/+1
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* sd/source/ui/tools boost->stdCaolán McNamara2015-09-251-2/+1
| | | | | | | Change-Id: I55f821dd9c2131cfbd8e2cb7838513a6bcb4b97d Reviewed-on: https://gerrit.libreoffice.org/18869 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* sd/source/ui/inc boost::scoped_ptr->std::unique_ptrCaolán McNamara2015-09-241-0/+1
| | | | | | | | Change-Id: Icf32ccd437c97dfa0ac3a569a3f2ec2b746ac300 Reviewed-on: https://gerrit.libreoffice.org/18822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* boost::shared_ptr->std::shared_ptrCaolán McNamara2015-09-231-1/+1
| | | | | | | | Change-Id: I2c6ac98f0984534894759cfbf4449eb554801cf8 Reviewed-on: https://gerrit.libreoffice.org/18678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* revert for mac and win unit case crashes after boost->stdCaolán McNamara2015-09-171-2/+2
| | | | Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
* boost->stdCaolán McNamara2015-09-171-2/+2
| | | | Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
* loplugin:defaultparamsNoel Grandin2015-08-201-3/+3
| | | | Change-Id: Ie989fe233fc3295fb1901881b59e506ef340ffea
* vcl: remove boost/signal2/signal.hpp from headerMichael Stahl2015-07-101-0/+2
| | | | | | | | | | | | | | The most relevant signal member function appears to be connect(), so let's create a wrapper function for that now, without the more esoteric ordering features for now. Move the signal member itself to a new pImpl. The benefits are worth it: preprocessor input reduced by 2.8GB, that's 9% of the total (excluding system headers which are not counted because they don't generate dependencies). Change-Id: I0aaeda51a5630a348bb12c81a83f67afbd508a14
* convert DRAWMODE constants to scoped enumNoel Grandin2015-05-201-6/+6
| | | | Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
* convert TEXT_DRAW constants to scoped enumNoel Grandin2015-05-201-5/+5
| | | | Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
* convert BMP_SCALE constant to scoped enumNoel Grandin2015-05-061-1/+1
| | | | Change-Id: Ibc9f88d2588c028cd71aa86c26d970a73025ef22
* Get rid of initial :: for the sdr namespaceTor Lillqvist2015-04-301-1/+1
| | | | Change-Id: Ibbeb069b6fcb2aa0581429ac5cb6db519548fd00
* Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks2015-04-281-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
| * sd: convert new to ::Create.Noel Grandin2015-04-201-1/+1
| | | | | | | | Change-Id: I35c03ea4430eb5a5bd4c7cfaed74f741c09cbf18
* | remove unnecessary use of void in function declarationsNoel Grandin2015-04-151-7/+7
|/ | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* WaE: potentially uninitialized local variableCaolán McNamara2015-03-251-1/+1
| | | | Change-Id: Icb4a7d71e23d202078ad27bee255b6f812a74707
* convert EE_CNTRL constants to enum classNoel Grandin2015-03-251-2/+2
| | | | | | | | there were a couple of lines in SC and SW where the code was using a EV_CNTRL constant. I switched it to used the same-valued constant from EE_CNTRL Change-Id: I027183cc3b6e700bf365d48833e37eddc9b50f04
* Fraction fiasco: avoid assert on clicking "master pages" in impress sidebarCaolán McNamara2015-01-081-3/+3
| | | | | | | | | avoids the dread assert in vcl wrt. "detect overflows" in ImplLogicToPixel of vcl/source/outdev/map.cxx but the whole thing looks a nightmare if a high precision double is given as an arg to Fraction and the underlying boost foo uses longs longer than 32bits to represent that. Change-Id: Ia0fa911cf07ed613e0b1bbd97b63a291f29628cb
* Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky2014-10-231-2/+2
| | | | | | | | | | | | | | This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
* Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky2014-10-231-2/+2
| | | | | | | | | | | | This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
* fdo#84854 it seems long is not enough on 32 bitDavid Tardon2014-10-161-2/+2
| | | | | | | Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
* fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca2014-10-091-2/+2
| | | | | | | | | | | | | | | | | | | | | * Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
* sd: std::auto_ptr -> std::unique_ptrStephan Bergmann2014-10-011-1/+0
| | | | | | | | | | | | | | | | ToolBarManager::Implementation::Update in sd/source/ui/view/ToolBarManager.cxx is dubious. It takes its parameter by value (so in UnlockUpdate() the passed-in mpSynchronousLayouterLock is reset upon passing it in), but the comment that it "is [...] released at its end" together with the redundant pLocalLayouterLock.reset() at the end of Update() make it look as though the intention was to pass by reference. However, resetting mpSynchronousLayouterLock even in the case where pass-by-ref would fail to reset it is apparently important, as otherwise e.g. JunitTest_svx_unoapi would run into the OSL_ASSERT(mpSynchronousLayouterLock.get()==NULL) in LockUpdate() with a call stack of ... -> Update -> SetValid -> UpdateLockImplementation -> LockUpdate. Change-Id: I7d2717d5e1f8aa69c79a626c100d7fefb0cfb120
* fdo#82577: Handle RegionNoel Grandin2014-09-301-1/+1
| | | | | | | Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
* fdo#82577: Handle FontNoel Grandin2014-09-181-2/+2
| | | | | | | Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
* SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin2014-09-061-13/+8
| | | | | | | | | | Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
* remove whitespacesMarkus Mohrhard2014-06-251-54/+0
| | | | Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
* typo: arround -> aroundThomas Arnhold2014-04-141-2/+2
|
generated by cgit (git 2.34.1) at 2024-09-18 12:27:28 +0000