summaryrefslogtreecommitdiffstats
path: root/sd/source/ui/tools/EventMultiplexer.cxx
Commit message (Collapse)AuthorAgeFilesLines
* Remove dynamic exception specificationsStephan Bergmann2017-01-261-15/+5
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* OSL_TRACE->SAL in sd..sdextNoel Grandin2016-12-121-4/+4
| | | | | | | Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8 Reviewed-on: https://gerrit.libreoffice.org/31898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#104046 - Slides in the slide pane don't update in realtimeNoel Grandin2016-12-121-41/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This appears to be a consequence of my change commit 942716fee138b68c2af9411384f402b5692a88b2 convert EID constants to typed_flags in that change I made a "fix": @@ -689,20 +687,20 @@ void EventMultiplexer::Implementation::CallListeners (EventMultiplexerEvent& rEv ListenerList::const_iterator iListenerEnd (aCopyListeners.end()); for (; iListener!=iListenerEnd; ++iListener) { - if ((iListener->second && rEvent.meEventId)) + if (iListener->second & rEvent.meEventId) iListener->first.Call(rEvent); } } which causes this bug. I should have noticed that my "fix" indicates that the event filtering part of this multiplexing code was never working, and since no-one has ever complained about, lets just remove all of this unnecessary complexity. Change-Id: Id71613d4fd5817ee1358705059e4ce63d57573ad Reviewed-on: https://gerrit.libreoffice.org/31894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert SFX_HINT to scoped enumNoel Grandin2016-12-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove pParentFrame from SfxFrameNoel Grandin2016-11-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Found by the singlevalfields loplugin. Dead as least as far back as commit 93a7b558588be1f12e137329548b706daccc07df Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Fri Nov 27 21:16:24 2009 +0100 [CWS autorecovery] merged SfxTopFrame into SfxFrame SfxTopFrame was the only class deriving from the abstract class SfxFrame, so both can effectively be treated as one class. Arguably when that commit was done, SfxFrame should also have been renamed to SfxTopFrame, since that it was it now seems to be. Expanding the nullptr value off that field means that: SfxFrame::GetTopFrame always return this SfxFrame::IsParent always returns false SfxViewFrame::GetTopFrame is now the same as SfxViewFrame::GetFrame SfxViewFrame::GetParentViewFrame now returns null Change-Id: Iac088fa485c3d7299d1553845ced2f5ced3c85f2 Reviewed-on: https://gerrit.libreoffice.org/30485 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethods in sdNoel Grandin2016-10-281-18/+6
| | | | | | | Change-Id: I87a537928bdf42285448bba7cb50c497f2637c3c Reviewed-on: https://gerrit.libreoffice.org/30330 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert EID constants to typed_flagsNoel Grandin2016-10-121-34/+32
| | | | Change-Id: I3bcccd8836e54dd33bb079856226fbedd574c824
* Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann2016-10-051-2/+2
| | | | | | | | | ...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
* perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke2016-09-231-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-131-1/+1
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* drop extraneous acquireDavid Tardon2016-08-301-1/+0
| | | | Change-Id: I1f26d0994f5895f8bb8ccd6c2ddce7fc1ec24ecc
* convert SdrHintKind to scoped enumNoel Grandin2016-08-221-6/+6
| | | | Change-Id: I77ad33425d440263a71bc94f41d8e141f16dfb78
* -Werror,-Wunused-private-fieldStephan Bergmann2015-11-241-2/+0
| | | | Change-Id: I592db0524cb1d028e7dd3c3d49457f4a4038d5be
* loplugin:unusedfields in sd/Noel Grandin2015-11-231-8/+3
| | | | Change-Id: Id6da990828ece02132032285116f3a20de423519
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-11/+11
| | | | Change-Id: If1b80da64ba575f07b31dce9bc0e34b7eb9f11a4
* yyyyyNoel Grandin2015-11-041-4/+4
| | | | Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
* com::sun::star->css in sdNoel Grandin2015-10-291-27/+23
| | | | Change-Id: Ic0cbc857a3a9c66241b94c30bf8c859435f5a4b4
* cppcheck: noExplicitConstructorCaolán McNamara2015-10-181-1/+1
| | | | Change-Id: I187273e39759b3a3ef45b047f8cc36829a7f0b10
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-121-7/+7
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* convert Link<> to typedNoel Grandin2015-09-221-4/+3
| | | | | | | Change-Id: I6f17e073c50e28f40e3df4e557a63f0bcdc502de Reviewed-on: https://gerrit.libreoffice.org/18778 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* convert Link<> to typedNoel Grandin2015-09-171-8/+8
| | | | Change-Id: I66e81dafa08b2e2a43b4b696741676e093439024
* sd: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe2015-08-311-2/+2
| | | | | | | | | with the variadic variants. Change-Id: I01909ee45c31d17356e13b1ff2430440daff9aa7 Reviewed-on: https://gerrit.libreoffice.org/18146 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* new loplugin: refcountingNoel Grandin2015-08-031-6/+0
| | | | | | | | | | | | | | This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Gradually typed LinkStephan Bergmann2015-04-301-7/+7
| | | | | | | | | | | | | | | | | Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-151-13/+13
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* sd: std::auto_ptr -> std::unique_ptrStephan Bergmann2014-10-011-1/+1
| | | | | | | | | | | | | | | | ToolBarManager::Implementation::Update in sd/source/ui/view/ToolBarManager.cxx is dubious. It takes its parameter by value (so in UnlockUpdate() the passed-in mpSynchronousLayouterLock is reset upon passing it in), but the comment that it "is [...] released at its end" together with the redundant pLocalLayouterLock.reset() at the end of Update() make it look as though the intention was to pass by reference. However, resetting mpSynchronousLayouterLock even in the case where pass-by-ref would fail to reset it is apparently important, as otherwise e.g. JunitTest_svx_unoapi would run into the OSL_ASSERT(mpSynchronousLayouterLock.get()==NULL) in LockUpdate() with a call stack of ... -> Update -> SetValid -> UpdateLockImplementation -> LockUpdate. Change-Id: I7d2717d5e1f8aa69c79a626c100d7fefb0cfb120
* SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin2014-09-061-8/+8
| | | | | | | | | | Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
* remove whitespacesMarkus Mohrhard2014-06-251-74/+0
| | | | Change-Id: I9daea42a433b5032931a722878874917cf37f4d1
* Explicitly mark overriding destructors as "virtual"Stephan Bergmann2014-04-011-1/+1
| | | | | | | | It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
* Second batch of adding SAL_OVERRIDE to overriding function declarationsStephan Bergmann2014-03-271-7/+7
| | | | | | | ...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
* cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann2014-02-261-10/+10
| | | | Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
* bool improvementsStephan Bergmann2014-01-171-1/+1
| | | | Change-Id: I19b429741a2ba972bef8863008657823b9bb7f91
* use uno::Reference#clear() method...Noel Grandin2013-06-051-1/+1
| | | | | | ...instead of assigning an empty value. Reduces code noise. Change-Id: Ic95b081a41fb740a738c92b3407a9514ccb8b06e
* mass removal of rtl:: prefixes for O(U)String*Luboš Luňák2013-04-071-5/+4
| | | | | | | | Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
* re-base on ALv2 code. Includes:Michael Meeks2012-11-281-23/+14
| | | | | | | | | | | | | | | | | | | | | | | Patches contributed by Armin Le-Grand #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles... http://svn.apache.org/viewvc?view=revision&revision=1293316 #118485# - Styles for OLEs are not saved. http://svn.apache.org/viewvc?view=revision&revision=1182166 Patches contributed by Andre Fischer http://svn.apache.org/viewvc?view=revision&revision=1172128 http://svn.apache.org/viewvc?view=revision&revision=1172133 Patch contributed by Ariel Constenla-Haile i#118505# - Remove MN_OLE_OBJECT menu item from Draw/Impress contextmenu - CWS contextmenu1 http://svn.apache.org/viewvc?view=revision&revision=1182915 Patch contributed by Zhang Jian Fang #118876#, Add check if the OutlinerParaObject is created successfully http://svn.apache.org/viewvc?view=revision&revision=1243381 restore a re-based rdbedit.
* More RTL_CONSTASCII_USTRINGPARAM removalsOlivier Hallot2012-04-081-2/+1
|
* Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operatorSzabolcs Dezsi2012-04-061-2/+2
| | | | | | Pattern used: find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
* remove static objects from static_initialization_and_destruction chainCaolán McNamara2012-04-021-13/+8
|
* New IMPL_LINK_NOARG to work around SAL_UNUSED_PARAMETER problemStephan Bergmann2012-03-011-1/+1
| | | | | ...see ebe26f72e90337da2d14f3029de148904e3e30b6 "WaE: 'unused' attribute ignored when parsing type" for the problem.
* remove include of pch header from sdNorbert Thiebaud2011-11-271-2/+0
|
* catch by const referenceCaolán McNamara2011-06-201-7/+7
|
* Add vim/emacs modelines to all source filesSebastian Spaeth2010-10-131-0/+3
| | | | | | | | Fixes #fdo30794 Based on bin/add-modelines script (originally posted in mail 1286706307.1871.1399280959@webmail.messagingengine.com) Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
* autorecovery: merged changes from m74. Still need to find out how to re-do ↵Frank Schoenheit [fs]2010-03-111-4/+1
|\ | | | | | | two patches (to module_hidden_ooo.scp and file_ooo.scp in scp2/source/ooo) which do not apply anymore.
| * changefileheader2: #i109125#: change source file copyright notice from Sun ↵Jens-Heiner Rechtien2010-02-121-4/+1
| | | | | | | | Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision)
* | autorecovery: Sfx(View)Frame::GetTopFrame now also returning a SfxFrame& ↵Frank Schoenheit [fs]2009-12-151-1/+1
|/ | | | instead of an SfxFrame*
* CWS-TOOLING: integrate CWS impress174Oliver Bolte2009-09-091-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2009-08-27 18:21:38 +0200 af r275502 : #i73289# Fixed detection of the cases when the layout menu is be disabled. 2009-08-24 17:45:50 +0200 sj r275326 : #i103360# only setting filltype if there is also a correct fill element 2009-08-24 16:11:06 +0200 cl r275322 : #i73871# only remove replaced objects from mark list if replaced by SdrEditView::ReplaceObjectAtView(). see issue for reason 2009-08-24 15:03:33 +0200 cl r275319 : fixed merge error 2009-08-20 12:45:29 +0200 sj r275174 : CWS-TOOLING: rebase CWS impress174 to trunk@275001 (milestone: DEV300:m55) 2009-08-19 15:54:47 +0200 sj r275153 : #158486# text of flipped shapes is not flipped in word 2009-08-17 17:30:16 +0200 sj r275063 : #158486# also correcting text bound for additional text rotation 2009-08-05 11:09:32 +0200 sj r274643 : #i102797# adapted customshape coloring (fixed fontwork) 2009-08-04 14:17:36 +0200 sj r274620 : #i99501# pdf export: fixed export of rotated graphics 2009-07-30 16:15:44 +0200 sj r274494 : #158653# binary ppt import: fixed table border lines 2009-07-27 18:28:02 +0200 sj r274376 : added shape text clipping for customshapes 2009-07-20 18:09:14 +0200 sj r274154 : #i101918# fixed gallery preview (now taking the correct mapmode) 2009-07-13 18:00:58 +0200 cl r273948 : #i103238# clear hard set attributes only if new style set is manually applied 2009-07-13 17:58:07 +0200 cl r273947 : #i73289# do not expand a toolpanel when it gets enabled 2009-07-08 12:39:49 +0200 sj r273827 : #i101566# applied patch from cmc to solve font width inconsistencies 2009-07-08 12:11:13 +0200 sj r273826 : #i87727# added PDFDialog service 2009-07-06 17:22:40 +0200 sj r273755 : #i103360# fixed a merge problem, no more looping when loading transparence gradients on background page 2009-07-03 14:42:07 +0200 sj r273701 : #102797# added patch from thb (Adapted customshape coloring) 2009-07-03 14:09:44 +0200 sj r273696 : #102797# removed warning 2009-07-03 14:01:47 +0200 sj r273695 : #102797# added patch from thb (Adapted customshape coloring) 2009-07-03 13:13:39 +0200 sj r273688 : #102797# added patch from thb (Adapted customshape coloring) 2009-07-03 11:25:30 +0200 sj r273684 : #i103278# fixed import of lines 2009-07-01 16:23:47 +0200 cl r273599 : #i96820# correctly call setChanged on model if table is modified 2009-07-01 14:43:09 +0200 cl r273588 : #i8770# Patch: fix missing type provider for pdf export dialog 2009-07-01 14:40:28 +0200 cl r273586 : #i73871# activate picture bar after converting shape to bitmap 2009-07-01 14:39:05 +0200 cl r273584 : #i73871# activate picture bar after converting shape to bitmap 2009-07-01 14:04:53 +0200 cl r273578 : #i73289# PATCH: Disable layout pane on the masterslide
* INTEGRATION: CWS changefileheader (1.15.234); FILE MERGEDRüdiger Timm2008-04-111-23/+18
| | | | | | 2008/04/01 15:36:10 thb 1.15.234.3: #i85898# Stripping all external header guards 2008/04/01 12:39:23 thb 1.15.234.2: #i85898# Stripping all external header guards 2008/03/31 13:59:05 rt 1.15.234.1: #i87441# Change license header to LPGL v3.
* INTEGRATION: CWS presenterview (1.15.22); FILE MERGEDKurt Zenker2008-04-031-12/+11
| | | | 2007/06/19 08:58:20 af 1.15.22.1: #i18486# Added EID_CONFIGURATION_UPDATED.
* #i76152# Avoid warning ''nEventType' may be used uninitialized in this ↵Rüdiger Timm2007-04-101-3/+3
| | | | function'.
* INTEGRATION: CWS components1 (1.11.50); FILE MERGEDRüdiger Timm2007-04-031-85/+152
| | | | | | | | | | | 2007/02/16 14:09:02 af 1.11.50.8: #i68075# Fixed the disposing() method. 2007/01/29 17:31:31 af 1.11.50.7: #i68075# Handle the disposing of the configuration controller. 2007/01/25 15:28:04 af 1.11.50.6: RESYNC: (1.12-1.13); FILE MERGED 2007/01/24 17:52:54 af 1.11.50.5: #i68075# Introduction of XResourceId interface. 2007/01/22 16:56:06 af 1.11.50.4: #i68075 Introduction of XResourceId interface. 2006/09/25 17:34:08 af 1.11.50.3: RESYNC: (1.11-1.12); FILE MERGED 2006/09/07 14:51:54 af 1.11.50.2: #i68075# Transition from URL to ResourceId. 2006/08/22 12:32:26 af 1.11.50.1: #i68075# Transition to new drawing framework.
generated by cgit (git 2.34.1) at 2024-09-18 12:22:47 +0000