summaryrefslogtreecommitdiffstats
path: root/scripting
Commit message (Collapse)AuthorAgeFilesLines
* cppcheck:redundantAssignmentNoel Grandin2015-06-151-4/+1
| | | | Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
* java: 'final static' to 'static final'Noel Grandin2015-06-152-5/+5
| | | | | | | | | this is the canonical order, and it makes the code easier to read Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470 Reviewed-on: https://gerrit.libreoffice.org/16242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
* java:regulatize the order of 'final' and public/privateNoel Grandin2015-06-113-4/+4
| | | | | | | | | | Make the order be 'public static' or 'private static' Just makes the code nicer to read. Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2 Reviewed-on: https://gerrit.libreoffice.org/16202 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* convert expressions like 'size() == 0' to 'empty()'Noel Grandin2015-06-111-1/+1
| | | | Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-084-11/+11
| | | | Change-Id: I14d1c6f703c83bc4a0259ce68e93a315bbfdde4e
* Rewrite all calls like Dialog(params).Execute()Philippe Jung2015-05-281-1/+1
| | | | | | | | | | | | | Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks2015-05-251-1/+2
| | | | | | Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
* Remove include stdio (part2)Julien Nabet2015-05-181-2/+0
| | | | | | | Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd Reviewed-on: https://gerrit.libreoffice.org/15775 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:staticmethodsNoel Grandin2015-04-232-2/+2
| | | | Change-Id: Ib0c0841e48814d1a6e13bcd4575725d86ffa5e5e
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-152-27/+27
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* loplugin:staticmethodsNoel Grandin2015-04-133-4/+4
| | | | Change-Id: If97f01a05294fa7efd59a8934c7b6f65cda5084a
* Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann2015-04-013-5/+5
| | | | Change-Id: I936ae26f8d5d7cdd32c15e937b7cae6668b6192c
* Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2015-03-311-1/+1
| | | | Change-Id: I7d6106bda60f8cae3e110e6757b3bf267ce15ec5
* TyposJulien Nabet2015-03-251-1/+1
| | | | Change-Id: I434be0034b26ac4719590238817538ecd90b8923
* Fix various XServiceInfo implementationsStephan Bergmann2015-03-173-8/+32
| | | | | | ...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
* tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann2015-03-131-1/+3
| | | | | | | | ...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
* Clean up previous commitStephan Bergmann2015-03-123-95/+45
| | | | | | ...and add missing XServiceInfo implementations Change-Id: I719cd10b6202d94e751805e1b838eb3f193e24d1
* scripting: use constructor syntax in vbaevents.componentChris Sherlock2015-03-125-74/+21
| | | | | Change-Id: Ie27ec9ca92137e9f8666d2080fd1bc028417e337 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* pyuno, scripting: remove executable bits from python, js, bsh filesMichael Stahl2015-03-0214-0/+0
| | | | Change-Id: Id108693d84fbca7764614e126ee1b3b045baec17
* Typo: deleteing->deletingJulien Nabet2015-02-211-2/+2
| | | | Change-Id: I2bdde7524a97039c94a8da5ac5d2eba38c91d71a
* Make LogUtils.getTrace actually workStephan Bergmann2015-02-161-25/+6
| | | | Change-Id: I59e2b93ed1142bac22ead08cc101e27cfa3e02df
* rhbz#1192732: Revert "From the context of the code, this field should...Stephan Bergmann2015-02-161-1/+1
| | | | | | | | | | | | | ...not be static." This reverts commit 6d4c1f0d4a623bf7f3b3a0af2ece5c969d5aec77. Whatever made the author of that commit think rhinoWindow shouldn't be static, it clearly needs to be, as in edit()'s Runnable.run(), the usage of rhinoWindow at the end relies on rhinoWindow being set via the new ScriptEditorForJavaScript(context, url) call to initUI() (or else rhinoWindow already being set from a previous such call if already editor != null).
* loplugin:deletedspecialStephan Bergmann2015-02-072-4/+4
| | | | Change-Id: I862b29974c770aea7396f2d650208b1f3e1f4e4b
* scripting: remove unnecessary SAL_CALLMichael Stahl2015-01-292-2/+2
| | | | Change-Id: Ic1fbb36a509ec1dce63f1c7fa4a8955a4780517d
* Fix types of functions called via pointer (-fsanitze=function)Stephan Bergmann2015-01-261-4/+2
| | | | Change-Id: Ife0151a04477ce30bb132e6dfae9f4d3a74bf4b0
* new loplugin: change virtual methods to non-virtualNoel Grandin2015-01-262-2/+2
| | | | | | | | | | Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
* typo: langugage -> languageAndras Timar2015-01-231-2/+2
| | | | Change-Id: Ifabd5a7851946b3e4109e22e6e9a1ff34575c1e5
* fdo#88256 fix crash when running javascript macroNoel Grandin2015-01-135-6/+49
| | | | | | | caused by my commit 8583da1e934a49791ef8d86668f3d5c3c5dae1d7 "java: remove unused fields" Change-Id: Ibcd6462e8229a0a6cb98ebfd16ce5d2ea45ca931
* cppcheck: Possible inefficient checking for <var> emptinessJulien Nabet2015-01-043-3/+3
| | | | Change-Id: I6ca0e477a4429e762c48c721951b9876db3a5c6c
* boost::unordered_map->std::unordered_mapCaolán McNamara2015-01-046-34/+24
| | | | Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
* fdo#39440 reduce scope of local variablesMichael Weghorn2014-12-212-2/+2
| | | | | | This addresses some cppcheck warnings. Change-Id: I390607e002e93cf7a6babc26d9be084d9f185058
* java: scripting: fix bug in removing model from mapNoel Grandin2014-12-191-1/+1
| | | | | | found by PMD Change-Id: I4bd35dd30f6c77aad96932216d8459b812004a88
* scripting: Use appropriate OUString functions on string constantsStephan Bergmann2014-12-184-5/+5
| | | | Change-Id: Iacb434225e779de4911e9acc8431662f5eabcee3
* scripting: Use appropriate OUString functions on string constantsStephan Bergmann2014-12-153-7/+7
| | | | Change-Id: I8ee8eb92ac95937893c894e67882e9df2c16a67d
* java: revert part of commit, scripting/ is public APINoel Grandin2014-12-112-5/+5
| | | | | | | | revert part of my commit 7557f23b31dcfb4d86c122bb34d9675c0db9a694 "java: reduce visibility of fields and methods" Change-Id: I2049a154b60b165d4d2217495935442d6da66e97
* java: reduce visibility of fields and methodsNoel Grandin2014-12-112-4/+4
| | | | | | | | | found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* java: unused importsNoel Grandin2014-12-101-1/+0
| | | | | | | Change-Id: I05824a6f19a5f3048a52101b96f6bf3d3099df08 Reviewed-on: https://gerrit.libreoffice.org/13403 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* java: remove some unused local variablesNoel Grandin2014-12-057-28/+12
| | | | Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
* java: remove some unused fieldsNoel Grandin2014-12-051-4/+0
| | | | Change-Id: I1b6fb6b47439c448ac31983702772e2115c70d56
* pyuno: move "officehelper.py" from scripting to pyunoMichael Stahl2014-12-022-85/+0
| | | | | | | | | | | | | | ... because at least in Fedora packages with system python it's a pain to use officehelper.bootstrap() because unlike pyuno it is not installed in the standard python directories but in libreoffice/program. You might think that bootstrap() is not appropriate functionality for a UNO langauge binding, but then why does ::cppu::bootstrap() exist? Change-Id: I5fd4b344a811c087d32fb6304e55105ab3cb137e Reviewed-on: https://gerrit.libreoffice.org/12968 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* java: final fields that can be staticNoel Grandin2014-11-251-1/+1
| | | | | | | | | found by PMD Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f Reviewed-on: https://gerrit.libreoffice.org/13099 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* java: make fields final where possibleNoel Grandin2014-11-1824-54/+52
| | | | | | found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
* sal: clean up public headers with include-what-you-useMichael Stahl2014-11-173-0/+3
| | | | | | | | | Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
* Fix common typos. No automatic tools. Handmade…Andrea Gelmini2014-11-122-2/+2
| | | | | | | Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* java: convert fields to local variables where possibleNoel Grandin2014-11-121-3/+0
| | | | | | | | | found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* java: reduce excessive code indentation levelsNoel Grandin2014-11-121-14/+15
| | | | | | | | | by using early return in some methods Change-Id: I3611c8c89b3a94ef7e1772d178acf065fd7fcdc7 Reviewed-on: https://gerrit.libreoffice.org/12374 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* fdo#38835 strip out OUString globalsNoel Grandin2014-11-054-58/+19
| | | | | | | they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
* coverity#1237350 use our double-locking templates for thisCaolán McNamara2014-10-242-23/+25
| | | | Change-Id: I589468e9663ffd01a237a1684345985396bc4eac
* Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist2014-10-221-1/+1
| | | | | | | | Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
* scripting: redundant cast to StringRobert Antoni Buj i Gelonch2014-10-192-5/+5
| | | | | | | Change-Id: I5e048964cc7885a32c59ff8a9eb1fc5b9523e843 Reviewed-on: https://gerrit.libreoffice.org/11859 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>