summaryrefslogtreecommitdiffstats
path: root/sc/source/ui/undo
Commit message (Collapse)AuthorAgeFilesLines
* convert SvxCellVerJustify to scoped enumNoel Grandin2017-09-151-1/+1
| | | | | | | Change-Id: I9d1cdb4ddfee43b7a0990624d7d16e06679343c4 Reviewed-on: https://gerrit.libreoffice.org/42276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy modernize-use-emplace in scNoel Grandin2017-09-121-1/+1
| | | | | | | Change-Id: Ifc38e1fc188fe957a0c717aec19cdd6637e4c658 Reviewed-on: https://gerrit.libreoffice.org/42183 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#107952: Move cursor to changed cell after undo/redo in ScUndoSetCellDennis Francis2017-09-071-0/+12
| | | | | | | Change-Id: Id9f2ba2ed2d77f03c9bd56c41b958aa23921da0d Reviewed-on: https://gerrit.libreoffice.org/42014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Dennis Francis <dennis.francis@collabora.co.uk>
* loplugin:constparam in sc part6Noel Grandin2017-08-257-11/+11
| | | | | | | Change-Id: Ifbb921b820b7210e7f9539e45d4852764a1e9cbd Reviewed-on: https://gerrit.libreoffice.org/41563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparamNoel Grandin2017-08-081-15/+1
| | | | | | | Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Related: tdf#109856 redo 'insert multiple tabs after' inserts too many tabsCaolán McNamara2017-08-011-1/+0
| | | | | | | Change-Id: I50e8941408343f8fa9acf017d7c195279952916d Reviewed-on: https://gerrit.libreoffice.org/40626 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:unusedmethodsNoel Grandin2017-07-261-42/+0
| | | | | | | Change-Id: I7f26ee112ed89ee3e69c56930260565f66ff145b Reviewed-on: https://gerrit.libreoffice.org/40442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields in scNoel Grandin2017-07-251-8/+1
| | | | | | | | | | | | | | | | | | | | The *chart* fields in ScTabViewShell in sc/source/ui/inc/tabvwsh.hxx are unused since: commit 5021f298418f6efa7bb7b6540113b712599778fe Author: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Date: Mon Jul 28 12:11:08 2014 -0300 Remove some unused code The bEveryoneButMe field in ScChangeViewSettings is unused since commit 90e8ad7ab779740c7381d26ffe7d08acc3a9ff96 Author: Noel Grandin <noel@peralex.com> Date: Tue Jul 21 15:39:17 2015 +0200 loplugin:unusedmethods scripting,sc Change-Id: Ie9fbdf8f5e9177449316aaeb40ca3bd26df78a95 Reviewed-on: https://gerrit.libreoffice.org/40264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* migrate to boost::gettextCaolán McNamara2017-07-215-25/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
* extend loplugin useuniqueptr to POD typesNoel Grandin2017-07-142-11/+6
| | | | | | | Change-Id: I6ff24f048bd8f75bf87a78b718f37b57855d4781 Reviewed-on: https://gerrit.libreoffice.org/39932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more OUString::operator== in scNoel Grandin2017-07-141-4/+4
| | | | | | | Change-Id: I1a7691fe59e5e93c15bd812f03366da814f9f3db Reviewed-on: https://gerrit.libreoffice.org/39900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in scNoel Grandin2017-07-131-6/+1
| | | | | | | Change-Id: I004e1f0292c8a40515880546574255ab835dbdbe Reviewed-on: https://gerrit.libreoffice.org/39875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach unnecessaryparen loplugin about identifiersNoel Grandin2017-07-103-5/+5
| | | | | | | Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* C++11 remove std::unary_function bases from functorsJochen Nitschke2017-07-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | std::unary_function is deprecated since C++11 and removed in C++17 90% done with regexp magic. removed obsolete <functional> includes. The std::unary_function base class was used in 3 places: * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole is used in a std::not1 function helper who uses the members return_type and argument_type. - replace deprecated std::not1 with a lambda * chart2/source/tools/ModifyListenerHelper.cxx: lcl_weakReferenceToSame used the argument_type member in the operator() parameter. - inline the parameter type. * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement used result_type and argument_type in operator(). - inline the types Also fix compile error with gcc about finding std::for_each. Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f Reviewed-on: https://gerrit.libreoffice.org/39358 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:casttovoid: scStephan Bergmann2017-07-021-1/+0
| | | | Change-Id: I1dddf4431ccbcea8a5d89d2849307efba592cae9
* loplugin:oncevar in scNoel Grandin2017-06-263-7/+3
| | | | | | | Change-Id: Ice59e286debb6bd0eb692f2b2b0c2c5087c069c0 Reviewed-on: https://gerrit.libreoffice.org/39239 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* 2nd arg of ApplySelectionFrame is always not nullCaolán McNamara2017-06-062-2/+2
| | | | Change-Id: I50a5c9c3f0f2b7424fa1b9b27ceeee9ae9348413
* coverity#1412032 ApplyPatternLines always passed non-null 2nd argCaolán McNamara2017-06-061-1/+1
| | | | | | | Change-Id: Ibf1754682a0d586a377709b8dacee1260a1f2ee1 Reviewed-on: https://gerrit.libreoffice.org/38445 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* clang-tidy performance-unnecessary-value-paramNoel Grandin2017-06-051-2/+2
| | | | | | | Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringcopy: scStephan Bergmann2017-05-192-3/+3
| | | | Change-Id: Ic6cb5406d20e7e07b8e34514df71adf1c3a4e727
* sc lok: Don't crash on comment undo.Jan Holesovsky2017-05-171-1/+1
| | | | | | | Change-Id: I3b8686e2d52359de2d99413e63d4a424ba1439d1 Reviewed-on: https://gerrit.libreoffice.org/37710 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
* lok: sc: invalidate col/row header on undo row/col operationsMarco Cecchetti2017-05-162-1/+23
| | | | | | | Change-Id: Ia0b2174cfcc3f2b3075e8f6eee1eb0f56b64db44 Reviewed-on: https://gerrit.libreoffice.org/37686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* Revert "lok: sc: invalidate col/row header on undo row/col operations"Stephan Bergmann2017-05-162-23/+1
| | | | This reverts commit 76d47e6f63e11d3509339ade6203757d63582d21, breaks the build.
* lok: sc: invalidate col/row header on undo row/col operationsMarco Cecchetti2017-05-162-1/+23
| | | | | | | Change-Id: Ifabce9941541a615840163168af6fedaf54575cd Reviewed-on: https://gerrit.libreoffice.org/37243 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* remove unused uno::Reference varsNoel Grandin2017-05-121-3/+2
| | | | | | | | | found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove some unnecessary temporary OUStringsNoel Grandin2017-05-111-2/+2
| | | | | | | | | | found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* partial revert of "loplugin:checkunusedparams in sc(part4)"Noel Grandin2017-05-101-2/+2
| | | | | | | | | | | | | | <erAck> noelgrandin: actually that "also fix bug in ScDocShell::DBAreaDeleted" with 4d047221945b34a9023d852bbd19a2a24a7f54c3 wasn't a bug because the aDocument.RemoveFlagsTab() call with ScMF::Auto removes the AutoFilter which is in the first row of the DB-Area <erAck> noelgrandin: now it unnecessarily processes the entire range <noelgrandin> erAck, does that also apply to the PostPaint call? <erAck> noelgrandin: should so, as only the row with the AF-buttons needs to be repainted <noelgrandin> erAck, will revert that part Change-Id: I29b9ee4e1b6517a01bf67f8efc09217d9df453a5
* loplugin:checkunusedparams in sc(part1)Noel Grandin2017-05-101-2/+2
| | | | | | | Change-Id: I8c4fca704fe8ed6f861728cc3f3782c676aba67c Reviewed-on: https://gerrit.libreoffice.org/37435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* sc lok: Add/Remove comment uno undo/redoPranav Kant2017-04-131-0/+2
| | | | Change-Id: I34a32ebecae44fd80789ed7daf13f31b181cd4c0
* tdf#92650: handle overwritten references correctly in undo.Kohei Yoshida2017-04-131-1/+1
| | | | | | | Change-Id: Idc3fbd78f8163c97a9cd80a3ff474b6da0349353 Reviewed-on: https://gerrit.libreoffice.org/36496 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
* rename ScCaptionPtr (mb|set)InUndo to (mb|set)NotOwnerEike Rathke2017-04-111-4/+4
| | | | | | ... which better suits the general purpose we'll need Change-Id: I32805c91d17180d5f18225a02c8a436826242e19
* flag ScCaptionPtr::setInUndo() in ScUndoReplaceNoteEike Rathke2017-04-101-1/+12
| | | | Change-Id: I174be1262074e1fed784806d2f052b36749dff0d
* support undo of whole conditional format list, tdf#95617Markus Mohrhard2017-04-081-0/+60
| | | | | | | Change-Id: I3ff0ddb05f794064e33164c60cd1b4e6b89dbcca Reviewed-on: https://gerrit.libreoffice.org/36295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#39468 Translate German commentsJens Carl2017-04-051-1/+1
| | | | | | | | | Translate German comments and terms in sc/source/core and sc/source/ui Change-Id: I214565e73893688963d99c0f0ddfc356b5ad63be Reviewed-on: https://gerrit.libreoffice.org/36107 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* convert ViewShellId to o3tl::strong_intNoel Grandin2017-03-242-3/+3
| | | | | | | Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop GetId() from SfxUndoActionNoel Grandin2017-03-163-21/+0
| | | | | | | | | | | mostly so that the subclasses can use proper enum types for their own IDs. It turns out that nothing at the svl/sfx2 level needs an ID anyhow. Change-Id: I3c020aeafb812fa30d896216d4e3bc1a82cbfeab Reviewed-on: https://gerrit.libreoffice.org/35222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert SvxCellHorJustify to scoped enumNoel Grandin2017-03-091-1/+1
| | | | | | | Change-Id: I0dd88b5bf9e1aededfa2d94b6b2d3d26694fff33 Reviewed-on: https://gerrit.libreoffice.org/34968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:loopvartoosmallStephan Bergmann2017-03-071-5/+3
| | | | Change-Id: I81b56ad2a32ef61a514d5e6e9f45c3f956126040
* typesafe wrappers for css::i18nutil::TransliterationModulesNoel Grandin2017-03-011-1/+1
| | | | | | | | | | | | | | | | | and related css::util::SearchOptions2 The TransliterationModules enum has it's constants spread over multiple UNO enum/constant-collections - TransliterationModules and TransliterationModulesExtra, which means that most code simply uses sal_Int32. Wrap them up into a better bundle so that only the lowest layer needs to deal directly with the UNO constants. Change-Id: I1edeab79fcc7817a4a97c933ef84ab7015bb849b Reviewed-on: https://gerrit.libreoffice.org/34582 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* a first stab against the note caption ownership messEike Rathke2017-02-241-6/+6
| | | | | | | | | | | | | | | | This should not change any existing behavior, but may help tracking down what happens where and when. The final goal is to let ScCaptionPtr also handle deletion of caption objects once they're unreferenced and guard against dangling pointers and double delete, and/or to manage transfer of ownership to the drawing layer. Further improvement to the structure could involve a head data element so that the duplicated (and unused except in head) mnRefs field could be eliminated and the walk simplified when removing an element from the list. Change-Id: Ifbb2fb1d9dc4d2594a1eae2a8489270dd1fe0d0c Reviewed-on: https://gerrit.libreoffice.org/34616 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* use std::unique_ptrCaolán McNamara2017-02-224-441/+334
| | | | | | | Change-Id: I11a58aa38f931c7912e2e5ac6df46f98e6bb681e Reviewed-on: https://gerrit.libreoffice.org/34539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#105667 forget target area's caption pointer in Merge UndoEike Rathke2017-02-181-1/+7
| | | | | | | It's the same that was copied to the Undo document, so don't delete the caption. Change-Id: Ib89870ed6e392c4271de2f416c78d42135922609
* split sc.hrc into definitely resources and maybe slotsCaolán McNamara2017-02-161-1/+1
| | | | Change-Id: Ic5a4ab631735cf8ef8f39424c7470e47f2f11c2d
* tdf#76183: refresh objects' positions on optimal height recalcMike Kaganski2017-02-133-2/+17
| | | | | | | | | | | | Since commit b10833d4db6046f2d32ea44a60cb19a626d80447, it's required to detect when objects' placement should be adjusted, and call SetDrawPageSize manually. Unit test included Change-Id: I933ba4802b212400cc47ed0fb7e1f8f44049bb81 Reviewed-on: https://gerrit.libreoffice.org/34165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-311-1/+1
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin: useuniqueptr: sc part 2Noel Grandin2017-01-196-32/+7
| | | | | | | Change-Id: I37936a297027313e2a8ae18f355567462955739e Reviewed-on: https://gerrit.libreoffice.org/33203 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#104967 preserve isolated notes data in clipboard when closing documentEike Rathke2017-01-181-1/+1
| | | | Change-Id: I0e263583e27c5103c0bb90e8fe00562e46a52d98
* New loplugin:externvar: scStephan Bergmann2017-01-091-2/+0
| | | | Change-Id: I6f9df997a957a1fa49161add2adafe228d036a30
* convert SFX_HINT to scoped enumNoel Grandin2016-12-089-43/+43
| | | | | | | | | | | | | | | | | | | | | | Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* init ScUndoRemoveMerge with range, tdf#92117 follow-upEike Rathke2016-10-261-2/+2
| | | | | | So the original selection is restored after Undo. Change-Id: Ie549a0b62da469ee38270ae089ea5abf9a6868e3