summaryrefslogtreecommitdiffstats
path: root/sc/source/filter/oox/workbookhelper.cxx
Commit message (Collapse)AuthorAgeFilesLines
* tdf#48140 Replace uno call from worksheethelper.cxxBartosz Kosiorek2016-11-211-2/+2
| | | | | | | Change-Id: Ibf738d67af6536e9300e11f8d4fa3fe79ab7099b Reviewed-on: https://gerrit.libreoffice.org/31006 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#48140 Remove not used UNO headers from filtersBartosz Kosiorek2016-11-191-4/+0
| | | | | | | Change-Id: I66e775b60343fe8ac772d8c0287ca19be58a7236 Reviewed-on: https://gerrit.libreoffice.org/30966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* remove unused BiffInputStreamNoel Grandin2016-11-031-1/+0
| | | | | | | Change-Id: If34bc1d5ea0e0153991d4891b88550e471b4ec07 Reviewed-on: https://gerrit.libreoffice.org/30489 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:singlevalfieldsNoel Grandin2016-11-021-2/+0
| | | | | | | Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76 Reviewed-on: https://gerrit.libreoffice.org/30476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Resolves: tdf#98481 Google Sheets uses OOXML t="str" differentlyEike Rathke2016-10-151-1/+16
| | | | | | | Set string results only for known good generators, otherwise recalculate. See source code comment. Change-Id: Ib89ba70fd7c3c515439498882fef90ca7c6e278d
* convert MapUnit to scoped enumNoel Grandin2016-10-051-1/+1
| | | | | | | | | | | | I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethods in sc..vclNoel Grandin2016-09-221-16/+0
| | | | | | | Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* sc: meBiff is always set to BiffType::BIFF_UNKNOWNJochen Nitschke2016-07-271-9/+0
| | | | | | | | | | | | remove meBeff and GetBiff(). adapt uses. remove enum BiffType, because only use is gone. keep BiffType symbols as comment for documetation. Change-Id: I7019a21b80fd5b5f0b92458f83dd9e34bc704731 Reviewed-on: https://gerrit.libreoffice.org/27253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:singlevalfields in sc(part2)Noel Grandin2016-07-131-25/+0
| | | | | | | | | | | the meFilterType field in WorkbookGlobals lead to a chain reaction of code removal. Change-Id: Iaa8b467c1c76cab78f8ce1796709590b666028db Reviewed-on: https://gerrit.libreoffice.org/26682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* tdf#48140 Remove unused headers from xlsx import to improve build performanceBartosz Kosiorek2016-06-081-2/+0
| | | | | | | Change-Id: Ie22dc56cceddcb91e946083c6bcf4c041545e75b Reviewed-on: https://gerrit.libreoffice.org/26001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
* tdf#42949: clean up includes in include/oox/helper with iwyuJorenz Paragas2016-05-101-0/+1
| | | | | | | | | ...and fix the many compiler errors that occurred as a result. Change-Id: I497c326272b2f02737ca3765720d6815b735423b Reviewed-on: https://gerrit.libreoffice.org/24735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:passstuffbyref in scNoel Grandin2016-04-141-2/+2
| | | | Change-Id: I75c483972db787ea9c941eaac0df023f1929b09c
* tdf#94306 Replace boost::noncopyable in sc/sourceJochen Nitschke2016-04-011-2/+6
| | | | | | | | | | | and sc/workben with C++11 delete copy ctors add default ctors needed missing delete some ctors instead of making them private Change-Id: I0a131f95444ef040e5d580d8326f372b8167e19b Reviewed-on: https://gerrit.libreoffice.org/23717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#84938 replace #define with scoped typed_flagsJochen Nitschke2016-03-221-5/+5
| | | | | | | | | | | | | 'RangeType' becomes 'Type', goes into ScRangeData and is strongly typed now. This revealed a misuse of RangeType in vbanames.cxx where the uno equivalent was expected, but it had no impact because both values were 0. Change-Id: I0b4764d1411c709a1faa243ec70afeb160410990 Reviewed-on: https://gerrit.libreoffice.org/23415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:constantparam in scNoel Grandin2016-03-101-6/+6
| | | | Change-Id: Ia7bc394fdc0dba720751c2a58d55bfe34b239098
* disable means Enable(false), not true.. tdf#98389 relatedEike Rathke2016-03-071-1/+1
| | | | | | | | | | | | | | EnableAdjustHeight(true) lead to the side effect that when clearing the range of a pivot table during import, formulas in the same rows were recalculated with then empty data. Through xSheetOp->clearContents() in PivotTable::finalizeImport() of sc/source/filter/oox/pivottablebuffer.cxx In the case of the bugdoc attached to tdf#98389 that lead to all VLOOKUP() calls resulting in #N/A errors because an empty string was looked up. Change-Id: Ie629ce871d255cc871671165c4da974f21041cec
* loplugin:privatebase: Make derivation from noncopyable explicitly privateStephan Bergmann2016-01-111-1/+1
| | | | Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-4/+4
| | | | Change-Id: I765d2a600f9c57da50c85354688e3ae796750d94
* com::sun::star->css in scNoel Grandin2015-10-281-1/+1
| | | | Change-Id: I7774890f46f9343e944e34db27af8bce3b1d0915
* WaE: Unreferenced function declaration [loplugin:unreffun]Tor Lillqvist2015-10-251-2/+0
| | | | Change-Id: Ia6baf94ada92ecd134587ed1148a2543c8c17614
* WaE: Unreferenced externally visible function definition [loplugin:unreffun]Tor Lillqvist2015-10-251-2/+0
| | | | Change-Id: I4adb1c6f3eb978429768640ca25eff7d8a5ce23e
* the cells need to be imported before we handle charts, tdf#81396Markus Mohrhard2015-10-251-51/+0
| | | | | | | | Change-Id: Ic0dc47b71e76aa4825a867fc171406d126ae0518 Reviewed-on: https://gerrit.libreoffice.org/19568 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* tdf#93688: Set CalcA1|ExcelA1 syntax only for imported docsKatarina Behrens2015-10-011-0/+10
| | | | | | | | | | those whose string ref syntax is unknown or can't be guessed i.e. don't use it for new documents (prefer user settings in that case) Change-Id: I1355031cdd63e2a5c50064531011be71ae7f7b8f Reviewed-on: https://gerrit.libreoffice.org/18923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
* boost->stdCaolán McNamara2015-09-181-3/+3
| | | | | | | | Change-Id: I7f3bb094f116103c1146a7d60e3af94c0b37d9ea Reviewed-on: https://gerrit.libreoffice.org/18677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* revert for mac and win unit case crashes after boost->stdCaolán McNamara2015-09-171-3/+3
| | | | Change-Id: I82c7084f203a834c2d42f9527705288e6036019b
* boost->stdCaolán McNamara2015-09-171-3/+3
| | | | Change-Id: I1e6a7fd66f90e6acd803c6cd464f1d73252f7bcb
* tdf#92256: Don't force CalcA1 syntax on all !Microsoft xlsx docsKatarina Behrens2015-08-141-15/+7
| | | | | | | | | | in other words, don't override user's configuration of string ref syntax Change-Id: I70281f6869663ccdaabacf506f6effcaf4b5a3fa Reviewed-on: https://gerrit.libreoffice.org/17702 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* loplugin: defaultparamsNoel Grandin2015-08-141-1/+1
| | | | Change-Id: Id5cdb8516db9e9017de06c3ab6e25f272c945677
* tdf#92256: Make sure ref syntax of Excel docs gets savedKatarina Behrens2015-08-121-1/+1
| | | | | | | SetStringRefSyntax guarantees that, as it sets also ScCalcConfig -> mbHasStringRefSyntax to true Change-Id: I44b4bd7854623a6229235ad0db9f0c4ddfbebe06
* cleanup some unnecessary direct usage of the OString/OUString C API.Noel Grandin2015-07-101-3/+2
| | | | | | | Change-Id: I6edee95aae1c169ce70063562a0c1b287e0c4735 Reviewed-on: https://gerrit.libreoffice.org/16861 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* TableRef: import OOXML table column names to ScDBDataEike Rathke2015-06-241-0/+15
| | | | Change-Id: I5fa32922fffcd027ddf1c61fe0b122fa2d320d98
* use XL_A1 as ref string syntax for excel produced documentsMarkus Mohrhard2015-05-191-0/+20
| | | | Change-Id: Ieed3521674ef713d9c09313cd41d1edd6ba3dcc5
* loplugin:staticmethodsNoel Grandin2015-05-051-1/+1
| | | | Change-Id: I912187d6c481a2ba61fed9c01998bf6f3c08a6a0
* first half of non-scriptable, Instance constructor conversion.Michael Meeks2015-04-101-2/+2
| | | | Change-Id: If73bb41bfa805e22609748f25971724b4778edb3
* vclwidget: fixup locally allocated vcl::Window objectsNoel Grandin2015-04-101-1/+1
| | | | | | They need to be wrapped in ScopedVclPtr in order to be disposed properly. Change-Id: Ib64dba353774f54711e4de7f5d15d859c6a4dc7e
* vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtrNoel Grandin2015-04-091-5/+5
| | | | | | | Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133 Conflicts: sw/qa/tiledrendering/tiledrendering.cxx
* convert EE_CNTRL constants to enum classNoel Grandin2015-03-251-1/+1
| | | | | | | | there were a couple of lines in SC and SW where the code was using a EV_CNTRL constant. I switched it to used the same-valued constant from EE_CNTRL Change-Id: I027183cc3b6e700bf365d48833e37eddc9b50f04
* Add const version of getDocImportKatarina Behrens2015-03-201-0/+5
| | | | | | Will need it for tdf#89597 Change-Id: I705d30422e2de9d5f75ac0c5c69c69ede05af48f
* shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara2015-02-061-1/+1
| | | | | | and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
* fdo#84872 give each SheetDataContext a new FormulaParserCaolán McNamara2014-10-131-2/+9
| | | | Change-Id: I120a9d0943db38571892defe1b5d3169158e3e42
* sc: std::auto_ptr -> std::unique_ptrStephan Bergmann2014-09-301-21/+21
| | | | Change-Id: I25468d578de597ff9aeba3ffc850c630fa532767
* nitpick on comment formEike Rathke2014-08-221-2/+2
| | | | Change-Id: I023f79187aaf6eb943a50516dace2aa229c5a87b
* fdo#82183 do not reset globals while loading a documentEike Rathke2014-08-221-0/+2
| | | | | | | | | Destroying the function list while an instance of the Formula Wizard is still open is a bad idea. Workaround not doing this when loading a document due to a DDE function or external reference being entered in the wizard. Change-Id: I6fa00fb4f442bf7c9410679e446ff460289e4b16
* remove unused includeMatúš Kukan2014-07-071-2/+0
| | | | Change-Id: Ia5a12fed570fcfc0db4e8080dd6cf3c2714293ab
* bnc#882595: Process VBA blobs before formula cells.Kohei Yoshida2014-06-251-6/+7
| | | | | | | So that formula cells with user-defined functions will be interpreted correctly. Change-Id: I49c10109575f9f82d7f85dea63590bf02b70e041
* new compilerplugin returnbyrefNoel Grandin2014-06-241-1/+1
| | | | | | | | | | | | | | Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
* improve the inlinesimplememberfunctions clang pluginNoel Grandin2014-06-171-6/+2
| | | | Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
* don't try to import invalid document, fdo#79135Markus Mohrhard2014-06-071-0/+2
| | | | Change-Id: I3b601d629550078a8fa353bf838619f8d7b34718
* remove boilerplate in UNO Exception constructor callsNoel Grandin2014-05-231-1/+1
| | | | | | | Now that we have default values for Exception constructor params, remove lots of boilerplate code. Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
* fix-includes.pl: scThomas Arnhold2014-05-111-7/+7
| | | | Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946