summaryrefslogtreecommitdiffstats
path: root/sc/inc
Commit message (Collapse)AuthorAgeFilesLines
...
* Replace some lists by vectors in unoobj (sc)Julien Nabet2017-09-062-4/+4
| | | | | | | Change-Id: I611f1a217ff1d5468c77f04a0c2eddd61ee33b8b Reviewed-on: https://gerrit.libreoffice.org/42025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Prefix one more member of ScDocument: pShellTor Lillqvist2017-09-051-2/+2
| | | | Change-Id: I72f2556f54e1ea4b397f9b21b1d767ae597e6e43
* Prefix one more member of ScDocument: pNoteEngineTor Lillqvist2017-09-051-1/+1
| | | | Change-Id: I93b95b8aca22df81985e4479fa6a7126eab45f0f
* Prefix one more member of ScDocument: pEditEngineTor Lillqvist2017-09-051-1/+1
| | | | Change-Id: Ib46b9b2b2b797f1d2de294819bf641f199e55dfa
* Prefix one more member of ScDocument: xPoolHelperTor Lillqvist2017-09-051-2/+1
| | | | Change-Id: Id1a216e909d5c0a6bafa80d1e40613fb38ceb1ef
* Apostrophe ' is invalid as first or last character in sheet name, tdf#103027Eike Rathke2017-09-041-1/+1
| | | | | | So hint in dialog. Change-Id: I04c85c9fc8d89ecc1be4d8d7fddc58672314d2dc
* loplugin:unnecessaryparen include c++ castsNoel Grandin2017-09-041-2/+2
| | | | | | | Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb Reviewed-on: https://gerrit.libreoffice.org/41874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* dynamic column container: fix some more for loopsNoel Grandin2017-09-022-1/+4
| | | | | | | | | and add reverse-iterator functionality Change-Id: Ide7ee9d2152871d414246303d76c91da36557524 Reviewed-on: https://gerrit.libreoffice.org/41727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make sure parent element is staying aroundMarkus Mohrhard2017-09-021-1/+1
| | | | | | | | | | If we use a reference to the object we need to ensure that it not suddenly disappears on us. Change-Id: I7917fc696b0cc48dd26fa332c892f09727e40054 Reviewed-on: https://gerrit.libreoffice.org/41820 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
* Harmonize capitalization of spreadsheet function UI parameter namesEike Rathke2017-09-011-519/+519
| | | | | | Also remove _ underscores in names and few better suiting renaming. Change-Id: Ic0b48f98c0b07404f3e0981d95fa5f3e5aa828f5
* make the ScColumnsRange iterator return SCCOLNoel Grandin2017-08-312-10/+27
| | | | | | | | | | | since we don't want to expose internal details like the ScColumn to most of the code, make the ScColumnsRange iterators return SCCOL instead of ScColumn* Change-Id: I67a58df90959170105255d18e7dd38ef0d6e3c11 Reviewed-on: https://gerrit.libreoffice.org/41719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
* fix ScJumpMatrixToken memory handlingNoel Grandin2017-08-301-5/+4
| | | | | | | | | | | | | | ScJumpMatrixToken unconditionally deletes the ScJumpMatrix pointer it receives. But it's copy constructor also just copies that pointer, meaning that we could end up freeing that pointer twice. ScJumpMatrix has no copy constructor, so I just managed it via shared_ptr. Change-Id: I9cf13312afb4f2869fdc878e5f34060614e31842 Reviewed-on: https://gerrit.libreoffice.org/41728 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#108352: Structure of pivot table coming from XLS is altered in LOTamás Zolnai2017-08-301-0/+2
| | | | | | | Change-Id: I001daeaa12cd41cc36033a26457f960d8b8a5c0e Reviewed-on: https://gerrit.libreoffice.org/41713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* remove some unused macro definitionsNoel Grandin2017-08-291-1/+0
| | | | | | | Change-Id: I253e5108161b932e3dc588b656e550bb9dc022b0 Reviewed-on: https://gerrit.libreoffice.org/41672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Use 1-based numbers in the ScAddress debugging output operator <<Tor Lillqvist2017-08-291-3/+3
| | | | Change-Id: If9f685bc504d9da8011c1788dfb90dc29b86e9ea
* Export to PNG: export selected cell range only, not as page, tdf#108317Eike Rathke2017-08-291-1/+2
| | | | Change-Id: If662f4ed360c702e572fc5d7b473eb53b9cb14d2
* remove unused header fileNoel Grandin2017-08-281-28/+0
| | | | | | | | | | | | | ever since commit 678dbe8f8197815919d7179c2eba17679942fdaa Date: Thu Oct 13 09:50:03 2016 +0100 unused src file Change-Id: I648f5b22d6d717404ec14f7775dfa0502295c2eb Reviewed-on: https://gerrit.libreoffice.org/41616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* convert code-class in ErrCode to scoped enumNoel Grandin2017-08-272-43/+43
| | | | | | | Change-Id: I9aa8703921308d6fee8bae9ee2d7b29e19181cc7 Reviewed-on: https://gerrit.libreoffice.org/41601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparam in sc part7Noel Grandin2017-08-263-4/+4
| | | | | | | Change-Id: Ica5421ddc343ce18a08f993778f42183b571ed0e Reviewed-on: https://gerrit.libreoffice.org/41578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* dynamic column container: more efficient loops over all colsNoel Grandin2017-08-253-0/+20
| | | | | | | | | | | | | | | | | | | | Create an ScColumnsRange class that returns a pair of (start,end) iterators to go through the list of currently allocated columns. This is a fairly thing wrapper around the underlying std::vector, so it should be fairly efficient (two pointers, and pointer increment for iteration). If this style of iteration is acceptable, I'll go through the rest of the code that does: for (SCCOL nCol=0; nCol<MAXCOLCOUNT; nCol++) type stuff, and change it to use ScColumnsRange. Change-Id: I81501c69b7f5566c6204dde0d87a6fe0deb9743c Reviewed-on: https://gerrit.libreoffice.org/41413 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparam in sc part6Noel Grandin2017-08-253-4/+4
| | | | | | | Change-Id: Ifbb921b820b7210e7f9539e45d4852764a1e9cbd Reviewed-on: https://gerrit.libreoffice.org/41563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in scNoel Grandin2017-08-252-3/+4
| | | | | | | Change-Id: Ia647ef2dda2dd54a4958a7dc561a0fb86abdfd86 Reviewed-on: https://gerrit.libreoffice.org/41522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2017-08-251-3/+0
| | | | | | | Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f Reviewed-on: https://gerrit.libreoffice.org/41539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* no need to use ERRCODE_RES_MASK hereNoel Grandin2017-08-251-36/+36
| | | | | | | | | the relevant usage sites already call GetRest() before comparing Change-Id: I5e8ce3a3c2b6972810aa527356f6350c61b8bd63 Reviewed-on: https://gerrit.libreoffice.org/41470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparam in sc part5Noel Grandin2017-08-244-6/+6
| | | | | | | Change-Id: Iba249d4d8f7cc686941106983031bae53c7528e1 Reviewed-on: https://gerrit.libreoffice.org/41510 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparam in sc part4Noel Grandin2017-08-246-15/+15
| | | | | | | Change-Id: I745f50257948a53ca07766955c4f4e86dd2a366e Reviewed-on: https://gerrit.libreoffice.org/41497 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparam in sc part3Noel Grandin2017-08-2416-36/+35
| | | | | | | Change-Id: I8abc44b9f0bcd5e39fd8a94abafaf80aadcd26ca Reviewed-on: https://gerrit.libreoffice.org/41496 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparam in sc part2Noel Grandin2017-08-2314-46/+47
| | | | | | | Change-Id: I4fd18096d7d22d8c146a2437906187d5df1cb268 Reviewed-on: https://gerrit.libreoffice.org/41447 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparam in sc part1Noel Grandin2017-08-2215-40/+40
| | | | | | | Change-Id: I82fba7ebb3b4f018721642c96bbfa615c6a382c3 Reviewed-on: https://gerrit.libreoffice.org/41419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Convert ErrCode area to scoped enumNoel Grandin2017-08-222-38/+39
| | | | | | | Change-Id: Ifa365bbac3c7eb21da9381ec8bb3be6b6785016b Reviewed-on: https://gerrit.libreoffice.org/41402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* external data: add a menu entry to refresh the dataMarkus Mohrhard2017-08-201-1/+2
| | | | | | | Change-Id: I1942488d518be91c3ad03f91d98834e22bfdfb16 Reviewed-on: https://gerrit.libreoffice.org/41339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* loplugin:unnecessaryparenNoel Grandin2017-08-181-1/+1
| | | | | | | | | | | look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop unused SdrCustomShapeAdjustmentItemJochen Nitschke2017-08-171-1/+0
| | | | | | | | | | | unused since commit 935baf97a926baa50d985808736e0adb8837c716 Date: Tue May 19 09:32:45 2009 +0000 CWS-TOOLING: integrate CWS impress169 Change-Id: I1e8b0285ae1f6e8d92efd3f5a2463ff3126f1a0d Reviewed-on: https://gerrit.libreoffice.org/41248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* add a way to restore from our new cache formatMarkus Mohrhard2017-08-163-0/+4
| | | | | | | Change-Id: I6eeaaf9ca05bed2a908143ae5f4daab6e098799c Reviewed-on: https://gerrit.libreoffice.org/41199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* tdf#39468 Translate German comments/termsJens Carl2017-08-161-1/+1
| | | | | | | Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea Reviewed-on: https://gerrit.libreoffice.org/41201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Add note about order or row, column, and tab as fields vs. parametersTor Lillqvist2017-08-161-1/+6
| | | | Change-Id: I45e0f9a95da20c1a3b6bdf2ac1387b3c14e3dad4
* remove unused param from CreateScNamePasteDlgNoel Grandin2017-08-161-1/+1
| | | | | | | | | | unused since commit b3dfb1e807eba91eed35a02d74fe8a917c41ee6f "loplugin:checkunusedparams in sc" Change-Id: I53ac9e281a93651259eb39a145acbb89613d3e04 Reviewed-on: https://gerrit.libreoffice.org/41205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* introduce a way to write a simple data representation to a streamMarkus Mohrhard2017-08-163-0/+6
| | | | | | | | | | | The format used is column orientated and allows quick import and export of the table content. This will be used for the external data to cache the results of each transformation step in the UI. Change-Id: I6e1bfd3b3384cbfadeb98fb995dfd0b03d5e6eb6 Reviewed-on: https://gerrit.libreoffice.org/41198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Removing unused serialisation codeVarun Dhall2017-08-161-2/+0
| | | | | | | Change-Id: Id31c8de69043d393f005f83d5c7eba878af5119c Reviewed-on: https://gerrit.libreoffice.org/41149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Change HardRecalcState to enum classTor Lillqvist2017-08-151-4/+4
| | | | Change-Id: I8b20ce6b58915c37e6d4caa11d2f4c724864a257
* tdf#96099: Get rid of one more pointless typedefTor Lillqvist2017-08-151-2/+0
| | | | Change-Id: If50b022cabb0a94297cdb13c58f80884c33892d3
* tdf#96099: Get rid of one more pointless typedefTor Lillqvist2017-08-151-2/+1
| | | | Change-Id: I669b020f2f251ef14cbfff78f6e186876ea0127c
* Removing unused SetVersionMap from scVarun Dhall2017-08-141-16/+0
| | | | | | | Change-Id: I16e4a80b721e8f419352ed2d546bd3d7197ed4f7 Reviewed-on: https://gerrit.libreoffice.org/41101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* external data: reenable the test and adapt to new interfacesMarkus Mohrhard2017-08-131-1/+1
| | | | Change-Id: I2d82b560e0bd499eb85c6ce22f5969f82dfe8937
* external data: introduce a deterministic mode for the testsMarkus Mohrhard2017-08-121-1/+1
| | | | | | | Change-Id: I5804800216bd7d22b89a4e54d3f46cc3520f7c42 Reviewed-on: https://gerrit.libreoffice.org/41091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Add a unit test to be used to test parallelised calculations in CalcTor Lillqvist2017-08-111-0/+1
| | | | | | | | | | Currently only tests SUMIFS. Yes, it would be nice if some of the already existing unit tests would work for this need, too. But there are various reasons wny not. Also, don't want to interfere in ongoing work by others. Change-Id: Ie9008a4a1a8c26eff4f2ab0bc91294b2239f0ae1
* convert std::map::insert to std::map::emplace IINoel Grandin2017-08-111-4/+4
| | | | | | | Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331 Reviewed-on: https://gerrit.libreoffice.org/41019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#111318: Improve msg about pivot table/chart when removing a cell (take 2)Julien Nabet2017-08-101-1/+1
| | | | | | | Change-Id: I56e0fb1716d38471682084569d48907520922b26 Reviewed-on: https://gerrit.libreoffice.org/40991 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* tdf#107797 UpdateAutoFilter handle more entriesTamas Bunth2017-08-101-1/+2
| | | | | | | | | | | | | | | Prepare UpdateAutoFilterFromMenu to handle more entries. Filter items can be hold by more than one entries. In that case we have to remove all the old entries before updating. E.g. setting AutoFilter from vba script results in more than one entries. Change-Id: I4f18f26281d0b8e689cd331f9a66f4c344fb6c6b Reviewed-on: https://gerrit.libreoffice.org/40967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
* Revert "tdf#111318: Improve message about pivot table/chart when removing a ↵Julien Nabet2017-08-101-1/+1
| | | | | | | | | | | cell" This reverts commit fac539889e32e5e47ca6b6da0a588abbe4cbe066. Change-Id: I1496f13119936e7be24345bc6f56469ce40b6080 Reviewed-on: https://gerrit.libreoffice.org/40990 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>