summaryrefslogtreecommitdiffstats
path: root/sax
Commit message (Collapse)AuthorAgeFilesLines
* tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani2016-03-081-10/+0
| | | | | | | Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#96505 Remove long integer literal specifier when not neededAleksas Pantechovskis2016-03-041-2/+2
| | | | | | | | | | Remove L from integer literals if it does not produce warnings and does not change semantics Change-Id: I9573a47d3e3401993a1f0fbcf7df4be20f9e6eba Reviewed-on: https://gerrit.libreoffice.org/22867 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Rename rtl::isValidCodePoint -> rtl::isUnicodeCodePointStephan Bergmann2016-02-151-2/+3
| | | | | | ...and fix its documentation, and use it throughout the code base. Change-Id: I349bc2009b1b0aa7115ea90bc6ecd0a812f63698
* Remove excess newlinesChris Sherlock2016-02-096-37/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* sax: Use comphelper's AttributeListMatúš Kukan2016-02-064-244/+6
| | | | Change-Id: I6eb0115dba8797025a513cf1e6cfbfbe0b6f7e50
* fix gcc build errorCaolán McNamara2016-02-031-2/+2
| | | | | | | | | | | error: invalid operands of types '__gnu_cxx::__enable_if<true, double>::__type {aka double}' and 'int' to binary 'operator%' apparently there's a template returning double for abs for the non-int/long/float/double argument case. So promote earlier to int so the abs<int> is called Change-Id: I882a27c5ec349f894c1c9f4857687360a46b55ae
* loplugin:unusedmethodsNoel Grandin2016-01-201-29/+0
| | | | | | | Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* crashtesting: plain-text import allows liberal with the UTF-8 inputCaolán McNamara2016-01-171-1/+1
| | | | | | | see ImplConvertUtf8ToUnicode which allows surrogates, so we need a non-liberal utf-input there if we want to enfore non-liberal utf-output here. Change-Id: I713818d7b6d79922d9b08f2b137a803384eccb65
* sax: use CPPUNIT_ASSERT_THROWMatúš Kukan2016-01-172-20/+2
| | | | | | | Change-Id: I34b0b559a91e77cc497e14d8ffad7e2c80e43d79 Reviewed-on: https://gerrit.libreoffice.org/21531 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Matúš Kukan <matus@libreoffice.org>
* Fix FastSaxSerializer::write() for non-BMP unicode characters.Mark Hung2016-01-121-23/+2
| | | | | | | Change-Id: I6ee9d028813c970b9ac5b9f0574af932e73111bd Reviewed-on: https://gerrit.libreoffice.org/21293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Fix typosAndrea Gelmini2016-01-102-2/+2
| | | | | | | Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* loplugin:unusedfieldsNoel Grandin2015-12-241-1/+0
| | | | | | | Change-Id: I979592adb978c3757a1e54615021ee424a2e02bf Reviewed-on: https://gerrit.libreoffice.org/20892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove unused typedefs and inline use-once typedefsNoel Grandin2015-11-181-3/+2
| | | | | | | | | and improve the script a little Change-Id: I2792ea4dd5df3a50736fbe209225c3f16fb86b84 Reviewed-on: https://gerrit.libreoffice.org/20033 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* use unique_ptr for pImpl in sax/Noel Grandin2015-11-183-6/+5
| | | | Change-Id: I0bef03451437cbdc5b0fed6b67690ac1d547291d
* use initialiser list for Sequence<OUString>Noel Grandin2015-11-162-8/+2
| | | | | | | Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use initialiser for Sequence<OUString>Noel Grandin2015-11-153-6/+3
| | | | | | | | | | | | | performed using: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f Reviewed-on: https://gerrit.libreoffice.org/19968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-1010-50/+50
| | | | Change-Id: I54bf272b404d2302cafbde73ec5061ea2cd966ab
* loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann2015-11-061-1/+1
| | | | Change-Id: Id1a67eb7ed5b76a7ad8902a80840a891e2ef8442
* use uno::Reference::set method instead of assignmentNoel Grandin2015-11-043-4/+4
| | | | Change-Id: I1c7240fe2e2b5eb825f028ca7502e5ba8793046b
* UNO: no need to use OUString constructor when calling createInstanceNoel Grandin2015-10-302-6/+3
| | | | | | | Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* cppcheck: noExplicitConstructorCaolán McNamara2015-10-305-10/+10
| | | | Change-Id: Id6d969713d94b558a93d303c6dabcbfdd1c65194
* com::sun::star->css in sal,saxNoel Grandin2015-10-2810-86/+86
| | | | | | | Change-Id: I24e202b1f8071fe918e4e164b5fa1c08a561cb24 Reviewed-on: https://gerrit.libreoffice.org/19626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* new loplugin: badvectorinitNoel Grandin2015-10-201-3/+1
| | | | | | | | | | | look for places calling the 1-argument vector fill constructor and then immediately called push_back, which is generally a sign that its leaving empty slots. Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517 Reviewed-on: https://gerrit.libreoffice.org/17525 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
* loplugin:defaultparamsStephan Bergmann2015-10-201-2/+2
| | | | Change-Id: Ie7a5b5defb52fea98baed8183f424dd21990e9b9
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-127-59/+59
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
* xmloff: fix ODF import of gradient draw:angle attribute a bitMichael Stahl2015-10-091-0/+56
| | | | | | | | | | | | | | | | ODF 1.2 part 3, 18.3.1 angle, says "An angle, as defined in §4.1 of [SVG]" and "If no unit identifier is specified, the value is assumed to be in degrees." Unfortunately OOo could only read and write 10th of degree here. See also https://issues.oasis-open.org/browse/OFFICE-3774 As the first step towards fixing that, implement the import for draw:angle values with an angle unit identifier, but leave the import as-is if the angle identifier is missing. Change-Id: Ib88d417c03998ebcfc569b01492f0e1f851bbc85
* sax: remove obsolete XML_UNICODE codeMichael Stahl2015-09-291-40/+0
| | | | Change-Id: Ib5b9b7dc01b713554cf33f58f8fe2f97cb32c369
* boost->stdCaolán McNamara2015-09-174-24/+22
| | | | Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
* loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann2015-08-311-7/+7
| | | | Change-Id: I752d7e9ddc11139e454135b88476341277f7f01d
* sax: tdf#88206 replace cppu::WeakImplHelper*Takeshi Abe2015-08-279-26/+24
| | | | | | | | | with the variadic variants. Change-Id: Id8d0c61b0454652abbbd09be0c72696a057dc2d2 Reviewed-on: https://gerrit.libreoffice.org/18008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Clean up emptyStringStephan Bergmann2015-08-271-4/+3
| | | | Change-Id: I5350322e5c957127fe125e633b31b2492410995e
* tdf#39440 reduce scope of local variablesMichael Weghorn2015-08-221-1/+2
| | | | | | | | | This addresses some cppcheck warnings. Change-Id: Ie492fb9c106b37c3fe7b0105236ad6315f4f159e Reviewed-on: https://gerrit.libreoffice.org/17921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* loplugin: defaultparamsNoel Grandin2015-08-112-2/+2
| | | | Change-Id: I5afe7f9f5caa1f5e55c6218bdb3771571ff0dafa
* new loplugin: refcountingNoel Grandin2015-08-032-25/+26
| | | | | | | | | | | | | | This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* inline a bunch of use-once macrosNoel Grandin2015-07-271-8/+0
| | | | | | | no point in having a macro unless it's actually going to reduce the number of lines of code Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
* sax: convert MergeMarksEnum to enum classMichael Stahl2015-07-183-14/+14
| | | | | | This should detect if a MergeMarks value is erroneously passed as tag. Change-Id: I7b855a661f182136824cf25f2174a9bcce8ff3d1
* sax, sw: try to make that maMarkStack easier to understandMichael Stahl2015-07-183-17/+29
| | | | | | | | | In DocxAttributeOutput it's not at all obvious which mark() is supposed to be ended by which mergeTopMarks(), so add an extra parameter to the FastSaxSerializer functions and verify with an assertion that a LIFO order is maintained. Change-Id: I5a421e2fb11f15343147417fe0b9b23642c70721
* Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann2015-07-131-4/+1
| | | | | | | ...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
* loplugin:unusedmethods sax,shell,stoc,basegfxNoel Grandin2015-07-061-4/+0
| | | | Change-Id: I8f3871fd4e82b6850718b6f2a8757f3043d00017
* WaE do not us #if for DB_UTIL but #ifdefNorbert Thiebaud2015-07-041-3/+3
| | | | Change-Id: I8b0a6c3323a4ffbe6a1ba09e5cff9ddd92ed49f1
* sax: FastSaxSerializer well-formed element test in presence of ...Michael Stahl2015-07-042-4/+160
| | | | | | | | | | | | | | | ... the maMarkStack, which causes the order of calls to startFastElement()/endFastElement() to differ from the order of the tags that are written into the output. This is an attempt to improve the assertions, but if an assertion fails it's generally not obvious where the problem actually is since the unpredictable order may cause the problem to be detected and reported much later than its root cause. Let's see if this finds any new problems in export testing. Change-Id: I97699cc8ef9b18ea9f4f221d5210134feecf0336
* tdf#91378: sax, oox: avoid sending empty strings to character callbacksMichael Stahl2015-07-041-2/+4
| | | | | | | | | | | | | | | | | | | This reverts the changes in FastSaxParserImpl from commit 16e8ffbd5ec1fe7b81835ea6584547669d55d751 and instead fixes the problem of inserting string properties with empty value locally in OOXMLDocPropHandler. This change was not wrong in any obvious way, but it turns out there is one doc rhbz583386-4.docx that, when imported with this change and exported to DOCX again, results in a non-well-formed document because of some weird SDT stuff. That problem is rather baffling, but unfortunately the DocxAttributeOutput usage of FastSaxSerializer::mark() makes the DOCX export rather un-debuggable, so avoid that problem by reverting the import change for now. Change-Id: I0d874cbfe82d4f15d58b50116dda152341bdf7b0
* Revert "loplugin:unusedmethods sax,shell,stoc,basegfx"Michael Stahl2015-07-031-0/+4
| | | | | | The basegfx changes appear to break Windows builds. This reverts commit 3b32c5898ff4e744d3f18b00421b433500426d74.
* loplugin:unusedmethods sax,shell,stoc,basegfxNoel Grandin2015-07-031-4/+0
| | | | Change-Id: Ia5d63f7153e4b02acc5e206739316264d6d1184e
* tdf#91378-Empty Custom Properties are lost while saving in .pptx formatHeena Gupta2015-06-251-4/+2
| | | | | | | | | Conflicts: sd/qa/unit/export-tests.cxx Reviewed on: https://gerrit.libreoffice.org/15966 Change-Id: Ibc24ab9633b51fe41ad483121646cc391319fe6f
* Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2015-06-172-5/+5
| | | | | | | | | | | | | | | | | | | | | | This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* remove unnecessary check for null when calling deleteNoel Grandin2015-06-151-4/+2
| | | | | | | | Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
* cppcheck:redundantAssignmentNoel Grandin2015-06-151-2/+1
| | | | Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-081-1/+1
| | | | Change-Id: I8c84f0f6aeb38147432ce5393b0286c379c6e135
* cppcheck: noExplicitConstructorCaolán McNamara2015-05-102-9/+9
| | | | Change-Id: Ic334d7b0110319e0c581eecd111b73d1cce3134d
generated by cgit (git 2.34.1) at 2024-10-18 16:14:49 +0000