summaryrefslogtreecommitdiffstats
path: root/sal
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:staticcallStephan Bergmann2014-06-131-1/+1
| | | | Change-Id: Ia4111a0fb76c848d3bd2d01f3835995e4c007b6b
* coverity#982462 Dereference after null checkCaolán McNamara2014-06-121-7/+11
| | | | Change-Id: I5e90d51440afa4e317bc07ccb937f606edbc9eb9
* sal/rtl: remove SAL_THROW macroNoel Grandin2014-06-052-14/+11
| | | | Change-Id: I70e41f087dbe188f8fc455150480faeae2b426ed
* Keep TestFixture alive until outputter is done with itStephan Bergmann2014-06-041-15/+19
| | | | Change-Id: Ifd921efa971f7a9a5c47f42c5d56a3deb1c3a0b3
* Cover ctors/dtors of our TestFixtures under the protectors, tooStephan Bergmann2014-06-041-3/+8
| | | | Change-Id: I4c3030e5a205bd102d0427e74d2fe3b828ff5ae6
* fdo#68849: Add header guards to all include filesJens Carl2014-06-012-0/+10
| | | | | | | | | Added header guards to files in directories sal/, sal/, and scripting/ Change-Id: Ieb7f224f2d27bd671618c516f47f5b7f08c1d294 Reviewed-on: https://gerrit.libreoffice.org/9582 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
* update_pchThomas Arnhold2014-05-281-0/+1
| | | | Change-Id: I5316693452427ed76a7738b090de023b110caa40
* dlclose confuses LeakSanitizerStephan Bergmann2014-05-281-4/+3
| | | | | | ...so just do not bother unloading the protector libs again Change-Id: I33caa7beaac3b5e6c4a4836061def24fc5372b70
* Remove unnecessary semicolonsPeter Senna Tschudin2014-05-272-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* fix encoding: iso-8859-1 -> utf8Thomas Arnhold2014-05-252-10/+10
| | | | Change-Id: I3643c38345ec253b7c396a67b9f350a51f6aaf40
* cppunit: always compile with debugging symbols on windows.Michael Meeks2014-05-241-0/+1
| | | | | | Also cleanup some makefile pieces and give better error warnings. Change-Id: I9f20d60f26d5828f60664941946c266c7d166f32
* coverity#982175 Unchecked return value from libraryCaolán McNamara2014-05-241-1/+2
| | | | Change-Id: I7acba38a00dfc1101e6217bff098ef7d6f032497
* coverity#1079283 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+6
| | | | Change-Id: Ib849ff0839bba80d5695c0f78dd18448b668ec78
* coverity#1079282 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+6
| | | | Change-Id: If20b1108af89dec75d8c6a232290ab28e51d09d4
* coverity#1079281 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+6
| | | | Change-Id: I17dc424d485053d3eb09e8eb0dd01dd4b4672bfd
* coverity#1079280 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+6
| | | | Change-Id: I57de2b441c6a1d04c0ea54ad4ff1a66989e0cac8
* coverity#1079279 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+7
| | | | Change-Id: I8b9ac5da3a7c137edec3688cc712079685039c26
* coverity#1079278 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+6
| | | | Change-Id: Ie5f9629340632b8ab17e3fc940dff8195f7673ce
* coverity#1079277 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+7
| | | | Change-Id: Ic7c05f298fec49f1336ab55dde31574a39ebe73b
* coverity#1079284 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+7
| | | | Change-Id: I0d39b2c7b39761fb89b9e7787fd3145ff3daa3a4
* coverity#1079285 Uninitialized scalar fieldCaolán McNamara2014-05-231-1/+6
| | | | Change-Id: Icca0d21a67f1322a84220cde3d10acd5230c9fdd
* WoE: while (..) {} instead of while(..);Douglas Mencken2014-05-221-1/+1
| | | | | | | | | "warning: suggest a space before ';' or explicit braces around empty body" Change-Id: I71a55cc888d3480217621491ecace7d0af3dca6e Reviewed-on: https://gerrit.libreoffice.org/9441 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
* Work around undef conversion of large double to floatStephan Bergmann2014-05-222-4/+35
| | | | | | | | | | ...as flagged by -fsanitize=undefined. But is it really undefined? [conv.double] "If the source value is between two adjacent destination values, the result of the conversion is an implementation-defined choice of either of those values." So if the double is between std::numeric_limits<float>::max() and std::numeric_limits<float>::infinity()... Change-Id: I6389c8ac4a922991e240638d231dd2a39e173882
* Avoid undef conversion from log10(INF) = INF to sal_Int32Stephan Bergmann2014-05-221-0/+8
| | | | Change-Id: Iffe85763097829cb04b766314077b5f2a9b5b8d5
* Fix order of function pointersStephan Bergmann2014-05-221-2/+2
| | | | Change-Id: Ic1bae7fcebfaf35b62aecd86ed8b3a70fae3e4d3
* fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTMukhiddin Yusupov2014-05-222-350/+46
| | | | | | | Replaced OSL_ASSERT with SAL_WARN_IF, OSL_TRACE with SAL_INFO Change-Id: Ia2283c09ac702558fe6ad39e963b0f401ef31de0 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* Default OS X thread stack size too small for -fsanitize=addressStephan Bergmann2014-05-211-5/+12
| | | | | | | | | ...witnessed stack overflow in huge function FunctionMapFactory::createFunctionMap__library_effects__allChildren in workdir/UnpackedTarball/opencollada/COLLADASaxFrameworkLoader/src/generated14/ COLLADASaxFWLColladaParserAutoGen14PrivateFunctionMapFactory.cpp Change-Id: I9451912043e282c8e06aff446cf3d1190f1de9cf
* fdo#60338: Introduce osl_createDirectoryWithFlagsStephan Bergmann2014-05-203-4/+29
| | | | | | | | | | | | | ...so that utl::TempFile can pass osl_File_OpenFlag_Private and doesn't have to resort to umask (the calls to umask around Directory::create had somewhat erroneously been removed recently with 1d72a0262c4570631d0aa8f98e34e21fb9d6ae42 "Related fdo#60338: Create missing temp file dir with user's original umask," mistaking this for creation of intermediate directories in the hierarchy). On Windows, the flags argument to osl_createDirectoryWithFlags is ignored completely for now. Change-Id: Iac56a5049d579be729a3f338aa62105123edb6cb
* Revert "fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT"Stephan Bergmann2014-05-202-9/+9
| | | | | This reverts commit 0562a17c64f4016f2d3ba01e1c19c27feadb2543, sal/log.hxx functionality is only available in C++.
* fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERTMukhiddin Yusupov2014-05-202-9/+9
| | | | | | | | | Changed OSL_ASSERT with SAL_WARN_IF Change-Id: Ie81eeb51f6978162abd372f7e9910344a2baaccd Reviewed-on: https://gerrit.libreoffice.org/9401 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Win32 - warn of extraordinary behaviour with LoadLibrary and long PATHsMichael Meeks2014-05-201-0/+8
| | | | Change-Id: I0a8ee157aa548a5b04df67a2355e3f4fd15e84cd
* Remove unnecessary castsStephan Bergmann2014-05-202-7/+7
| | | | Change-Id: Iafc7727a22d657dfb6bc97ed767907cce3679364
* C string usage improvmentArnaud Versini2014-05-203-19/+8
| | | | | Change-Id: I5c59f0d2d1b911ffa1ee251e0f1355d137616493 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* fdo#60338: Add osl_File_OpenFlag_Private to avoid umaskStephan Bergmann2014-05-191-3/+6
| | | | Change-Id: I293295244d1b089d747548c5025cb73b8ec428a4
* error C3861: 'rtl_allocateMemory': identifier not foundMiklos Vajna2014-05-181-0/+1
| | | | Change-Id: Ie1576aba31dbbd067280ba8fa9c5ef095879cbc2
* remove some external header guardsThomas Arnhold2014-05-185-12/+0
| | | | Change-Id: I5a51dc496835f0998a3422f2a1f0f2ff8bb3c13f
* Related: #i124896# Remove Allocator from sal, tooThomas Arnhold2014-05-151-1/+1
| | | | Change-Id: I3b1c7ccb523232433421def6622e2fc75348ec5f
* Resolves: #i124896# [API CHANGE] remove obsoleted rtl/allocator.hxxHerbert Dürr2014-05-156-15/+4
| | | | | | | | | | | | | | | | | | | | | remove obsoleted sal-module-internal custom STL allocator The SAL module avoided the heavy dependency on the stlport4-libraries by using a custom allocator for its internal STL containers. With stlport4 removed these dependencies are gone and the SAL-internal custom allocator is obsoleted. (cherry picked from commit c6e0325df6efce45dbb2616a32b7745c449c6c58) Conflicts: include/osl/diagnose.hxx include/rtl/allocator.hxx sal/osl/w32/procimpl.cxx sal/qa/osl/process/osl_process.cxx sal/rtl/bootstrap.cxx sal/rtl/source/hash.cxx sal/rtl/source/unload.cxx Change-Id: I8515382828eda36aba1fec5f23e0f2a89aef7a33
* Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold2014-05-1532-84/+84
| | | | | | | Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
* Related fdo#60338: Restrictive open mode flags for tempfile w/o calling umaskStephan Bergmann2014-05-134-14/+27
| | | | Change-Id: Ia83cbe4c9352eb2a2cf317dd1fc5771ddc12c993
* Convert sal/osl/unx/tempfile.c to C++Stephan Bergmann2014-05-132-2/+2
| | | | | | ...for easier future maintenance Change-Id: I501076882daa7f36f414f9fa62f790eb85ac3259
* include sal/log.hxx hereMatúš Kukan2014-05-131-0/+1
| | | | Change-Id: Iefcae15eb9f456cde933d49e1c118185883cd27c
* osl_openFilePath is internal sal/osl/unx functionalityStephan Bergmann2014-05-135-6/+10
| | | | Change-Id: I14e4d08f209e3d6a444d6c09f9ffb9c178d8731d
* All three uses of osl_getFileOSHandle have been removed againStephan Bergmann2014-05-133-35/+0
| | | | | | | | | | | | | ...introduced with a64db11b6ca1c0c99937cd99129758dbbe575ac2 "Add some non-public API to be used by SvFileStream" and e541105b45d5da8df296883111194e3a0297a2e7 "Use osl API to access files in the SvFileStream code" but subsequently identified as dead code with ab02fa6552fb098990e74f2787cf02b01c0e532b "callcatcher: update list," 05a8216d03b5db559e01dd1808f2805df31c970a "STAR_ENABLE_FILE_LOCKING was a secret," and 1d3483ed279982278b2f9fb1bab63485523e48c5 "Remove some unused code from unusedcode.easy." Change-Id: I9c8584890270a87e58b8d8021080ffe54bc97b93
* osl_openMemoryAsFile is internal, Android-only functionalityStephan Bergmann2014-05-133-37/+5
| | | | Change-Id: I36734b0e5e1c0b15ed4f0845450b444b23579ffe
* fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IFMichaël Lefèvre2014-05-125-10/+16
| | | | | Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* coverity#1213310 Dereference before null checkCaolán McNamara2014-05-111-7/+1
| | | | Change-Id: I8590afae1f7b74a250a550adfa010374a3533473
* coverity#984128 Uninitialized scalar fieldCaolán McNamara2014-05-101-1/+5
| | | | Change-Id: I4daff986c15bd6fce03fbcfcb8aa4f6e5df967f7
* remove globally disabled warnings from source filesThomas Arnhold2014-05-101-4/+0
| | | | Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8
* coverity#1209362 coverity gold, wrong maskCaolán McNamara2014-05-091-1/+1
| | | | Change-Id: I039563908a391103cc478e11666648cc517fc677