summaryrefslogtreecommitdiffstats
path: root/sal
Commit message (Collapse)AuthorAgeFilesLines
* ofz#3186: wrong starting offset for JOHAB 0x6D blockCaolán McNamara2017-09-011-1/+1
| | | | | | | | Change-Id: I4de6d9d781b2f2313d8fd338b34dcb31434efe91 Reviewed-on: https://gerrit.libreoffice.org/41640 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 4f982fb4f6ec635f8f900431761a55ab7d5cac2a)
* ofz#2852 korean table entries start at 0xF not 0x7Caolán McNamara2017-08-111-2/+2
| | | | | | | | Change-Id: Iaf3ed48d0eb0e5a57770af057c565a7310bb96d4 Reviewed-on: https://gerrit.libreoffice.org/40763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit c28ceacf6a1aedb4c965a513c72f7570244fbb6f)
* ofz#770 JOHAB_73 table starts at 0xA not 0x2Caolán McNamara2017-03-101-1/+1
| | | | | | | | | | the start value is out by one row Change-Id: I77ed154358516ccd47a090cf7ed45bb609bc81a3 Reviewed-on: https://gerrit.libreoffice.org/34993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 87c783c4a463969984e660f0b5bc57f4910f7856)
* sal: add SAL_NO_ASSERT_DIALOGS variable to redirect...Michael Stahl2017-02-011-0/+18
| | | | | | | | | | | ... the dialogs that pop up on assert() and abort() to stderr, which should work better in CI builds. Change-Id: I80ec95bae6cc21b8ac27f68ca93aa6c6cce707f4 (cherry picked from commit 2fc5a65a1808ce4304ea55f06c4587a2459b5d52) Reviewed-on: https://gerrit.libreoffice.org/33719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* ofz#358 SJIS_84 table mnLeadEnd is out by oneCaolán McNamara2017-01-021-3/+3
| | | | | | | | | | | | | sjis 82 and 83 correctly denote the last index available while 84 reports one past the last available index 0x84BE is the last value to map, not 0x84BF Change-Id: Idcadc2d554ee59586f6e2f2775301fe69c94d55a (cherry picked from commit 0f4eb22d5f3a86af9e5f8042c69e4ddf4a350b93) Reviewed-on: https://gerrit.libreoffice.org/32588 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Typo in meant-to-be-overloading function nameStephan Bergmann2016-12-161-1/+1
| | | | | | | | Change-Id: I65ab9176b39a436afce23e6bd4423ebf76219166 (cherry picked from commit 0dc19268d2f82c4b95b1a0de28a19aea4e0f7e76) Reviewed-on: https://gerrit.libreoffice.org/32079 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* trivial makefile cleanupsMichael Stahl2016-11-221-3/+3
| | | | Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
* remove dep on unotest from osl_Pipe testDavid Tardon2016-11-212-2/+1
| | | | Change-Id: I5f5862a684e52bd3d1336fa9f8cffa77cdebbe4c
* fix for 'warning C4702: unreachable code'Jochen Nitschke2016-11-211-1/+1
| | | | | | | | | on windows vista and higher only Change-Id: I19cc63ad7e96b58fa8eb341801f5ad55260abf85 Reviewed-on: https://gerrit.libreoffice.org/31021 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Use the larger stack size for ASan/UBSan builds on macOS, tooStephan Bergmann2016-11-081-3/+1
| | | | | | | | | At least on my macOS 10.12.1, PTHREAD_STACK_MIN is 8192 (so stacksize was substantially smaller than 12MB), and without this change there were randomly looking failures in e.g. JunitTest_chart2_unoapi with a -fsanitize=address build. Change-Id: Icfe989a0e5097a9a0ae76c6e0f6ffcca18271245
* loplugin:unusedfieldsNoel Grandin2016-11-022-14/+0
| | | | | | | Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar in sal..scriptingNoel Grandin2016-11-012-9/+7
| | | | | | | Change-Id: Id9ab12f3a61eb83a2288b2fd4d99ab77f5833e1b Reviewed-on: https://gerrit.libreoffice.org/30461 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* sal::detail::logFormat is no longer neededStephan Bergmann2016-10-262-47/+9
| | | | | | | ...since 97354578d7195bce927f0c00c4e2ae9cd7344776 "Remove the obsolete functionality originally underlying osl/diagnose.h" Change-Id: I7c920bca9cdddb37fcbbc15d8629d01c21eb0787
* loplugin:expandablemethodds in reportdesign..salNoel Grandin2016-10-191-5/+0
| | | | | | | Change-Id: Idb133e442b881d263fcb83a4858c4a08b451c0f0 Reviewed-on: https://gerrit.libreoffice.org/30032 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* CppunitTest_desktop_lib: fix loplugin:cppunitassertequals warningsMiklos Vajna2016-10-143-6/+6
| | | | | | | | | | And also address a few new warnings in sal, plus silence such warnings in salhelper till we can't print typeids out of the box. Change-Id: I38049146710b6885f6a874bf74eedbc38b4d4651 Reviewed-on: https://gerrit.libreoffice.org/29809 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* approxEqual: check isFinite()Eike Rathke2016-10-131-0/+2
| | | | | | | | Necessary as all comparisons involving a Nan evaluate to false and the assert() in isRepresentableInteger() was hit by crash test documents where approxEqual() was called with a least one Nan. Change-Id: I9e8f41c36c0cf14cabf47c3df773c601d32682d6
* SOCKET_USE_AUTODIAL is dead codeStephan Bergmann2016-10-132-231/+55
| | | | | | | | | | | | | | | ...ever since 010f71130b0d55079d01fbda38d45901de98b133 "INTEGRATION: CWS sal01: #105958# Remove usage of wininet.dll autodial functions" wrapped its central code in #ifdef SOCKET_USE_AUTODIAL instead of removing it properly. Change-Id: I4c077c71ce8eda3a3f8b83286178d0d7907a6e02 Reviewed-on: https://gerrit.libreoffice.org/29742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Don't allow O[U]StringBuffer in string concatenationStephan Bergmann2016-10-122-6/+2
| | | | | | | | | | | | | | | ...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html> "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
* Handle loplugin:fpcomparison false positives by whitelistStephan Bergmann2016-10-101-3/+1
| | | | Change-Id: I58e2beb0695a27922856bd8f8988d9e4508aceb6
* New rtl::splitSurrogates, remove code duplicationStephan Bergmann2016-10-071-7/+1
| | | | Change-Id: Ic96b64244f817196ccdfe06b97f7f31291adf372
* tdf#100302: gbuild: always use $(LFS_CFLAGS)Michael Stahl2016-10-074-10/+0
| | | | | | | | | | Currently LFS_CFLAGS are only used in a handful of libraries but there's no obvious reason why it can't just be set everywhere. Also set it in windows.mk, i have no idea if it's needed for MinGW (certainly not for MSVC). Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
* isRepresentableInteger: assert(fAbsValue >= 0.0)Eike Rathke2016-10-041-0/+1
| | | | Change-Id: Idf140b312617e2a3a739cb5571d1b29ef700315c
* At least MSVC 2015 doesn't find sal/osl/w32/time.hStephan Bergmann2016-10-041-1/+1
| | | | | | | ...when included as <time.h> (our rather sick convention, for include files other than standard headers) rather than "time.h" Change-Id: I5aacfb81de95ae4254e39badffc9c83c7ac0f58f
* @since tag; sortingStephan Bergmann2016-10-041-1/+1
| | | | | | | follow-up to 2135eae2a97c17d89cb47a2074830fd2d7b2226f "let approxEqual() not scale too early for large representable integer values" Change-Id: I628e01297fea08915d0ca1c95f3ba13f7ce15db8
* clang-cl loplugin: salStephan Bergmann2016-10-0438-949/+1075
| | | | | | | Change-Id: If04d3f07dc8bffac8887773b5424c09848cd8f1a Reviewed-on: https://gerrit.libreoffice.org/29404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* -Werror,-Wdeprecated-declarationTor Lillqvist2016-10-031-1/+1
| | | | | | | 'stringByAddingPercentEscapesUsingEncoding:' is deprecated: first deprecated in iOS 9.0. Change-Id: I3a95cbd4ff6ff4924bb7fe1a4c1bac4fad405856
* unit test cases for approxEqual() and approxSub()Eike Rathke2016-10-021-0/+23
| | | | | | | Change-Id: I4aa53d83feaccd3d08c69a35cee2fa84f1ec0964 Reviewed-on: https://gerrit.libreoffice.org/29429 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* let approxEqual() not scale too early for large representable integer valuesEike Rathke2016-10-012-0/+40
| | | | | | | | | | | And since this is now too much code for inline move implementation to math.cxx Which again made it necessary to give libreofficekit lokdocview.cxx its own implementation that doesn't even claim to build against sal ... Change-Id: I0f80be9d9172ee20693b9babde715206f2c3d8c1 Reviewed-on: https://gerrit.libreoffice.org/29428 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* Fix typosAndrea Gelmini2016-10-011-1/+1
| | | | | | | Change-Id: I6aeda978911b25caa45d4e459e581fc743e93d2c Reviewed-on: https://gerrit.libreoffice.org/29442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2016-10-012-2/+2
| | | | | | | Change-Id: Icfc61fcc5ace717bca4bea988243674afe31e6f8 Reviewed-on: https://gerrit.libreoffice.org/29435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* sal: WNT: print errno when oslCreateThread failsMichael Stahl2016-09-301-0/+20
| | | | Change-Id: Iad0a2a7ba68b3f43c22e0b5a3cee646f8baba30e
* osl_getSocketOption shall return the new lengthStephan Bergmann2016-09-301-1/+1
| | | | | | | regression introduced with c89f22ffcd4191f7cb8ef0e68adb2a0f0ec6c74e "INTEGRATION: CWS pj72" Change-Id: Icea8bc43e346dbe4cf7cbfdf1176704d52b339f4
* tdf#83306 add unit test for compareWithLength and '\0'Michael Stahl2016-09-292-1/+41
| | | | Change-Id: Iba48390035c560ea499c7fd793d5dd84d1f63cf0
* tdf#83306: sal: fix compare of rtl::OUString/OString containing '\0'Michael Stahl2016-09-291-4/+5
| | | | | | | | | | | | | | | | For whatever reason oox shape import code uses OUStrings that contain '\0' characters. The rtl_uString / rtl_String are allowed to contain '\0' but the strncmp/wcsncmp functions stop comparing on the first '\0', so use memcmp/wmemcmp instead. (regression from 281989007fd7dea997ed9a65f513f80b1aff67dd) Change-Id: If148927f19d065a21f32f3c14433b0bda7ae9301 Reviewed-on: https://gerrit.libreoffice.org/29384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* sal: Mac OS X 10.8 fails test_log1pMichael Stahl2016-09-261-0/+4
| | | | | | | | | ... because its libc log1p() does not return -0.0 unmodified but as +0.0 Change-Id: Ib3fcd005a9876e0e74775bf4f826a887cdd29279 Reviewed-on: https://gerrit.libreoffice.org/29237 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* -Werror,-Wunused-variable (clang-cl)Stephan Bergmann2016-09-231-1/+0
| | | | Change-Id: I829e2d45ac9fabc8fe1a26bebd9e6ce8c2af29c7
* This is fixed with MSVC 2015Stephan Bergmann2016-09-231-1/+1
| | | | Change-Id: I032b872f75b59904c1c81e8932ad8058ece301b0
* CPPUNIT_ASSERT_EQUAL disambiguationStephan Bergmann2016-09-201-12/+12
| | | | Change-Id: I31d30627badb08469f7e0fd3ded957df78b58275
* Related cid#1371289: Work around missing OUStringBuffer move semanticsStephan Bergmann2016-09-202-0/+83
| | | | | | ...by adding more assign op overloads instead Change-Id: I2d2e1b7f19d1b57528707ed5a5cce94b5fa5c2d0
* loplugin:unusedenumvaluesNoel Grandin2016-09-181-2/+1
| | | | | | | Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b Reviewed-on: https://gerrit.libreoffice.org/28942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove outdated commentTor Lillqvist2016-09-151-1/+0
| | | | Change-Id: I8547760d4ea24205e21f215f25f0c58757bd9329
* loplugin:singlevalfields in l10ntools..saxNoel Grandin2016-09-153-13/+6
| | | | | | and ignore URE headers in the plugin Change-Id: I939df744c1173cf0f67d515f6c3fb4ac4cb25588
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-135-19/+19
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* Bin some noise comments and superfluous vertical whitespaceTor Lillqvist2016-09-121-10/+0
| | | | Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
* Fix MSVC 2015 buildStephan Bergmann2016-09-021-1/+3
| | | | | | | | ...which has HAVE_CXX11_UTF16_STRING_LITERAL but cannot use chart16_t string literals with ConstCharArrayDetector (which uses sal_Unicode) as long as sal_Unicode is still wchar_t instead of char16_t for MSVC. Change-Id: I7c55e0361d1c8c717467d5ab6c942bce3569f3a7
* Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann2016-08-301-11/+12
| | | | | | | | ...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
* Make OUStringLiteral1 a wrapper around UTF-16 instead of just ASCIIStephan Bergmann2016-08-291-4/+6
| | | | | | | | | ...not merely an ASCII character Change-Id: Id2b381b35fe3a15574728ed973d60263dfef7249 Reviewed-on: https://gerrit.libreoffice.org/28446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Support ConstCharArrayDetector also for UTF-16 arraysStephan Bergmann2016-08-293-0/+287
| | | | | | | | | | | | | The long-term benefit will be support of C++11 char16_t string literals (for cases of string literals with non-ASCII content) once we drop any compilers that don't support those yet. The short-term benefit is support for an improved OUStringLiteral1 that accepts any sal_Unicode value, not just ASCII ones (see next commit). Change-Id: I3f8f6697d7eb62b5176b7e812b5a5113c53b83a4 Reviewed-on: https://gerrit.libreoffice.org/28445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* OUString construction from OUStringLiteral1 must not be overruled by...Stephan Bergmann2016-08-291-2/+1
| | | | | | | | | ...Except[Const]CharArrayDetector, under RTL_STRING_UNITTEST Change-Id: Ib185fb8406c4afcff1c854a2b74dae02a0ee2b3f Reviewed-on: https://gerrit.libreoffice.org/28444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* coverity#1371449 Uninitialized scalar fieldCaolán McNamara2016-08-191-1/+4
| | | | Change-Id: I9e43b01f40cc325b83d23903fcec9010f848fb28
generated by cgit (git 2.34.1) at 2024-06-05 07:25:33 +0000