summaryrefslogtreecommitdiffstats
path: root/rsc
Commit message (Collapse)AuthorAgeFilesLines
* cppcheck: variableScopeCaolán McNamara2015-06-091-5/+1
| | | | Change-Id: If0c56c89e2722d47a401363f3854331229856490
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-088-20/+20
| | | | Change-Id: I27516cc532e46b6e43a2f2f292246f1414e9f9b3
* -fsanitize=nonnull-attribute in memcpy callStephan Bergmann2015-06-021-1/+5
| | | | Change-Id: I4fc491906311781b9941c8f02d99d254542027ae
* loplugin:cstylecast: deal with those that are (technically) const_castStephan Bergmann2015-06-021-1/+1
| | | | Change-Id: Ie100fc1048b076f94e7ef33b632df4264d37cf51
* loplugin:loopvartoosmallNoel Grandin2015-05-291-2/+2
| | | | Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
* loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann2015-05-111-10/+10
| | | | Change-Id: I1e62523e08e6f1e7ec926b1a5e7c45d7c688f781
* Bin empty eval statementMatúš Kukan2015-05-021-3/+0
| | | | Change-Id: I52755c373f86490ba3e8910e71e3fab88b1ca38c
* Gradually typed LinkStephan Bergmann2015-04-302-2/+2
| | | | | | | | | | | | | | | | | Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
* Clean up tools/link.hxxStephan Bergmann2015-04-291-0/+3
| | | | Change-Id: I44e4abb228394f99109f7d7e005cfeb26e4b95c1
* Remove unnecessary IMPL_LINK[_NOARG]_INLINE_START/ENDStephan Bergmann2015-04-291-9/+5
| | | | | | ...just use IMPL_LINK[_NOARG] and let the compiler decide what to inline Change-Id: I63ec5116df7e79093ebf31193f8c674f1351c0e6
* cppcheck: invalidPrintfArgType_uintCaolán McNamara2015-04-291-1/+1
| | | | Change-Id: I5a0b5a4ff60c508f8ea11d613022ee7799900098
* loplugin:simplifyboolStephan Bergmann2015-04-241-3/+3
| | | | Change-Id: I86cec7670db8594a7563e86c6645c480d3f8702c
* Various #include <sal/log.hxx> fixupsStephan Bergmann2015-04-221-0/+1
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
* rsc crash on WIN64 due to LP64Norbert Thiebaud2015-04-204-30/+30
| | | | | | | | | | | | | | rsc stash stuff in a 'value' filed that was defined as 'long' saddly it stash also pointer there... which on WIN64 truncate 64 bits pointers in 32 bits scalar. That went unnoticed for years because on every other platform sizeof(long) = sizeof(void*) Change-Id: I218ae181c9d6b64ade457ee49942d1d07a933bb7 Reviewed-on: https://gerrit.libreoffice.org/15394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-151-2/+2
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann2015-03-311-1/+1
| | | | Change-Id: I5be4952b732eab9a32aeaee7eb45a68698be4ad2
* Clean up C-style casts from pointers to voidStephan Bergmann2015-03-2816-71/+71
| | | | Change-Id: I85d6761e72ba2f67a1d67a94cae674cbb271b43f
* loplugin:staticfunctionNoel Grandin2015-03-275-6/+6
| | | | Change-Id: I10c30ef28e7321882a720d1e7869a75a89febfc5
* const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann2015-03-262-6/+6
| | | | Change-Id: I9f8a64433177ba871fa020c0922a539c3e277bc2
* tdf#39440 cppcheck cleanliness, Fixing basic cpp errorsVarun2015-03-261-1/+1
| | | | | | | | | Initialized a non-initialized integer variable which is widely used in if else Change-Id: Ibd99c0baa4cd3d4d409310a9a70dc7b421f6a8b2 Reviewed-on: https://gerrit.libreoffice.org/14780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:constantfunction: rscNoel Grandin2015-03-245-22/+0
| | | | Change-Id: I574bac6b25c9f36ff3d545420ea49d99a9c79b05
* Explicitly default the copy ctorStephan Bergmann2015-03-051-1/+1
| | | | | | | (better than making it implicitly declared, as defining it defaulted is deprecated for that case because of the user-declared copy assignment op) Change-Id: I0c2c4c063e19e3a15b06e75d0c080911acf26ca3
* V805: Decreased performanceCaolán McNamara2015-03-021-1/+1
| | | | Change-Id: I822c5ebc321ebda87c238a1781a31793c1623e34
* remove executable bit from c / h / cxx / hxx / l filesMichael Stahl2015-03-023-0/+0
| | | | Change-Id: I90d7788208fb86c8aea36c4944ca11d881f11720
* wrong length value for string lengthMarkus Mohrhard2015-03-011-1/+1
| | | | Change-Id: Ic8b41ec4bb6b46177b02f533b936ab678207f926
* remove unnecessary parenthesis in return statementsNoel Grandin2015-02-2319-111/+108
| | | | | | | found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
* Werror: data lost during conversion from size_t to intDavid Ostrovsky2015-02-093-8/+9
| | | | | | | Change-Id: Iee080b89cf0588c8076ef4c0334d36a7aefce44d Reviewed-on: https://gerrit.libreoffice.org/14374 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* coverity#1266502 Useless callCaolán McNamara2015-01-261-6/+0
| | | | Change-Id: I443cc28b81508b32c49ba795583ed304729d3fa0
* followup code removal after changing virtual methods to non-virtualNoel Grandin2015-01-261-5/+5
| | | | | | | | | | This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
* new loplugin: change virtual methods to non-virtualNoel Grandin2015-01-261-5/+5
| | | | | | | | | | Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
* Some more loplugin:cstylecast: rscStephan Bergmann2015-01-2014-183/+178
| | | | Change-Id: If62d142481cb3520042a040325bdd9167ae178e7
* brute-force find-and-remove of unused #define constants.Noel Grandin2015-01-084-11/+0
| | | | Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
* fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin2015-01-071-2/+2
| | | | Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
* fdo#84938: replace BUTTONTYPE_ constants with 'enum class'Noel Grandin2015-01-062-3/+6
| | | | Change-Id: I54f9019297913683605b5aea9f79b3defc1dcc13
* boost::unordered_map->std::unordered_mapCaolán McNamara2015-01-025-10/+10
| | | | | | you can get debug stl this way Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
* Remove unnecessary comphelper::string::getTokenStephan Bergmann2015-01-022-5/+4
| | | | Change-Id: I49192637121441b9a1980350b9bb32cd995d4386
* various other apparently unnecessary rsc stuffCaolán McNamara2014-12-314-42/+0
| | | | Change-Id: I745695a92023e7a14ee547ca6bef5981dd329d19
* drop dateformatter resource loadingCaolán McNamara2014-12-313-93/+0
| | | | Change-Id: Ie94c7502b0a82ca406b8d76e18def7bab8233a00
* drop timeformatter resource loadingCaolán McNamara2014-12-313-78/+0
| | | | Change-Id: I11de468ab65aa4dec761fbcc1e9416528c332dd5
* TimeFields not loaded from resource files anymoreCaolán McNamara2014-12-313-25/+0
| | | | Change-Id: Idf69d375eff4bfff7115e59530b37200ee79f086
* splitters no longer loaded from resource filesCaolán McNamara2014-12-283-23/+0
| | | | Change-Id: I84ee0c754118882734301bf1d34c15ba640a3889
* HelpButtons no longer loaded from .rsc filesCaolán McNamara2014-12-221-9/+0
| | | | Change-Id: I0fe82e319ac44a189e93fabd932e3e0a891598d2
* fdo#39440 rsc: reduce scope of local variablesMichael Weghorn2014-12-194-22/+10
| | | | | | | | | This addresses some cppcheck warnings. Change-Id: I69454a75c8ce4aecf9e68f5887f38f8bf6fe6dca Reviewed-on: https://gerrit.libreoffice.org/13543 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* document coverity#983096 Resource leakCaolán McNamara2014-11-211-0/+1
| | | | Change-Id: If5a60dac2329432b30a7b5528e0fca05d4369b1a
* fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2014-11-142-2/+2
| | | | | | | Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
* fdo#84938: replace TOOLBOXITEM_ constants with enumNoel Grandin2014-11-052-4/+6
| | | | | | | Change-Id: I08c4a456f9e80f70719ca8c3ad5c0f0d2d8282f6 Reviewed-on: https://gerrit.libreoffice.org/12258 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#982297 EBCDIC-related cleanupCaolán McNamara2014-11-032-3/+2
| | | | Change-Id: I8da7911c342ffe114d7b25b996602aabed7aa1ed
* fdo#84938: replace MIB_ constants with enumNoel Grandin2014-11-012-5/+8
| | | | | | | Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* sal_Int16 as the underlying type of WindowBorderStyleTakeshi Abe2014-10-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | because g++ 4.7.2 generates [-Werror=type-limits] as follows: > [build CXX] vcl/source/window/settings.cxx > [build CXX] vcl/source/window/paint.cxx > [build CXX] vcl/source/window/resource.cxx > [build CXX] vcl/source/window/accel.cxx > [build CXX] vcl/source/window/accmgr.cxx > [build CXX] vcl/source/window/brdwin.cxx > [build CXX] vcl/source/window/accessibility.cxx > [build CXX] vcl/source/window/legacyaccessibility.cxx > [build CXX] vcl/source/window/clipping.cxx > [build CXX] vcl/source/window/stacking.cxx > [build CXX] vcl/source/window/debug.cxx > [build CXX] vcl/source/window/globalization.cxx > [build CXX] vcl/source/window/btndlg.cxx > [build CXX] vcl/source/window/builder.cxx > [build CXX] vcl/source/window/cmdevt.cxx > [build CXX] vcl/source/window/cursor.cxx > [build CXX] vcl/source/window/debugevent.cxx > [build CXX] vcl/source/window/decoview.cxx > In file included from /home/tabe/core/include/rsc/rsc-vcl-shared-types.hxx:24:0, > from /home/tabe/core/include/vcl/keycodes.hxx:23, > from /home/tabe/core/include/vcl/keycod.hxx:26, > from /home/tabe/core/vcl/inc/svdata.hxx:35, > from /home/tabe/core/vcl/source/window/brdwin.cxx:21: > /home/tabe/core/include/o3tl/typed_flags_set.hxx: In instantiation of 'typename o3tl::typed_flags<T>::Wrap operator&(E, E) [with E = WindowBorderStyle; typename o3tl::typed_flags<T>::Wrap = o3tl::is_typed_flags<WindowBorderStyle, 12339>::Wrap]': > /home/tabe/core/vcl/source/window/brdwin.cxx:1027:44: required from here > /home/tabe/core/include/o3tl/typed_flags_set.hxx:105:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > /home/tabe/core/include/o3tl/typed_flags_set.hxx:106:5: error: comparison is always true due to limited range of data type [-Werror=type-limits] > cc1plus: all warnings being treated as errors > make[1]: *** [/home/tabe/build/workdir/CxxObject/vcl/source/window/brdwin.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [vcl.all] Error 2 > tabe@thunk:~/build$ Cf. a6b01d01f77f84517d267bdfe31de91b9050a70c Change-Id: Ic596eaf886d9aebb8a5b8636b5b90d5935aeadaf
* fdo#84938: replace TIMEF_ constants with enumNoel Grandin2014-10-282-4/+7
| | | | | | | Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-11 07:51:36 +0000