summaryrefslogtreecommitdiffstats
path: root/reportdesign
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:unusedmethodsNoel Grandin2017-02-213-5/+4
| | | | | | | Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:subtlezeroinit: reportdesignStephan Bergmann2017-02-213-8/+8
| | | | Change-Id: I20b7cf2b65900eb336e1a3c6f301eb08b47485a4
* Convert RID_MENU_REPORT to xmlMaxim Monastirsky2017-02-186-338/+99
| | | | | | | | | | | | | | | The change in PopupMenu::ImplExecute is needed because MenuBarManager dispatches commands synchronously, and a command can try to dispose the parent window of the MenuFloatingWindow (e.g. right clicking inside the report header, and choosing "Delete Header"), which will lead to Application::Abort in a debug build. So we must get rid of the MenuFloatingWindow before handling menu selection. Change-Id: I1657cd16a005207abc31f4b65595ab78ed235e37 Reviewed-on: https://gerrit.libreoffice.org/34407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
* convert DlgEdMode to scoped enumNoel Grandin2017-02-165-32/+29
| | | | | | and drop unused RPTUI_READONLY enumerator Change-Id: I863ffc40b3b8f065d01e9570134ee1e2cef400c1
* Some simplifications, using UNO_QUERY_THROWStephan Bergmann2017-02-152-6/+3
| | | | | | | Change-Id: I6723de749d0e741a79a3ec276e781ee0e5b49934 Reviewed-on: https://gerrit.libreoffice.org/34262 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Add missing #includesStephan Bergmann2017-02-069-0/+12
| | | | | | | | | ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
* loplugin:unusedenumconstants in reportdesignNoel Grandin2017-02-061-2/+0
| | | | | | | Change-Id: I19c9a72f36bcb70ca33192a75946698c64e9375a Reviewed-on: https://gerrit.libreoffice.org/33950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* .uno:ScriptOrganizer should be menu:menuitemMaxim Monastirsky2017-02-051-1/+1
| | | | | | | | ... so it won't show as an empty submenu in the customization dialog, and allow accidentally overwriting it. Change-Id: I9431e5240485a58f63a2333850a9052e475db63e
* convert method names in tools::SvRef to be more like our other..Noel Grandin2017-02-022-2/+2
| | | | | | | | | | | reference classes, uno::Reference and rtl::Reference. Specifically rename Is()->is() and Clear()->clear(). Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae Reviewed-on: https://gerrit.libreoffice.org/33576 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* expand out ::sax::Converter::convertNumber to OUString::numberNoel Grandin2017-02-022-15/+5
| | | | | | | | | | which results in much simpler code overall, there is no need to go via an OUStringBuffer all the time Change-Id: I69eba92c93f471fa9a45f97c29c56dcf3cd1ebf8 Reviewed-on: https://gerrit.libreoffice.org/33773 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringconstant handle calls to constructors with one argNoel Grandin2017-02-011-1/+1
| | | | | | | Change-Id: Ide9148a908bef46ba14640dfa6f556beaf6e3f60 Reviewed-on: https://gerrit.libreoffice.org/33772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-317-13/+13
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin2017-01-282-4/+4
| | | | | | | | | ..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-2683-2059/+2019
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor oox..saxNoel Grandin2017-01-253-13/+0
| | | | | | | Change-Id: Ie12bfabc92bce04d702f3e77aa5896366e49245e Reviewed-on: https://gerrit.libreoffice.org/33509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Change all Idle* LINKs to be Timer*Jan-Marek Glogowski2017-01-234-5/+5
| | | | | | | | | | | | | | | | | | | | | Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
* New loplugin:dynexcspec: Add @throws documentation, reportdesignStephan Bergmann2017-01-1928-0/+92
| | | | Change-Id: I3f2c79bc345935e7369e92473ca543c0917820e0
* Refactor Scheduler to add Task classJan-Marek Glogowski2017-01-171-1/+1
| | | | | | | | Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
* new loplugin: useuniqueptr: jvmfwk..saxNoel Grandin2017-01-171-4/+3
| | | | | | | Change-Id: I732e2e22c6f953f0982fbc8833453e7c23cf9d49 Reviewed-on: https://gerrit.libreoffice.org/33166 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* r*: load BitmapEx resources instead of Image onesCaolán McNamara2017-01-163-11/+13
| | | | Change-Id: I9931345912bdb7d3200b1a74742c1fcde1544bc3
* new loplugin: useuniqueptr: vclNoel Grandin2017-01-131-1/+1
| | | | | | | Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* XSubToolbarController is only used by SvxColorToolBoxControlMaxim Monastirsky2017-01-081-2/+2
| | | | Change-Id: I10c31aa9c773649c99b52c2d34cb648a37bf42ac
* drop AutoHide codeCaolán McNamara2017-01-041-1/+0
| | | | | | | only used from reportdesign and that appears to be overlooked from an earlier eradication program Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
* use std::vector instead of naked array in SfxItemPoolNoel Grandin2016-12-262-7/+7
| | | | | | | Change-Id: I2d4ac010ff5818e673567cee05700872588918e4 Reviewed-on: https://gerrit.libreoffice.org/32384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* unwind RID_SVXIMGLIST_RPTEXPL ImageListCaolán McNamara2016-12-223-64/+131
| | | | Change-Id: I395dfb5e54f3196f59b5079c580714f57c992f2d
* Adapt to no-longer explicit OUStringLiteral ctorStephan Bergmann2016-12-174-84/+84
| | | | | | | | | ...from previous commit Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f Reviewed-on: https://gerrit.libreoffice.org/32098 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* OSL_TRACE->SAL in framework..salNoel Grandin2016-12-133-5/+0
| | | | | | | Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9 Reviewed-on: https://gerrit.libreoffice.org/31903 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#104105: fix Vcl lifecycle in CondFormat (reportdesign)Julien Nabet2016-12-091-1/+6
| | | | | | | | | | | | | | | Avoid this error: Window ( 7VclVBox()) with live children destroyed: N5rptui9ConditionE() * n by calling disposeAndClear on each element of m_aConditions m_aConditions is Conditions type Conditions type is ::std::vector< VclPtr<Condition> > See http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/inc/CondFormat.hxx#70 Change-Id: Ie99f8cdb5acd787892237787525d79f3231689db Reviewed-on: https://gerrit.libreoffice.org/31775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* convert SFX_HINT to scoped enumNoel Grandin2016-12-083-3/+3
| | | | | | | | | | | | | | | | | | | | | | Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert VCLEVENT constants to scoped enumNoel Grandin2016-12-072-3/+3
| | | | | | | Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryoverrideStephan Bergmann2016-12-061-5/+0
| | | | Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
* loplugin:unnecessaryoverride (dtors) in reportdesignStephan Bergmann2016-12-051-5/+1
| | | | Change-Id: I9d28fbc78b24ec143d6ad3132137642309d02fa0
* Use Size::Width/Height instead of inherited Pair::A/BStephan Bergmann2016-11-292-10/+10
| | | | Change-Id: Ie0346d5ec054fbe7eff1d4b73814a5e2b9f654c2
* loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin2016-11-292-22/+14
| | | | | | | | | | | | | | Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* vcl: rename Window::Notify to EventNotifyMichael Stahl2016-11-244-5/+3
| | | | | | | | | There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
* use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin2016-11-242-2/+2
| | | | Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e
* convert inventorId to scoped enumNoel Grandin2016-11-216-20/+15
| | | | | | | | | | SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* add missing deps on ui filesDavid Tardon2016-11-211-0/+4
| | | | Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
* gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud2016-11-201-1/+1
| | | | | | | | | | | | | | | this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
* remove some double callsNoel Grandin2016-11-181-9/+5
| | | | | | | | | | found with git grep -P '\W(\w+)\s*\(\s*\W' Change-Id: Ia93f83193959c72dcc15c5c1bf54e805b43f14e5 Reviewed-on: https://gerrit.libreoffice.org/30934 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:datamembershadow in reportdesignNoel Grandin2016-11-1710-53/+52
| | | | | | | Change-Id: I90f95775c5bc6615cc8a8026355cd410e9656a89 Reviewed-on: https://gerrit.libreoffice.org/30922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosSamuel Mehrbrodt2016-11-151-1/+1
| | | | | | | Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* update vclwidget loplugin to find ref-dropping assigmentNoel Grandin2016-11-112-4/+4
| | | | | | | | | | Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* 'make screenshot' use-after-free fixesStephan Bergmann2016-11-101-2/+2
| | | | Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
* 'make screenshot' loplugin fixesStephan Bergmann2016-11-101-8/+1
| | | | Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
* loplugin:expandablemethods in reportdesignNoel Grandin2016-11-0823-112/+50
| | | | | | | | | which led to discovering some unused parameters Change-Id: Ie8f67a47aa9ec409637da32ef9bc457952397772 Reviewed-on: https://gerrit.libreoffice.org/30681 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "Reverts a commit series that cripple windows ci."Caolán McNamara2016-11-075-166/+47
| | | | | | | | | | | | | | | with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* improve indentationNoel Grandin2016-11-071-14/+14
| | | | Change-Id: I1ca7f386cbd85d64e86fe293b2a4a4cbb205edef
* Reverts a commit series that cripple windows ci.Norbert Thiebaud2016-11-055-47/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
* replace OColorPopup with SvxColorWindowCaolán McNamara2016-11-045-166/+47
| | | | Change-Id: I1aa06f70016b935bb13a0f6e93234eea10ba8b84
generated by cgit (git 2.34.1) at 2024-08-09 06:25:59 +0000