summaryrefslogtreecommitdiffstats
path: root/reportdesign/inc
Commit message (Collapse)AuthorAgeFilesLines
* cleanup unused css/script/ includesJochen Nitschke2017-05-201-3/+0
| | | | | | | | | but keep exception includes in headers for now Change-Id: I826828675a2d14b906e57068cbced2e790e12bce Reviewed-on: https://gerrit.libreoffice.org/37846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert SdrLayerId to strong_intNoel Grandin2017-05-121-3/+3
| | | | | | | | | | | | | | Also - rename SetOfByte to SdrLayerIDSet - add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't allocate overlapping SdrLayerID values - add a new constant SDRLAYERPOS_NOTFOUND to be returned from SdrLayerAdmin::GetLayerPos Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8 Reviewed-on: https://gerrit.libreoffice.org/37467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* fix spelling, methode -> methodNoel Grandin2017-05-051-1/+1
| | | | | | | Change-Id: I1c7a4e657601e28d9d50d86e24c4e0ba7579b9d4 Reviewed-on: https://gerrit.libreoffice.org/37289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:checkunusedparams in package..reportdesignNoel Grandin2017-05-031-1/+1
| | | | | | | Change-Id: I8ebccc413153667269954c303e216b155ee9d1ae Reviewed-on: https://gerrit.libreoffice.org/37145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* untranslated strings are just stringsCaolán McNamara2017-05-022-4/+23
| | | | | | | | | | removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tools: move errcode.hxx to the vcl moduleChris Sherlock2017-04-271-1/+1
| | | | | | | Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* remove reportdesign bitmaps from .src filesCaolán McNamara2017-04-262-21/+35
| | | | Change-Id: I9dfea090c130962591762cba88fcd69bbacf05fe
* errinf.hxx moved out of tools and into vcl moduleChris Sherlock2017-04-252-2/+2
| | | | | | | | | | ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* loplugin:unusedmethodsNoel Grandin2017-04-202-2/+0
| | | | | | | Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert navigator menu to .uiCaolán McNamara2017-04-181-2/+0
| | | | Change-Id: I754da935de04dde6d94fa2a1331c771a4bd5ec88
* convert group sort context menu to .uiCaolán McNamara2017-04-141-1/+0
| | | | Change-Id: I8ad51ef49cc0f869efd09b95d3dc11f201e8ee61
* convert ControlModification to scoped enumNoel Grandin2017-04-131-13/+13
| | | | | | | Change-Id: Ia81f1d9f27fb91b831c2ffc3572e119946b085d1 Reviewed-on: https://gerrit.libreoffice.org/36505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna2017-03-311-4/+4
| | | | | | | | | | | | | | | Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* convert ViewShellId to o3tl::strong_intNoel Grandin2017-03-241-1/+1
| | | | | | | Change-Id: I45553d11d56aa8c4432aec126ca51f24bd3ead09 Reviewed-on: https://gerrit.libreoffice.org/35421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused defines from HRC files in reportdesignNoel Grandin2017-03-172-7/+0
| | | | | | | Change-Id: If7d0b32742395e01bb979ffff9012161b0b7826d Reviewed-on: https://gerrit.libreoffice.org/35273 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused RID constantsNoel Grandin2017-03-141-13/+0
| | | | | | | | | found with the attached bin/find-unused-rid.py script Change-Id: I1cf79caa6cafedb8bc642f394dc7e7da889d6fdf Reviewed-on: https://gerrit.libreoffice.org/35136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove redundant 'inline' keywordStephan Bergmann2017-03-035-22/+22
| | | | | | | | | | ...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unusedmethodsNoel Grandin2017-02-211-1/+1
| | | | | | | Change-Id: I52a9f16f3ed543a3c83ca111df70e3f7ae1ef33c Reviewed-on: https://gerrit.libreoffice.org/34508 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Convert RID_MENU_REPORT to xmlMaxim Monastirsky2017-02-181-3/+2
| | | | | | | | | | | | | | | The change in PopupMenu::ImplExecute is needed because MenuBarManager dispatches commands synchronously, and a command can try to dispose the parent window of the MenuFloatingWindow (e.g. right clicking inside the report header, and choosing "Delete Header"), which will lead to Application::Abort in a debug build. So we must get rid of the MenuFloatingWindow before handling menu selection. Change-Id: I1657cd16a005207abc31f4b65595ab78ed235e37 Reviewed-on: https://gerrit.libreoffice.org/34407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
* Remove dynamic exception specificationsStephan Bergmann2017-01-265-288/+288
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New loplugin:dynexcspec: Add @throws documentation, reportdesignStephan Bergmann2017-01-192-0/+4
| | | | Change-Id: I3f2c79bc345935e7369e92473ca543c0917820e0
* r*: load BitmapEx resources instead of Image onesCaolán McNamara2017-01-161-3/+3
| | | | Change-Id: I9931345912bdb7d3200b1a74742c1fcde1544bc3
* unwind RID_SVXIMGLIST_RPTEXPL ImageListCaolán McNamara2016-12-221-2/+18
| | | | Change-Id: I395dfb5e54f3196f59b5079c580714f57c992f2d
* convert inventorId to scoped enumNoel Grandin2016-11-212-8/+3
| | | | | | | | | | SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "Reverts a commit series that cripple windows ci."Caolán McNamara2016-11-072-5/+0
| | | | | | | | | | | | | | | with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Reverts a commit series that cripple windows ci.Norbert Thiebaud2016-11-052-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
* replace OColorPopup with SvxColorWindowCaolán McNamara2016-11-042-5/+0
| | | | Change-Id: I1aa06f70016b935bb13a0f6e93234eea10ba8b84
* Omit the default comparatorTakeshi Abe2016-11-011-1/+1
| | | | | | | Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0 Reviewed-on: https://gerrit.libreoffice.org/30319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
* loplugin:expandablemethodds in reportdesign..salNoel Grandin2016-10-191-6/+0
| | | | | | | Change-Id: Idb133e442b881d263fcb83a4858c4a08b451c0f0 Reviewed-on: https://gerrit.libreoffice.org/30032 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert floating add field to .ui formatCaolán McNamara2016-09-271-11/+1
| | | | Change-Id: Ica9adc19f370d6340d2f5fac552cf1b995b390e0
* perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke2016-09-231-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-137-11/+11
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* coverity#1371177 default assign is good enoughCaolán McNamara2016-09-041-2/+0
| | | | | | | | | and coverity#1371311 coverity#1371240 Change-Id: I1f792b9a8e3e386633d4026d8b073ab615d243f3
* loplugin:unusedenumconstants in package..svtoolsNoel Grandin2016-08-121-3/+0
| | | | | | | Change-Id: I8136b93b9303ebecafd791159e813c335b1bc172 Reviewed-on: https://gerrit.libreoffice.org/28052 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna2016-08-011-1/+1
| | | | | | | | | | | | | Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* svl: avoid defaulted parameter in SfxUndoManager::EnterListAction()Miklos Vajna2016-08-011-1/+1
| | | | | | | | | It's a virtual function, and defaulted parameters there are problematic. Change-Id: I3f110c7ac36dfda90811b033620286ad9fce1af1 Reviewed-on: https://gerrit.libreoffice.org/27772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* new loplugin overrideparamNoel Grandin2016-07-251-1/+1
| | | | | | | | | | verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove unused constants in HRC filesNoel Grandin2016-06-062-9/+0
| | | | | | | Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove some manual ref-countingNoel Grandin2016-06-061-2/+2
| | | | | | | | | | | | | triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f Reviewed-on: https://gerrit.libreoffice.org/25806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* (nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara2016-05-251-4/+0
| | | | | | | | | The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
* Revert "remove some manual ref-counting"Noel Grandin2016-05-241-2/+2
| | | | | | | until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
* remove some manual ref-countingNoel Grandin2016-05-241-2/+2
| | | | | | | | | | | | | triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* reportdesign: replace rest of boost::ref usage with C++11 lambdasMichael Stahl2016-05-123-3/+0
| | | | Change-Id: Ib530bbecbbb19fa09b24d3837d8f8f023d4ed359
* teach passstuffbyref plugin to check for..Noel Grandin2016-05-061-1/+1
| | | | | | | | | | | | unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Avoid reserved identifiersStephan Bergmann2016-04-221-6/+6
| | | | Change-Id: Ifccf58c748ca8189949efeecc1ac7329a07be1f7
* loplugin:passstuffbyref in reportdesignNoel Grandin2016-04-143-4/+4
| | | | Change-Id: I6e024c3043e1fa9f618e96088581ade3c3a00c3c
* tdf#94306 remove unused boost dependenciesJochen Nitschke2016-04-133-3/+0
| | | | | | | | | | remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Avoid reserved identifiersStephan Bergmann2016-04-122-6/+6
| | | | Change-Id: I93e7c254f8777c2dfbb192b306c991387d9cc641
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-121-2/+1
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#94306 replace boost::noncopyable r.. to sdextJochen Nitschke2016-04-111-2/+3
| | | | | | | | | | | | | | | ... in modules reportdesign to sdext Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Make some overloaded ctors explicit (most in sd slidesorter). Add deleted copy-assignment in sc/inc/chart2uno.hxx. Change-Id: I21d4209f0ddb00063ca827474516a05ab4bb2f9a Reviewed-on: https://gerrit.libreoffice.org/23970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-04 17:28:29 +0000