| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Change-Id: I1cc4544e807d7c04aa171358ccd1c204040dff55
Reviewed-on: https://gerrit.libreoffice.org/57078
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
|
|
|
|
|
| |
Change-Id: I56477227bafdd7fdb29aa5a5c857cbfda110e395
Reviewed-on: https://gerrit.libreoffice.org/53643
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
|
|
|
|
|
|
|
| |
Change-Id: I4143da3c5a809118d57849664f6ab1d2e775837f
Reviewed-on: https://gerrit.libreoffice.org/46253
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
|
|
|
|
|
| |
Change-Id: I72bec7ec76fbbbfee9d5185ac1a358659f0d06b5
Reviewed-on: https://gerrit.libreoffice.org/35638
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
|
|
| |
Change-Id: I9f0f98c989cb7ecf6227154e1d81d49abade66c2
|
|
|
|
|
|
|
| |
Change-Id: Ic1cee9e61d31a6ee8f248c7e976c5eca8e0d86bd
Reviewed-on: https://gerrit.libreoffice.org/29233
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
|
|
|
|
|
| |
Change-Id: I9701cc93a9f4315e71c133237fdd96ef6964c8ff
Reviewed-on: https://gerrit.libreoffice.org/29438
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
|
|
| |
Change-Id: I95041f49dd22ba9a15da3598b04a010eecf761a8
|
|
|
|
|
|
| |
and lets see if anyone complains
Change-Id: I0ec236006476064e67cda9869ab45c1860ed351b
|
|
|
|
|
|
| |
found by UCDetector
Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
|
|
|
|
| |
Change-Id: I1d51b96042f229de42ed26d90ecc2a070eb5b3a6
|
|
|
|
|
|
|
|
| |
Change-Id: I4586168d3af81f047a4ded59fc6d257f17554885
Reviewed-on: https://gerrit.libreoffice.org/22194
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
|
|
|
|
|
|
| |
...same as 8fb3808f555ad5b5c66cb894f9402647ca9ba341
Change-Id: If21d6bbf5f88b8ca5ed5387d98b2dd9c74f0e32c
|
|
|
|
|
|
| |
...as null values are handled just fine by compare()
Change-Id: Ifd17b96187ad3d13be99b107d3c3fa47e51b586e
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the property type is e.g. a UNO sequence or struct type, !equals would
trivially be always true (as the UNO bridge creates fresh instances of such
value types on the fly), masking failures where the tested code didn't change
the property value at all.
And one such masked failure was
sw.CharacterStyle::com::sun::star::style::CharacterProperties in
JunitTest_sw_unoapi_1 not changing any of the CharLeft/Right/Bottom/TopBorder
properties, as SvxBorderLine::GuessLinesWidths
(editeng/source/items/borderline.cxx) appears to only work properly if nStyle is
DOUBLE, so work around that for now by explicitly setting that BorderLineStyle
in the ValueChanger for BorderLine2.
Change-Id: If9536822c5db04cbd01e6d760b5b63da04c4cf5b
|
|
|
|
| |
Change-Id: Ib585408c26e14b83e896861c2793ff3229dba7d1
|
|
|
|
| |
Change-Id: I84cb3bb1e3fa42a7b96286f317aa0fb4e8ada8f3
|
|
|
|
|
|
|
|
| |
...if all we want to verify is that resValue == newValue (and it is the test
code's responsibility to come up with a newValue != oldValue, but which might
sometimes not be possible)?
Change-Id: Ibfce322b50bb0074ca76c33ad0c83541a8d4dc41
|
|
|
|
| |
Change-Id: I5501f4f40024d3a47bb7007896e07c6252151cf6
|
|
|
|
|
|
|
| |
which is more accurate since 'PASSED' normally means 'successful',
which is not the case here
Change-Id: I8e9368a810e7be823655f69646fd15feb9f8f502
|
|
|
|
| |
Change-Id: Idc757217b84812fa55efbcfc004abd02d0a78dc3
|
|
|
|
| |
Change-Id: I6f74e597fe9834b18023e73ee8b8bf50d10c82e2
|
|
|
|
| |
Change-Id: Id88aa9e43b736e6fdeaf098a952dae5421468f83
|
|
|
|
|
|
|
| |
Change-Id: Id27f5a357c1333dec5c24c4f5e0fdaed7a775774
Reviewed-on: https://gerrit.libreoffice.org/18963
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
|
|
|
|
|
| |
Change-Id: I52cbaad71560d73f5e24f3de3cd62b00d678dd6c
Reviewed-on: https://gerrit.libreoffice.org/17187
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
|
|
|
|
|
|
| |
Change-Id: I8e429d1f03aac7c7cdb7ff4b43b3f46d40292510
Reviewed-on: https://gerrit.libreoffice.org/16709
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
|
|
|
|
|
|
|
|
|
| |
this is the canonical order, and it makes the code easier to read
Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
|
|
|
|
|
|
|
| |
Change-Id: Id9a13c7f4ae0fd53c95c551544e60af44bb3fb95
Reviewed-on: https://gerrit.libreoffice.org/16203
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
and replacing them with a call to XToolkitExperimental::
processEventsToIdle
Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932
Reviewed-on: https://gerrit.libreoffice.org/16201
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
|
|
| |
Modify createTestEnvironment so that it throws Exception. This
is appropriate for unit testing.
The wrapping adds no value and the calling method already has
a catch(Exception) to handle anything.
Change-Id: I430a414f63d2cbfc3b65ecfde0285509265e5192
|
|
|
|
|
|
|
|
|
| |
...avoid setting bad values from generic qadevOOo property set tests, and throw
an IllegalArgumentException if bad values do get set. Found via
-fsanitize=enum. The TODO about ScLkUpdMode vs. LinkUpdateModes mismatch looks
worrying.
Change-Id: Ibc01845e7e3179dc693fe8c59c1f1ffad5282420
|
|
|
|
|
|
|
|
| |
- remove the SHORT_WAIT test parameter, no-one is using it
- inline the various independent shortWait() methods
- use the util.utils.shortWait() utility method everywhere
Change-Id: I93cd4a2580172a1441d2ff3d390f52b9505e2721
|
|
|
|
| |
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
|
|
|
|
|
|
|
|
|
|
| |
found by running UCDetector over the code many times, like peeling
an onion
Change-Id: I54d5147eb1b5c921ad236331bc4c1f765b13ca83
Reviewed-on: https://gerrit.libreoffice.org/13445
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
|
|
| |
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
|
|
|
| |
found by PMD
Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
| |
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
|
|
|
|
|
|
|
| |
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
| |
Change-Id: I3c0c7f08d4d8ea594e72fc0d9b93d085d4ab4bf5
|
|
|
|
|
|
|
| |
Change-Id: I1bb0999783f365e20b682c3707e73c65724265c9
Reviewed-on: https://gerrit.libreoffice.org/11955
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
|
|
| |
the instanceof check returns false when passed a null value
Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
|
|
|
|
|
|
|
| |
so that we get a nice complete stacktrace when it hits the final
handler
Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
|
|
|
|
|
|
|
| |
Change-Id: Ibbac337b481e138ff9bfaa9d350b52e368ba5f2b
Reviewed-on: https://gerrit.libreoffice.org/11355
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
|
|
|
|
| |
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
|
|
|
|
| |
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
|
|
|
|
| |
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
|
|
|
|
| |
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
|
|
|
|
|
|
| |
from the java test code, this was legacy, just finishing the job
Change-Id: I2475efcde561cf10b29ea956972cddc06ec5635e
|
|
|
|
|
|
|
|
|
|
| |
- remove unused fields
- make all external code go through the get(XXX)
methods instead of also using the default values
- remove default values
declarations and inline them, since they are now unnecessary.
Change-Id: Idc875fbd133de90044647f3e3b1feb225d81a643
|
|
|
|
| |
Change-Id: Ib81b58a6fbcd14a4902bd0650117c07f08088ad6
|