summaryrefslogtreecommitdiffstats
path: root/onlineupdate
Commit message (Collapse)AuthorAgeFilesLines
* replace #ifdef SOLARIS with #ifdef __sunMichael Stahl2017-01-172-2/+2
| | | | | | | Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
* cleanup tailing backslashesJochen Nitschke2016-12-301-2/+2
| | | | | | | Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* [API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always trueStephan Bergmann2016-09-201-1/+1
| | | | | | | | | | | | | | | | | * GCC documents -fvisibility at least as far back as the GCC 4.0 online documentation at <https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>. * For external code, odk/settings/settings.mk unconditionally set HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows. Make this a fatal configure error for now. The check should be removed completely after LO 5.3 branch-off. Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112 Reviewed-on: https://gerrit.libreoffice.org/29073 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann2016-07-131-4/+0
| | | | | | | Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* move #includes to top of fileNoel Grandin2016-06-291-7/+8
| | | | | | | | | | | | | instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#98602 Duplicate code in onlineupdate/Ras-al-Ghul2016-06-1344-9127/+49
| | | | | | | | | | | Converted libmar into static library and removed duplicate code. Change-Id: I51c58ae9a6a1f1128422b4a79491d0cd62e6ced6 Reviewed-on: https://gerrit.libreoffice.org/23312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* Handle wchar_t as native C++11 type on windowsDavid Ostrovsky2016-05-031-6/+0
| | | | | | | | | | | | | | | | | | | | The option /Zc:wchar_t- prevented to use wchar_t as a built-in type according to the C++ standard. In Visual C++ 6.0 and earlier, wchar_t was not implemented as a built-in type, but was declared in wchar.h as a typedef for unsigned short. Now, years later after the end of life this outdated toolchain, there is no reason not to use native type. The only issue could be the ABI compatibility. But on a quick look at least, it looks like none of the mangled C++ symbols in the stable URE interface actually depend on wchar_t. We forgot to get rid of /Zc:wchar_t- in 5.1. Do that for LibreOffice 5.2, though. Change-Id: I8d6b380660859efa44c83c830734978d31d756a0 Reviewed-on: https://gerrit.libreoffice.org/22589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2016-04-303-3/+3
| | | | | | | Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* onlineupdate: revert SAL_N_ELEMENTS changesMichael Stahl2016-03-317-55/+56
| | | | | | | It's not clear if the foreign code in onlineupdate is supposed to include sal headers, so revert the 2 changes from earlier today there. Change-Id: I604720b4bd4897204e354ec230582b0fd2036716
* use SAL_N_ELEMENTS more widelyNoel Grandin2016-03-316-55/+54
| | | | | | | found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
* use SAL_N_ELEMENTS in for loopsNoel Grandin2016-03-311-1/+1
| | | | | | | | | | for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Revert "tdf#98602 Duplicate code in onlineupdate/"Jan Holesovsky2016-03-1411-32/+1466
| | | | | | Unfortunately needs more work, I've pushed it too early... This reverts commit e60506acc53098b4b479d565048c316562657cec.
* tdf#98602 Duplicate code in onlineupdate/Ras-al-Ghul2016-03-1411-1466/+32
| | | | | | | | | Converted libmar into static library and removed duplicated code Change-Id: I6a6c8ce24103a400e1835ccf7e6421024f5cec4b Reviewed-on: https://gerrit.libreoffice.org/23179 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* use consistent #define checks for the Windows platformNoel Grandin2016-02-1735-99/+99
| | | | | | | | | | | | stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* use consistent #define checks for the Windows platformNoel Grandin2016-02-164-4/+4
| | | | | | | | | | stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Remove excess newlinesChris Sherlock2016-02-091-1/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Formatting changes across all modulesChris Sherlock2016-02-091-2/+0
| | | | | | | | | | | | | | + Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Fix typosAndrea Gelmini2016-02-054-5/+5
| | | | | | | Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* Fix typosAndrea Gelmini2016-01-106-7/+7
| | | | | | | Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* cppcheck: noExplicitConstructorCaolán McNamara2016-01-081-1/+1
| | | | | | | | Change-Id: If1ddb112c85f127295eb55566360b066e7173ba2 Reviewed-on: https://gerrit.libreoffice.org/21245 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* onlineupdate: linking libpthread should work better than including itMichael Stahl2016-01-061-11/+1
| | | | Change-Id: Ib19a5651f7e30108e8fbcdc6f7924c47cbeb4434
* onlineupdate: Executable_updater should decide which GTK it wants to useMichael Stahl2016-01-061-5/+0
| | | | | | | Using both GTK2 and GTK3 sounds like a recipe for disaster, so use gtk2 for now (since we get numerous deprecation warnings with gtk3). Change-Id: I32a27c3620503b6c5d7d81510137bfddc5abb05c
* onlineupdate: -Werror=unused-but-set-variableMichael Stahl2015-11-042-6/+4
| | | | Change-Id: I136eb25d2831cdbd3f1ce81714039cbd28b16577
* onlineupdate: -Werror=unused-variableMichael Stahl2015-11-042-0/+4
| | | | | | There are actually 2 identical copies of the file in onlineupdate! WTF? Change-Id: I967bd90045ca0f56db151dd82d3baf8e848a8863
* onlineupdate: error: statement with no effectMichael Stahl2015-11-041-0/+3
| | | | | | Actually enable NSS on non-WNT/Mac platforms. Change-Id: Ib465d0175878bc2846a4d779b3b34ca57e55462e
* cppcheck:variableScopeNoel Grandin2015-10-125-8/+5
| | | | | | | Change-Id: I037feb335499629300309851dcda3bb661f03d4f Reviewed-on: https://gerrit.libreoffice.org/19316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Fix typosAndrea Gelmini2015-09-304-8/+8
| | | | | | | Change-Id: I013414cf10e25acd5216643855aaa230258a1b5f Reviewed-on: https://gerrit.libreoffice.org/18962 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Fix typosAndrea Gelmini2015-09-181-1/+1
| | | | | | | Change-Id: I021589aeca9ef6bceb1c828c2197f5ff58f85b09 Reviewed-on: https://gerrit.libreoffice.org/18707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#39440 cppcheck: redundantAssignmentMichael Weghorn2015-08-231-2/+1
| | | | | | | | | | | This addresses some of cppcheck's "redundantAssignment" warnings ("Variable '<varName>' is reassigned a value before the old one has been used"). Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e Reviewed-on: https://gerrit.libreoffice.org/17926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#39440 reduce scope of local variablesMichael Weghorn2015-08-222-3/+3
| | | | | | | | | This addresses some cppcheck warnings. Change-Id: I6ab170c4426494ab9fc53017f88e47fbfdbd9aad Reviewed-on: https://gerrit.libreoffice.org/17920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Add the needed #ifndef instead of removing the variable.Jan Holesovsky2015-08-121-0/+3
| | | | | | This reverts commit 058c924c9385d003eefa728be7b23b2effd73913. Change-Id: I0418af18177cef350b2bf13008ed54336c54938c
* cppcheck: uninitMemberVarCaolán McNamara2015-08-111-1/+3
| | | | Change-Id: I78acdab89764a27291ca05b0bb1d448608202208
* cppcheck: arrayIndexThenCheckCaolán McNamara2015-08-101-1/+1
| | | | Change-Id: I66dc4dd095d4e1a9d963b1c2c6a99b16d9f9bf61
* cppcheck: unusedVariableCaolán McNamara2015-08-101-1/+0
| | | | Change-Id: I11e9a952fdb401e08d6095fc36f0eb2dba6e2917
* remove some unused typedefsNoel Grandin2015-08-031-4/+0
| | | | | | | Change-Id: I98c1e7eaa66b7afb05255a017a3de54714637501 Reviewed-on: https://gerrit.libreoffice.org/17491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove some unused definesNoel Grandin2015-07-271-6/+0
| | | | | | | Change-Id: Ib2d50e8c29ccbc5ffcb52cdff4ae3eaae9a62188 Reviewed-on: https://gerrit.libreoffice.org/17332 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* online update: Fix many warnings.Jan Holesovsky2015-07-2211-26/+29
| | | | | | Not all yet, though. Change-Id: Ic4f0fe3ded31d585faefd8bda8ab87f54b88dc6c
* online update tdf#68274: fix --enable-online-update=mar on WindowsNathan Yee2015-07-2233-59/+2875
| | | | Change-Id: I397566ae2488799399cad361b24a281d3599cc5b
* online update: Make the 'updater' build & link at least on Linux.Jan Holesovsky2015-07-032-17/+1
| | | | | | | | Works with the non-system bzip2; the --with-system case might still need some love - but then again, distros want to have the online update switched off anyway... Change-Id: I26a27aec07a8f1aac22a4d14a38fb5b833550ea7
* online update: Add the bzip2 external.Nathan Yee2015-07-031-4/+1
| | | | Change-Id: Id7547390c49c0bcf672eb1a9863fc236518bfa49
* online update: Remove unneeded files.Nathan Yee2015-07-0310-517/+2
| | | | Change-Id: Id69448d893f7492e7321c6c6f84d6cccc9024220
* online update: Configure switch --enable-online-update=marJan Holesovsky2015-06-292-8/+2
| | | | | | | | This will enable the mar-based online update instead of the 'traditional' one. At the moment, this does not build, as libbz2 was not packaged as an external library yet. Change-Id: I1ad7d9adf7a12a427786682ad932597eb2319256
* online update: Add updater executable build supportNathan Yee2015-06-2941-88/+4766
| | | | Change-Id: I033f114d29cd020b6dba5a74257d3f577dd73ea7
* online update: Add mar executable build supportNathan Yee2015-06-2913-26/+2580
| | | | | | | | | | Remove unneeded mar library build support Add macro workarounds in mar.c; will deal with them in the future Change PL_strdup to strdup (is this safe?) Change-Id: Ib3108abdf360f6fc1ccc1bf5030df8529d724b82
* online update: Add preliminary support for creating MAR librariesNathan Yee2015-06-293-0/+54
| | | | Change-Id: I04040d67b82afc0f00558d493ee046c97001cd5d
* online update: MAR-based online update - initial import from Mozilla.Jan Holesovsky2015-06-2982-0/+13176
This commit copies several source files around the Mozilla's online update from the Mozilla sources to LibreOffice. The hope is that we will be able to modify it so that LibreOffice can use the same update mechanism as Firefox, including downloading the packs on background, and applying them on the next start. changeset: 248917:ce863f9d8864 The following locations in the Mozzila sources were copied: firefox/modules/libmar -> onlineupdate/source/libmar firefox/toolkit/mozapps/update -> onlineupdate/source/update JavaScript parts were omitted. Change-Id: I0c92dc0bf734bfd5d8746822f674e162d64fa62f