summaryrefslogtreecommitdiffstats
path: root/odk
Commit message (Collapse)AuthorAgeFilesLines
* odk: build examples with GCC with explicit -std=c++11Michael Stahl2021-05-131-1/+1
| | | | | | | | | | | | GCC 11 defaults to -std=c++17, which doesn't support exception specifications any more. ddcc98fa50dd9d86a60dada4daa00f4d95ffe005 seems a bit large to backport. Change-Id: I74a182435b268be8fd7a9ff0be9f404122108b51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115505 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
* Move all public Java classes to libreoffice.jarSamuel Mehrbrodt2020-06-058-13/+9
| | | | | | | | | | | | | | | | | | | | | | This moves the classes from juh.jar and ridl.jar to libreoffice.jar The goal is to have one single jar (and Java module, will be added later) which developers can include to work with LO. juh.jar and ridl.jar are kept as basically empty jars with libreoffice.jar on its classpath to keep backwards compatibility. This is a continuation of ae855bf48163ff64d94cfc34aff8e37abdb5518d and a preparation to have Java 9 module support. Change-Id: Ifbbfb97f60373d14256e62ae3122913bd17d5bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 35518c92365cc183ba6cce2a4d284a130c0ca13f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95048 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Cleanup: Move files to ridljarSamuel Mehrbrodt2020-05-301-1/+1
| | | | | | | | | | | | | | | | These files are now part of ridl.jar instead of jurt.jar, so move them accordingly. Follow-up cleanup for ae855bf48163ff64d94cfc34aff8e37abdb5518d Change-Id: I01df60d99f5296b6252b260f52160c3e62f4b8dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88007 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 57eee86bab2efd63b7eec9d73a86b1cc0422de29) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95046 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* tdf#117331 Merge jurt and unoil into ridlSamuel Mehrbrodt2020-02-057-17/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | jurt.jar and unoil.jar are kept as effectively empty jars, each with a Class-Path: ridl.jar in their meta-inf/manifest.mf, so that 3rd-party code loading them (with or without also loading ridl.jar) will still have access to their content. Conceptually, the UNOIDL entities in unoil.jar (corresponding to module offapi) are not part of the URE, but are now made available by URE's ridl.jar. This should probably not cause problems in practice. At least for now, we seal exactly those packages in ridl.jar that were originally sealed in jurt.jar. Ideally, all of ridl.jar could be sealed now, but that would be mildly incompatible, as it would prevent 3rd-party code from introducing additional UNOIDL entities in the relevant namespaces (even if that is something we do not want 3rd-party code to do anyway). However, some JunitTest_jurt_* define classes in those sealed packages. In the past they got away with that by using gb_JunitTest_use_jar_classset,*,jurt. Instead they now need to gb_JunitTest_use_jar_classset,*,ridl and drop the gb_JunitTest_use_jar,*,ridl. But the former only makes available the classes that are specified in ridljar/Jar_ridl.mk with gb_Jar_add_sourcefiles, not the UNOIDL entities specified via gb_Jar_add_packagedirs. But the tests need the udkapi UNOIDL entities, so introduce gb_JunitTest_add_classpath to let the tests get them explicitly. (Curiously, JunitTest_jurt_uno and JnitTest_jurt_util use gb_JunitTest_use_jar_classset,*,jurt but don't seem to acutally need it; lets leave that for a follow-up clean up.) As a follow-up clean up, relevant files could be moved from jurt/ to ridljar/. Change-Id: I836f4e7bb47fb41f1306e3f223da90dba988eb9a Co-authored-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ae855bf48163ff64d94cfc34aff8e37abdb5518d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88005 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Bump copyright year to 2020Adolfo Jayme Barrientos2020-01-086-6/+6
| | | | | | | | | | | Change-Id: I6fb736591f32907c8977fbac8fbf1dcbaef1bb97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86092 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a526e85a0d6371781482a9b7de4e05b8b2578de2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86093 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* odk: fix for change directory in complextoolbarcontrols sampleVasily Melenchuk2019-11-012-3/+8
| | | | | | | | | | | | | On Windows classical "cd" command does not change drive automatically. So if OO_SDK_OUT folder located on another drive than SDK_HOME we will receive confusing buid errors. To avoid this for Windows configuration we should use "cd /d". Change-Id: I22908d49fc915d3a834972357934349ba82bbec5 Reviewed-on: https://gerrit.libreoffice.org/80827 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* ODK: cleanup windows linker debug argsThorsten Behrens2019-10-231-6/+5
| | | | | | | | | This was a somehow confused & partially commented-out setup Change-Id: Iad5ef6721cda6f85ded3296650ee9a7df9ec59fd Reviewed-on: https://gerrit.libreoffice.org/81333 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typo and dotsAndrea Gelmini2019-10-191-1/+1
| | | | | | | Change-Id: Ia34130dbab42d61074a73a2b16e03360b5b123b6 Reviewed-on: https://gerrit.libreoffice.org/81086 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* rtl/stringconcat.hxx is not part of the URE interfaceStephan Bergmann2019-10-121-1/+0
| | | | | | | | | | (and #include's of it in include/rtl/*.hxx are already guarded with LIBO_INTERNAL_ONLY) Change-Id: I9224f71a244a69ef69406ea3a5879b66b3cae3a3 Reviewed-on: https://gerrit.libreoffice.org/80666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* simplify "a = a +" to "a +="Noel Grandin2019-10-111-2/+2
| | | | | | | | | mostly so that my stringadd loplugin can point out places to improve Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5 Reviewed-on: https://gerrit.libreoffice.org/80618 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make odk build-examples work on macOS 10.15Stephan Bergmann2019-10-091-4/+21
| | | | | | | | | | | | | | | | | | | | | | ...which apparently got even stricter with unsetting DYLD_LIBRARY_PATH when starting a shell, so the old workaround from 9ac2aad4c1cd0f8d513c02a897da90c42f2fa961 "OSX fix ODK example builds with enabled SIP" no longer worked for me (and CustomTarget_odk/build-examples_java failed with > dyld: Library not loaded: @__VIA_LIBRARY_PATH__/libreglo.dylib > Referenced from: /Users/stephan/Software/lo/core/instdir/LibreOffice6.4_SDK/bin/idlc > Reason: image not found ). Building on macOS 10.15 now requires to build a shell from upstream sources and pass it into toplevel make as a SHELL=... command line argument (but which I at least already needed to do anyway, to preserve a global DYLD_LIBRARY_PATH pointing at a nonstandard libc++, when building external/firebird). Change-Id: I00ec0649fafa1842bed3f2a1258e3184d6bcfdd1 Reviewed-on: https://gerrit.libreoffice.org/80532 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2019-09-101-12/+12
| | | | | | | Change-Id: Ibc1b7393a8e65bf23c78fdb9da78c6b73b544cf3 Reviewed-on: https://gerrit.libreoffice.org/78793 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fixing '....' and '..'Andrea Gelmini2019-09-066-6/+6
| | | | | | | Change-Id: I926069d6c1f2712e5020d930f7ff6c62fd00e912 Reviewed-on: https://gerrit.libreoffice.org/78667 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix '..'Andrea Gelmini2019-09-017-7/+7
| | | | | | | | | | | | | | | To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* Fix typoAndrea Gelmini2019-08-291-1/+1
| | | | | | | Change-Id: I46650797efa70d6b416356a3e5ed57d26d8e69be Reviewed-on: https://gerrit.libreoffice.org/78252 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* odk: fixed typos in generated manifestsVasily Melenchuk2019-08-212-2/+2
| | | | | | | Change-Id: I85766d1ba3598b37e3a776605628402ca5795bc5 Reviewed-on: https://gerrit.libreoffice.org/77809 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix EXTENSION_PLATFORM for Windows x86_64Stephan Bergmann2019-08-201-1/+5
| | | | | | | | Change-Id: I7fbe1963aff666205dbc9405e94d6093fb9a5a48 Reviewed-on: https://gerrit.libreoffice.org/77804 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2019-08-193-5/+5
| | | | | | | | | | | To complete https://gerrit.libreoffice.org/#/c/77567/ Change-Id: I9f56eb308ff9b23c4259a0abae60ac2f97038393 Reviewed-on: https://gerrit.libreoffice.org/77589 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Fix typosAndrea Gelmini2019-08-191-2/+2
| | | | | | | Change-Id: I0b5182a3cec87ee44b7467d6e8e3d1c21ce93ac2 Reviewed-on: https://gerrit.libreoffice.org/77680 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2019-08-162-2/+2
| | | | | | | Change-Id: I5d0776d5f90f44ebbeeb5916cbbf6e87406adcad Reviewed-on: https://gerrit.libreoffice.org/77609 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2019-08-121-2/+2
| | | | | | | Change-Id: I62b669b85e2380df2a6efa05764f21405e7eb2ae Reviewed-on: https://gerrit.libreoffice.org/77318 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typoAndrea Gelmini2019-08-122-2/+2
| | | | | | | | | "an one" Change-Id: Ic12d139acfdb32aaf0089c60609feaa653fd686b Reviewed-on: https://gerrit.libreoffice.org/77259 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2019-08-122-4/+4
| | | | | | | | | "its" Change-Id: I02c660e46964270376a66210fdb5f1b1985ce5b6 Reviewed-on: https://gerrit.libreoffice.org/77255 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fixed "OfficeDocument"Matthias Seidel2019-08-111-1/+1
| | | | | | | | | | (cherry picked from commit 856d28801b59d45cf4d32602adc57a08cd618b6d) Change-Id: Ie915588bda5930dc51a1484f20d0bbd9d955ec29 Reviewed-on: https://gerrit.libreoffice.org/77269 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Fix typosAndrea Gelmini2019-08-091-1/+1
| | | | | | | Change-Id: I994f656b0828c9c7ea1463b86cd692f847d01e7e Reviewed-on: https://gerrit.libreoffice.org/77126 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typo 'a SDK'Andrea Gelmini2019-07-242-2/+2
| | | | | | | | | | Partial revert of: https://gerrit.libreoffice.org/#/c/76028/4 Change-Id: I94173556f1dff21ff47245f8b632411fc8be1ff6 Reviewed-on: https://gerrit.libreoffice.org/76200 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* Fix typosAndrea Gelmini2019-07-2033-55/+55
| | | | | | | Change-Id: Ib361243332b7219c0073c787c378c648e44705f2 Reviewed-on: https://gerrit.libreoffice.org/75487 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
* Fix typos in codeAndrea Gelmini2019-07-204-5/+5
| | | | | | | | | Extracted from https://gerrit.libreoffice.org/#/c/75487/1 Change-Id: I80f9247c5c961a33c0d2c8354ea0524820b33409 Reviewed-on: https://gerrit.libreoffice.org/76028 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
* an uno -> a unoCaolán McNamara2019-05-102-3/+3
| | | | | | | | Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* an is used before a vowel soundCaolán McNamara2019-05-106-8/+8
| | | | | | | | | | not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* par command does not allow n command in its first line(title)Tomoyuki Kubota2019-05-091-1/+1
| | | | | | | | | | | Doxygen used to allow this but there was a regression, which is apparently not being fixed: https://github.com/doxygen/doxygen/issues/6304 Change-Id: I7602236522a56c30a2249bd8065796b3c6458704 Reviewed-on: https://gerrit.libreoffice.org/70377 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
* fix usage of successful/successfully in commentsNoel Grandin2019-04-162-4/+4
| | | | | | | Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b Reviewed-on: https://gerrit.libreoffice.org/70813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* odk: Add hint to test this in instdir/sdkSamuel Mehrbrodt2019-04-041-0/+2
| | | | | | | Change-Id: I8881f33a024cb5b9e36d4a6a668d8a32aea2ed1a Reviewed-on: https://gerrit.libreoffice.org/70189 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Fix typosJens Carl2019-04-035-6/+6
| | | | | | | | | | Change indefinite article "an" to "a" before the word unique and some variants. Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f Reviewed-on: https://gerrit.libreoffice.org/70174 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* (blind) fix of 'ERROR: Source for LICENSE.html not found!' on macOSAndras Timar2019-04-011-1/+1
| | | | | | | Change-Id: I0f87d96691281e773b48ab11380c0dfa3a65ebba Reviewed-on: https://gerrit.libreoffice.org/70083 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
* tdf#120703 PVS: Silence V575 warningsMike Kaganski2019-03-311-0/+3
| | | | | | | | | | | | V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* single source file for licensing info with conditional textTamas Bunth2019-03-191-3/+5
| | | | | | | | | | | | | | ... for easier maintenance. This commit only introduces the framework. Follow up commits will update the license file. Advantages: * single source, multiple outputs (html, txt) * conditional text, i.e. output will not include license terms of components that are not configured in the build Change-Id: I0ffad41119228a0a26fd1b6ce19930ca6085adb2 Reviewed-on: https://gerrit.libreoffice.org/69396 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
* Adopt odk configure to new java 6 baselineSamuel Mehrbrodt2019-02-152-3/+3
| | | | | | | Change-Id: I015f439b04ddbc337a1c0b000fa708686d1f83bb Reviewed-on: https://gerrit.libreoffice.org/67751 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
* odk: CustomTarget_build-examples hard-codes on "gcc" and "g++"Michael Stahl2019-01-291-0/+1
| | | | | | | | | | ... so it fails if these aren't available; instead use the C++ compiler of the LO build system. Change-Id: I8a95d1865c481dc0a790d6fec6ff9fae8284d76d Reviewed-on: https://gerrit.libreoffice.org/67078 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
* Fix build with recent jdk 11.0.2Fridrich Štrba2019-01-241-1/+1
| | | | Change-Id: I0ee68e087e3973b6a148f9bfefc16581606d6568
* Bump copyright year to 2019Adolfo Jayme Barrientos2019-01-016-6/+6
| | | | Change-Id: I0d49ec7db57a0f7d18489dad61e86cbfdf4418cd
* Rename Mac OS X to official name macOS in comments and documentationBartosz Kosiorek2018-11-293-3/+3
| | | | | | | Change-Id: I651b7f202fa52ff5f5357a11aa72c43eb7dc7f95 Reviewed-on: https://gerrit.libreoffice.org/64102 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
* Fix typosAndrea Gelmini2018-11-181-1/+1
| | | | | | | Change-Id: I2a7877dc341e9bcbea231f5ce9edb1236f97df1c Reviewed-on: https://gerrit.libreoffice.org/63505 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2018-11-051-1/+1
| | | | | | | Change-Id: Id5489f3e8f1d3ced3d57b56f8d3a7a4818af0fca Reviewed-on: https://gerrit.libreoffice.org/62377 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* Java 11 no longer synthesizes DocumentView$1.classStephan Bergmann2018-10-211-2/+1
| | | | | | | | | | ...so, for simplicity, just include whatever generated DocumentView$*.class by wildcard Change-Id: I779e2709c8ef2859d68233300302dd62dbe2455f Reviewed-on: https://gerrit.libreoffice.org/62073 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Restore explicit _WIN32_WINVER in the ODK exampleJan-Marek Glogowski2018-10-111-0/+3
| | | | | | | Change-Id: I01855c37955dcae13dbb3c6f028d4030dc48945a Reviewed-on: https://gerrit.libreoffice.org/61657 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
* Drop duplicate WINVER and _WIN32_WINNT definesJan-Marek Glogowski2018-10-111-3/+0
| | | | | | | | | | | Just keep the definition of _WIN32_WINNT in windows.mk, which claims it automatically derivates WINVER in some sdk header. Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c Reviewed-on: https://gerrit.libreoffice.org/61631 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* Add some colour to a sample odt fileTor Lillqvist2018-10-021-0/+0
| | | | Change-Id: If4dc6458d9c5fb3b574c1bb55196a5086aff3365
* Fix toogle->toggleAndrea Gelmini2018-09-281-3/+3
| | | | | | | | | It passed "make check" on Linux Change-Id: Id25a7893e536a579cef58f63e8ec7ce240ad16fb Reviewed-on: https://gerrit.libreoffice.org/60633 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:external (clang-cl)Stephan Bergmann2018-09-241-5/+5
| | | | | | | | | | | | | | | | | | | | | | Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>