summaryrefslogtreecommitdiffstats
path: root/lotuswordpro
Commit message (Collapse)AuthorAgeFilesLines
* TyposJulien Nabet2017-02-031-3/+3
| | | | | | | Change-Id: I36f443c266670bd26aa6b813075e18653f372f52 Reviewed-on: https://gerrit.libreoffice.org/33900 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:useuniqueptr extend to check local varsNoel Grandin2017-02-014-19/+14
| | | | | | | | | | | just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-262-27/+9
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor jvmfwk..lotuswordproNoel Grandin2017-01-2444-95/+0
| | | | | | | | Change-Id: Iaa4f9b178ab265342255066af7fff09f5b33ab37 Reviewed-on: https://gerrit.libreoffice.org/33496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* use rtl::Reference in XFSaxAttrListNoel Grandin2017-01-242-17/+14
| | | | | | instead of storing both a raw pointer and an uno::Reference Change-Id: I227ac624b03a172e10840c4d1e2c4ca0362b33a4
* coverity#1399429 Uninitialized scalar variableCaolán McNamara2017-01-211-1/+1
| | | | Change-Id: I7f10d609b9c031f4b51843bbd4ba945dc23ab169
* New loplugin:dynexcspec: Add @throws documentation, lotuswordproStephan Bergmann2017-01-191-0/+1
| | | | Change-Id: Id54bb9f05a4354855a8e9fa5ecbffc8440e39c5d
* new loplugin: useuniqueptr: lotuswordproNoel Grandin2017-01-1159-277/+260
| | | | | | | Change-Id: I1f9569cb5ca05faf12663b3df8508d10a8cd75e6 Reviewed-on: https://gerrit.libreoffice.org/32957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* coverity#736938 Copy into fixed size bufferCaolán McNamara2017-01-081-6/+6
| | | | Change-Id: If706e57343a9c81b7d31d8e018450a151d38ad49
* cleanup unused includes (related to tdf#88206)Jochen Nitschke2016-12-062-4/+0
| | | | | | | | | | | | cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Rewrite some (trivial) assignments inside if/while conditions: lotuswordproStephan Bergmann2016-11-291-2/+4
| | | | Change-Id: Iae2b653381562c5a46de6e05afb96954f523114a
* includes should be at the top of the fileNoel Grandin2016-11-1812-27/+27
| | | | | | | | | | | | not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* drop useless semicolonsDavid Tardon2016-11-131-2/+2
| | | | Change-Id: I039f8ff491b42ea9c3936bf13922df8095434228
* loplugin:countusersofdefaultparams in editeng..rscNoel Grandin2016-11-113-6/+6
| | | | Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
* loplugin:expandablemethods in lotuswordpro..packageNoel Grandin2016-11-0812-60/+17
| | | | | | | Change-Id: Ic9827c998f4f78775fdf5c1eaf9d4749d4986102 Reviewed-on: https://gerrit.libreoffice.org/30682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unnecessaryvirtual in hwpfilter..rscNoel Grandin2016-11-083-8/+8
| | | | | | | Change-Id: I2e9df8223d503b813b4c458747e8c44bb8ef8868 Reviewed-on: https://gerrit.libreoffice.org/30661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:singlevalfieldsNoel Grandin2016-11-022-5/+0
| | | | | | | Change-Id: I65f96d9cd24572c8d0946acf4d2d45eb3db83a76 Reviewed-on: https://gerrit.libreoffice.org/30476 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* style fixes for cppcheck noExplicitConstructorJochen Nitschke2016-11-011-1/+1
| | | | | | | Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin2016-10-282-6/+1
| | | | | | | | | | | | which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethodds in lotuswordpro..packageNoel Grandin2016-10-1920-70/+12
| | | | | | | Change-Id: Id33d88edc4be00f4238792d885e392cc08e72386 Reviewed-on: https://gerrit.libreoffice.org/30017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert MapUnit to scoped enumNoel Grandin2016-10-051-1/+1
| | | | | | | | | | | | I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethods in chart2..svxNoel Grandin2016-09-223-7/+2
| | | | | | | Change-Id: Ifb6045885049733415895f58cdd911256f48323c Reviewed-on: https://gerrit.libreoffice.org/29187 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* -Werror,-Wunused-private-fieldStephan Bergmann2016-09-151-1/+0
| | | | Change-Id: I8200bd0fa2480cbca71305027963fa1cd9106a91
* loplugin:singlevalfields in l10ntools..saxNoel Grandin2016-09-1538-185/+35
| | | | | | and ignore URE headers in the plugin Change-Id: I939df744c1173cf0f67d515f6c3fb4ac4cb25588
* replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl2016-09-152-4/+4
| | | | | | | | ... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
* loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2016-09-1393-211/+211
| | | | | | | | | | | | | | | | | The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
* coverity#1372879 Integer overflowed argumentCaolán McNamara2016-09-131-3/+9
| | | | Change-Id: I9e5115a00781d07c9c57e39854d6e1482bd02795
* loplugin:constantparam in extensions..lotuswordproNoel Grandin2016-09-124-12/+7
| | | | | | | Change-Id: Ifb30d5d53536045638d872761626a1b60fa52dad Reviewed-on: https://gerrit.libreoffice.org/28831 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:countusersofdefaultparamsNoel Grandin2016-08-304-5/+5
| | | | | | | Change-Id: I69f55593e6101906e0e97565f2cfc818852258dd Reviewed-on: https://gerrit.libreoffice.org/28486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* silence coverity#1371316 operator= is equal to default, so unnecessaryCaolán McNamara2016-08-282-10/+0
| | | | Change-Id: I9b301b6f661732ce4f6e9010324aa0a828736b50
* convert XBitmapType to scoped enumNoel Grandin2016-08-181-1/+1
| | | | Change-Id: I749831dfb78c10f3f7b9ebed6a5ee296ba6b2886
* loplugin:countusersofdefaultparams in framework..lotuswordproNoel Grandin2016-08-0519-34/+34
| | | | | | | Change-Id: I9833d85eb6543e996b0f357657c53b1c076ecde4 Reviewed-on: https://gerrit.libreoffice.org/27898 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* use std::move in a few placesNoel Grandin2016-08-051-1/+1
| | | | | | | | | | found by git grep -n '.reset.*.release' Change-Id: I498709bd32b21d9dbbaa73603ce21d21c274f8dc Reviewed-on: https://gerrit.libreoffice.org/27863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* improve passstuffbyref return analysisNoel Grandin2016-07-274-4/+4
| | | | | | | Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* new loplugin overrideparamNoel Grandin2016-07-251-1/+1
| | | | | | | | | | verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* move #includes to top of fileNoel Grandin2016-06-294-7/+6
| | | | | | | | | | | | | instead of being randomly embedded somewhere deep inside the CXX code. Found with: git grep -nP '^#include' -- *.cxx | sort -g -k 2 -t : Change-Id: I9ee432d3b665ecb6ec600bd51cc4b735a1b1127a Reviewed-on: https://gerrit.libreoffice.org/26764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* lwp: pass numbers by valueJochen Nitschke2016-06-262-8/+8
| | | | | | | | | and add const to LtTm refenrence Change-Id: I3515db0fa1b79ce73592de6cba0ec79c39a9e9f4 Reviewed-on: https://gerrit.libreoffice.org/26315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1362681 Untrusted loop boundCaolán McNamara2016-06-111-5/+17
| | | | | | | | and coverity#1362682 Untrusted loop bound Change-Id: I97eacad09abed4f91744b36f572761e43a3477fb
* remove "read request longer than buffer" warningNoel Grandin2016-06-091-1/+0
| | | | | | code is actually relying on this clamping behaviour Change-Id: I7f85679929b2c163dbabe01fc7bb8f1fe2327679
* tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2016-06-091-4/+1
| | | | | | | | | | | | | | | | | | | | This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
* Let loplugin:passstuffbyref also look at fn defn not preceded by any declStephan Bergmann2016-06-082-8/+8
| | | | Change-Id: I752bc96d2d521d790e919283cabb14b6526626f4
* tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl2016-06-068-23/+23
| | | | | | | Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* lotuswordpro: fix some endian issuesMichael Stahl2016-06-062-14/+14
| | | | Change-Id: I224c2d894071d6ec7d0afd5e2780a42b842aa32e
* loplugin:unusedfieldsNoel Grandin2016-06-022-2/+0
| | | | | | | Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* remove (un-)definitions of NDEBUG from source filesMichael Stahl2016-05-251-7/+1
| | | | | | | The build system already defines NDEBUG only if OSL_DEBUG_LEVEL=0 AND ASSERT_ALWAYS_ABORT=FALSE so the C++ code shouldn't override that. Change-Id: Ie67a576646cc7e18c3ffac67a3c81b80747ea438
* loplugin:unusedmethods in l10ntools to lotuswordproNoel Grandin2016-05-1911-161/+0
| | | | | | | Change-Id: Ibda82734821f3faa9388f7508e6a3e39e5b5007d Reviewed-on: https://gerrit.libreoffice.org/25106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann2016-05-101-1/+1
| | | | | | | | | | | | | | | | ...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
* fftester: subtable is a subtable of itselfCaolán McNamara2016-05-093-0/+9
| | | | Change-Id: I9de983e3c9436ab3a37d3482b0f18f04c7cdaaca
* fftester: fail on double parse of the same tableCaolán McNamara2016-05-082-7/+10
| | | | Change-Id: I3e462cdc8812d0ac55d9896d2b04ace34a6c4670
* teach passstuffbyref plugin to check for..Noel Grandin2016-05-064-10/+10
| | | | | | | | | | | | unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-08 01:32:54 +0000