summaryrefslogtreecommitdiffstats
path: root/lotuswordpro/source
Commit message (Collapse)AuthorAgeFilesLines
* ofz#26676 null derefCaolán McNamara2021-04-091-1/+8
| | | | | | | | Change-Id: Ic2bd8b49762266ad48263bd68a143b46fb5fd66f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104863 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9bf58fd45814f10ecf6131aeeec86123a383723f)
* ofz#20517 null-dereferenceCaolán McNamara2021-04-091-1/+3
| | | | | | | | Change-Id: I443869f848925911ed46e2f547f0dc652b1ff290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 08695569fd4fccc1722e7e3c7e0a234699199196)
* ofz#20447 Null-dereference READCaolán McNamara2021-04-091-1/+2
| | | | | | | | Change-Id: I76c1c815ab5aaf4548c886a69989fcabe3de5248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit fec7e3422f4d1c5b9382518a11d0bb99b12e41c9)
* ofz#20456 Null-dereference READCaolán McNamara2021-04-091-2/+3
| | | | | | | | | | this is the first honggfuzz (honggfuzz_asan_libreoffice) report I've seen to date Change-Id: Iac733aa63c7c94d9454b9c8596340dc2286393c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0754e581b0d8569dd08cf26f88678754f249face)
* ofz#25881 use std::vector with bounds checking accessorCaolán McNamara2021-04-092-8/+8
| | | | | | | | Change-Id: Ic557e85bce5f3ebe7224b0aa2192a74969f4fce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103194 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit f074ad34d5fbc52f4f8df4eec31ba95ee92f879b)
* tdf#129993 broken tables opening LWP fileNoel Grandin2020-01-306-80/+80
| | | | | | | | | | | | | | | | | | | regression from commit e2080e70fe8b085f18e868e46340454720fa94ca new compilerplugin returnbyref The parts that fix this specific bug are in lwprowlayout.cxx and lwprowlayout.cxx, but fix the other parts I messed up but not understanding the semantics of assigning to reference variables. Change-Id: I064cdd108c5b05da6092da0297dc7bcf487c7702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0b113d6ebbaf923e11ba576bed2691bb68e95ae6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87717 (cherry picked from commit 678e00d2251060b562f295a5fb3c0215b12c8042) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87728
* Resolves: tdf#130093 some lwp file not loadingCaolán McNamara2020-01-212-4/+1
| | | | | | | Change-Id: I2be53792f0fadcf1ca0e99c8f9fab7305d0fcddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87102 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
* tdf#120703 PVS: Silence V522 warningsMike Kaganski2019-04-144-7/+15
| | | | | | | | | V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:sequentialassign in linguistic..lotuswordproNoel Grandin2019-04-139-27/+12
| | | | | | | Change-Id: Ic561f56e1cfe06de219bd7a257186107b5c152fb Reviewed-on: https://gerrit.libreoffice.org/70706 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy: Silence warnings from WIP unhandled-self-assignment checkTamás Zolnai2019-04-101-21/+0
| | | | | | | | | | | Where it can be done by removing useless / duplicate code. For XFListStyle I removed the copy operator entirely, because it was bugous and it seems not to be used anyway. Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22 Reviewed-on: https://gerrit.libreoffice.org/70482 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* Remove unused using declarations in directories [e-l]*Gabor Kelemen2019-04-051-1/+0
| | | | | | | | | | Found by: run-clang-tidy-7 -checks=-*,misc-unused-using-decls Change-Id: Iee4e9df37d4c971ea97256d041afbc3d3aaa3d27 Reviewed-on: https://gerrit.libreoffice.org/70027 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Resolves: tdf#123815 null terminator included in stringCaolán McNamara2019-03-051-1/+3
| | | | | | | | | | | | | | | | | | | regression from... commit 18d636063fd7be165e7888af49372a6e2b851776 Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Jun 19 09:46:31 2017 +0100 ofz: use OString instead of bare char* this is no use to the reporter though, as the document format is 10 and 11 is the oldest the filter will open Change-Id: I4cdfe92e37f047493a6eab95f0e8e9f5dced1a35 Reviewed-on: https://gerrit.libreoffice.org/68745 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Rename SVBT16ToShort to SVBT16ToUInt16Stephan Bergmann2019-03-041-3/+3
| | | | | | | | | | | | For one, it that way matches reality (as it returns sal_uInt16, not short or sal_Int16) and its SVBT32ToUInt32 counterpart. For another, I plan a follow-up commit of introducing an additional SVBT16ToInt16 to explicitly return sal_Int16. Change-Id: I28915e6593ccdca0c11d7b2fa593e96e359a9532 Reviewed-on: https://gerrit.libreoffice.org/68686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unusedfields look for classes where we can make all the..Noel Grandin2019-02-279-18/+18
| | | | | | | | | fields private Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27 Reviewed-on: https://gerrit.libreoffice.org/68302 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Simplify containers iterations in [f-l]*Arkadiy Illarionov2019-02-181-32/+9
| | | | | | | | | Use range-based loop or replace with STL functions Change-Id: Ib3fab47318d1bfbb4df8f886a8cd9596525a420f Reviewed-on: https://gerrit.libreoffice.org/67914 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski2019-02-111-1/+1
| | | | | | | Change-Id: I4449fead67459bdcbdc0e9320129e7a5b36aecd9 Reviewed-on: https://gerrit.libreoffice.org/67545 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:indentation in jvmfwk..lotuswordproNoel Grandin2019-02-097-21/+20
| | | | | | | Change-Id: I1af665f4c6d34d8514dd23bb7a3eba700ce3ddbc Reviewed-on: https://gerrit.libreoffice.org/67559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* o3tl::make_unique -> std::make_unique in i18npool...reportdesignGabor Kelemen2019-01-221-5/+4
| | | | | | | | | | Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I8bee1344f7df82536f31bc5e4ec4fd379cac1d04 Reviewed-on: https://gerrit.libreoffice.org/66704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use unique_ptr in LwpTools::GetSystemDateStyleNoel Grandin2019-01-073-12/+11
| | | | | | | Change-Id: I6ea90be5736982422aaa45c7147beec1cfd5430b Reviewed-on: https://gerrit.libreoffice.org/65918 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use unique_ptr in lotuswordproNoel Grandin2019-01-0710-52/+38
| | | | | | | Change-Id: I49ae12639d1a5adab25407115cf65ebcfe3936c9 Reviewed-on: https://gerrit.libreoffice.org/65920 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use unique_ptr in BenOpenContainerNoel Grandin2019-01-074-17/+10
| | | | | | | Change-Id: Idc9d728e711f70cc11974020aa507552f31d4c9c Reviewed-on: https://gerrit.libreoffice.org/65919 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove obsolete SAL_FALLTHROUGH completelyStephan Bergmann2018-12-081-1/+1
| | | | | | | | | | ...after 7ffdd830d5fb52f2ca25aa80277d22ea6d89970b "HAVE_CPP_ATTRIBUTE_FALLTHROUGH is always true now" Change-Id: I54e5ff4e036a6bb3e5774d1c0524158aae18e937 Reviewed-on: https://gerrit.libreoffice.org/64800 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:singlevalfields in lotuswordproNoel Grandin2018-12-051-8/+0
| | | | | | | Change-Id: I1fe56271bfcbbc8aba023047b0888f75dd6ce886 Reviewed-on: https://gerrit.libreoffice.org/64600 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski2018-11-252-3/+3
| | | | | | | Change-Id: I2ae298f49ceba8059cd7236431db9a4d9a46b125 Reviewed-on: https://gerrit.libreoffice.org/63992 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* loplugin:buriedassign in dbaccess..ooxNoel Grandin2018-11-161-1/+1
| | | | | | | Change-Id: Ic0ca695a1d9d05418213475a68e233953136cc8e Reviewed-on: https://gerrit.libreoffice.org/63468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin singlevalfields improvementNoel Grandin2018-11-132-5/+1
| | | | | | | | | | checking for casting to void* turns out to mask useful stuff, so remove that and just deal with a few extra false+ Change-Id: Id9700d7ceda90ba8fdb38aa870f13a7ca3acb668 Reviewed-on: https://gerrit.libreoffice.org/63145 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:collapseif in dbaccess..lotuswordproNoel Grandin2018-11-062-28/+19
| | | | | | | Change-Id: Ia2a0d25c3833dfde0cd28337361f3cbd2aa29662 Reviewed-on: https://gerrit.libreoffice.org/62934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2018-11-041-37/+35
| | | | | | | Change-Id: I3432afca1ee9bf9e8adce1d55d58d57bf1a09cb4 Reviewed-on: https://gerrit.libreoffice.org/62847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* clang-tidy: (WIP) bugprone-too-small-loop-variable findingsTamás Zolnai2018-11-011-1/+1
| | | | | | | Change-Id: Iaa255b39928ac45dec1ed37e368c149d6027f561 Reviewed-on: https://gerrit.libreoffice.org/62701 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* simpler to use a vectorCaolán McNamara2018-10-221-4/+4
| | | | | | | | Change-Id: I6acd4b042bc29dcf52d36061e897a9bae5c8cc8b Reviewed-on: https://gerrit.libreoffice.org/62188 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* GetBulletOverride never returns nullptrCaolán McNamara2018-10-212-19/+12
| | | | | | | | Change-Id: I9becc9397a93369cd46922b66b45990e9e6a51f1 Reviewed-on: https://gerrit.libreoffice.org/62108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* use unique_ptr in LwpGraphicObject::GetGrafDataNoel Grandin2018-10-192-9/+5
| | | | | | | Change-Id: I19ba8eb5251af3b0c381275a0a18cf8c50944372 Reviewed-on: https://gerrit.libreoffice.org/61941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2018-10-171-37/+0
| | | | | | | Change-Id: I73de303f93b3557881dbb84d6d11d89f193da010 Reviewed-on: https://gerrit.libreoffice.org/61868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-tidy readability-redundant-smartptr-getNoel Grandin2018-10-173-5/+5
| | | | | | | | | redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:singlevalfields in lotuswordproNoel Grandin2018-10-166-215/+9
| | | | | | | Change-Id: Iac507cb050c93367a8d5dd4cc33106f54c5d462f Reviewed-on: https://gerrit.libreoffice.org/61816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* add SvStream::TellEndNoel Grandin2018-10-152-16/+3
| | | | | | | | | | | and simplify callsites to use it instead of the current "seek to end, find pos, seek back to original pos" pattern Change-Id: Ib5828868f73c341891efc759af8bd4695ae2f33c Reviewed-on: https://gerrit.libreoffice.org/61738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann2018-10-091-1/+1
| | | | | | | | | | | | | | | | ...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:unusedmethodsNoel Grandin2018-10-031-1/+0
| | | | | | | Change-Id: I7db0c27ff2213210ed4b46ebbadc1a2f74a18257 Reviewed-on: https://gerrit.libreoffice.org/61249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedmethodsNoel Grandin2018-09-282-10/+0
| | | | | | | Change-Id: I5f9ef043d76c55f2c761fd08a2bc1dae66b675c8 Reviewed-on: https://gerrit.libreoffice.org/61073 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:methodcycles more graph theory for the winNoel Grandin2018-09-272-38/+0
| | | | | | | | | | | | | | | implemeent a reduction approach, which is good at finding virtual methods that only themselves or their virtual partners. The accessibility GetVisArea stuff is dead since commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 Date: Wed Apr 4 11:23:22 2018 +0200 dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5 Reviewed-on: https://gerrit.libreoffice.org/60912 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typoAndrea Gelmini2018-09-261-1/+1
| | | | | | | | | Not so sure, but anyway, let's see what the gods say. Change-Id: I5abffb27f8d124c34b50a3591de1ffc8c64fa13a Reviewed-on: https://gerrit.libreoffice.org/60994 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
* loplugin:useuniqueptr in LwpFormulaInfoNoel Grandin2018-09-262-26/+18
| | | | | | | Change-Id: Iac1f025f1311ef05fd48581d5bee9875163f4f2b Reviewed-on: https://gerrit.libreoffice.org/60972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in LwpFormulaInfoNoel Grandin2018-09-262-23/+11
| | | | | | | Change-Id: I73fbad626ab1d37448ea12052a2fbafab5656fc7 Reviewed-on: https://gerrit.libreoffice.org/60971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in XFIndexNoel Grandin2018-09-261-6/+0
| | | | | | | | | but actually this object should be held by rtl::Reference Change-Id: Iabf068bd909201af5df6f987c6dcdb64679fefbd Reviewed-on: https://gerrit.libreoffice.org/60970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:externalStephan Bergmann2018-09-173-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:useuniqueptr in lotuswordproNoel Grandin2018-09-123-18/+16
| | | | | | | Change-Id: Ib34984180cea7143b6595decba785f1b55d15e2c Reviewed-on: https://gerrit.libreoffice.org/60336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:simplifyconstruct in l10ntools..packageNoel Grandin2018-09-0917-28/+6
| | | | | | | Change-Id: I8dba8ef1e7455af1e55bbd6086b49c0606bf4927 Reviewed-on: https://gerrit.libreoffice.org/60212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* ofz: infinite loopCaolán McNamara2018-08-171-2/+5
| | | | | | | Change-Id: Ie42e73ebe02cd4c2bb10c9d0e55a5256b1fffd15 Reviewed-on: https://gerrit.libreoffice.org/59248 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* -Werror,-Wformat (clang-cl)Stephan Bergmann2018-08-161-1/+1
| | | | | | | Change-Id: I2605d5d9bc201bac8160c96b47c6e03181fcbfc3 Reviewed-on: https://gerrit.libreoffice.org/59156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* ofz#9910 Direct-leakCaolán McNamara2018-08-151-15/+10
| | | | | | | | Change-Id: I14e5fbf8e572e9ea1fd8779434fd46ed43caac2c Reviewed-on: https://gerrit.libreoffice.org/59069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-05-22 07:03:02 +0000