summaryrefslogtreecommitdiffstats
path: root/libreofficekit
Commit message (Collapse)AuthorAgeFilesLines
* coverity#1351757 Uninitialized pointer fieldCaolán McNamara2017-05-121-0/+1
| | | | Change-Id: I99211e2dc016fb97b6744799b35e05acd7470464
* lok: sc: notify cell cursor position to address control in clientMarco Cecchetti2017-05-112-0/+80
| | | | | | | | | | A new callback has been introduced for notifying the client: LOK_CALLBACK_CELL_ADDRESS Change-Id: I40b38a3cb8fb658c3f00332d56cfcbaf98e13771 Reviewed-on: https://gerrit.libreoffice.org/37357 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* Resolves: rhbz#144437 make gnome-documents not crash the whole timeCaolán McNamara2017-05-101-11/+23
| | | | | | | | | | | | | | | accept that once initted that LibreOffice cannot be deinitted and reinited (without lots of work), but allow the main loop to quit and restart so LOKs thread can run and exit successfully, new LOK connections will restart the main loop. The buckets of global state continues to be valid the whole time this way Change-Id: Ide54c0df2ce4065f7c192ae8c2cedfaaa2b58d72 Reviewed-on: https://gerrit.libreoffice.org/37399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* rhbz#1444437 gnome-documents finalize may not occur immediatelyCaolán McNamara2017-05-091-2/+15
| | | | | | | | | | | when LOK Widget is destroyed, it may instead happen during GC of javascript, like in the in gnome-documents case, but "destroy" will be called promptly. So close documents and office in destroy, not finalize Change-Id: I1dd7b828839894cb2d87f5c087194fe458ca22f0 Reviewed-on: https://gerrit.libreoffice.org/37398 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-211-1/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* CppunitTest_libreofficekit_tiledrendering: disable occasionally failing testMiklos Vajna2017-04-121-1/+4
| | | | | | | | | | | | | | | | | When it failed, it always failed like this: libreofficekit/qa/unit/tiledrendering.cxx:311:TiledRenderingTest::runAllTests equality assertion failed - Expected: 3 - Actual : It's not clear yet what triggers the failure, sounds like some kind of timing. Change-Id: Ib5f44523f9a29c892aeda9eb881f452b57adb8a8 Reviewed-on: https://gerrit.libreoffice.org/36445 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* CppunitTest_libreofficekit_tiledrendering: add more processEventsToIdle callsMiklos Vajna2017-04-111-0/+2
| | | | | | | | | | With this the test passes for me 10 times in a row, while previously it failed from time to time, hopefully this fixes the false negatives. Change-Id: I233276ddfe4e9d8c86557f7f1c29d997f2fb51f6 Reviewed-on: https://gerrit.libreoffice.org/36420 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* lokit: compile-test a plain C versionThorsten Behrens2017-04-063-0/+43
| | | | | | | Change-Id: Ibe2108984df8f4fef9ed681941d517ca9ad9479c Reviewed-on: https://gerrit.libreoffice.org/36177 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Use symbolic names for keys from css::awt::KeyTor Lillqvist2017-03-282-12/+18
| | | | Change-Id: Iee2f4540cddeb05fcf0ae2ecadf7de8fbb4e3a0d
* Fix typosAndrea Gelmini2017-03-252-2/+2
| | | | | | | Change-Id: Id5811d092917c872715559f4508d01e4173d090c Reviewed-on: https://gerrit.libreoffice.org/35636 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* lok: Unit test for setting of the language during load of the document.Jan Holesovsky2017-03-242-0/+89
| | | | Change-Id: Idf4d3ba6b55be1f885f9d8fc89157e7e498d4e42
* lok: Fix crash in paintPartTile() when the current view was destroyed.Jan Holesovsky2017-03-211-0/+32
| | | | | | | Change-Id: I59b71ee6815cbcfa4c8b5f68ae6dc9299856d49e Reviewed-on: https://gerrit.libreoffice.org/35494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
* lok: start describing UNO commands used through LOKTomaž Vajngerl2017-03-121-0/+15
| | | | Change-Id: I44ce5a8a7ef939cbe48f6164284fae88a090a724
* libreofficekit: GTK 3.22 deprecates gtk_show_uriMichael Stahl2017-03-061-1/+8
| | | | | | | | | | Avoid -Werror=deprecated-declaration and use gtk_show_uri_on_window instead, which needs a GtkWindow. Change-Id: Ia77978348809c8d88cb2823a1549cbdeffcc6c97 Reviewed-on: https://gerrit.libreoffice.org/34926 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* tdf#106287 Remove outdated remarkAdolfo Jayme Barrientos2017-03-031-2/+1
| | | | Change-Id: Ia26123f469cc92f91682d05e16d761d4dca5dfca
* libreofficekit: adapt README to realityMiklos Vajna2017-02-241-4/+3
| | | | Change-Id: I7098e5c304a0fa945e3d3ba794be2b7932788c74
* Better make the zero-initialization more explicitStephan Bergmann2017-02-231-1/+3
| | | | | | | ...if initializing these members is necessary at all; a bit hard to tell from the code. Change-Id: I384fbeedb3a5b0690a80cabdd13ca13d07e8d627
* loplugin:unusedfieldsNoel Grandin2017-02-222-10/+4
| | | | | | | Change-Id: I8a114bcda99f123d230d61b0d0595bfe657cc3c0 Reviewed-on: https://gerrit.libreoffice.org/34513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* gtktiledviewer: Different reply uno command for impressPranav Kant2017-02-201-1/+6
| | | | Change-Id: I9dcd32a7e64198ca4772f263ed89a458e298c53b
* gtktiledviewer: Id param is string nowPranav Kant2017-02-201-3/+3
| | | | | | It was changed in ce96c5957c38384f8911d6307605c502eca0c644 Change-Id: I4cc1f90d85e31044306ab36eaeac9d4424d965c0
* gtktiledviewer: Adjust for different delete uno cmd for impressPranav Kant2017-02-201-14/+21
| | | | Change-Id: I7fa82096298a8a7c9f586a1d3c06aa5852e6842e
* gtktiledviewer: enable comment sidebar for all doctypesPranav Kant2017-02-201-3/+1
| | | | | | | Impress was the only doctype remaining which didn't have comments api yet, but now it does Change-Id: I4e287301e879dff1c29c26880305505466ceaba4
* gtktiledviewer: Different UNO command for calcPranav Kant2017-02-161-1/+1
| | | | | | | Change-Id: I229451bac7cf4c223efd3fa18c177d650d3f9954 Reviewed-on: https://gerrit.libreoffice.org/34327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
* gtktiledviewer: This is a better place to change doc-specific controlsPranav Kant2017-02-161-5/+8
| | | | Change-Id: Id8fbebe2f6e339120741ed3744b18f50941c995e
* gtktiledviewer: Kill CommentsSidebar's docConfigurePranav Kant2017-02-161-49/+41
| | | | | | Move this code to initWindow too Change-Id: I057d9b8f60b9da2c20b28901ab958f9fc2095df3
* gtktiledviewer: Kill signalSize; move its code to initWindowPranav Kant2017-02-161-14/+5
| | | | Change-Id: I8aa0a00768e074b016ea20680c67884f19fe26df
* gtktiledviewer: Factor out per view code to separate functionPranav Kant2017-02-161-12/+24
| | | | | | | | This code (populating part selector, part mode selector etc.) is something that needs to be executed for each view, not just the view that makes open_document call. Put all such code in initWindow function from now. Change-Id: Ibf9b12adb156258aa3cfdf959fffb541a88da529
* gtktiledviewer: Store author name of each viewPranav Kant2017-02-161-4/+6
| | | | Change-Id: I9a5be9050f3bedd14b6b5602b51bf40da0a11175
* gtktiledviewer: comment id can be a string too nowPranav Kant2017-02-161-13/+12
| | | | Change-Id: Ia94041884b7fde5f6c104a41c77c6a3aa96b7be1
* Fix typosAndrea Gelmini2017-02-131-1/+1
| | | | | | | Change-Id: Iaf6bbe81f519d49b82f624282d786c8cc18d641c Reviewed-on: https://gerrit.libreoffice.org/34199 Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com> Tested-by: Aleksandar Stefanović <theonewithideas@gmail.com>
* gtktiledviewer: gtk version checksPranav Kant2017-01-311-2/+12
| | | | | | | There is no major harm in excluding these lines of code on platforms with older gtk. Change-Id: Ica3f1e2b4f60f0bab55254632663ace7b4c61d4d
* gtktiledviewer: Handle comment callback with Modify flagPranav Kant2017-01-301-18/+29
| | | | Change-Id: I8333876cc4b540c385e316ce8dcbc5f7bd1f7902
* gtktiledviewer: Unused variablePranav Kant2017-01-301-2/+1
| | | | Change-Id: I1bf8833041cf0e0a42aca1b6d851f6f4ca28d68f
* gtktiledviewer: Mark reply comments with lightgreen backgroundPranav Kant2017-01-301-0/+13
| | | | Change-Id: Ic6623ebc05f1a09d5fc1b6bae5fab149d98724ab
* gtktiledviewer: Can edit comment from comment sidebar nowPranav Kant2017-01-301-2/+27
| | | | | | | TODO: Ideal would be to replace these buttons with a popover menu containing all the actions that can be taken on a comment Change-Id: Iec19e6c4a934394f84bcf4bb20cc14f207ef95be
* coverity#1351757 Uninitialized pointer fieldCaolán McNamara2017-01-281-0/+1
| | | | Change-Id: Ieeae560fc6b6c82ef92ad5331cc6cddacb893a19
* gtktiledviewer: Can reply, delete comments from sidebarPranav Kant2017-01-271-13/+81
| | | | | | ... and put the sidebar in a scrolled window Change-Id: I57e982c849ed0c4dda4e8f5fdbcb0b85e46da36c
* gtktiledviewer: factor out user prompt entry dialogPranav Kant2017-01-271-36/+48
| | | | Change-Id: I282390f7319de2e24564e0122e8c0081235a0ef5
* lokdocview: 'comment' signal for comment callbacksPranav Kant2017-01-272-16/+98
| | | | Change-Id: I82040893added83ff13395db3917b230ef6b01d5
* gtktiledviewer: Comment dialog when tiled annotations are offPranav Kant2017-01-271-1/+44
| | | | Change-Id: I6762baac6c387d968dc6ee94d3494907c817214c
* lokdocview: Separate gobject property for turning off commentsPranav Kant2017-01-272-8/+42
| | | | | | | | | | Pass --enable-tiled-annotations to gtktiledviewer on command line to turn comments on again, by default they are turned off now. Change-Id: I40e93ab683ec9538e088ae9aa83cda2eaaf9939e Reviewed-on: https://gerrit.libreoffice.org/33622 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* gtktiledviewer: Comments sidebarPranav Kant2017-01-271-2/+96
| | | | | | | Change-Id: Icf5bb78859668bfb5c43efc3e5fa9afce8458f41 Reviewed-on: https://gerrit.libreoffice.org/33621 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* lok: Implement new callbacks for comment notificationsPranav Kant2017-01-271-0/+4
| | | | | | | Change-Id: I298183b295c68c4a39cb1f6fffe4b89b4eaee0f3 Reviewed-on: https://gerrit.libreoffice.org/33469 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* lokdocview: Turn off annotations rendering herePranav Kant2017-01-271-0/+1
| | | | | | | Change-Id: Ia1ee4f54a05ab3daca62a78fe335e731e4cfc02d Reviewed-on: https://gerrit.libreoffice.org/33465 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* CppunitTest_libreofficekit_tiledrendering: fix cppunitassertequals warningsMiklos Vajna2017-01-271-8/+8
| | | | | | | Change-Id: I0fce00d4c794918e5b14b2c4f3f9f36231f28718 Reviewed-on: https://gerrit.libreoffice.org/33604 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin: unnecessary destructor jvmfwk..lotuswordproNoel Grandin2017-01-241-2/+0
| | | | | | | | Change-Id: Iaa4f9b178ab265342255066af7fff09f5b33ab37 Reviewed-on: https://gerrit.libreoffice.org/33496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* gtktiledviewer: Make edit mode the default onePranav Kant2017-01-231-0/+2
| | | | | | | | This is a testing tool, most of the time developers want to do something with the document to test some functionality, lets keep edit mode on by default and save them a second. Change-Id: I61bbd2b85054b7ebdd14e69ca170674e260368e5
* lokdocview: Handle keypad enterPranav Kant2017-01-231-0/+1
| | | | | | | Change-Id: Ia892c346d4a3c0a5439c7977963cc502d287e6f7 Reviewed-on: https://gerrit.libreoffice.org/33445 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* lok: Listen for state change events for cell alignment commandsPranav Kant2017-01-231-12/+5
| | | | | | | | | | | | We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
* New loplugin:externvar: libreofficekitStephan Bergmann2017-01-091-1/+1
| | | | Change-Id: Ib2a19249e1dd8d187b1fdc5559a9b4b9c2825e8c
generated by cgit (git 2.34.1) at 2024-08-04 10:40:47 +0000