summaryrefslogtreecommitdiffstats
path: root/jvmfwk
Commit message (Collapse)AuthorAgeFilesLines
* Don't pass empty option to JNI_CreateJavaVMStephan Bergmann2018-04-031-6/+11
| | | | | | | | | | | | | | | | | sUserClassPath may be empty (instead of containing "-Djava.class.path=...") here, which older versions of Java have apparently silently ignored. But Java 10 now fails with JNI_EINVAL (-6). (Happens e.g. during CppunitTest_dbaccess_hsqldb_test.) Change-Id: Ifd13222f0d0ae69547bd1a9fe0fd5eae47917d0a Reviewed-on: https://gerrit.libreoffice.org/51949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 19d2ec6539f789dfbe38612e5e7807cac9fe0819) Reviewed-on: https://gerrit.libreoffice.org/51977 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9a335d04c017b39df309471f5614cfdbe8ba2ce9)
* Find Java 9 with the new registry keys on WindowsStephan Bergmann2018-02-151-25/+39
| | | | | | | | | | | | | See <https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-EEED398E-AE37- 4D12-AB10-49F82F720027> section "Windows Registry Key Changes". Change-Id: Ic30ce430663cc1608c6268fa937142f73c55f138 Reviewed-on: https://gerrit.libreoffice.org/49792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit cc8e8215c8d7583f36feca20f0a1235edc05a6d7) Reviewed-on: https://gerrit.libreoffice.org/49811 Reviewed-by: Michael Stahl <mstahl@redhat.com>
* loplugin:simplifybool for negation of comparison operatorNoel Grandin2017-11-231-1/+1
| | | | | | | Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:flatten loosen conditionNoel Grandin2017-11-141-4/+1
| | | | | | | | | the description in the comment was right, but the code was not Change-Id: I7c038e7453f4387d33ec6423c0c55446d6d0df47 Reviewed-on: https://gerrit.libreoffice.org/44680 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2017-11-131-1/+1
| | | | | | | Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91 Reviewed-on: https://gerrit.libreoffice.org/44654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
* loplugin:finalclasses in h*,i*,j*Noel Grandin2017-11-011-4/+2
| | | | | | | Change-Id: I3b5f319a88dbe6a9c2ffbfdf991345beda9a2fcd Reviewed-on: https://gerrit.libreoffice.org/44154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparam in i18nlangtagNoel Grandin2017-10-311-6/+5
| | | | | | | Change-Id: I148a47a9b63b78651ec18cd947f45b8f4dbb9345 Reviewed-on: https://gerrit.libreoffice.org/44094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constmethod in svlNoel Grandin2017-10-262-4/+4
| | | | | | | Change-Id: If92869e19c413e11f1f299a97f96b9637aaba65d Reviewed-on: https://gerrit.libreoffice.org/43864 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:includeform: jvmfwkStephan Bergmann2017-10-2327-119/+119
| | | | Change-Id: I7292ced23647692fdc85a3c234fb1469a91ad0ea
* Use loop ranges in jvmfwkJulien Nabet2017-10-136-117/+84
| | | | | | | | | | to simplify and avoid all the typedefs Change-Id: Ia14337dd71b55fc24f162b5436af76aeeb8d2575 Reviewed-on: https://gerrit.libreoffice.org/43346 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Rename and move SAL_U/W to o3tl::toU/WMike Kaganski2017-10-051-3/+4
| | | | | | | | | | | | | | | | Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Use SAL_W/SAL_U instead of reinterpret_cast btwn wchar_t* and sal_Unicode*Mike Kaganski2017-09-301-1/+1
| | | | | | | | | | This is type-safe, and allows to catch cases where a source type is changed for some reason, but reinterpret_cast masks that Change-Id: Ib64b6fa2e22d94a6bba890f0ccc3e20325c6f0a1 Reviewed-on: https://gerrit.libreoffice.org/42961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski2017-09-303-12/+14
| | | | | | | | | | | | | | | | | | We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Some more WIN32_LEAN_AND_MEANMike Kaganski2017-09-183-0/+9
| | | | | | | Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* clang-tidy modernize-use-emplace in hwpfilter..lotuswordproNoel Grandin2017-09-113-8/+6
| | | | | | | Change-Id: Ic11634ca28396fd156390c511087bae03bd5fb70 Reviewed-on: https://gerrit.libreoffice.org/42156 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#100501: Fix thinkoStephan Bergmann2017-08-281-1/+1
| | | | | | | ...in previous 52ffad9bb7be800790de6d918154dbeade88cadd "tdf#100501: Adapt to Java 9 (at least on Linux x86-64)" Change-Id: I4d6bc31e0a7051a2657bb3d1ffc20c7a03d69038
* tdf#100501: Adapt to Java 9 (at least on Linux x86-64)Stephan Bergmann2017-08-282-2/+8
| | | | | | | | | | | | | | | | | Checking with both jdk-9+181_linux-x64_bin.tar.gz and jre-9+181_linux-x64_bin.tar.gz as currently available at <http://jdk.java.net/9/> "JDK 9 Early-Access Builds": For one, make SunVersion::init understand <http://openjdk.java.net/jeps/223> "JEP 223: New Version-String Scheme" at least insofar as to accept strings like "9" with less than three dot-separated segments (where the missing segments are treated like "0"). For another, at least for Linux x86-64, libjvm.so is now apparently located in a path without an "amd64" architecture segment, "lib/server/libjvm.so". (But could that also be "client"?) Other platforms may need further adjustments. Change-Id: Idcebc833472c81a1dc74dcdd481b0a37274a8713
* remove unnecessary use of OUString::getStrNoel Grandin2017-08-172-3/+3
| | | | | | | Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* log details of exception when we catch std::exceptionNoel Grandin2017-08-131-2/+3
| | | | | | | Change-Id: Ibfaba3473b11e24381d5a71a722c021ecde3488b Reviewed-on: https://gerrit.libreoffice.org/41112 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert std::map::insert to std::map::emplaceNoel Grandin2017-08-111-3/+2
| | | | | | | | | which is considerably less verbose Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b Reviewed-on: https://gerrit.libreoffice.org/40978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevarNoel Grandin2017-07-314-14/+7
| | | | | | | | | extend oncevar to any POD type Change-Id: Ia98ee0a67f183e40fb0c38477760124b2c411dc0 Reviewed-on: https://gerrit.libreoffice.org/40564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use more OUString::operator== in forms..salNoel Grandin2017-07-134-12/+12
| | | | | | | Change-Id: I70d7e50f8c1e019524ccad915f0cca912c5035dc Reviewed-on: https://gerrit.libreoffice.org/39899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar: empty strings: jvmfwkStephan Bergmann2017-07-131-2/+1
| | | | Change-Id: Ic021968b648359d94e7e44d59606b25a6f6ce8c3
* use OString::operator== in preference to ::equalsNoel Grandin2017-07-061-1/+1
| | | | | | | Change-Id: Ib291521963a791a9c6175964571e9d9895072acf Reviewed-on: https://gerrit.libreoffice.org/39646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:oncevar in helpcompiler..jvmfwkNoel Grandin2017-06-251-5/+5
| | | | | | | Change-Id: Ia9b20a8ca95684cbeb21e3425972c43ba50df3cd Reviewed-on: https://gerrit.libreoffice.org/39187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields in jvmfwk..mysqlcNoel Grandin2017-06-231-6/+2
| | | | | | | Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08 Reviewed-on: https://gerrit.libreoffice.org/39099 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused osl/mutex.hxx includesJochen Nitschke2017-06-181-1/+0
| | | | | | | Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* use more SAL_N_ELEMENTS part 3Noel Grandin2017-06-155-15/+15
| | | | | | | Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623 Reviewed-on: https://gerrit.libreoffice.org/38789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cleanup some OString stuff in jvmfwkNoel Grandin2017-05-304-64/+45
| | | | | | | Change-Id: I80d221a348c4bd5fcec82cafc455a051237ae95d Reviewed-on: https://gerrit.libreoffice.org/38131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "loplugin:stringcopy"Stephan Bergmann2017-05-291-1/+1
| | | | | | | | | This reverts commit 957874168491f4b030fda85c65dd969aae82a670. It wasn't really necessary (see commit message of 8b1fcedcd10366523967ebcbd463b2c0c6b5b17a "...and re-eanble loplugin:stringcopy again") and reportedly causes issues with older Boost (see <https://lists.freedesktop.org/archives/libreoffice/2017-May/077786.html> "[Libreoffice-commits] core.git: jvmfwk/source").
* remove unnecessary use of OString::getStrNoel Grandin2017-05-281-1/+1
| | | | | | | Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:stringcopy (macOS)Stephan Bergmann2017-05-201-2/+2
| | | | Change-Id: I855db37cdcd17920cf02d804e5cfa38d316ba236
* loplugin:stringcopyStephan Bergmann2017-05-191-1/+1
| | | | Change-Id: I04e3faf18cd6dae39d948cfb3dd0834dd96751b1
* revert OSL_ASSERT changesChris Sherlock2017-05-077-23/+23
| | | | Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
* tdf#43157: convert jvmfwk from OSL_ASSERT to assertChris Sherlock2017-05-077-23/+23
| | | | Change-Id: Ie06633dd6a49ed9fc51dfb5e6066529020dcf268
* clang-tidy readability-simplify-boolean-expr in hwpfilter..lotuswordproNoel Grandin2017-04-243-14/+4
| | | | | | | Change-Id: I945d3fe6af5f88937b341dfc3696bf1d36344862 Reviewed-on: https://gerrit.libreoffice.org/36874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Clean up do_msvcr_magicStephan Bergmann2017-04-211-33/+38
| | | | Change-Id: I932d903d04b03d3a437db3d3c549c21a1a330965
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-212-2/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin2017-04-211-1/+1
| | | | | | | Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Use std::unique_ptr<JavaInfo> in createJavaInfoStephan Bergmann2017-04-131-18/+14
| | | | Change-Id: Ie39c40e0fd05f75e734d8cd2d33a7fb13c746f77
* Use std::unique_ptr<JavaInfo> in jfw_plugin_getAllJavaInfosStephan Bergmann2017-04-134-62/+13
| | | | Change-Id: I2beb95c42c666a788a87a45f59bc15ccfcf25aa6
* Use std::unique_ptr<JavaInfo> in jfw_plugin_getJavaInfoByPathStephan Bergmann2017-04-133-12/+8
| | | | Change-Id: I3511eaa12bb689a374a775204a3480d7c667a915
* Use std::unique_ptr<JavaInfo> in jfw_plugin_getJavaInfoFromJavaHomeStephan Bergmann2017-04-133-9/+7
| | | | Change-Id: I8be48d1eec799f347a5edaa67837cf1bbf4d2cc3
* Use std::unique_ptr<JavaInfo> in jfw_plugin_getJavaInfosFromPathStephan Bergmann2017-04-133-31/+24
| | | | | | ...thereby fixing a memory leak Change-Id: I1aa91eeb407987abcdaa5221f4abd447f881c5d2
* Simplify jfw_findAllJREsStephan Bergmann2017-04-132-154/+32
| | | | | | ...dropping remaining uses of CJavaInfo Change-Id: I76afd5af927233712181f58b14fe6f4c1a9c15c2
* Replace a use of CJavaInfo with std::unique_ptr<JavaInfo>Stephan Bergmann2017-04-132-30/+23
| | | | Change-Id: Ib659d6edf362901a95cfb50ac008520805ad0fb0
* Replace a use of CJavaInfo with std::unique_ptr<JavaInfo>Stephan Bergmann2017-04-132-16/+11
| | | | Change-Id: I89cb19969285200a61c47d29e819a50845fa692b
* More std::unique_ptr<JavaInfo> lifecycle managementStephan Bergmann2017-04-133-16/+15
| | | | Change-Id: If53347633ec4b2f8c2b221ba2057e0c38fa97b67
* Simplify passing options to jfw_startVMStephan Bergmann2017-04-131-6/+8
| | | | | | | Change-Id: Idac31e282fe4df69449298a03d491473e460c742 Reviewed-on: https://gerrit.libreoffice.org/36495 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Removed duplicated includesAndrea Gelmini2017-04-131-1/+0
| | | | | | | | | No automatic tools. Manual checked and tested. Change-Id: Ife260fa4e1d786cf81f2917a901664cc54943754 Reviewed-on: https://gerrit.libreoffice.org/36371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>