summaryrefslogtreecommitdiffstats
path: root/javaunohelper
Commit message (Collapse)AuthorAgeFilesLines
* HTML tt -> code in JavaDoc commentsStephan Bergmann2018-10-101-24/+24
| | | | | | | | | | ...to avoid "error: tag not supported in the generated HTML version: tt" with JDK 11 Change-Id: I761c987257f42d01f24c88440495698cac6226d2 Reviewed-on: https://gerrit.libreoffice.org/61614 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann2018-10-091-1/+1
| | | | | | | | | | | | | | | | ...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* New loplugin:externalStephan Bergmann2018-09-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...warning about (for now only) functions and variables with external linkage that likely don't need it. The problems with moving entities into unnamed namespacs and breaking ADL (as alluded to in comments in compilerplugins/clang/external.cxx) are illustrated by the fact that while struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } returns 1, both moving just the struct S2 into an nunnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { namespace { struct S2: S1 { int f() { return 1; } }; } int f(S2 s) { return s.f(); } } int main() { return f(N::S2()); } as well as moving just the function f overload into an unnamed namespace, struct S1 { int f() { return 0; } }; int f(S1 s) { return s.f(); } namespace N { struct S2: S1 { int f() { return 1; } }; namespace { int f(S2 s) { return s.f(); } } } int main() { return f(N::S2()); } would each change the program to return 0 instead. Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c Reviewed-on: https://gerrit.libreoffice.org/60539 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* replace rtl_allocateMemory with std::mallocNoel Grandin2018-08-291-1/+1
| | | | | | | | | where used directly, since rtl_allocateMemory now just calls into std::malloc Change-Id: I59f85bdb7efdf6baa30e8fcd2370c0f8e9c999ad Reviewed-on: https://gerrit.libreoffice.org/59685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* boostrap->bootstrapCaolán McNamara2018-08-261-1/+1
| | | | | | | | Change-Id: I3082130a39a55609fa38fbf9a667fb95fe6d60ea Reviewed-on: https://gerrit.libreoffice.org/59612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Add missing sal/log.hxx headersGabor Kelemen2018-07-301-0/+1
| | | | | | | | | | | | | | rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from filter to jvmfwk Change-Id: I2a73d63f2aaef5f26d7d08957daaa8a30b412ac5 Reviewed-on: https://gerrit.libreoffice.org/58204 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* Fix typosAndrea Gelmini2018-07-231-1/+1
| | | | | | | Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2 Reviewed-on: https://gerrit.libreoffice.org/57810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typosAndrea Gelmini2018-07-181-1/+1
| | | | | | | Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
* Use https instead of httpGulsah Kose2018-04-161-1/+1
| | | | | | | | | | | Use "https://cgit.freedesktop.org/libreoffice/core" instead of "http://cgit.freedesktop.org/libreoffice/core" Change-Id: Ic7248eeb2a9452da7236eeee08414a77714dd234 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/52926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
* loplugin:salcall fix functionsNoel Grandin2017-12-111-1/+1
| | | | | | | | | | since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:includeform: javaunohelperStephan Bergmann2017-10-237-36/+36
| | | | Change-Id: If8f65b5942fd41c7023a14f9e321568a0d6c7946
* add << operator for css::uno::ExceptionNoel Grandin2017-10-041-2/+2
| | | | | | | Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
* Fix a locking bug in our Java ComponentBase class, where after the transitionDamjan Jovanovic2017-09-131-2/+5
| | | | | | | | | | | | | | | | | to disposed, the relevant variables (bDisposed and bInDispose) are written to outside a synchronized block. The equivalent C++ implementation in main/cppuhelper/source/implbase.cxx, method WeakComponentImplHelperBase::dispose(), already does this. Patch by: me (cherry picked from commit 2d382cef5450cf1593322184649257d3666cbbd8) Change-Id: I6c3e2ef78bc3c945245fe9fb7b6b713eb83710be Reviewed-on: https://gerrit.libreoffice.org/42189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Typos for "available"Julien Nabet2017-09-021-1/+1
| | | | | | | Change-Id: I8050b1f2ea5414b6e6da3392e8e22d330c794ff5 Reviewed-on: https://gerrit.libreoffice.org/41836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* Fix typos: uniform registeredAndrea Gelmini2017-06-231-1/+1
| | | | | | | | | We have in the same files "registered" and "registred". Change-Id: I604a8fdb7d5c40fe208fc11e9120333b3eaef3da Reviewed-on: https://gerrit.libreoffice.org/39097 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* Translate German comments and debug strings (leftovers in dirs j... to q...)Johnny_M2017-06-121-1/+1
| | | | | | | | | | | | | Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "j" to "q". Additionally: - A few spelling fixes Change-Id: I5abf71dde3efc0dbaad162c705c6dc17af50f6c1 Reviewed-on: https://gerrit.libreoffice.org/38613 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* cleanup osl/diagnose.h includesJochen Nitschke2017-05-091-1/+0
| | | | | | | | | | | | | | with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* revert OSL_ASSERT changesChris Sherlock2017-05-071-2/+2
| | | | Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
* tdf#43157: convert javaunohelper from OSL_ASSERT to assertChris Sherlock2017-05-071-2/+2
| | | | Change-Id: Ia000b8e1406954cc9c65a9c4e2ad25f656db0dbd
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-212-2/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* Fix typosAndrea Gelmini2017-03-252-3/+3
| | | | | | | Change-Id: Id5811d092917c872715559f4508d01e4173d090c Reviewed-on: https://gerrit.libreoffice.org/35636 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* teach lolugin:stringconstant about calling constructorsNoel Grandin2017-01-311-6/+2
| | | | | | | | | | | so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove dynamic exception specificationsStephan Bergmann2017-01-261-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Typo: listerner->listenerJulien Nabet2017-01-171-1/+1
| | | | | | | Change-Id: Ib2cb62477630641f0302769eacdd0dd00f4e760c Reviewed-on: https://gerrit.libreoffice.org/33192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* OSL_TRACE->SAL in framework..salNoel Grandin2016-12-131-2/+2
| | | | | | | Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9 Reviewed-on: https://gerrit.libreoffice.org/31903 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* javaunohelper: fix all javadoc warningsMichael Stahl2016-02-176-3/+146
| | | | Change-Id: Iaaeab13005fef160def2e5bd49d4bfd40f42fe33
* cid#1326918 FB.NP_CLONE_COULD_RETURN_NULLStephan Bergmann2016-02-081-10/+13
| | | | Change-Id: I875cc2fc868fb4f1f45e90320e1fdaf70fe871d8
* coverity#1326400 Dereference null return valueCaolán McNamara2016-02-041-6/+6
| | | | Change-Id: Ie28d817d7be24b2de19f51e11786c0396a2e016f
* coverity#1326973 SBSC: String concatenation in loop using + operatorCaolán McNamara2015-12-301-4/+6
| | | | Change-Id: I8fb8afa2951201106443f76fde3f55ead24d43c2
* related tdf#86784: new API got backported to 5.1Thorsten Behrens2015-12-211-2/+2
| | | | Change-Id: Id195e487a029424e490008915f0df513a32b22b0
* cid#1343654 FindBugs: Bad practice (FB.DMI_RANDOM_USED_ONLY_ONCE)Stephan Bergmann2015-12-211-1/+3
| | | | Change-Id: Ifbc362835bc62578851a029e9c5ce8c20184846a
* Fix @since tagsStephan Bergmann2015-12-201-2/+2
| | | | Change-Id: I0ef45caae00ba056fd5feffb1b393b024775db5e
* tdf#86784: Pass custom options to Java bootstrapKatarina Behrens2015-12-181-7/+51
| | | | | | | Change-Id: I9e9c78387627e173dea8062e4a3f16bc396e8115 Reviewed-on: https://gerrit.libreoffice.org/20720 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Add build toolchain to upload LibreOffice API to Maven CentralDavid Ostrovsky2015-12-031-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set up the toolchain to create sources and javadocs artifacts in addition to JARs created during the build. Use Buck build tool for that: [1]. This is a fork of Google's build tool Blaze, created by Xooglers at Facebook. This build tool (like Blaze itself) uses Python to write build files. Add needed tools and build files to install LibreOffice API artifacts to local Maven repository or deploy them to Maven Central. To build all needed artifacts LibreOffice must be built regularly with GNU make first. To build the rest of the API (sources and javadocs): $> buck build api To replace version number with upcoming release version: $> solenv/bin/version.py 5.1.0 To install the API to local Maven repository: $> buck build api_install To deploy the API to Maven Central: $> buck build api_deploy Detailed documentation is added to document the prerequisites and the workflow to upload LibreOffice API to Maven Central. * [1] https://buckbuild.com Change-Id: Ibdd552a01110836703bc069abe829b9921491cac Reviewed-on: https://gerrit.libreoffice.org/20343 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Expose metadata to deploy LibreOffice artifacts on Maven CentralDavid Ostrovsky2015-12-011-0/+44
| | | | | | | | | | | | | | | | | As outlined in the requirements to deploy the artifacts on Maven Central, the metdata must be provided: * Project Name, Description and URL * License Information * Developer Information * SCM Information [1] http://central.sonatype.org/pages/requirements.html Change-Id: I0bcd19a22d0e1a48f0faec0b414f816f7da5b318 Reviewed-on: https://gerrit.libreoffice.org/20315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* cppcheck: noExplicitConstructorCaolán McNamara2015-11-241-1/+1
| | | | Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
* Don't assume sal_Unicode is unsigned shortStephan Bergmann2015-11-172-3/+3
| | | | Change-Id: I083a33e71d1bb9fcef3b287e1db15910779312ab
* coverity#1338592 Explicit null dereferencedCaolán McNamara2015-11-111-4/+2
| | | | Change-Id: Ief5c2effbddebe29fc7a4d38ed0af4fed72de40e
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-103-21/+21
| | | | Change-Id: I89aa17e66c502e81089f42578b45097f44de4ea9
* new loplugin: oncevarNoel Grandin2015-11-091-8/+4
| | | | | | | Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* java: remove ((unnecessary)) parenthesesNoel Grandin2015-11-054-12/+10
| | | | Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
* java: combine nested if statementsNoel Grandin2015-11-052-18/+11
| | | | Change-Id: I0457b81668e9427a3c8d6a4af93438b7fb2bb7ba
* java:no need to explicitly create these constructorsNoel Grandin2015-11-051-4/+0
| | | | | | the compiler will do it for you Change-Id: I770670e70a43664a87ce28b48fc822d891d8fb41
* UNO: no need to use OUString constructor when calling createInstanceNoel Grandin2015-10-301-2/+2
| | | | | | | Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* com::sun::star->css in lingucomponentNoel Grandin2015-10-231-2/+2
| | | | Change-Id: Iceef10c51db88b3e85f118a366de45f0f70bbf21
* coverity#1326731 Dm: Dubious method usedCaolán McNamara2015-10-151-2/+6
| | | | | | | | | | | and coverity#1326732 Dm: Dubious method used coverity#1326734 Dm: Dubious method used coverity#1326735 Dm: Dubious method used coverity#1326739 Dm: Dubious method used Change-Id: Id9d39decf7442b503079ebcfe8c881f0f2fe3eb3
* cid#1326115 Unchecked return valueNoel Grandin2015-10-151-13/+2
| | | | | | and drop some truly bizarre and unnecessary code Change-Id: I105ba8784b6c4179a3cd7ad5bf9a250fd680d64a
* cid#1326733 Dm: Dubious method usedNoel Grandin2015-10-141-29/+25
| | | | | | | there is no point in re-decoding a Java String object, it is already UTF-16 Change-Id: Iedc59d457422d32b306782f24cac9b6c2f6b04fe
* use early returns to make method easier to readNoel Grandin2015-10-141-74/+73
| | | | Change-Id: Iabaedbd51d3832eff8e7470fd586132c38e1d039
* Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann2015-10-121-3/+3
| | | | Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274