summaryrefslogtreecommitdiffstats
path: root/include/vcl/gfxlink.hxx
Commit message (Collapse)AuthorAgeFilesLines
* inline GfxLink::SwapInNoel Grandin2018-10-061-3/+2
| | | | | | | | | only called from one site Change-Id: I2f8cb927df2f4f389c5d1bee19845aed5535663b Reviewed-on: https://gerrit.libreoffice.org/61437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constfields in vclNoel Grandin2018-09-141-1/+1
| | | | | | | Change-Id: I1072642be4fdfa720e61f2d7bad3c2701eb81610 Reviewed-on: https://gerrit.libreoffice.org/60430 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#103913 keep ".emf" file extension and mime typeLászló Németh2018-06-191-0/+1
| | | | | | | | | | | in documents, don't change them to wmf and image/x-wmf silently, resulting for example, dropping or rejecting modified documents by firewall packet filtering. Change-Id: I3b8634ae022c7c026b0ed4ebc345c1c3b3f96337 Reviewed-on: https://gerrit.libreoffice.org/56045 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
* Function to load graphic swapped out (loaded on demand)Tomaž Vajngerl2018-04-201-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a document is loaded it takes a lot of time and memory to load the graphic that are in the documet, so avoid that and just store the compressed graphic into a temporary file (handeled by GfxLink) and load when we really need to show the graphic. GraphicObject cached some attributes from Graphic, but this attributes now aren't available immediately so this attributes are removed form GraphicObject and now delegate to the Graphic itself. GetSizeBytes attribute however was removed as it is only used in some tests. GfxLink initial values were moved to the constructor and are not set in the header file anymore (as it is the recommended way to do it). The SdImportTest::testDocumentLayout failed as it looks like the dump sometimes didn't include the width and height of the null bitmap (which is set to 32x32) of the FillBitmap in some situations, but then in other situations it did include this attributes. With this change the width and height are always included for the FillBitmap which looks like it is more correct. Change-Id: Ia1218f93b1735402b7828404f65660e2d4acf32f Reviewed-on: https://gerrit.libreoffice.org/53016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* loplugin:constmethod in vcl and stocNoel Grandin2017-10-301-2/+2
| | | | | | | Change-Id: I7c02eecc16ca7cf89d9f7021116b0226885dbf06 Reviewed-on: https://gerrit.libreoffice.org/44044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert GfxLink::IsEqual to operator==Noel Grandin2017-09-291-1/+1
| | | | | | | | | exactly one use site Change-Id: Id0a75d46c459be213e81b47aa6c1194c87aec848 Reviewed-on: https://gerrit.libreoffice.org/42891 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* default dtors are fine hereCaolán McNamara2016-08-301-1/+0
| | | | Change-Id: I503f954a2729aa2737d783ed8c72f62d8a68da4c
* vcl: add graphic export-as-pdf filterMiklos Vajna2016-06-241-2/+3
| | | | | | | | | | | | In case the metafile was imported from a PDF originally, then this allows storing the PDF stream next to the graphic. This means that e.g. in Writer choosing 'Save' from the context menu of the graphic can write the original PDF stream, not the replacement metafile. Change-Id: I4ab45d5af17fe46d7538df6d79d6b57ed163572a Reviewed-on: https://gerrit.libreoffice.org/26628 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Simplify GfxLink using smart pointersMark Page2016-06-081-69/+31
| | | | | | | | | | | | | Uses std::shared_ptr for sharing graphic data Changed constructor to std::unique_ptr<sal_uInt8[]> to ensure the delete[] operator is called when GfxLink internals takes ownership of the data Change-Id: I4edd4634df8d6ba4d94953260c1a7ac560ccf04a Reviewed-on: https://gerrit.libreoffice.org/25402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Convert GfxLinkType to scoped enumNoel Grandin2016-05-311-16/+15
| | | | | | | Change-Id: Iae074ef0927a55f1fbf401cb66f4f183213f547c Reviewed-on: https://gerrit.libreoffice.org/25656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Revert "Simplify GfxLink using std::shared_ptr to clarify ownership"Stephan Bergmann2016-05-241-30/+68
| | | | | | | This reverts commit d64431ac5a7bede7661c64e0bd6d46805841e704, which caused ASan to complain about "alloc-dealloc-mismatch (operator new [] vs operator delete)" (while e.g. building Gallery_arrows), as GfxLink::mpSwpInData is a std::shared_ptr<sal_uInt8> holding a pointer to an array of sal_uInt8.
* Simplify GfxLink using std::shared_ptr to clarify ownershipMark Page2016-05-231-68/+30
| | | | | | | | | | The functionality has not changed in this class, however the ABI has changed (this class is DLL Public) Change-Id: I11005f03e747d56cb59550e071755429390db7a7 Reviewed-on: https://gerrit.libreoffice.org/25081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:unusedmethods in vclNoel Grandin2016-05-201-7/+0
| | | | | | | | | | also drops the CairoFontsCache ref-counting, since nothing was actually using it. Change-Id: If05ecb054b6b8d97b0d3010185cf23c28390ec04 Reviewed-on: https://gerrit.libreoffice.org/25105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:constantparams in vcl/Noel Grandin2016-03-161-1/+1
| | | | | | | | | also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Remove excess newlinesChris Sherlock2016-02-091-10/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Formatting changes across all modulesChris Sherlock2016-02-091-5/+0
| | | | | | | | | | | | | | + Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-2/+2
| | | | Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
* Reduce scope of #include <tools/stream.hxx>Matteo Casalin2015-10-271-1/+2
| | | | Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
* loplugin:unusedmethods vclNoel Grandin2015-07-081-3/+1
| | | | Change-Id: I98b88ca3369a2c888fd63796e39d42376d513002
* vcl: remove more unnecessary headers from mapmod.hxxMichael Stahl2014-11-141-0/+1
| | | | Change-Id: I9ce4c11cc9e7e703fbaad76a062ad38bb900ed9a
* improve the inlinesimplememberfunctions clang pluginNoel Grandin2014-06-171-4/+4
| | | | Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
* loplugin: inlinesimplememberfunctionsNoel Grandin2014-06-091-2/+2
| | | | Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
* Remove visual noise from includeAlexander Wilms2014-03-011-10/+10
| | | | | | | | | | | | | | | Conflicts: include/framework/preventduplicateinteraction.hxx include/sfx2/sfxbasecontroller.hxx include/sfx2/sfxbasemodel.hxx include/toolkit/awt/vclxtabpagemodel.hxx include/vcl/field.hxx include/vcl/settings.hxx Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2 Reviewed-on: https://gerrit.libreoffice.org/8272 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: #i15508# Added support for BMP file typeArmin Le Grand2014-02-271-2/+4
| | | | | | | | | | | | | (cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4) Conflicts: filter/source/msfilter/escherex.cxx include/vcl/gfxlink.hxx svx/source/xml/xmlgrhlp.cxx sw/source/ui/docvw/romenu.cxx vcl/source/filter/graphicfilter.cxx Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
* coverity#1187863 unused mnExtra2Caolán McNamara2014-02-271-1/+0
| | | | Change-Id: Ic6a55a3640d782ba95a5ba4681f447ee28ae163e
* vcl: sal_Bool -> boolStephan Bergmann2014-02-211-9/+9
| | | | Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
* convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin2014-02-041-1/+1
| | | | | | | | | | as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* convert SvStream::operator<< overloads to more explicit methodsNoel Grandin2014-01-161-1/+1
| | | | | | | | | This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
* fdo#70338 : Fixed file corruption issue after save for docx.Sushil Shinde2013-12-131-0/+1
| | | | | | | | | | | | - File was giving corruption message if saved in LO. - Issue due to video file. - Attached file contain .mov which was not handled properly. - Added mov extension support in graphic filter. Reviewed on: https://gerrit.libreoffice.org/6818 Change-Id: Ia278127ddc4afcd2d5fe04e86ed6201fb28dc04f
* fixincludeguards.sh: include/vclThomas Arnhold2013-10-231-2/+2
| | | | Change-Id: Iaea4396f60aeade5303bf83a4504ad62f161b83c
* Related: fdo#38838 remove UniString::EqualsIgnoreCaseAsciiCaolán McNamara2013-09-251-3/+3
| | | | Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
* Cleanup String in connectivityNorbert Thiebaud2013-07-191-1/+1
| | | | | | | Change-Id: Ica1cf0ac9e9da9c943e50ba77b1ce4a9dc7f8300 Reviewed-on: https://gerrit.libreoffice.org/4895 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
* Clean String and sal_Bool in toolsNorbert Thiebaud2013-06-301-0/+1
| | | | | | | Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655 Reviewed-on: https://gerrit.libreoffice.org/4627 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
* execute move of global headersBjoern Michaelsen2013-04-231-0/+180
see https://gerrit.libreoffice.org/#/c/3367/ and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a