summaryrefslogtreecommitdiffstats
path: root/include/sal
Commit message (Collapse)AuthorAgeFilesLines
* [API CHANGE] Remove SAL_CALL_ELLIPSEStephan Bergmann2017-12-131-2/+0
| | | | | | | | | | | | At least internally it was unused at least ever since 9399c662f36c385b0c705eb34e636a9aec450282 "initial import", it is unlikely that it ever was used for anything useful, and it is highly unlikely that it is used by 3rd-party code. Change-Id: I8b1e7e18e041164580acbb0bdba205ec1dca71d2 Reviewed-on: https://gerrit.libreoffice.org/46364 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* gpg4libre: permit multi-select encrypt certThorsten Behrens2017-12-071-0/+1
| | | | | | And pass down all necessary parameters everywhere Change-Id: I152b9d84c0e35be9e5193a9a6f67de9fb86133b0
* Various loplugin warnings in --enable-online-update=marStephan Bergmann2017-11-211-0/+1
| | | | | | | Change-Id: I5dabd5b65420d30b8d5b631de4d755ecf385b762 Reviewed-on: https://gerrit.libreoffice.org/45027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* First steps for Calc parallelismTor Lillqvist2017-11-211-0/+2
| | | | | | | | | For now, formula group calculations are done in parallel threads when 1) OpenCL is not used, and 2) the environment variable CPU_THREADED_CALCULATION is set. This commit is a surely broken first step and does not actually work that well at all. Change-Id: Ia7e5019703ba89bff0695faef0f7504765061149
* Remove obsolete "lo_warn_unused" workaroundStephan Bergmann2017-11-081-2/+0
| | | | | | | | Per README.md, Clang 3.4 is the baseline for --enable-compiler-plugins, which is the sole consumer of the "lo_warn_unused" attribute, but Clang 3.4 already supports HAVE_GCC_ATTRIBUTE_WARN_UNUSED. Change-Id: I9654028e24852335e463c73bcb5ece5e5b54d53c
* QT5 rename from KF5Jan-Marek Glogowski2017-11-061-1/+1
| | | | | | | | Move out of unx, as this will eventually compile on other OS platforms. At least currently it doesn't contain platform dependant code. Change-Id: Iea0bebf574201881ea158381fe7ba8af2a9a6488
* KF5 initial VCL pluginJan-Marek Glogowski2017-11-061-0/+1
| | | | | | | Something that compiles, basically just interface stubs. All used Svp classes don't use any cairo. Change-Id: I9a8858c930989438cc2a3f3346c01a7abc579d62
* [API CHANGE] tdf#65393 Import signature line images from ooxmlSamuel Mehrbrodt2017-11-031-0/+1
| | | | | | | | | showing whether the signature behind the signature line is valid or not. Change-Id: Ia6cca62812019f26d55d234cac767a9b4b7c8175 Reviewed-on: https://gerrit.libreoffice.org/40980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#111486 Fix description of SAL_ macro after EMF refactorBartosz Kosiorek2017-10-271-0/+4
| | | | | | | Change-Id: Ia4530d987e8555a5c09d49492e09079a3710b53b Reviewed-on: https://gerrit.libreoffice.org/43838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove some old KDE3 and TDE stuffJan-Marek Glogowski2017-10-271-1/+0
| | | | | | | | | | | | Both VCL plugins are long gone. We currently just keep the desktop detection. Generally fall back to gtk in VCL detection. Change-Id: I35830868cb75d16ae7b90b20df699929cefa4636 Reviewed-on: https://gerrit.libreoffice.org/43940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#111486 Fix description of SAL_ macros after EMF+ refactorBartosz Kosiorek2017-10-261-1/+4
| | | | | | | Change-Id: If235956228d7f807817d9ffff3da652bd6485ffa Reviewed-on: https://gerrit.libreoffice.org/43834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
* kde5: rename classes and other relevant data: KDE[4]->KDE5Katarina Behrens2017-10-251-0/+1
| | | | | | add log area too Change-Id: I187c04c8646ec9c9264d84938e1ccf3a1cbd62f1
* loplugin:includeform: UNO API include filesStephan Bergmann2017-10-237-20/+20
| | | | | | | Change these back to consistently use the "..." form to include other UNO API include files, for the benefit of external users of this API. Change-Id: I9c9188e895eb3495e20a71ad44abfa2f6061fa94
* sw dbg_lay: make it easer to match log entries with code locationsMiklos Vajna2017-10-131-0/+1
| | | | | | | | | | Also warn when logging stops due to a limit, not because the layout finished. Change-Id: Ifd44901602edec001839ab4ee88f459b45e36da6 Reviewed-on: https://gerrit.libreoffice.org/43362 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* Rename and move SAL_U/W to o3tl::toU/WMike Kaganski2017-10-051-15/+0
| | | | | | | | | | | | | | | | Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* lok - sc: row/column headers are updated fasterMarco Cecchetti2017-10-021-0/+1
| | | | | | | | | | | | | Now the computation of the row/column headers data exploits the cached row/col positions in HeightHelper/WidthHelper. That makes updating row/column headers at the bottom of the document as fast as at the top even for very big spreadsheets. Change-Id: I27381b520aaed68662e4d07c5879046d182c70e6 Reviewed-on: https://gerrit.libreoffice.org/40451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* lok - sc: document size as sum of row heights/col widths in pixelMarco Cecchetti2017-10-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | Grid lines, cursor overlay, row/col headers are all computed by summing up row heights / col widths converted to pixels. On the contrary the document size was converted to pixel only at the end after having summed up heights/widths in twips. All that lead to have a document height/width greater than the position of the last row/col, with the scrolling in online going unplesantly far beyond the last row/column. This patch change the way the document size is computed, so that the spreadsheet height/width matches the position of the last row/column. Moreover it exploits the cache-like structure for row/col positions introduced in a previous commit. Change-Id: Ibb2cc6a7b592e359a0b1202dc9bea1dd4c421354 Reviewed-on: https://gerrit.libreoffice.org/40448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* lok - sc: a cache-like structure for row/col positions in the documentMarco Cecchetti2017-10-021-0/+1
| | | | | | | | | | | | | | | | | | | ScPositionHelper provides the ability to insert (and remove) row- position pairs where the position is in pixel and related to the spreadsheet top. In this way one can compute a new row position by starting from the nearest row presents in this cache-like data structure. It offers also the ability to invalidate the cache by removing all cached data below a given row or position. This data structure can be used for columns, too. Change-Id: Ifd66a003680ef9a3babf46ae952221c04451be9a Reviewed-on: https://gerrit.libreoffice.org/40447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
* lokdialog: Better dialog rendering APIPranav Kant2017-10-021-0/+1
| | | | | | | | | After painting the dialog, also write width and height of the rendered dialog. The dialog is rendered always on the top left of the given canvas, so client can crop the canvas accordingly. Change-Id: If052058a6db8a85d4e28ec88cffcca05564b17f0
* sal: fix numerous doxygen warningsMichael Stahl2017-09-191-0/+2
| | | | Change-Id: I2fd3fb7b67a62d349ff917466b08c75c19dcbff6
* Assert active Tasks on scheduler de-initJan-Marek Glogowski2017-09-191-0/+1
| | | | | | | | | | | | | | | | | | This shuts down the VCL scheduler later in the DeInitVCL call and asserts active pending tasks, as these will never be processed after shutdown. There is currently a TODO whitelist, so the unit tests still pass but probably most of these should be fixed. No task in the list looks critical - all seem to do some idle / cleanup work. This also processes all the Idles before shutdown. All seem to be of type sfx::SfxItemDisruptor_Impl. Change-Id: I9cc484a525cc2bacd54c4f271f86997517393e92 Reviewed-on: https://gerrit.libreoffice.org/40533 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
* PDF signing: don't fail unittest on invalid certificatesMike Kaganski2017-09-191-0/+1
| | | | | | | | | | Without this, expired/not yet valid certificates, as well as certificates without private key, make test needlessly fail. Change-Id: Ic8ff85db54f1f1b1fb49fde82424f597f1555c96 Reviewed-on: https://gerrit.libreoffice.org/42434 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* sax: allow some debug logging in FastParserMichael Stahl2017-09-131-0/+1
| | | | | | | | Multi-threading makes this difficult; have it print synchronously where it is in the input when setting: SAL_LOG="+INFO.sax.fastparser+WARN" SAX_DISABLE_THREADS=1 Change-Id: I8c77974acb2b4d4e273fc9c0f273c345d8feb2ff
* Clean up sal/backtrace.hxxStephan Bergmann2017-09-061-3/+8
| | | | | | | Change-Id: Id78e9c0ca29ff2e52591f3d446431ac23c20ab7a Reviewed-on: https://gerrit.libreoffice.org/41926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix leak BacktraceState (enable-dbgutil)Julien Nabet2017-09-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | buffer is created from sal/osl/unx/backtraceapi.cxx with: 70 auto b1 = new void *[maxDepth]; 71 int n = backtrace(b1, static_cast<int>(maxDepth)); 72 return std::unique_ptr<BacktraceState>(new BacktraceState{ b1, n }); and from sal/osl/w32/backtrace.cxx with: 79 auto pStack = new void *[maxDepth]; 80 // https://msdn.microsoft.com/en-us/library/windows/desktop/bb204633.aspx 81 // "CaptureStackBackTrace function" claims that you "can capture up to 82 // MAXUSHORT frames", and on Windows Server 2003 and Windows XP it even 83 // "must be less than 63", but assume that a too large input value is 84 // clamped internally, instead of resulting in an error: 85 int nFrames = CaptureStackBackTrace( 0, static_cast<ULONG>(maxDepth), pStack, nullptr ); 86 87 return std::unique_ptr<BacktraceState>(new BacktraceState{ pStack, nFrames }); Introduced with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=bc9a2ba677ce3fcd46c2bbef6e8faeacb14292c1 Change-Id: Iea0528f5d2b38ff1f3dc4bd50ff035bb100ab981 Reviewed-on: https://gerrit.libreoffice.org/41854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2017-09-011-1/+1
| | | | | | | Change-Id: I4496faa9ce7cad393bf06ca789099b045aea2741 Reviewed-on: https://gerrit.libreoffice.org/41785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* assert on duplicate listener in SfxListenerNoel Grandin2017-08-161-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To enable finding the source of the duplicate calls, I add new SAL API (only for internal use) to retrieve and symbolise stack backtraces. The theory is that it relatively cheap to just store a backtrace, but quite expense to symbolise it to strings. Note that the backtrace() library we use on Linux does not do a particularly good job, but it gives enough information that developers can use the addr2line tool to get more precise info. Explanation of fixes in the code that triggered the assert: In SwFrameHolder, we need to only call StartListening() if the pFrame member is actually changing. We also need to call EndListening() on the old values when pFrame changes. In SwNavigationPI, there is already a StartListening() call in the only place we assign to m_pCreateView. In ImpEditEngine, we need to ignore duplicates, because it is doing a ref-counting thing. By storing duplicates on the listener list, it doesn't need to keep track of which stylesheets its child nodes are using. Given that it therefore will see duplicate events, there is probably some performance optimisation opportunities here. In MasterPageObserver::Implementation::RegisterDocument, we seem to be getting called multiple times with the same SdDrawDocument, so just check if we've been registered already before calling StartListening() In SvxShape::impl_initFromSdrObject, do the same thing we do elsewhere in this class, i.e. only call StartListening() if the model has changed. Change-Id: I7eae5c774e1e8d56f0ad7bec80e4df0017b287ac Reviewed-on: https://gerrit.libreoffice.org/41045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* xmlsecurity: Log unknown xml elements for ooxmlSamuel Mehrbrodt2017-08-101-0/+1
| | | | | | | Change-Id: I0daf81ac91da1d6206282e486298d059b937bb21 Reviewed-on: https://gerrit.libreoffice.org/40819 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Sort list lexicographicallyStephan Bergmann2017-08-101-2/+2
| | | | Change-Id: Ib52b66544cd3f0bed1742369404eced28b8b5904
* Remove excess SAL_INFOsStephan Bergmann2017-08-101-1/+0
| | | | Change-Id: I21aa7c7878c4ec1371cec4738d2482cc101020a1
* SAL_RETURNS_NONNULL: handle old clang not understanding returns_nonnull attrMiklos Vajna2017-08-091-1/+5
| | | | | | | | | Seen on the macOS baseline. Change-Id: Ibfd4a848b2f31bb782a83c523c72ccf7de4e0e6d Reviewed-on: https://gerrit.libreoffice.org/40902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* cppu: remove unnecessary LOG_LIFECYCLE_* macrosChris Sherlock2017-07-171-0/+3
| | | | | | | Change-Id: I0f19cf7045e6ff2906404a73ce710e42800c0a72 Reviewed-on: https://gerrit.libreoffice.org/39994 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* connectivity: add initial writer backendMiklos Vajna2017-07-171-0/+1
| | | | | | | | | | Similar to the calc one. As a first step the Driver and the Connection interfaces are implemented, though the later has some stubs. Change-Id: Id043f7742fdb2006d4f88526ef4d055a6d8dee82 Reviewed-on: https://gerrit.libreoffice.org/40033 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* svl: move byte-array signing from vclAshod Nakashian2017-07-151-0/+1
| | | | | | | | | | | | Signing a generic byte-array can (and will be) used by more than the existing PDF signing code, hence the move into comphelper from vcl and ourside of the PDF-specific logic. Change-Id: I7257b5218c6ba37960c6a013746eb387917a23a4 Reviewed-on: https://gerrit.libreoffice.org/39717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* simplify some string handling in tracing callsNoel Grandin2017-06-231-0/+1
| | | | | | | Change-Id: I0fb76562429e691400a02216019c7f96791cf9b3 Reviewed-on: https://gerrit.libreoffice.org/39159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* gpg4libre: initial GPG signature validationThorsten Behrens2017-06-211-0/+1
| | | | Change-Id: I80afd77f74a6cb3f3fb7da03a6a4b74b132360d2
* add COVERITY_NOEXCEPT_FALSECaolán McNamara2017-06-061-0/+10
| | | | | | | | | | | | to markup dtors that coverity warns might throw exceptions which won't throw in practice, or where std::terminate is an acceptable response if they do Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4 Reviewed-on: https://gerrit.libreoffice.org/38318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* and fix my previous commitNoel Grandin2017-05-301-3/+1
| | | | Change-Id: I63a22d5cf7a45d7b6fb3d1b356aa98ff954449e5
* define SAL_RETURNS_NONNULL as LIBO_INTERNAL_ONLYNoel Grandin2017-05-301-3/+6
| | | | | | and improve the comment Change-Id: I832fa0133810fee920024e7df9ff3c5c1c335582
* remove unnecessary use of OString::getStrNoel Grandin2017-05-281-0/+4
| | | | | | | Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* create SAL_RETURNS_NONNULL annotationNoel Grandin2017-05-261-0/+16
| | | | | | | | | and apply it to some methods in OString and OUString Change-Id: I30e91f961b6d310799d3641f68b7ed54b3080f3a Reviewed-on: https://gerrit.libreoffice.org/38020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* connectivity: convert the other OSL_ENSURE to SAL_WARN_IFMichael Stahl2017-05-051-0/+1
| | | | Change-Id: Ie3d84129b73792e1f129d65350bf0e1455b08566
* gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2017-04-211-5/+0
| | | | | | | | | Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
* remove the old collaboration feature based on telepathyMarkus Mohrhard2017-04-141-3/+0
| | | | | | | Change-Id: I1f08d6ef43b76e7bae41ac33bb954f506ae7c485 Reviewed-on: https://gerrit.libreoffice.org/36542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* Keep list sortedStephan Bergmann2017-04-101-1/+1
| | | | Change-Id: I34fd3ed006bdcecbe8b7e1f17cb379242a5eef95
* loplugin:sallogareasNoel Grandin2017-04-101-0/+1
| | | | Change-Id: I382360e7756c8e0afa47c6bc96dfc04fec558a45
* Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann2017-04-041-5/+19
| | | | | | | | | | | | | There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Keep list sortedStephan Bergmann2017-04-041-1/+1
| | | | Change-Id: I680be319b6c2d87a8fba0e07a3b24d0a2ed478b7
* sw: [loplugin:sallogareas]Michael Stahl2017-04-031-0/+1
| | | | Change-Id: I94c552e4b2ae95f57b0c667f6072664eab570042
* Fix typosAndrea Gelmini2017-03-251-2/+2
| | | | | | | Change-Id: I998e9b2ad8ebdcc983239192cb61f6689e378ad9 Reviewed-on: https://gerrit.libreoffice.org/35633 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>