summaryrefslogtreecommitdiffstats
path: root/include/filter
Commit message (Collapse)AuthorAgeFilesLines
* convert nDrawingContainerId to sal_uInt16Noel Grandin2017-11-071-3/+3
| | | | | | | | | which is all that can be stored anyhow Change-Id: Iaec28a97ed25004715accafc0cbd4bd620bfbba9 Reviewed-on: https://gerrit.libreoffice.org/44360 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams in filterNoel Grandin2017-11-042-4/+4
| | | | | | | Change-Id: I9fc76693da88d74b6fe7bbb920b8e731b82be298 Reviewed-on: https://gerrit.libreoffice.org/44260 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparam in f*Noel Grandin2017-10-312-3/+2
| | | | | | | Change-Id: I87145db3af6c3eb180cea6b4244f98b00205a306 Reviewed-on: https://gerrit.libreoffice.org/44095 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use std::unique_ptr in EscherSolverContainerNoel Grandin2017-10-201-4/+11
| | | | | | | Change-Id: I46d10aec5b69d120dfca8fea076013664cbb3278 Reviewed-on: https://gerrit.libreoffice.org/43527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make Color a forward declarationChris Sherlock2017-10-083-3/+5
| | | | | | | Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a Reviewed-on: https://gerrit.libreoffice.org/43227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Revert "check for unnecessary DLLPUBLIC annotations"Stephan Bergmann2017-10-044-5/+5
| | | | | | | | | | | This reverts commit a599eeab786ecbe1b5b6509e3c792e5c1ba31248, plus follow-up fa4431449d0306e8179f53a2a69c549800bd24bd "Avoid bogus loplugin:dllmacro 'unnecessary *DLLPUBLIC declaration ...'". See (abandoned) <https://gerrit.libreoffice.org/#/c/42983/> "loplugin:dllmacro: Handle implicit member functions" how this would have needed to be extended to give consistent results across Linux and macOS, but then would have started to remove DLLPUBLIC from entities that apparently need to at least have default type visibility on macOS and started to make tests fail.
* check for unnecessary DLLPUBLIC annotationsNoel Grandin2017-09-294-5/+5
| | | | | | | | | on classes which are fully defined in a header file Rename the dllprivate plugin to dllmacro and add the functionality there. Change-Id: I4581d551c46a8f61213d95973f323359d08278d8
* ofz#2538 avoid oomCaolán McNamara2017-09-191-3/+3
| | | | | | | Change-Id: Ief86805a1d8c010826351d7b701678ee2945770d Reviewed-on: https://gerrit.libreoffice.org/42466 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* bBObjIsTemporary is never readJulien Nabet2017-09-061-1/+0
| | | | | | | | | | | | | | | | | since 2010-02-11 author Armin Le Grand <Armin.Le.Grand@Sun.COM> 2010-02-11 16:35:16 (GMT) committer Armin Le Grand <Armin.Le.Grand@Sun.COM> 2010-02-11 16:35:16 (GMT) commit a9626fc825840c49fd3135fbf4818e276cd347cb (patch) tree 989109ecba1c8fdcc58b22974fa011cab299aca3 parent a4d83adbf01e4d8f935ad2ded82be80d13b7cdb1 (diff) aw079 #i99386# cleanup of define and last change from CL see https://cgit.freedesktop.org/libreoffice/core/commit/?id=a9626fc825840c49fd3135fbf4818e276cd347cb Change-Id: Ib430ddb01b40e1c2d0ef3b888ebb94ebf073b88c Reviewed-on: https://gerrit.libreoffice.org/42024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* convert SHAPEFLAG defines to scoped enum ShapeFlagJochen Nitschke2017-09-022-26/+33
| | | | | | | | | | | | | | | | | | | | | | they were defined in escherex.hxx as SHAPEFLAG_* and in msdffimp.hxx as SP_*. Added include for escherex.hxx to msdffimp.hxx. Filled the missing flag bits. ShapeFlag::Deleted is not used at the moment. Convert ADD_SHAPE macro to lambda. Fix horizontal/vertical mixup in RtfSdrExport::AddLineDimensions. Comments for flag Connector were wrong. The flag applies to shapes which ARE connectors. MSO definition: "connector: A line that is used to connect two or more shapes and that remains connected to those shapes." So Rectangles and such with Connector flag don't make sense. Change-Id: I735de00110411b280a302840dc0fcdfac5156399 Reviewed-on: https://gerrit.libreoffice.org/41754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* replace magic numbers for ppt view typesJochen Nitschke2017-08-271-2/+25
| | | | | | | | Change-Id: I0cd234cd039a2117fe49e6de3461becdbfa07e30 Reviewed-on: https://gerrit.libreoffice.org/40475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* Fix two issues in ActiveX DOCX import / export codeTamás Zolnai2017-08-221-1/+1
| | | | | | | | | | | | | | | * Inline anchored VML shape had wrong vertical position ** In MSO inline shapes are positioned to the top of the baseline * During export all shape ids were the same (shape_0) ** VML shapes used to be exported only as fallback, I guess that's why it did not cause any issue before. ** Override the shapeid generator with a new one, which actually generates unique shapeids. Change-Id: I752f39d092d0b61d91824141655dae662dbeafbc Reviewed-on: https://gerrit.libreoffice.org/41319 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* loplugin:constantparamNoel Grandin2017-08-082-4/+2
| | | | | | | Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e Reviewed-on: https://gerrit.libreoffice.org/40843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* rename Anz->Cnt in filterNoel Grandin2017-08-041-1/+1
| | | | | | | Change-Id: Ic6a8b8a5504052469b232767f5671d532c2fe5f3 Reviewed-on: https://gerrit.libreoffice.org/40741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams in filterNoel Grandin2017-07-312-10/+10
| | | | | | | Change-Id: I938375bd3072dbc00e4b8c2e6d53c5c4c6ef0e7c Reviewed-on: https://gerrit.libreoffice.org/40580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constparams in filterNoel Grandin2017-07-275-22/+22
| | | | | | | Change-Id: I0ba463fcaff4c449f762a7969e0feab659b37adf Reviewed-on: https://gerrit.libreoffice.org/40471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert pXRelTo/pYRelTo to boost::optionalNoel Grandin2017-07-131-3/+5
| | | | | | | | | seems wasteful to be allocating a single int for this Change-Id: I8e1122fec8c8dc90805a38b677a1e08cd89a66ff Reviewed-on: https://gerrit.libreoffice.org/39917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in filterNoel Grandin2017-07-103-14/+17
| | | | | | | Change-Id: Ie64ba38d607733b457d66ed1b9af84303c676e13 Reviewed-on: https://gerrit.libreoffice.org/39695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Watermark: RTF font import and exportSzymon Kłos2017-06-151-0/+3
| | | | | | | | | | | | | | * font size * font family * rotation * TextPath geometry - working transparency & color * revert TextBox export removed by mistake Change-Id: I3f6df86809ae57dc40c275652a96b19d2a3d7eba Reviewed-on: https://gerrit.libreoffice.org/38494 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* clang-tidy readability-non-const-parameterNoel Grandin2017-06-091-1/+1
| | | | | | | Change-Id: I7b2680898dbfc49185fb949349d81f4ac615a470 Reviewed-on: https://gerrit.libreoffice.org/38593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#39468 Translate German comments and dbg strings (leftovers in h.. to i..)Johnny_M2017-06-061-2/+2
| | | | | | | | | | | | | Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "h" to "i". Additionally: - Fixed a few spellings Change-Id: I54ea06f8e0cf1bd4bd6c84b171bec1bd342a8df8 Reviewed-on: https://gerrit.libreoffice.org/38390 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* Revert "[API-CHANGE] Add persistent (in addition to persistant)"Stephan Bergmann2017-05-291-1/+1
| | | | | This reverts commit 795d56dfd55a78a240cef79c822ba958c4f18006. The Gerrit UI had fooled me into pushing the "Submit" button in error.
* [API-CHANGE] Add persistent (in addition to persistant)Julien Nabet2017-05-291-1/+1
| | | | | | | | | | + keep "persistant" for compatibility reasons but put it as deprecated Change-Id: I7ef8efb9f376eadfdac876d142840aab5a0b4416 Reviewed-on: https://gerrit.libreoffice.org/37042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* Fix typosAndrea Gelmini2017-05-211-1/+1
| | | | | | | Change-Id: I438b6719817e0bbb47370ec54561eed2bc402cba Reviewed-on: https://gerrit.libreoffice.org/37783 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* loplugin:unusedfieldsNoel Grandin2017-05-191-1/+0
| | | | | | | | | make it a little smarter in dealing with fields that are smart pointers Change-Id: I44072105170882dc29fb19558f1065cffc7e5f11 Reviewed-on: https://gerrit.libreoffice.org/37751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:unusedfields improve write-only analysisNoel Grandin2017-05-161-5/+1
| | | | | | | | | | by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* convert SdrLayerId to strong_intNoel Grandin2017-05-121-3/+4
| | | | | | | | | | | | | | Also - rename SetOfByte to SdrLayerIDSet - add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't allocate overlapping SdrLayerID values - add a new constant SDRLAYERPOS_NOTFOUND to be returned from SdrLayerAdmin::GetLayerPos Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8 Reviewed-on: https://gerrit.libreoffice.org/37467 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:checkunusedparams in filterNoel Grandin2017-05-032-9/+5
| | | | | | | Change-Id: Icdfe9c86b78f28fb79b697e769afe6acb1dbc6f6 Reviewed-on: https://gerrit.libreoffice.org/37139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tools: move errcode.hxx to the vcl moduleChris Sherlock2017-04-272-2/+2
| | | | | | | Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
* use strong_int for LanguageTypeNoel Grandin2017-04-261-2/+2
| | | | | | | Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:inlinefields in PPTTextObjNoel Grandin2017-04-101-21/+18
| | | | | | | Change-Id: If0bdb1cad649eb6acceca125367cbd1c3c267fc0 Reviewed-on: https://gerrit.libreoffice.org/36350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:inlinefields in PPTParaPropSetNoel Grandin2017-04-101-6/+3
| | | | | | | Change-Id: I2a307d5be85f10b410f211c020fdaa9c2bec2bec Reviewed-on: https://gerrit.libreoffice.org/36349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:inlinefields in SvxMSDffManagerNoel Grandin2017-04-101-3/+3
| | | | | | | Change-Id: I30a7f593c1d2f751adcdde1a381fb616c2dfed74 Reviewed-on: https://gerrit.libreoffice.org/36347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:inlinefields in PPTTextRulerInterpreterNoel Grandin2017-04-101-8/+7
| | | | | | | Change-Id: Ic814a5dce507b5a0cb49a093a60bd71768ee40d5 Reviewed-on: https://gerrit.libreoffice.org/36348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:singlevalfieldsNoel Grandin2017-04-061-3/+1
| | | | | | | Change-Id: Ia681765aa1da5c80a3dbe91b7376af841a9c9ec1 Reviewed-on: https://gerrit.libreoffice.org/36145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparam part2Noel Grandin2017-04-053-9/+7
| | | | | | | Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#39468 Translate German commentsJens Carl2017-03-313-4/+4
| | | | | | | | | Translate German comments in filter/ Change-Id: I2b5856f1d4b894ca64a5b8105ca3f6466b17360b Reviewed-on: https://gerrit.libreoffice.org/35953 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
* tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna2017-03-313-42/+42
| | | | | | | | | | | | | | | Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:singlevalfieldsNoel Grandin2017-03-291-2/+0
| | | | | | | Change-Id: I7f05903aaab9b0b274358243d680d0c30694ae61 Reviewed-on: https://gerrit.libreoffice.org/35804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Change SvxMSDffManager::ImportOLE nOLEId parameter from long to sal_uInt32Stephan Bergmann2017-03-232-3/+3
| | | | | | | | | | | | | | The only place this function is called (SvxMSDffManager::ImportGraphic, filter/source/msfilter/msdffimp.cxx) it is passed the sal_uInt32 return value from a call to DffPropSet::GetPropertyValue, so that seems a better type. (SvxMSDffManager::ImportOLE used long at least since d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter"; DffPropSet::GetPropertyValue used UINT32 back then, changed to sal_uInt32 with e8c2c1daae9008d383288f94600b1d34d2059fb1 "removetooltypes01: #i112600# remove tooltypes from filter". Unclear if those had ever had more compatible types in the distant past.) Change-Id: Ia486d169cd2cc0e73042e72fd4476cc2ae0e8cc5
* Fix typosAndrea Gelmini2017-03-161-1/+1
| | | | | | | Change-Id: I1488e2147fa0cd4a821eb5bfe172a58a4e396ace Reviewed-on: https://gerrit.libreoffice.org/35224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
* Fix typosAndrea Gelmini2017-03-121-1/+1
| | | | | | | Change-Id: I63da858b3f264cd099e60192633b44d362b6fad7 Reviewed-on: https://gerrit.libreoffice.org/35055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* ofz: fix ppt import leakCaolán McNamara2017-03-071-4/+9
| | | | Change-Id: I48b855f96464c74b76b473d5674fcdcc8388bf1b
* Remove redundant 'inline' keywordStephan Bergmann2017-03-034-11/+11
| | | | | | | | | | ...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typosAndrea Gelmini2017-03-032-2/+2
| | | | | | | Change-Id: I5e3c9683741ddc66283008c20794be5c2b2bc53f Reviewed-on: https://gerrit.libreoffice.org/34804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Clean up use of integer typesStephan Bergmann2017-02-271-1/+1
| | | | Change-Id: Idf47d1511aff3cdb7c139671173a97e405b6078e
* Remove dynamic exception specificationsStephan Bergmann2017-01-261-14/+9
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor cppcanvas..filterNoel Grandin2017-01-241-8/+0
| | | | | | | Change-Id: I009cdd60869a67d210edf879ddb451663a7b8676 Reviewed-on: https://gerrit.libreoffice.org/33491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:dynexcspec: Add @throws documentation, filterStephan Bergmann2017-01-191-0/+3
| | | | Change-Id: Id465279b54f775ae688d02798c7a67fc50829fc6
* new loplugin: useuniqueptr: filterNoel Grandin2017-01-162-6/+9
| | | | | | | Change-Id: Ie5cee5d7dd067df121397b60a7adc85c62906e54 Reviewed-on: https://gerrit.libreoffice.org/33155 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>