summaryrefslogtreecommitdiffstats
path: root/hwpfilter/source/hwpread.cxx
Commit message (Collapse)AuthorAgeFilesLines
* ditch problematic HWPFile::Read4b variantCaolán McNamara2021-10-131-4/+4
| | | | | | | Change-Id: Ied3603d8f96e15013f657fc5d8150969ae3b808d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* ofz: nLen should be of type 'uint' not tools::LongCaolán McNamara2021-10-131-1/+1
| | | | | | | Change-Id: If0ea7d2156511b325e866f79bf40e32418f7d658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* cid#1490898 Unchecked return valueCaolán McNamara2021-09-031-5/+5
| | | | | | | Change-Id: I49124165e0d00d84f3ebdb0414d6db58f6da1209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121519 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-311-4/+3
| | | | | | | Change-Id: I0e671742043662aec27751974223b205d24508aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-311-8/+12
| | | | | | | | | check for short reads Change-Id: I1fb142e08f5664ca73dc62f6c5a5ecfd2ee1e875 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara2021-08-291-2/+0
| | | | | | | Change-Id: Ibe0f0307d939d8ce54ffdf54ae42948bfa22303a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Fix typoAndrea Gelmini2021-07-191-1/+1
| | | | | | | Change-Id: I8babf7975eb3b8f3e43f72572e75cbf46f510b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119147 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:indentation improve checks for brace alignmentNoel Grandin2021-06-281-23/+23
| | | | | | | Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typoAndrea Gelmini2021-04-111-1/+1
| | | | | | | Change-Id: Ia6fc35fa8e6c43686b84e441ea3949b7ecbb78a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113954 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* ofz#31685 give up on large tables to avoid TimeoutCaolán McNamara2021-04-111-1/+6
| | | | | | | Change-Id: I99a7cdede74c4e8a661579467624f21fcf9132df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Related: ofz#31685 Timeout. This hunk is a simple swapCaolán McNamara2021-04-111-8/+4
| | | | | | | Change-Id: Ia4c0f2727c0278496c68f54eca3046a924fa21e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* long->tools::Long in hwpfilter..ooxNoel2020-10-221-1/+2
| | | | | | | Change-Id: I9ab8876aac7b2f8b488db6dfa9c6fd0cecd2238b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104626 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Remove unused include list in hwpfilterJulien Nabet2020-09-271-1/+0
| | | | | | | Change-Id: I7cac4483173e7c75413a6b17a468659ee2790768 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103508 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:simplifybool in hwpfilter..lotuswordproNoel Grandin2020-05-291-10/+10
| | | | | | | Change-Id: Iedfd492c963eb89fe75fdd73cae630e7e1dae119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cid#1455209 Wrapper object use after freeCaolán McNamara2019-11-021-8/+6
| | | | | | | | Change-Id: I5883d2d954d62301c8d6ca47ceedd6401aee1dc6 Reviewed-on: https://gerrit.libreoffice.org/81935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* cid#1448471 Wrapper object use after freeCaolán McNamara2019-10-291-6/+26
| | | | | | | Change-Id: I4a6f31491f857280623302569afa982b37c16e89 Reviewed-on: https://gerrit.libreoffice.org/81629 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Remove some memset callsMike Kaganski2019-10-171-3/+0
| | | | | | | | | Replace them with default initialization or calloc Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1 Reviewed-on: https://gerrit.libreoffice.org/80805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* ofz#17823 avoid timeoutCaolán McNamara2019-10-041-0/+9
| | | | | | | | Change-Id: I3658d476873a502adc0cbd8be9a4f6ffd5b62c87 Reviewed-on: https://gerrit.libreoffice.org/80236 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:indentation in helpcompiler..ioNoel Grandin2019-02-091-11/+11
| | | | | | | Change-Id: Ia3f05662cc9542feeac3096d29e9dec6d1858620 Reviewed-on: https://gerrit.libreoffice.org/67558 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* use unique_ptr in hwpfilterNoel Grandin2018-12-211-6/+6
| | | | | | | Change-Id: I3491777281912e095c9222e83028d358d6826841 Reviewed-on: https://gerrit.libreoffice.org/65522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* ofz#10259 ofz#10263 ofz#10264 ofz#10265 use-after-freeCaolán McNamara2018-09-081-1/+1
| | | | | | | | Change-Id: I3e845c21f7a4e853ce9548f2992cab324dec05a8 Reviewed-on: https://gerrit.libreoffice.org/60200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* drop the slow pathCaolán McNamara2018-01-261-38/+38
| | | | | | | | Change-Id: Ibf9721d852c1b57593e34272214d9f11c0188016 Reviewed-on: https://gerrit.libreoffice.org/48611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* ofz#5379 TimeoutCaolán McNamara2018-01-251-1/+1
| | | | | | | | Change-Id: I876ed253c61a13faae2b31c43fa595b3612cd082 Reviewed-on: https://gerrit.libreoffice.org/48610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* convert a<b?a:b to std::min(a,b)Noel Grandin2018-01-151-3/+3
| | | | | | | | | | | | with something like git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23 Note: we also convert a>b?b:a Reviewed-on: https://gerrit.libreoffice.org/47736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:simplifybool for negation of comparison operatorNoel Grandin2017-11-231-14/+14
| | | | | | | Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791 Reviewed-on: https://gerrit.libreoffice.org/45068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in hwpfilterNoel Grandin2017-11-161-4/+4
| | | | | | | Change-Id: If6e8dfcec2842a329229e5c57417ca3f00ef74b3 Reviewed-on: https://gerrit.libreoffice.org/44763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* ofz#3858 use a single scratch bufferCaolán McNamara2017-11-021-7/+6
| | | | | | | Change-Id: Icdea835b89da2e7233e17893c759e411d659811c Reviewed-on: https://gerrit.libreoffice.org/44213 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* hwp fuzzing timeoutCaolán McNamara2017-10-271-7/+8
| | | | | | | | Change-Id: I88656c558dfe1ef6e701ba54633bfe251bc4e279 Reviewed-on: https://gerrit.libreoffice.org/43884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* ofz#3160 Direct-leakCaolán McNamara2017-08-281-4/+7
| | | | | | | | Change-Id: I6dcc35aaa06c2599a4524194e5e633cd4e36474e Reviewed-on: https://gerrit.libreoffice.org/41634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* ofz#2846 null derefCaolán McNamara2017-08-031-0/+7
| | | | | | | Change-Id: I88b61d7a4faaed118db8df6f99cef08310c1f2eb Reviewed-on: https://gerrit.libreoffice.org/40724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* ofz#2668 fix oomCaolán McNamara2017-07-171-4/+20
| | | | | | | | Change-Id: Ie30b24a0ad6395d59afa2f2c96b48f98a33f18a8 Reviewed-on: https://gerrit.libreoffice.org/40064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:useuniqueptr in hwpfilterNoel Grandin2017-07-101-13/+13
| | | | | | | Change-Id: Id271fdb59cb0dedf2f180879d2116d11e45d68b3 Reviewed-on: https://gerrit.libreoffice.org/39739 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* ofz#1193 we only set these values, never read themCaolán McNamara2017-06-011-0/+1
| | | | | | | | Change-Id: Ia2f54b536a4262e19abe260e8e19c9b15cc2d0ec Reviewed-on: https://gerrit.libreoffice.org/36779 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* ofz: avoid timeout and return early on failureCaolán McNamara2017-04-281-4/+7
| | | | Change-Id: I083aa07b311fa073ea5eeb1d569b0902e0f9c095
* convert to std::vectorCaolán McNamara2017-04-281-4/+1
| | | | Change-Id: I315755d49df5d29c6c7075237b7401f16c89b449
* fix indentCaolán McNamara2017-04-281-57/+55
| | | | Change-Id: I75faea4d701f401c5367142e4710ae613c8834be
* ofz#798 oomCaolán McNamara2017-03-101-5/+5
| | | | Change-Id: I6fa8dd999af7e00d6236a1ead5f8bb519f2d128d
* bin is unusedCaolán McNamara2017-03-041-2/+1
| | | | Change-Id: I5168b18898cff023ab014a86e7afc82d7b69f363
* TyposJulien Nabet2017-02-031-1/+1
| | | | | | | Change-Id: Ic54695e86b4b462419fa7d5ded7b1ddb19ee8ed5 Reviewed-on: https://gerrit.libreoffice.org/33904 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
* new loplugin: useuniqueptr: helpcompiler..ioNoel Grandin2017-01-171-2/+2
| | | | | | | Change-Id: I6b394163c144e6b5540cb160abb613d56fe327de Reviewed-on: https://gerrit.libreoffice.org/33165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:expandablemethodds in hwpfilter..linguisticNoel Grandin2016-10-191-1/+1
| | | | | | | Change-Id: If20fd4a6cf8a8e005804dbb7caf41cce73d587a5 Reviewed-on: https://gerrit.libreoffice.org/30016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-101-2/+2
| | | | Change-Id: Idec97093ca48c14b825c7b87ec050cc99aadc526
* tdf#91067: Translate Korean commentsJihui Choi2015-07-161-38/+38
| | | | | Change-Id: Idbee9cb5a1745bb2cc3c4cb1238773da7ff2a0a3 Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
* wrong skip set hereCaolán McNamara2015-02-261-1/+1
| | | | Change-Id: I86bdd1c2603c984380b52b080504b7583155b0fb
* check if reads were successfulCaolán McNamara2015-02-251-30/+39
| | | | | | | Change-Id: I69ab0ca9c017c9a1c10d18fd850f32a92c641d12 Reviewed-on: https://gerrit.libreoffice.org/14631 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Some more loplugin:cstylecast: hwpfilterStephan Bergmann2015-01-201-1/+1
| | | | Change-Id: I0ba3fe95ab6ef317166b286531a718287308f62f
* coverity#707916 Uninitialized scalar fieldCaolán McNamara2014-05-101-2/+3
| | | | Change-Id: I42a2c556739d41728c68516646facd2009232ae2
* coverity#707918 Uninitialized scalar fieldCaolán McNamara2014-05-101-3/+4
| | | | Change-Id: I2d54b7afa9dd2639d36cdead4e4e94866d775c8d
* Change encoding from EUC-KR to utf8Julien Nabet2014-04-131-38/+38
| | | | | | | | These files have been converted with this command line: iconv -f EUC-KR -t utf8 <file> > <tmp file> For more info, see http://nabble.documentfoundation.org/About-encoding-of-some-files-in-hwpfilter-td4105106.html Change-Id: Ibb2fc0af465641d6cc9236887addefe8062d4ffe
* coverity#707909 Uninitialized scalar fieldCaolán McNamara2014-03-131-3/+4
| | | | Change-Id: I0cf8f5f862afb13b406776e17dd5036cefe23f3b