summaryrefslogtreecommitdiffstats
path: root/helpcompiler
Commit message (Collapse)AuthorAgeFilesLines
* remove unnecessary use of OString::getStrNoel Grandin2017-05-281-1/+1
| | | | | | | Change-Id: I0490efedf459190521f4339854b3394d57765fdb Reviewed-on: https://gerrit.libreoffice.org/38058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Make helpcompiler more verbose on dot ahelpsGabor Kelemen2017-05-261-1/+1
| | | | | | | | | | | | | | | | | Currently we get a warning if the ahelp is one dot and there was no previous bookmark tag. This warning contains only the text with the problemmatic ahelp. It would make it easier to hunt down such problems if we would know the file names. This patch does that, and now I see 334 problems in 137 files. Change-Id: I364368f7affb85d5c5d526dd4674757c51956aea Reviewed-on: https://gerrit.libreoffice.org/38044 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
* Clean up uses of SAL_U/SAL_W: helpcompilerStephan Bergmann2017-05-091-1/+1
| | | | Change-Id: I0b9c7959cae65428ed1e80753e31f3ee9d726fc4
* remove empty commentsNoel Grandin2017-05-031-3/+0
| | | | | | | | | | | | found with: git ls-files | xargs grep -Pzl '/\*\* (\*|\s| )*\*/' Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597 Reviewed-on: https://gerrit.libreoffice.org/37159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock2017-04-252-0/+2
| | | | | | | Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann2017-04-041-1/+1
| | | | | | | | | | | | | There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Remove unused #include <ctype.h>Stephan Bergmann2017-03-231-1/+0
| | | | Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
* Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char)Stephan Bergmann2017-03-221-2/+4
| | | | Change-Id: If8085dc00db196eb51b6f14b4f4bac7c37dab249
* Prevent calls to rtl/character.hxx functions with (signed) char argumentsStephan Bergmann2017-03-222-2/+3
| | | | | | | | | | ...that would implicitly be sign extended (for plain char only if it is signed), so non-ASCII char values would trigger the isUnicodeCodePoint assert. Change-Id: Iaf8024ad509e64525558e882fe3fd078cfb4ea91 Reviewed-on: https://gerrit.libreoffice.org/35523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* convert HelpProcessingErrorClass to scoped enumNoel Grandin2017-02-163-28/+28
| | | | | | and drop unused HELPPROCESSING_INTERNAL_ERROR enumerator Change-Id: I0f2cf063a3f1472e1d52bab5039b1c3158d4865e
* Remove dynamic exception specificationsStephan Bergmann2017-01-264-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin: unnecessary destructor forms..idlcNoel Grandin2017-01-252-4/+0
| | | | | | | Change-Id: I765e0fa61f8134a60e5ea24452c6bbcb3fa8b054 Reviewed-on: https://gerrit.libreoffice.org/33492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:dynexcspec: Add @throws documentation, helpcompilerStephan Bergmann2017-01-192-0/+5
| | | | Change-Id: Id2ebe51d610ecd372ee215f3a38a979a322e6e10
* new loplugin: useuniqueptr: helpcompiler..ioNoel Grandin2017-01-172-5/+3
| | | | | | | Change-Id: I6b394163c144e6b5540cb160abb613d56fe327de Reviewed-on: https://gerrit.libreoffice.org/33165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* New loplugin:conststringvar: helpcompilerStephan Bergmann2017-01-101-1/+1
| | | | Change-Id: Iaf9cedae10b9bc04353d175778ff68cb38fdb409
* New loplugin:charrightshiftStephan Bergmann2017-01-061-1/+1
| | | | Change-Id: Ib645fb11004bc0fe05c9c416ae72b0ae56c23a15
* New o3tl::runtimeToOUString to convert from C++ runtime NTBS to OUStringStephan Bergmann2016-11-231-1/+2
| | | | Change-Id: I613bb70b6828f615fd45af38b2d873ece55ace60
* loplugin:oncevar in helpcompiler..reportdesignNoel Grandin2016-11-021-3/+1
| | | | | | | Change-Id: I2dc57931fb230953c285aeb18f57c0a41fedafcb Reviewed-on: https://gerrit.libreoffice.org/30463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-cl loplugin: helpcompilerStephan Bergmann2016-10-161-1/+1
| | | | | | | Change-Id: I72050a984389b2685dc7d78d4d52bec4ce453b53 Reviewed-on: https://gerrit.libreoffice.org/29864 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* [API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always trueStephan Bergmann2016-09-201-2/+2
| | | | | | | | | | | | | | | | | * GCC documents -fvisibility at least as far back as the GCC 4.0 online documentation at <https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>. * For external code, odk/settings/settings.mk unconditionally set HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows. Make this a fatal configure error for now. The check should be removed completely after LO 5.3 branch-off. Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112 Reviewed-on: https://gerrit.libreoffice.org/29073 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:singlevalfields in basic..idlNoel Grandin2016-09-162-23/+1
| | | | | | | | | | | Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Reduce scope of variableStephan Bergmann2016-08-231-3/+1
| | | | Change-Id: Ib3669c8946b431b845bcb217e7cf4a5f7a89177f
* tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu2016-06-231-1/+2
| | | | | | | Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav2016-05-091-1/+2
| | | | | | | | | Used toAsciiUpperCase() from character.hxx Change-Id: I79f4638866daf8952103c8a521db925150e8dcda Reviewed-on: https://gerrit.libreoffice.org/24709 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* clang-tidy modernize-loop-convert in h-l/*Noel Grandin2016-04-282-12/+11
| | | | | | | Change-Id: I843528327b25d18476f8959cabba16371213a48a Reviewed-on: https://gerrit.libreoffice.org/24460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* update loplugin stylepolice to check local pointers varsNoel Grandin2016-04-261-6/+6
| | | | | | | | | | | | are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#84323: Make osl::Thread::wait more readableGurkaran2016-03-221-5/+2
| | | | | | | | | | It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert HighlighterLanguage to scoped enumNoel Grandin2016-02-241-1/+1
| | | | Change-Id: Ibf0871601e52ea4fa49e9622176431943c55abdd
* convert TokenTypes to scoped enumNoel Grandin2016-02-242-14/+14
| | | | Change-Id: I17c0a616dd6cf48a22896b6cd6b0df157d1f9a9f
* use consistent #define checks for the Windows platformNoel Grandin2016-02-173-7/+7
| | | | | | | | | | | | stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Remove excess newlinesChris Sherlock2016-02-091-2/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Remove unused FILE_WRITING BasicCodeTagger::TaggerExceptionStephan Bergmann2016-01-181-1/+1
| | | | Change-Id: Ie9d487c934f6d03000a1a44ee1b2d4038763a20e
* loplugin:unusedmethods unused return value in include/helpcompilerNoel Grandin2016-01-122-6/+2
| | | | Change-Id: Ieebbd896bf1ad66cd1950456ca1600f0dd8cda83
* Fix typosAndrea Gelmini2016-01-101-1/+1
| | | | | | | Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* tdf#96042: Oops, fix a typo.Jan Holesovsky2015-12-101-1/+1
| | | | | | This fixes a regression from commit 4c4999d944bbf8a34f8a320b8de6f4a325bd5d97. Change-Id: Ie8496392f4811cc1ff146d7a5c43988da0d539c2
* tdf#96042: 'std::string::find("something") == 0' means "startsWith()".Jan Holesovsky2015-12-082-3/+3
| | | | | | | This should fix a regression from 3bdd176731c351638f541a37b94094124f3c9f52, apparently the cppcheck's advice is misleading. Change-Id: I427ecaa1eb3c9841cb6112997b9b51feda4583d0
* loplugin:unusedfieldsNoel Grandin2015-11-302-3/+0
| | | | Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
* loplugin:unusedfields helpcompilerNoel Grandin2015-11-204-10/+4
| | | | Change-Id: I8a4feaea642cf781fde54e4afc5cd98e326f8db3
* cppcheck:stlIfStrFindNoel Grandin2015-11-152-3/+3
| | | | | | | | | "Inefficient usage of string::find() in condition; string::compare() would be faster." Change-Id: I90403b1d05eff6499c10be33068e5fd4fed30b62 Reviewed-on: https://gerrit.libreoffice.org/19966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-106-45/+45
| | | | Change-Id: I6e34abccb0bda1c76e30ab973b8fd827d6c99c72
* coverity#1338271 Uncaught exceptionCaolán McNamara2015-11-061-48/+57
| | | | Change-Id: Ib2b7617f9862b904bd3d5939800244c541eba8a5
* coverity#1338258 Uncaught exceptionCaolán McNamara2015-11-062-2/+2
| | | | Change-Id: I61032db81c012f2120bdd971111155d660eef5b4
* coverity#1338235 Uncaught exceptionCaolán McNamara2015-11-062-2/+2
| | | | Change-Id: I66bd63a75e9d75cb5d87be5e4573aec891994588
* Fix typosAndrea Gelmini2015-09-301-1/+1
| | | | | | | Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8 Reviewed-on: https://gerrit.libreoffice.org/18953 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
* boost->stdCaolán McNamara2015-09-193-7/+6
| | | | | | | | Change-Id: I5079e03f70370ed83a1158b2e278f48642108f08 Reviewed-on: https://gerrit.libreoffice.org/18692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* boost->stdCaolán McNamara2015-09-171-2/+0
| | | | Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
* loplugin:unusedmethodsNoel Grandin2015-07-301-9/+0
| | | | | | | Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1309070 Uncaught exceptionCaolán McNamara2015-07-021-0/+5
| | | | Change-Id: I33eca20633236ab98df0eabdec4e3761d544167d
* coverity#1308500 Uncaught exceptionCaolán McNamara2015-06-282-2/+2
| | | | Change-Id: I38d6c03ee380ba6b3055e000f905a4cc568d5ab6
* loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann2015-06-261-2/+1
| | | | Change-Id: I4d168bda12604116c223b6fd0d78ded484591855