summaryrefslogtreecommitdiffstats
path: root/helpcompiler
Commit message (Collapse)AuthorAgeFilesLines
* loplugin:oncevar in helpcompiler..reportdesignNoel Grandin2016-11-021-3/+1
| | | | | | | Change-Id: I2dc57931fb230953c285aeb18f57c0a41fedafcb Reviewed-on: https://gerrit.libreoffice.org/30463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* clang-cl loplugin: helpcompilerStephan Bergmann2016-10-161-1/+1
| | | | | | | Change-Id: I72050a984389b2685dc7d78d4d52bec4ce453b53 Reviewed-on: https://gerrit.libreoffice.org/29864 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* [API CHANGE] Remove HAVE_GCC_VISIBILITY_FEATURE, always trueStephan Bergmann2016-09-201-2/+2
| | | | | | | | | | | | | | | | | * GCC documents -fvisibility at least as far back as the GCC 4.0 online documentation at <https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/Code-Gen-Options.html>. * For external code, odk/settings/settings.mk unconditionally set HAVE_GCC_VISIBILITY_FEATURE for all platforms other than Windows. Make this a fatal configure error for now. The check should be removed completely after LO 5.3 branch-off. Change-Id: I1de415b6ed1591e0a7b6640ece861b6f0ef74112 Reviewed-on: https://gerrit.libreoffice.org/29073 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
* loplugin:singlevalfields in basic..idlNoel Grandin2016-09-162-23/+1
| | | | | | | | | | | Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Reduce scope of variableStephan Bergmann2016-08-231-3/+1
| | | | Change-Id: Ib3669c8946b431b845bcb217e7cf4a5f7a89177f
* tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu2016-06-231-1/+2
| | | | | | | Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* tdf#99589 tolower / toupper - dangerous to Turks ...Krishna Keshav2016-05-091-1/+2
| | | | | | | | | Used toAsciiUpperCase() from character.hxx Change-Id: I79f4638866daf8952103c8a521db925150e8dcda Reviewed-on: https://gerrit.libreoffice.org/24709 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
* clang-tidy modernize-loop-convert in h-l/*Noel Grandin2016-04-282-12/+11
| | | | | | | Change-Id: I843528327b25d18476f8959cabba16371213a48a Reviewed-on: https://gerrit.libreoffice.org/24460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* update loplugin stylepolice to check local pointers varsNoel Grandin2016-04-261-6/+6
| | | | | | | | | | | | are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* tdf#84323: Make osl::Thread::wait more readableGurkaran2016-03-221-5/+2
| | | | | | | | | | It is to improve the readability of calls to osl::Thread::wait. Change-Id: I025d89abf8e84ca73ba08f001be3f45b86c89957 Signed-off-by: Gurkaran <gurkran@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* convert HighlighterLanguage to scoped enumNoel Grandin2016-02-241-1/+1
| | | | Change-Id: Ibf0871601e52ea4fa49e9622176431943c55abdd
* convert TokenTypes to scoped enumNoel Grandin2016-02-242-14/+14
| | | | Change-Id: I17c0a616dd6cf48a22896b6cd6b0df157d1f9a9f
* use consistent #define checks for the Windows platformNoel Grandin2016-02-173-7/+7
| | | | | | | | | | | | stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Remove excess newlinesChris Sherlock2016-02-091-2/+0
| | | | | | | | | | | | | | | | | | | A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
* Remove unused FILE_WRITING BasicCodeTagger::TaggerExceptionStephan Bergmann2016-01-181-1/+1
| | | | Change-Id: Ie9d487c934f6d03000a1a44ee1b2d4038763a20e
* loplugin:unusedmethods unused return value in include/helpcompilerNoel Grandin2016-01-122-6/+2
| | | | Change-Id: Ieebbd896bf1ad66cd1950456ca1600f0dd8cda83
* Fix typosAndrea Gelmini2016-01-101-1/+1
| | | | | | | Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
* tdf#96042: Oops, fix a typo.Jan Holesovsky2015-12-101-1/+1
| | | | | | This fixes a regression from commit 4c4999d944bbf8a34f8a320b8de6f4a325bd5d97. Change-Id: Ie8496392f4811cc1ff146d7a5c43988da0d539c2
* tdf#96042: 'std::string::find("something") == 0' means "startsWith()".Jan Holesovsky2015-12-082-3/+3
| | | | | | | This should fix a regression from 3bdd176731c351638f541a37b94094124f3c9f52, apparently the cppcheck's advice is misleading. Change-Id: I427ecaa1eb3c9841cb6112997b9b51feda4583d0
* loplugin:unusedfieldsNoel Grandin2015-11-302-3/+0
| | | | Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
* loplugin:unusedfields helpcompilerNoel Grandin2015-11-204-10/+4
| | | | Change-Id: I8a4feaea642cf781fde54e4afc5cd98e326f8db3
* cppcheck:stlIfStrFindNoel Grandin2015-11-152-3/+3
| | | | | | | | | "Inefficient usage of string::find() in condition; string::compare() would be faster." Change-Id: I90403b1d05eff6499c10be33068e5fd4fed30b62 Reviewed-on: https://gerrit.libreoffice.org/19966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* loplugin:nullptr (automatic rewrite)Stephan Bergmann2015-11-106-45/+45
| | | | Change-Id: I6e34abccb0bda1c76e30ab973b8fd827d6c99c72
* coverity#1338271 Uncaught exceptionCaolán McNamara2015-11-061-48/+57
| | | | Change-Id: Ib2b7617f9862b904bd3d5939800244c541eba8a5
* coverity#1338258 Uncaught exceptionCaolán McNamara2015-11-062-2/+2
| | | | Change-Id: I61032db81c012f2120bdd971111155d660eef5b4
* coverity#1338235 Uncaught exceptionCaolán McNamara2015-11-062-2/+2
| | | | Change-Id: I66bd63a75e9d75cb5d87be5e4573aec891994588
* Fix typosAndrea Gelmini2015-09-301-1/+1
| | | | | | | Change-Id: Iab78219aff60a7a45a319a96f326e27a6e8e25b8 Reviewed-on: https://gerrit.libreoffice.org/18953 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
* boost->stdCaolán McNamara2015-09-193-7/+6
| | | | | | | | Change-Id: I5079e03f70370ed83a1158b2e278f48642108f08 Reviewed-on: https://gerrit.libreoffice.org/18692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* boost->stdCaolán McNamara2015-09-171-2/+0
| | | | Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
* loplugin:unusedmethodsNoel Grandin2015-07-301-9/+0
| | | | | | | Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* coverity#1309070 Uncaught exceptionCaolán McNamara2015-07-021-0/+5
| | | | Change-Id: I33eca20633236ab98df0eabdec4e3761d544167d
* coverity#1308500 Uncaught exceptionCaolán McNamara2015-06-282-2/+2
| | | | Change-Id: I38d6c03ee380ba6b3055e000f905a4cc568d5ab6
* loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann2015-06-261-2/+1
| | | | Change-Id: I4d168bda12604116c223b6fd0d78ded484591855
* Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2015-06-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* remove unnecessary check for null when calling deleteNoel Grandin2015-06-151-2/+1
| | | | | | | | Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
* Fix typosAndrea Gelmini2015-06-131-1/+1
| | | | | | | Change-Id: Ifaa52b49b717d893846fc1e7ae4ac50735f824ac Reviewed-on: https://gerrit.libreoffice.org/16260 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
* loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2015-06-081-1/+1
| | | | Change-Id: Idca144969e2b978fee8cd5b0868fcf418b193967
* loplugin:loopvartoosmallNoel Grandin2015-05-291-1/+1
| | | | Change-Id: I5518e40a30bdad53470cc52b59eff04ab6d873d4
* loplugin:loopvartoosmallNoel Grandin2015-05-291-1/+1
| | | | Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
* Rename makefile to match target nameMatúš Kukan2015-05-143-2/+2
| | | | Change-Id: Iba879e0c2c79fd1c307c3dfe45370dbbfd4ae998
* remove unnecessary use of void in function declarationsNoel Grandin2015-04-152-2/+2
| | | | | | | | | | | | | | | | ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
* loplugin:staticmethodsNoel Grandin2015-04-073-3/+3
| | | | Change-Id: Ibaad2adabecb878411fdd66383bca91f034477af
* V801: Decreased performanceCaolán McNamara2015-03-092-2/+2
| | | | Change-Id: Id8cd45d2844c121f63684734ab3546c24a1aab32
* Typo: containted->containedJulien Nabet2015-02-211-1/+1
| | | | Change-Id: I678c35ca2007169a38529b36fd31367bac4ed481
* Typo: trough->throughJulien Nabet2015-02-211-1/+1
| | | | Change-Id: I5af784709df88492695d1ac9c9a5b020e909f362
* Resolves: fdo#88970 fix Incorrect Extended-tips with dodgy ahelp tagsCaolán McNamara2015-02-021-5/+25
| | | | | | | | | | | | ahelp puts the tip on the previous bookmarks with hid branches but has a scattergun effect if those previous bookmarks have nothing to do with the current element being described. So take the hid attribute of the ahelp and if its hid="." use the current set of bookmarks as the context otherwise believe it and apply the tip just to the stated hid Change-Id: I00648daadf5673e1abc96f222a4526959f1f7d7a
* replace '\n' to space in extended help textAndras Timar2015-01-221-0/+1
| | | | | | | Change-Id: Ida354ee41b4158716ab39a92f009fa7c9a2ce21f Reviewed-on: https://gerrit.libreoffice.org/13919 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
* Some more loplugin:cstylecast: helpcompilerStephan Bergmann2015-01-204-31/+31
| | | | Change-Id: I9e094356601cf156537f75d0629fd214710d80e8
* fdo#39440 reduce scope of local variablesŁukasz Hryniuk2015-01-071-1/+1
| | | | | | | | | Beside scope changes, it fixes lack of initialization in a few places. Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2 Reviewed-on: https://gerrit.libreoffice.org/13755 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* Some loplugin:revisibility clean-upStephan Bergmann2015-01-051-1/+1
| | | | | | | | | | | | | Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510