summaryrefslogtreecommitdiffstats
path: root/framework
Commit message (Collapse)AuthorAgeFilesLines
* merge IUndoManager into SfxUndoManagerNoel Grandin2018-07-131-32/+31
| | | | | | | | | | | | SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some covariant parameters, which will make using std::unique_ptr easier. Change-Id: I6661b9876b18da830bead78794d237886cd3c5c9 Reviewed-on: https://gerrit.libreoffice.org/57317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* pass SvStream around by std::unique_ptrNoel Grandin2018-07-101-3/+1
| | | | | | | | | | and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typoAndrea Gelmini2018-07-083-5/+5
| | | | | | | Change-Id: I1cc4544e807d7c04aa171358ccd1c204040dff55 Reviewed-on: https://gerrit.libreoffice.org/57078 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
* loplugin:constantparamNoel Grandin2018-07-023-7/+5
| | | | | | | Change-Id: I9fbfa6163c1d4650c52b00dc911972f07fe7c0e5 Reviewed-on: https://gerrit.libreoffice.org/56778 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Improved loplugin:redundantcast (const-qualified typedefs): frameworkStephan Bergmann2018-06-291-1/+1
| | | | | | | Change-Id: Ibcceaa03a73926b559a297f62b3d1d2676c9f4f0 Reviewed-on: https://gerrit.libreoffice.org/56698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk2018-06-286-6/+47
| | | | | | | | | | | | | new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: https://gerrit.libreoffice.org/56443 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Clean up XMLNamespacesStephan Bergmann2018-06-262-22/+3
| | | | | | | | | | | | | | | ...so that it no longer has a m_aXMLAttributeNamespace member that the user- provided copy ctor did not copy. (Which was presumably by accident, but appears to not have had bad consequences due to how XMLNamespaces::adNamespace is only called before the copy ctor is called in SaxNamespaceFilter::startElement, framework/source/fwe/xml/saxnamespacefilter.cxx). Found by new -Wdeprecated-copy of GCC trunk towards GCC 9. Change-Id: I0701ecdfbef9c078a09ed411f4d9ccd166271aae Reviewed-on: https://gerrit.libreoffice.org/56469 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Rename nFlags to nSearchFlagsSamuel Mehrbrodt2018-06-191-4/+4
| | | | | | | Change-Id: Ib03046acf3d34fc307a3765d7d0b1b7d9448b507 Reviewed-on: https://gerrit.libreoffice.org/56088 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* tdf#118238 Only disable UI interaction when loading document as hiddenSamuel Mehrbrodt2018-06-191-1/+9
| | | | | | | | | | | | | | The "quiet" interaction handler was used unconditionally when loading a document via the loadComponentFromURL API method. So no dialog was shown asking the user whether he wants to enable macros. With this patch, the "quiet" interaction handler is only used, when the document was loaded with the "Hidden" property set. Change-Id: Idd522d0bf605499b071390fb58312181b755dfca Reviewed-on: https://gerrit.libreoffice.org/56086 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* tdf#108523 Remove @author annotationsAbhyudaya Sharma2018-06-183-6/+0
| | | | | | | Change-Id: I85e364da59ce70ddd97fdae9bc03a4ea76b007fc Reviewed-on: https://gerrit.libreoffice.org/55263 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Fix typosAndrea Gelmini2018-06-181-1/+1
| | | | | | | Change-Id: I77c4c8feb12d7ed6ee4b4eaa6132a91f4e655fbc Reviewed-on: https://gerrit.libreoffice.org/55967 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
* WaE: Wmaybe-uninitializedCaolán McNamara2018-06-131-1/+1
| | | | | | | | Change-Id: I48e0d84ec0307f9895b5148f9522df8f0c02ac6c Reviewed-on: https://gerrit.libreoffice.org/55758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:constantparamNoel Grandin2018-06-121-7/+6
| | | | | | | Change-Id: Ia769b3176aea287cd57414d7ce8e88c6da43883e Reviewed-on: https://gerrit.libreoffice.org/55622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* new loplugin:shouldreturnboolNoel Grandin2018-06-112-4/+2
| | | | | | | | | | | | look for methods returning only 1 and/or 0, which (most of the time) should be returning bool. Off by default, because some of this is a matter of taste Change-Id: Ib17782e629888255196e89d4a178618a9612a0de Reviewed-on: https://gerrit.libreoffice.org/54379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* menubar: framework/startpage sync help menubar entryandreas kainz2018-06-111-1/+2
| | | | | | | Change-Id: I8895c79a65750330600ebf0be19d184736fe2c1c Reviewed-on: https://gerrit.libreoffice.org/55543 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins <ci@libreoffice.org>
* look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin2018-06-081-7/+4
| | | | | | | | | | | | | | | | | Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* enable incremental linking on windowsNoel Grandin2018-06-063-6/+12
| | | | | | | | | requires a handful of workarounds Change-Id: I77c25580135eeec437716eceea1412607f8d14ca Reviewed-on: https://gerrit.libreoffice.org/55244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#42949 remove unused compheler includes ..Jochen Nitschke2018-06-0510-8/+3
| | | | | | | | | and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* drop Image(Bitmap) constructorNoel Grandin2018-06-011-3/+3
| | | | | | | | | and convert some more code from Bitmap to BitmapEx Change-Id: Icf3c18608e0bb608408fe69722441cfa19f6b161 Reviewed-on: https://gerrit.libreoffice.org/55160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
* tdf#117872: Revert "tdf#115284: Unify LibreOffice and system full-screen..."Tor Lillqvist2018-05-303-46/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead, never participate in the macOS system full-screen mode. There is just too much complexity involved, and the way LibreOffice works really isn't prepared for the concept of windows having the option from a system point of view to being full-screenable or not. This means that the green bubble in window title bars changes from being a (system) full-screen toggle to being a maximize/restore toggle. Sure, the "maximize" concept also probably can be confused with LibreOffice's own full-screen concept. For instance, the Start Centre window is not expecting to be made full-screen. Still, when you from the Start Centre open a Writer document, it is the *same* window that is re-used as the Writer window, and then suddenly should be prepared to handle going full-screen. Also, it is up to each separate kind of document window whether it can be made full-screen (from the LibreOffice point of view) or not. Writer windows can, but Impress windows can't, for example. The View>Full Screen menu entry is added separately each case. Maybe I will come back to this mess later, or not. Anybody else is welcome to have a go, too, of course. This reverts commit 4b42fd7e9516fbbd8a92d97680524f32dd260fb2. Change-Id: I6983481cbd30c0e5190c450483b1246006c80632 Reviewed-on: https://gerrit.libreoffice.org/55049 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
* Improve re-throwing of UNO exceptionsNoel Grandin2018-05-253-16/+29
| | | | | | | | | | | | | | | | | (*) if we are already throwing a Wrapped*Exception, get the exception using cppu::getCaughtexception. (*) when catching and then immediately throwing UNO exceptions, use cppu::getCaughtException to prevent exception slicing (*) if we are going to catch an exception and then immediately throw a RuntimeException, rather throw a WrappedTargetRuntimeException and preserve the original exception information. Change-Id: Ia7a501a50ae0e6f4d05186333c8517fdcb17d558 Reviewed-on: https://gerrit.libreoffice.org/54692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#115284: Unify LibreOffice and system full-screen concepts on macOSTor Lillqvist2018-05-243-2/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also tdf#76476, and probably more. Make it so that when a window is in full-screen mode from LibreOffice's point of view, it is also full-screen from the system's point of view, and vice versa. All three ways to enter and leave full-screen mode can now be used with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full Screen" menu entry, and the green bubble on the title bar. Don't disable/deactivate/etc menus while in full-screen mode. The menu auto-hides so there is no harm in having it function normally. Don't display the floating toolbar with a single "Full Screen" button in it as the way to leave full-screen mode. Instead, the same three ways that can be used to enter full-screen mode work to leave it, too. Sadly I could not figure out a way to set a window properly to full-screen at the point where a document window is created and set to be the same size as that kind of document window was the previous time it was open in LibreOffice. Thus don't save state for full-screen windows as we can't properly restore them. At least not for macOS. It is not good to just restore them as non-full-screened but still at the size they had when full-screen. One irritating glitch remains, and I was unable to fix that properly: I now prevent closing the document window that is in full-screen mode. Otherwise, if it is closed, the full-screen mode remains even if no window is open there; the desktop is completely black. Moving the cursor to the top edge, the LibreOffice menu is there, though. I tried to fix that but with no fully satisfying result. (Some attempts even lead to crashes, so just disabling closing is better than crashing at least.) Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f Reviewed-on: https://gerrit.libreoffice.org/54760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
* Fix typosAndrea Gelmini2018-05-221-1/+1
| | | | | | | Change-Id: Idbe136fbfd222e8baad588dc36a2f9b7ce6996ec Reviewed-on: https://gerrit.libreoffice.org/54590 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
* loplugin:unusedfields in formula..registryNoel Grandin2018-05-176-43/+13
| | | | | | | Change-Id: I031654d8bb4f1788d364ef4f8d3bf7a05fadb148 Reviewed-on: https://gerrit.libreoffice.org/54454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Fix typosAndrea Gelmini2018-05-053-5/+5
| | | | | | | Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: https://gerrit.libreoffice.org/53638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* loplugin:useuniqueptr in PathSettingsNoel Grandin2018-05-031-5/+3
| | | | | | | Change-Id: Ib0e6e293e10473b7ada3919f781cfd05ef78749c Reviewed-on: https://gerrit.libreoffice.org/53761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:useuniqueptr in ImageManagerImplNoel Grandin2018-05-032-17/+12
| | | | | | | Change-Id: I686d68ccee120246c20c2c52977422f49a318af9 Reviewed-on: https://gerrit.libreoffice.org/53762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* loplugin:constantparamNoel Grandin2018-04-271-3/+2
| | | | | | | Change-Id: I966dcf87be021520e7cc394338b9c0574bb8afee Reviewed-on: https://gerrit.libreoffice.org/53541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* make WB_LINESPACING a bool field on ToolboxNoel Grandin2018-04-273-3/+6
| | | | | | | Change-Id: If9332993a4917b00c230d2a3693daf8c5d3f5559 Reviewed-on: https://gerrit.libreoffice.org/53521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* cppcheck: identicalInnerConditionJochen Nitschke2018-04-211-2/+1
| | | | | | | | | | renamed temporary list in EnhancedCustomShape2d.cxx to avoid shadow of a local variable Change-Id: I17a2261dafd2067480fcc5314af4f48765d6b690 Reviewed-on: https://gerrit.libreoffice.org/53244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* Empty ELMENT should say EMPTY in dtd; fixes tdf#116791Kevin Brubeck Unhammer2018-04-151-1/+1
| | | | | | | Change-Id: I27906786edddd37d6e616f1bb5b6e8f6902e8049 Reviewed-on: https://gerrit.libreoffice.org/52878 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
* remove some unused comphelper includesJochen Nitschke2018-04-154-4/+0
| | | | | | | | | and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* Remove useless iterator in XCUBasedAcceleratorConfiguration::storeToStorageArnaud Versini2018-04-141-1/+0
| | | | | | | Change-Id: Ibe3c89901e02d495eb367882138f79cb4b7513fc Reviewed-on: https://gerrit.libreoffice.org/52872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
* Fix typosAndrea Gelmini2018-04-131-1/+1
| | | | | | | Change-Id: If4bc1698af2a43a2dbc45b8518c0f5b736d6abaf Reviewed-on: https://gerrit.libreoffice.org/52278 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* tdf#42949 Remove unnecessary localization headers from frameworkGabor Kelemen2018-04-116-12/+0
| | | | | | | | | | Found by searching for the header names and the localization function: git grep -l -e \<fwkresid.hxx\> -e \<strings.hrc\> framework/ | xargs grep -c FwkResId | grep :0$ | grep -v /pch Change-Id: I026d78b5d1400c66705bd717eca9ed95e8c75366 Reviewed-on: https://gerrit.libreoffice.org/52597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
* new loplugin:unusedvariablemoreNoel Grandin2018-04-111-2/+0
| | | | | | | | | | | | | collection of heuristics to look for local variables that are never read from i.e. do not contribute to the surrounding logic This is an expensive plugin, since it walks up the parent tree, so it is off by default. Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06 Reviewed-on: https://gerrit.libreoffice.org/52450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Revert "long->sal_Int32 in tools/gen.hxx"Stephan Bergmann2018-04-072-13/+13
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 8bc951daf79decbd8a599a409c6d33c5456710e0. As discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-April/079955.html> "long->sal_Int32 in tools/gen.hxx", that commit caused lots of problems with signed integer overflow, and the original plan was to redo it to consistently use sal_Int64 instead of sal_Int32. <https://gerrit.libreoffice.org/#/c/52471/> "sal_Int32->sal_Int64 in tools/gen.hxx" tried that. However, it failed miserably on Windows, causing odd failures like not writing out Pictures/*.svm streams out into .odp during CppunitTest_sd_export_ooxml2. So the next best approach is to just revert the original commit, at least for now. Includes revert of follow-up 8c50aff2175e85c54957d98ce32af40a3a87e168 "Fix Library_vclplug_qt5". Change-Id: Ia8bf34272d1ed38aac00e5d07a9d13fb03f439ae Reviewed-on: https://gerrit.libreoffice.org/52532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Fix typoAndrea Gelmini2018-04-041-1/+1
| | | | | | | Change-Id: I6c03a7e99b31251eb0fe1c197d565e85bec419df Reviewed-on: https://gerrit.libreoffice.org/52279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
* Remove leftover framework/inc/uielement/notebookbarmenucontroller.hxxStephan Bergmann2018-04-032-88/+0
| | | | | | | | | | ...after 5c573a2f7473bae7bb965ca36557cd1b0bf7b9c9 "tdf#115131 made a common submenu for toolbars and notebookbars" Change-Id: Ic1713fa1173a8dbb1bcc971c30d0df4549c825a9 Reviewed-on: https://gerrit.libreoffice.org/52331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* long->sal_Int32 in tools/gen.hxxNoel Grandin2018-04-032-13/+13
| | | | | | | | | which triggered a lot of changes in sw/ Change-Id: Ia2aa22ea3f76463a85ea077a411246fcfed00bf6 Reviewed-on: https://gerrit.libreoffice.org/48806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* pass area param to DBG_UNHANDLED_EXCEPTIONNoel Grandin2018-04-036-8/+8
| | | | | | | | | and update sallogareas plugin to enforce this Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a Reviewed-on: https://gerrit.libreoffice.org/52249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* tdf#115131 made a common submenu for toolbars and notebookbarsKshitij Pathania2018-04-026-331/+39
| | | | | | | | | | Also added the submenu in base, maths and draw Change-Id: I94850c09c08fd3848eabe2597679634f30fbc735 Reviewed-on: https://gerrit.libreoffice.org/49575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* remove unused processfactory.hxx includesJochen Nitschke2018-04-0134-34/+1
| | | | | | | | | and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
* tdf#115683 there are other cases of dialogs before document loadCaolán McNamara2018-03-212-3/+39
| | | | | | | | Change-Id: I97ddbb528927fecb66072b42baa90272de2af39a Reviewed-on: https://gerrit.libreoffice.org/51704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* Resolves: tdf#114648 don't show new document until wizard is finishedCaolán McNamara2018-03-201-1/+2
| | | | | | | | Change-Id: Ia9cb3fd549c17cb602fa3d7f9163a89697395c77 Reviewed-on: https://gerrit.libreoffice.org/51648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* loplugin:useuniqueptr in ImplImageListNoel Grandin2018-03-203-9/+7
| | | | | | | | | and fix leak in RemoveImage in the process Change-Id: I20e395178f92f7127e99011aebbe97246f255d1d Reviewed-on: https://gerrit.libreoffice.org/51550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* remove unused ucbstreamhelper includesJochen Nitschke2018-03-194-4/+0
| | | | | | | | | and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Use for-range loops in frameworkJulien Nabet2018-03-1727-709/+480
| | | | | | | Change-Id: I72ea832848fd7c76863bcee70a3303de488c0b0f Reviewed-on: https://gerrit.libreoffice.org/51471 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
* simplify ImageList::GetAsHorizontalStripNoel Grandin2018-03-161-8/+1
| | | | | | | | | no need to repeat logic the BitmapEx constructor already implements Change-Id: Ic958b3a3baafe9911b8461e1fc512e36616db89c Reviewed-on: https://gerrit.libreoffice.org/51401 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
* move framework/toolkit use of BitmapEx::GetMask inside vclNoel Grandin2018-03-161-16/+3
| | | | | | | Change-Id: I2a942377d6e9b8b09673e5ad2804e0e7fb2bb943 Reviewed-on: https://gerrit.libreoffice.org/51387 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>