summaryrefslogtreecommitdiffstats
path: root/framework
Commit message (Collapse)AuthorAgeFilesLines
* LoadEnv::getTargetComponent() is supposed to return nothingMaxim Monastirsky2016-05-041-0/+1
| | | | | | | | | ... if loading the document failed. Make sure that's the case also when the frame containing BackingComp was about to be recycled. Can be tested by trying to open password-protected odt, but canceling the password prompt. Change-Id: I733357b3a961fd88db010dd8eb89e01f0cad10fa
* tdf#97499 Fixed containers parameters clearing #8tymyjan2016-05-011-2/+2
| | | | | | | Change-Id: I82ca89ac483e9742be0d38a3c6882a240c7c38d8 Reviewed-on: https://gerrit.libreoffice.org/24499 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
* framework: CheckXTitle still sometimes fails on WNT...Michael Stahl2016-04-281-0/+2
| | | | | | ... when dispatching the .uno:CloseWin. Change-Id: Iaf0651ea7e05bd8a6629d5af6e62f5918ef241ce
* SubToolBarController: Use initialize to change tb bitsMaxim Monastirsky2016-04-271-6/+6
| | | | | | | update is called so late that the dropdown addition is noticeable by the user. Change-Id: I36d76770125f927a851caef010e81f12f40d4405
* tdf#80999 Canceling password prompt should abort detectionMaxim Monastirsky2016-04-271-0/+5
| | | | | | | | | | | | | | | ... instead of continuing the detection loop and being "detected" as plain text. The detection API will from now return a type based on the file extension only, which is far more useful than "plain text" anyway. Plus the media descriptor has a flag to indicate that the detection wasn't completed, which can be also used by the loading code to abort the loading process. Change-Id: Ida37e2687bd5cd86b5780620724e9bce82e11946 Reviewed-on: https://gerrit.libreoffice.org/24428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
* clang-tidy modernize-loop-convert in f*Noel Grandin2016-04-276-28/+28
| | | | Change-Id: Id866aa244378758e3bdb9e99d02cdd2ae6104e16
* tdf#99527: show all accelerators in menus of extensionsOliver Specht2016-04-271-1/+4
| | | | | | | | | | | | XCUBasedAcceleratorConfiguration::getPreferredKeyEventsForCommandList() throws if the command string of a menu entry is empty. Parent entries of sub menus of extensions are empty. As the method doesn't know about the source of the command a dummy entry is supplied. Change-Id: I1d12bbf41c22b66e9ee29f1f05ea216134168795 Reviewed-on: https://gerrit.libreoffice.org/24423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
* Change label to title case similar to other surrounding labelsYousuf Philips2016-04-261-1/+1
| | | | | | | Change-Id: I4b02aada5e50e7b30ed23fe12fab1c99f38ccfeb Reviewed-on: https://gerrit.libreoffice.org/24056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* loplugin:salboolStephan Bergmann2016-04-221-1/+1
| | | | Change-Id: I14a902c644c467d8e02474e5d0ba8d3dced2860f
* Fix typosAndrea Gelmini2016-04-222-2/+2
| | | | | | | Change-Id: Iea11112a1bf1ff934de0e355b9e81979aa1966a3 Reviewed-on: https://gerrit.libreoffice.org/24286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
* Fix typosAndrea Gelmini2016-04-212-2/+2
| | | | | | | | Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
* loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2016-04-2049-160/+160
| | | | Change-Id: Idf27ee5370f1fa24adf22908d9e801c7d40db935
* Elide macros used onceStephan Bergmann2016-04-192-22/+11
| | | | Change-Id: I5d5c916c966c9e9f2c77c9655f3e8d13a7032117
* Remove unused XMLNS_XLINKStephan Bergmann2016-04-182-6/+0
| | | | Change-Id: Ibb2831ed71f61461e7f23edd6eea29ba64df05a9
* Elide macro used onceStephan Bergmann2016-04-182-3/+3
| | | | Change-Id: Ie0ad7834f54a5bf9cea65b4bb6d7501a90da0f24
* Clean up framework/inc/dispatchcommands.hStephan Bergmann2016-04-183-16/+12
| | | | Change-Id: I6a9a8ae34c2f5abafd4192287fb12d4289a761ff
* Remove dead ENABLE_COMPONENT_SELF_CHECKStephan Bergmann2016-04-182-349/+0
| | | | | | | There is no sign it got ever used past 4011187ff516846635d4e2c3256dca3eb8c3719f "MWS_SRX644: migrate branch mws_srx644 -> HEAD" at least. Change-Id: Ia98613420a095b326ad26c024ff74f3c62bf4f99
* clang-tidy performance-unnecessary-copy-initializationNoel Grandin2016-04-1810-91/+43
| | | | | | | | | | | probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* clean-up: unused using declarations and includesJochen Nitschke2016-04-182-2/+0
| | | | | | | | | | | | | | Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
* bin theseDouglas Mencken2016-04-161-15/+2
| | | | | | | Change-Id: Ic43d15d68533ee19b1a7268e5b139e4584ceeb42 Reviewed-on: https://gerrit.libreoffice.org/24121 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
* Race between Frame::dispose and timer-triggered LayoutManager::AsyncLayouHdlStephan Bergmann2016-04-141-1/+13
| | | | Change-Id: I8e9ca61c2a8334697b7a0adef7a2fc20f503f299
* tdf#94306 remove unused boost dependenciesJochen Nitschke2016-04-132-2/+0
| | | | | | | | | | remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
* Avoid null ToolBox::mpData deref during Frame::closeStephan Bergmann2016-04-131-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | Oh my, whatever the true cause for this SEGV in JunitTest_framework_complex, <http://ci.libreoffice.org/job/lo_tb_master_linux_dbg/6628/console>, processing an incoming URP request > ToolBox::GetMenu() const at vcl/source/window/toolbox2.cxx:1775 > framework::ToolBarManager::ImplClearPopupMenu(ToolBox*) at framework/source/uielement/toolbarmanager.cxx:1309 > framework::ToolBarManager::dispose() at framework/source/uielement/toolbarmanager.cxx:470 > framework::ToolBarWrapper::dispose() at framework/source/uielement/toolbarwrapper.cxx:106 > framework::ToolbarLayoutManager::destroyToolbars() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:654 > framework::ToolbarLayoutManager::reset() at framework/source/layoutmanager/toolbarlayoutmanager.cxx:363 > framework::LayoutManager::implts_reset(bool) at framework/source/layoutmanager/layoutmanager.cxx:413 > framework::LayoutManager::frameAction(com::sun::star::frame::FrameActionEvent const&) at framework/source/layoutmanager/layoutmanager.cxx:2804 > (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&) at framework/source/services/frame.cxx:2953 > (anonymous namespace)::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) at framework/source/services/frame.cxx:1449 > (anonymous namespace)::Frame::close(sal_Bool) at framework/source/services/frame.cxx:1689 > framework::Desktop::impl_closeFrames(bool) at framework/source/services/desktop.cxx:1674 > framework::Desktop::terminate() at framework/source/services/desktop.cxx:238 and the main thread idling in Application::Yield. Change-Id: I41ff8007ee4bbc37473aa5f077ff706b51d31c64
* Use UNO service constructorsStephan Bergmann2016-04-131-10/+4
| | | | Change-Id: I8ac2621a4594b2d8a7cf8fdafd2191f3bf52579b
* remove unused m_xFrame in CheckXTitle unit testAkash Jain2016-04-131-14/+0
| | | | | | | Change-Id: I1b654b308b79d13d23a1b9a935fd2eaf84836d91 Reviewed-on: https://gerrit.libreoffice.org/24044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Tooltip/bits should also depend on state changeMaxim Monastirsky2016-04-131-8/+5
| | | | Change-Id: I18093e42dd2fc54483e620759e4ba00c988ce9db
* Avoid reserved identifiersStephan Bergmann2016-04-122-4/+4
| | | | Change-Id: I13bbc627ba058143862a77d27bbca85f2d961d60
* Try to fix Windows buildMaxim Monastirsky2016-04-121-1/+1
| | | | Change-Id: I46d1d3428ba1cfd8c0ab47aff6b32807e52c3c48
* Yet another SaveToolbarController refactoringMaxim Monastirsky2016-04-121-39/+44
| | | | | | Nothing changed for the end user. Change-Id: Ib5833ae81e94a7cc9aa9ac0eba29702364ea755c
* Don't use bitfield bool members in MenuBarManagerStephan Bergmann2016-04-121-9/+9
| | | | | | | | | | | For one, there's likely few enough instances of MenuBarManager that the code pessimization of using bitfields probably weighs worse than the space optimization. For another, the code generated by at least Clang trunk tends to confuse Valgrind, <https://bugs.kde.org/show_bug.cgi?id=242137> "Valgrind on LLVM compiled code reports tons of 'Conditional jump or move depends on uninitialised' false positives". Change-Id: I4c2ef22e7e54e2a220e2cb490ca0566af4f81f52
* clang-tidy performance-unnecessary-value-param in frameworkNoel Grandin2016-04-1210-20/+20
| | | | Change-Id: I80987ea1bfac7478574de46ee30fc58fcc17eb68
* cleanup: remove unused com/sun/star/uno includesJochen Nitschke2016-04-1210-16/+0
| | | | | | | | | | | | Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* FwkTabWindow is unused since d6d86237b1b438919609988049ac4a152612fee1Maxim Monastirsky2016-04-123-487/+0
| | | | Change-Id: Ifad573ac687548a889165012e7b7bb2f4b82750c
* SaveToolbarController: Better support of readonly docsMaxim Monastirsky2016-04-121-38/+41
| | | | | | | | | The sfx2 impl. of XStorable::isReadonly isn't really helpful for files w/o write permissions that were switched to edit mode, as it returns the state of the UI. So instead let's just rely on the state of the .uno:Save slot. Change-Id: I3b033be3c9424a4479e9224f02d186960b540d21
* SaveToolbarController: Blacklist RelationDesign in officecfgMaxim Monastirsky2016-04-121-8/+1
| | | | Change-Id: I8aa14bb76a26aa12771000b393bee37d26ba85e7
* Lock member access in Frame::disposingStephan Bergmann2016-04-111-65/+107
| | | | | | | | | | | | | | What a mess. Ideally, Frame would use its own rBHelper.rMutex, not SolarMutex. But much of the framework code it calls into uses SolarMutex, too, making it difficult to change that without running into the risk of deadlock. And then, some member variables are cleared early in Frame::disposing, while others are only cleared en bloc at the end. Be conservative and keep it that way (as other Frame functions recursively called from within Frame::disposing could observe the difference and rely on the current behavior), even if that means creating lots of small, independent locked regions within Frame::disposing (which can be detrimental to both performance and correctness). Change-Id: I28f9a379ce03ed661e96c7deb8eb73cb58fb2cf7
* Turn disableLayoutManager into a member functionStephan Bergmann2016-04-111-5/+6
| | | | Change-Id: I489859a53f98a1e70f8a79c3a974dd0d8954ccd1
* Remove leftover commentsStephan Bergmann2016-04-111-21/+0
| | | | Change-Id: Iabecc0d240c499ef81d8b85c8d0b37383813b06a
* Remove obsolete commentStephan Bergmann2016-04-111-3/+2
| | | | Change-Id: I43b65f48d75e293c3fe721e6d5a401f1e176df12
* Combine successive private blocksStephan Bergmann2016-04-111-4/+0
| | | | Change-Id: Id0da294261d9f42e4ba31864827e38e29bf44ea0
* protected -> privateStephan Bergmann2016-04-111-2/+0
| | | | Change-Id: Ic021240bbc2069d6d47b51c0b8e0d81739a72151
* Fold impl_initializePropInfo into initListenersStephan Bergmann2016-04-111-45/+33
| | | | Change-Id: I14d6461d442a8e0ff1efd719e7e2233ffbc523a5
* No need to lock SolarMutex hereStephan Bergmann2016-04-111-3/+0
| | | | Change-Id: Id626dc7c5c75b885b3665e06596b7a58d225cd4c
* loplugin:stringconstantStephan Bergmann2016-04-111-1/+1
| | | | Change-Id: I4776cca99c362998a979507880dce1eccf8e5e04
* allow disabling recent files menu entryOliver Specht2016-04-111-1/+2
| | | | | | | | | | | | patch 85071c6c7b120935b03926228916393a94aa5ef0 fixed the problem of submenus in tools/language but broke the disabling of the recent files menu entry This patch makes it possible to disable and the recent files entry without breaking other menu entries Change-Id: Ia1ba7c0a75cdf82faacead4f92902f65f05186ba Reviewed-on: https://gerrit.libreoffice.org/23988 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* tdf#48300 bring window to top and restore window when minimized.Mark Hung2016-04-111-1/+1
| | | | | | | | | | | | | | While XWindow->ToTop() in Linux do the both for default ( None ), ToTopFlags::RestoreWhenMin has to be specified in Windows in order to restore the window, and ToTopFlags::ForegroundTask is necessary when ToTopFlags::RestoreWhenMin is specified in order to bring non-minimized window to the front. Change-Id: Ief4a825a18d874a0c35211c9022a4261da6bcf8f Reviewed-on: https://gerrit.libreoffice.org/23938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
* No need to clear component context during disposeStephan Bergmann2016-04-111-23/+10
| | | | | | ...which simplifies access to m_xContext member. Change-Id: Ia028b5ae26d94527b6668365ab1197103afb8c22
* tdf#94306 replace boost::noncopyable ...Jochen Nitschke2016-04-118-20/+33
| | | | | | | | | | | | | ... in modules editeng to oox. Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes and one unused boost/checked_delete.hpp include in linguistic. Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80 Reviewed-on: https://gerrit.libreoffice.org/23928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
* Base Frame on WeakComponentImplHelper instead of TransactionManagerStephan Bergmann2016-04-081-459/+131
| | | | | | | | | | | | | | | | | | ...to get the deadlock under control the fix for which had to be reverted with 22fbbfe984f5da2592674f9260f5e4988b1341fe "Revert 'Avoid deadlock when two threads call into Frame::close'". Generally, replaced instances of TransactionGuard(E_HARDEXCEPTIONS) with checkDisposed() and instances of TransactionGuard(E_SOFTEXCEPTIONS) with nothing. A TransactionGuard would not establish a locked section per se (only would it engage in locking when TransactionManager::setWorkingMode is called, see the deadlock mentioned above), so the potential for introducing new races should be manageable. While at it, get rid of those implcp_* "debug methods" used to SAL_WARN about bad arguments to some UNO interface method implementations. Change-Id: I5ea9c1c8b20fd38457c558dbcb3a853a51a09b6e
* Drop unused uses of TransactionBaseStephan Bergmann2016-04-082-7/+2
| | | | Change-Id: I606fc8e06823df9caf8786b1ae4d432c061ddc80
generated by cgit (git 2.34.1) at 2024-06-08 03:50:51 +0000